status
stringclasses 1
value | repo_name
stringclasses 13
values | repo_url
stringclasses 13
values | issue_id
int64 1
104k
| updated_files
stringlengths 11
1.76k
| title
stringlengths 4
369
| body
stringlengths 0
254k
⌀ | issue_url
stringlengths 38
55
| pull_url
stringlengths 38
53
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
unknown | language
stringclasses 5
values | commit_datetime
unknown |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed | dagger/dagger | https://github.com/dagger/dagger | 3,717 | ["website/yarn.lock"] | [DISCUSSION] - Define CLI experience. | In preparation for the GraphQL API announcement we need to provide Dagger users a way to execute GraphQL queries from a file. Currently, this is being allowed through the `cloak` command which is a binary that's not intended to be used by users. Below are some of the questions that initially I'm thinking need some answers:
- Shall we extract the `cloak do` to something public that requires its own SDLC?
- Is the current `cloak do` UX enough for this initial release? I'd assume so.
- Do we need to combine this as part of the Bash SDK release and don't release a GraphQL CLI until that's ready?
cc @shykes @vito @sipsma @aluzzardi | https://github.com/dagger/dagger/issues/3717 | https://github.com/dagger/dagger/pull/954 | c7b9549afa6edb3631792415db51532f9e3292af | f29de14a2f1f8b1a54973511fce477714f6383f2 | "2022-11-07T17:24:35Z" | go | "2021-09-10T15:59:00Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,709 | ["sdk/python/poetry.lock", "sdk/python/src/dagger/engine/cli.py"] | Rename exec to something less confusing | ## Problem
Developers learning Dagger get occasionally confused by the programming model. Most commonly the confusion revolves around the exact behavior of `Container.Exec`: when is a command actually executed, and why?
One reason of the confusion about Exec is its name: unlike almost every other step that lazily adds a node to the dag, it does not have the `With` prefix:
* `WithDirectory`: lazily add a directory
* `WithFile`: lazily add a file
* `WithEnvVariable`: lazily add an environment variable
* `WithUser`: lazily set user
* **`Exec`: lazily execute a command** 🤔
This “breaks the pattern” and although there are several aspects of the DX that contribute to the overall confusion on the programming model, this is definitely one of them.
## Solution
Rename `Exec` to `WithExec`. This is not a perfect name (which is why we didn’t choose it in the first place), but the current lack of consistency is worse.
### Other possible names
Some other possible names:
* `WithExec` (current proposal).
* `AfterExec` (original name in API draft. Was changed to Exec for simplicity). IMO the difference between “with” and “after” makes sense, it’s semantically more elegant and expressive. But also too subtle, and per @aluzzardi ”I got confused because I thought there was a callback involved”.
* `Command` (proposed by @aluzzardi). I think this looks too much like `Directory` or `EnvVariable` ie: a different pattern of operations that return a different type, are often (always?) non-lazy. So IMO it would be confusing in a different way.
* `WithCommand` (proposed by @dolanor & @marcosnils). Evokes familiar `CMD` in Dockerfile
* `WithRun`. Evokes familiar `RUN` in Dockerfile
May the bikeshedding begin :) | https://github.com/dagger/dagger/issues/3709 | https://github.com/dagger/dagger/pull/5074 | c77f63e96ea77ac0af22ce9d98f0de4cd4315802 | 4506a1f0bb437d1696d4008426d3159e556d68ef | "2022-11-06T03:58:53Z" | go | "2023-05-05T00:14:54Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,707 | ["sdk/nodejs/package.json", "sdk/nodejs/yarn.lock"] | Allow container { from { withFS } } | ## Problem
The following query has a surprising and, in my opinion, undesirable result:
```graphql
query customAlpine($fs: DirectoryID!) {
container {
from(address: "alpine:3.16") {
withFS(id: $fs) {
id
}
}
}
```
* Expected behavior: download alpine, replace its root filesystem
* Actual behavior: download alpine, *wipe its contents*, and set a new root filesystem
This is causing problem for users. For example see #3673
@kpenfound says:
> I want my build artifact to end up on a specific base, so the `.From().WithFS()` would have to work. Similar to David's feedback, what I'm really looking for is the equivalent of the dockerfile `COPY --from`
## Solution
Change the behavior of `Container { withFS }` such that it only modifies the container's root filesystem, without modifying anything else in the container content.
## See also
#3264 | https://github.com/dagger/dagger/issues/3707 | https://github.com/dagger/dagger/pull/5398 | 0a458514c85b3a7f93182c32e3cbedb20f0c8c0c | a4c1069f50be9f548345199570e4cb892b0ec396 | "2022-11-05T08:20:23Z" | go | "2023-07-02T14:29:27Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,702 | [".github/workflows/publish-sdk-python.yml", ".gitignore", "internal/mage/sdk/python.go", "sdk/python/.gitignore", "sdk/python/LICENSE", "sdk/python/README.md", "sdk/python/poetry.lock", "sdk/python/pyproject.toml"] | Switch to Poetry | ## Context
We're using [hatch](https://hatch.pypa.io/latest/).
## Pros
- Better support (e.g., ~dependabot~[^1], vs code, ...)
- Better known by users
- Reproducible dev environment (via lock file)
## Cons
- Need tox[^2] to replace our use of scripts in dedicated environments
- Hatch is more standards compliant
[^1]: It [supports hatch](https://github.blog/changelog/2022-10-24-dependabot-updates-support-for-the-python-pep-621-standard/) now.
[^2]: Or something else, e.g., [poethepoet](https://pypi.org/project/poethepoet/). | https://github.com/dagger/dagger/issues/3702 | https://github.com/dagger/dagger/pull/3730 | cd5fbd323926d1eef68a00f5f00e5e89dc0084b7 | 94f086f6f0e7ffedc4883d0be8e3f32b7b10a4fd | "2022-11-05T00:40:24Z" | go | "2022-11-09T12:10:25Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,693 | ["sdk/python/poetry.lock", "sdk/python/pyproject.toml", "sdk/python/src/dagger/connectors/http.py", "sdk/python/src/dagger/transport/__init__.py", "sdk/python/src/dagger/transport/httpx.py"] | Migrate to httpx | ## Reasons
- Supports [AnyIO](https://anyio.readthedocs.io/en/stable/), which supports both [asyncio](https://docs.python.org/3/library/asyncio.html) (built-in) and [Trio](https://github.com/python-trio/trio) (easier to use);
- Supports both async and sync (currently we're using [aiohttp](https://docs.aiohttp.org) for one and [requests](https://requests.readthedocs.io/en/latest/) for the other);
- Simpler support for unix socket connections (https://github.com/dagger/dagger/issues/3694);
## Todo
- [x] Create _async_ transport for GraphQL client
- [x] Create _sync_ transport for GraphQL client
- [x] Hook them in dagger's `HTTPConnector`
- [x] Sunset _aiohttp_ | https://github.com/dagger/dagger/issues/3693 | https://github.com/dagger/dagger/pull/3999 | 8e85cf49185740f9d54c206d3f266cded2314019 | 06e52f8086cd037755761e689f74fae861d091b2 | "2022-11-04T19:36:22Z" | go | "2022-11-28T18:54:25Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,690 | ["sdk/python/pyproject.toml", "sdk/python/src/dagger/api/base.py", "sdk/python/src/dagger/api/gen.py", "sdk/python/src/dagger/api/gen_sync.py", "sdk/python/src/dagger/codegen.py", "sdk/python/src/dagger/connectors/base.py", "sdk/python/src/dagger/connectors/docker.py", "sdk/python/tests/api/test_codegen.py", "sdk/python/tests/api/test_integration.py", "sdk/python/tests/api/test_integration_sync.py"] | Hide IDs in API client | See:
- https://github.com/dagger/dagger/issues/3558
- https://github.com/dagger/dagger/pull/3598 | https://github.com/dagger/dagger/issues/3690 | https://github.com/dagger/dagger/pull/3870 | adaf88cf312696118750593380d129ef51c07955 | 10e89ac6c3b3a20d1ecdde6bf2b9a320d1a3881c | "2022-11-04T19:11:48Z" | go | "2022-11-16T15:09:11Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,686 | ["examples/python/client-simple/say.py", "sdk/python/README.md", "sdk/python/src/dagger/cli.py", "sdk/python/src/dagger/connection.py", "sdk/python/src/dagger/connectors/__init__.py", "sdk/python/src/dagger/connectors/base.py", "sdk/python/src/dagger/connectors/docker.py", "sdk/python/src/dagger/connectors/http.py", "sdk/python/tests/api/test_integration.py"] | Fix engine provisioning | Depends on:
- https://github.com/dagger/dagger/issues/3653
## Todo
- [x] Use a worker thread with sync code[^1]
- [x] Follow instructions in https://github.com/dagger/dagger/issues/3653#issuecomment-1303984783
- [x] Use `docker.io/eriksipsma/test-dagger@sha256:eb6a15a52fed7ac51b26e181dc1c6b2731ba0451f1951c575d85690159cb0722`
- [ ] Test connection
[^1]: Quicker to reuse previous sync implementation and to have it ready for sync support. | https://github.com/dagger/dagger/issues/3686 | https://github.com/dagger/dagger/pull/3716 | e6d2e1657e70a28a479123ee12ae333dc7a99e3d | aa21304d28d8c6599936acf2e0f82f5f68075a66 | "2022-11-04T18:57:28Z" | go | "2022-11-08T09:52:13Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,682 | [".github/workflows/publish-sdk-python.yml", ".gitignore", "internal/mage/sdk/python.go", "sdk/python/.gitignore", "sdk/python/LICENSE", "sdk/python/README.md", "sdk/python/poetry.lock", "sdk/python/pyproject.toml"] | Add Python's CI pipeline to GitHub Actions | ## Tasks
- [x] Add steps from #3678
- [x] Deploy (trigger on release)
- [x] Add test step (trigger on PRs)
\cc @gerhard | https://github.com/dagger/dagger/issues/3682 | https://github.com/dagger/dagger/pull/3730 | cd5fbd323926d1eef68a00f5f00e5e89dc0084b7 | 94f086f6f0e7ffedc4883d0be8e3f32b7b10a4fd | "2022-11-04T16:00:10Z" | go | "2022-11-09T12:10:25Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,678 | [".github/workflows/publish-sdk-python.yml", ".gitignore", "internal/mage/sdk/python.go", "sdk/python/.gitignore", "sdk/python/LICENSE", "sdk/python/README.md", "sdk/python/poetry.lock", "sdk/python/pyproject.toml"] | Add Python's CI pipeline to mage | Depends on:
- #3672
- #3720
- #3730
## Tasks
- [x] Add **generate** step
- [x] Need to `lint:fmt` afterwards
- [x] Add **lint** (`lint:style`) step
- [x] Add **publish** with *build*
\cc @aluzzardi | https://github.com/dagger/dagger/issues/3678 | https://github.com/dagger/dagger/pull/3730 | cd5fbd323926d1eef68a00f5f00e5e89dc0084b7 | 94f086f6f0e7ffedc4883d0be8e3f32b7b10a4fd | "2022-11-04T15:52:19Z" | go | "2022-11-09T12:10:25Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,675 | ["sdk/python/README.md", "sdk/python/pyproject.toml", "sdk/python/src/dagger/api/base.py", "sdk/python/src/dagger/api/gen.py", "sdk/python/src/dagger/connectors/base.py", "sdk/python/src/dagger/connectors/http.py", "sdk/python/tests/api/test_api.py", "sdk/python/tests/api/test_integration.py", "sdk/python/tests/api/test_response.py", "sdk/python/tests/connectors/test_base.py"] | Add a few essential tests | There's a lot of tests to be added, for sure, but I should add at least a few more basic ones for next launch.
- Reuse some test examples from Go (integration)
- Add a few deserialization test cases (unit)[^1]
[^1]: This is where I am most unsure, helps to build confidence. | https://github.com/dagger/dagger/issues/3675 | https://github.com/dagger/dagger/pull/3656 | 4edc2a615a8f2c41c5d4eef0980ca334acb47c17 | b7a567ed2afd66c629f816895ac041d4a7b55fda | "2022-11-04T14:10:33Z" | go | "2022-11-05T10:11:51Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,664 | ["core/integration/git_test.go", "core/schema/git.go", "core/schema/git.graphqls", "sdk/go/api.gen.go"] | API: lookup git commit | ## Problem
The Dagger API supports pulling a remote git repository 1) by branch (`git { branch }`) and 2) by tag (`git { tag }`), but not by commit.
Initially reported [on discord](https://discord.com/channels/707636530424053791/1037789606134939758)
## Solution
Add a new field to the API `git { commit }`
Under the hood it's all refs, but it's better to have a dedicated field for each, to be closer to the actual intent of the developer, and adapt the wording. | https://github.com/dagger/dagger/issues/3664 | https://github.com/dagger/dagger/pull/3666 | 3fb2e1d944d8c291f3718624771d5955c9bbb4d8 | dfbf6896f56e129a09ad06ef8ee86c66de0c7057 | "2022-11-03T18:57:14Z" | go | "2022-11-03T21:46:40Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,641 | ["website/README.md", "website/STYLE_GUIDE.md"] | Create docs style guide | null | https://github.com/dagger/dagger/issues/3641 | https://github.com/dagger/dagger/pull/4004 | 8ec40179dddf4a82a5c4f32c31838278764d06ba | 271c810ae9a1581a4b4e8844f4f777d0b5bf8f96 | "2022-11-02T19:21:49Z" | go | "2022-12-07T13:45:24Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,640 | ["docs/current/sdk/nodejs/722802-index.md", "docs/current/sdk/nodejs/783645-get-started.md", "docs/current/sdk/nodejs/835948-install.md", "docs/current/sdk/nodejs/snippets/get-started/step3/build.ts", "docs/current/sdk/nodejs/snippets/get-started/step4/build.ts", "docs/current/sdk/nodejs/snippets/get-started/step5/build.ts"] | NodeJS Documentation | ### What is the issue?
We will need the following for the NodeJS launch.
- New section in docs
- Get Started Guide
- API reference guide
- Installation
- FAQ
@slumbering can help support as needed since he is NodeJS SDK release lead. | https://github.com/dagger/dagger/issues/3640 | https://github.com/dagger/dagger/pull/3823 | dea51153c37566831d1075479f708d7d51bbcf5d | 410559c588e8b0e5bfdf119366608ba9c1d6fdf7 | "2022-11-02T15:35:55Z" | go | "2022-11-15T22:03:26Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,630 | ["docs/current/sdk/go/275922-guides.md", "docs/current/sdk/go/guides/544174-multistage-build.md", "docs/current/sdk/go/snippets/multistage-build/main.go"] | Docs: Multistage build example using Go SDK | Write an example of a multistage build for the Go SDK docs
context: https://discord.com/channels/707636530424053791/1037094543721496596
cc @mircubed @vikram-dagger | https://github.com/dagger/dagger/issues/3630 | https://github.com/dagger/dagger/pull/3659 | 21ab3928f51c826d9180d5c4c5493539091771a0 | d88f849922fd9a40ef6415c712ca845bc00727ff | "2022-11-01T20:51:13Z" | go | "2022-11-16T18:37:56Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,628 | ["sdk/python/poetry.lock"] | Improve copy/paste flows in documentation | ### What is the issue?
Feedback from this video: https://youtu.be/w-3K8in9jb4?t=904
@marcosnils feedback -
Because he's not following the the docs by the line as he's an advanced Go developer, here he gets an error about dagger not being available as the dependency got removed when he did go mod tidy without having any code. Even though it's highlighted here (https://devel.docs.dagger.io/sdk/go/371491/install/), you can tell that he didn't read the message and went directly to the copy/paste snippet flow. I actually have two suggestions on how we could improve this:
**To-Do:**
In the get started page, have two very friendly copy/paste flows. One for adding dagger to an existing project, and another to start a project from scratch (current example). I feel we'll have several other users falling into the same confusion he did with the current doc structure. | https://github.com/dagger/dagger/issues/3628 | https://github.com/dagger/dagger/pull/4860 | 8b8093570fa324eb434f09883ca2c01a25bcd6a2 | f58f964d3e0cf8a722dd9b5541bf63cecce156d8 | "2022-11-01T17:46:31Z" | go | "2023-04-06T15:10:07Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,615 | ["sdk/python/poetry.lock"] | Guide: building a Go program | There should be a guide explaining how to build a Go program with Dagger. Note: this is different from building a docker container.
Benefits of having this guide:
* Seeing it in the list, clarifies to the user that this is something you can do
* Reading its content, helps you actually getting it done
| https://github.com/dagger/dagger/issues/3615 | https://github.com/dagger/dagger/pull/4860 | 8b8093570fa324eb434f09883ca2c01a25bcd6a2 | f58f964d3e0cf8a722dd9b5541bf63cecce156d8 | "2022-10-31T20:21:55Z" | go | "2023-04-06T15:10:07Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,593 | ["docs/current/sdk/go/275922-guides.md", "docs/current/sdk/go/guides/421437-work-with-host-filesystem.md", "docs/current/sdk/go/snippets/work-with-host-filesystem/export-dir/main.go", "docs/current/sdk/go/snippets/work-with-host-filesystem/list-dir-exclude/main.go", "docs/current/sdk/go/snippets/work-with-host-filesystem/list-dir-include/main.go", "docs/current/sdk/go/snippets/work-with-host-filesystem/list-dir/main.go", "docs/current/sdk/go/snippets/work-with-host-filesystem/mount-dir/main.go", "docs/current/sdk/go/snippets/work-with-host-filesystem/set-workdir/main.go", "website/sidebars.js"] | Docs: guide: interacting with the local filesystem | A common request with the new Go SDK is: "how do I read to, and write from, the local filesystem?".
Thanks to #3560 we now have a much more robust answer. We should document it in an easy-to-find guide. | https://github.com/dagger/dagger/issues/3593 | https://github.com/dagger/dagger/pull/3627 | c80ac2c13df7d573a069938e01ca13f7a81f0345 | 56fb442d233c54e3439a7bf88c4bbf5906daf9b3 | "2022-10-28T21:53:56Z" | go | "2022-11-03T19:06:41Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,588 | ["core/directory.go", "core/integration/directory_test.go", "core/schema/README.md", "core/schema/directory.go", "core/schema/directory.graphqls", "magefile.go", "sdk/go/api.gen.go"] | Directory: rename `withCopiedFile` to `withFile` | See https://github.com/dagger/dagger/issues/3567#issuecomment-1294368392 | https://github.com/dagger/dagger/issues/3588 | https://github.com/dagger/dagger/pull/3590 | 530446113eeeeffb2aa0388641ba30d9a1435158 | 027d0c09d20c3900da341686699b4da3525034d7 | "2022-10-28T20:36:31Z" | go | "2022-11-01T20:14:00Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,571 | ["core/container.go", "core/integration/container_test.go"] | Container: `build` does not respect context subdirectory | This does not currently work:
```go
workdir := client.Host().Workdir()
app, err := workdir.Read().Directory("app/").ID(ctx)
if err != nil {
return err
}
runtime := client.Container().Build(app)
```
The `app/` part gets ignored when using the `dockerfile.v0` frontend. This path is embedded in the `DirectoryID` but it's currently ignored.
It looks like this should be configurable: https://github.com/moby/buildkit/blob/46f6f51822ffe7f7764307aa8fa882ded6688002/frontend/dockerfile/builder/build.go#L59
Make sure this works as expected with given `Dockerfile` paths too; the path param should always be relative to the internal subdir of the `DirectoryID`. | https://github.com/dagger/dagger/issues/3571 | https://github.com/dagger/dagger/pull/3597 | b8491b8679a3775ccf4fbed1592c615df41cbb7a | 68f3e1d54d59f9d4c6fcd2c540e8f0e4067ab853 | "2022-10-26T23:11:42Z" | go | "2022-10-29T01:11:40Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,567 | ["core/directory.go", "core/integration/directory_test.go", "core/schema/README.md", "core/schema/directory.go", "core/schema/directory.graphqls", "magefile.go", "sdk/go/api.gen.go"] | Directory: add `withNewDirectory` for creating an empty dir | New naming scheme for copying files/dirs vs creating files/dirs: https://github.com/dagger/dagger/issues/3567#issuecomment-1294368392
> * `withDirectory`, `withFile`: copy a directory/file (source always required)
>
> * `withNewDirectory`, `withNewFile`: create a new directory/file
This issue is for adding `withNewDirectory` since `withNewFile` already exists.
| https://github.com/dagger/dagger/issues/3567 | https://github.com/dagger/dagger/pull/3590 | 530446113eeeeffb2aa0388641ba30d9a1435158 | 027d0c09d20c3900da341686699b4da3525034d7 | "2022-10-26T22:43:16Z" | go | "2022-11-01T20:14:00Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,551 | ["core/container.go", "core/integration/container_test.go"] | 🐞 Odd container behavior with exec / multiple withMountedDirectory | ### What is the issue?
The following code executes but provides unexpected logs / output. Other similar use cases error due to missing files due to same issue. This may be something very simple (haven't used golang in many years) but seems like there may be an underlying issue with the execution engine.
I would expect this code to run the `ls` command twice, one time showing the two mounted directories, one time showing the root output. Instead in the logs I see `ls` with d1 and d2 (expected), an `ls` with just d1 (??), and then an `ls` with the root fs. This causes issues if the first ls is changed to `ls /example/d2` as it will error the whole pipeline due to missing path.
```golang
workdir := client.Host().Workdir()
d1, err := workdir.Read().Directory("dir1/").ID(ctx)
if err != nil {
return err
}
d2, err := workdir.Read().Directory("dir2/").ID(ctx)
if err != nil {
return err
}
build := client.Container().From("alpine:latest").
WithMountedDirectory("/example/d1", d1).
WithMountedDirectory("/example/d2", d2)
build = build.Exec(dagger.ContainerExecOpts{
Args: []string{"ls", "/example"},
})
_, err = build.ExitCode(ctx)
if err != nil {
return err
}
build = build.Exec(dagger.ContainerExecOpts{
Args: []string{"ls", "/"},
})
_, err = build.ExitCode(ctx)
if err != nil {
return err
}
```
I was able to get the same functionality working fine by using `fs, err := build.FS().WithDirectory(d1, "/example/d1").WithDirectory(d2, "/example/d2").ID(ctx); build = build.WithFS(fs);` so conceptually don't think I'm doing anything wrong.
### Log output
```
#1 resolve image config for docker.io/library/alpine:latest
#1 DONE 0.4s
#2 mkfile /Dockerfile
#2 DONE 0.0s
#3 mkfile /main.go
#3 CACHED
#4 [internal] load metadata for docker.io/library/golang:1.18.2-alpine
#4 DONE 0.1s
#5 local://__dagger_workdir_/home/plaisted/source/OSD.PJI-Temporary/repro
#5 DONE 0.0s
#6 local://__dagger_workdir_/home/plaisted/source/OSD.PJI-Temporary/repro
#6 transferring __dagger_workdir_/home/plaisted/source/OSD.PJI-Temporary/repro: 309B done
#6 DONE 0.0s
#7 [build 1/6] FROM docker.io/library/golang:1.18.2-alpine@sha256:4795c5d21f01e0777707ada02408debe77fe31848be97cf9fa8a1462da78d949
#7 resolve docker.io/library/golang:1.18.2-alpine@sha256:4795c5d21f01e0777707ada02408debe77fe31848be97cf9fa8a1462da78d949 0.0s done
#7 DONE 0.0s
#8 [build 3/6] RUN apk add --no-cache file git
#8 CACHED
#9 [build 4/6] RUN go mod init go.dagger.io/dagger/shim/cmd
#9 CACHED
#10 [build 2/6] WORKDIR /src
#10 CACHED
#11 [build 5/6] COPY . .
#11 CACHED
#12 [build 6/6] RUN CGO_ENABLED=0 go build -o /_shim -ldflags '-s -d -w' .
#12 CACHED
#13 [stage-1 1/1] COPY --from=build /_shim /_shim
#13 CACHED
#14 mkdir /meta
#14 CACHED
#15 copy / /
#15 DONE 0.0s
#16 docker-image://docker.io/library/alpine:latest
#16 resolve docker.io/library/alpine:latest
#16 resolve docker.io/library/alpine:latest 0.1s done
#16 CACHED
#17 copy / /
#17 CACHED
#18 ls /example
#18 0.157 d1
#18 0.157 d2
#18 DONE 0.2s
#1 resolve image config for docker.io/library/alpine:latest
#1 DONE 0.5s
#4 [internal] load metadata for docker.io/library/golang:1.18.2-alpine
#4 DONE 0.4s
#19 ls /example
#19 0.172 d1
#19 DONE 0.2s
#20 ls /
#20 0.105 _shim
#20 0.105 bin
#20 0.105 dagger
#20 0.105 dev
#20 0.105 etc
#20 0.105 example
#20 0.105 home
#20 0.105 lib
#20 0.105 media
#20 0.105 mnt
#20 0.105 opt
#20 0.105 proc
#20 0.105 root
#20 0.105 run
#20 0.105 sbin
#20 0.105 srv
#20 0.105 sys
#20 0.105 tmp
#20 0.105 usr
#20 0.105 var
#20 DONE 0.1s
#0 0.148 d1
#0 0.148 d2
#18 DONE 0.2s
#1 resolve image config for docker.io/library/alpine:latest
#1 DONE 0.4s
#4 [internal] load metadata for docker.io/library/golang:1.18.2-alpine
#4 DONE 0.4s
#19 ls /example
#0 0.135 d1
#19 DONE 0.2s
#20 ls /example
#0 0.104 d1
#0 0.104 d2
#20 DONE 0.1s
```
### Steps to reproduce
* Mount two directories
* Run multiple exec commands and observe logs output
### Dagger version
dagger v0.3.1
### OS version
Ubuntu-20.04 | https://github.com/dagger/dagger/issues/3551 | https://github.com/dagger/dagger/pull/3602 | b734ed35554bbfbc5caf63674eaa9c22692e614e | b4bb0b9e06e1edf8b81f9054b7419daabcb5bedb | "2022-10-26T01:16:16Z" | go | "2022-10-31T22:13:34Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,544 | ["docs/current/sdk/cue/604916-index.md", "docs/current/sdk/go/440319-index.md"] | Fix list punctuation in SDK overview pages | Feedback from https://discord.com/channels/707636530424053791/1034373947040477204
`There are missing . at end of some sentances in list, be consistent` | https://github.com/dagger/dagger/issues/3544 | https://github.com/dagger/dagger/pull/3545 | fcd98b0fdffecd59a8f382d48059d71a63b67843 | ba96cd1fa639bad9506a313e4588a50bf4c4b1df | "2022-10-25T19:24:33Z" | go | "2022-10-25T19:42:08Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,542 | ["RELEASING.md"] | Document docs deployment process | Document how the docs are deployed both to docs.dagger.io and devel.docs.dagger.io, so that everyone in the team is aware of the process. | https://github.com/dagger/dagger/issues/3542 | https://github.com/dagger/dagger/pull/4337 | 3a320167ae98dbd6022753e0674a7dd110a4b890 | d368422dd142d310fef789ac63bf105b6c22e228 | "2022-10-25T19:11:30Z" | go | "2023-01-12T18:27:37Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,537 | ["docs/current/sdk/cue/core-concepts/151357-what-is-cue.md", "docs/current/sdk/cue/core-concepts/667572-dagger-fs.md", "docs/current/sdk/cue/getting-started/526369-install.mdx", "docs/current/sdk/cue/getting-started/tutorial/470907-local-dev.md", "docs/current/sdk/cue/getting-started/tutorial/665980-ci-environment.md", "docs/current/sdk/cue/guides/concepts/937034-api-customizable-image.md", "docs/current/sdk/cue/references/112043-dagger-env-reference.md", "docs/current/sdk/cue/use-cases/493789-aws-sam.md"] | Fix links to old page versions in CUE SDK docs | The current versions of the CUE SDK docs include links to pages from previous versions. This creates a navigation issue where users will see a different sidebar when clicking those links. | https://github.com/dagger/dagger/issues/3537 | https://github.com/dagger/dagger/pull/3539 | ba57a41bbcbf1d3c8d4e3f7b45058072fded0436 | 8c7e60f79f16fabf7e3a5620982a74ffa39f4853 | "2022-10-25T16:28:00Z" | go | "2022-10-25T16:54:42Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,503 | ["docs/current/partials/_get-started-cue-first-run.md", "docs/current/partials/_get-started-cue-modify-code.md", "docs/current/partials/_install-sdk-cue.md", "docs/current/sdk/cue/604916-index.md", "docs/current/sdk/cue/getting-started/470907-get-started.md", "docs/current/sdk/cue/getting-started/526369-install.mdx", "docs/current/sdk/cue/getting-started/tutorial/470907-local-dev.md", "docs/current/sdk/cue/guides/actions/490715-handling-outputs.md", "website/sidebars.js"] | Edit CUE SDK get started guide | null | https://github.com/dagger/dagger/issues/3503 | https://github.com/dagger/dagger/pull/3538 | ab4ecf351679b73cd04d6e0168919a2ddf1351be | fcd98b0fdffecd59a8f382d48059d71a63b67843 | "2022-10-24T21:52:12Z" | go | "2022-10-25T19:22:21Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,502 | ["docs/current/partials/_install-sdk-go.md", "docs/current/sdk/go/959738-get-started.md"] | Copy edit Go SDK get started | null | https://github.com/dagger/dagger/issues/3502 | https://github.com/dagger/dagger/pull/3578 | 79bed0e2bf2d317e57ab5b51899690f39ffdc66e | 5bc035f2ac800aaa9c939ef44a6a6b29cdec4a6e | "2022-10-24T21:51:18Z" | go | "2022-10-31T18:06:18Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,491 | ["website/docusaurus.config.js"] | CUE source code files not imported into doc pages | null | https://github.com/dagger/dagger/issues/3491 | https://github.com/dagger/dagger/pull/3494 | 68a0f5c08cfc07ace74a59c1af97446247373049 | b9da7b0452a696c07ef1fb2d7eb8901b3632ea5b | "2022-10-24T20:30:48Z" | go | "2022-10-24T20:46:04Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,481 | ["sdk/python/poetry.lock"] | Port `client.commands` to Dagger Engine 0.3 | Sub-issue of https://github.com/dagger/dagger/issues/3121
Most of this won't need any work... but creating secrets isn't possible yet. | https://github.com/dagger/dagger/issues/3481 | https://github.com/dagger/dagger/pull/4754 | d3c6dd9987b7896ecf2de7135196154415391c79 | 076b60be9a01c1e42a47ccf23f81405c2c640c9b | "2022-10-21T20:37:08Z" | go | "2023-03-14T13:19:41Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,470 | ["README.md"] | Organize the dagger/examples repo by SDK | Organize the dagger/examples repo by SDK: transpose the contents of the `v0.2.x` branch of dagger/examples into `main`, under an sdk-specific subdirectory | https://github.com/dagger/dagger/issues/3470 | https://github.com/dagger/dagger/pull/4326 | 8511f143f81ca7dbcc5bd3b01264f8eb465ce357 | 6dbef118931766411a10c8f06124be7b455bc7b9 | "2022-10-20T23:32:22Z" | go | "2023-01-09T08:02:38Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,457 | ["sdk/python/pyproject.toml", "sdk/python/src/dagger/api/base.py", "sdk/python/src/dagger/api/gen.py", "sdk/python/src/dagger/api/gen_sync.py", "sdk/python/src/dagger/codegen.py", "sdk/python/tests/api/test_codegen.py", "sdk/python/tests/api/test_integration.py", "sdk/python/tests/api/test_response.py"] | 🐞 codegen: Handling lists of objects | ## Overview
The Go generated client executes the query when a scalar or list is requested.
https://github.com/dagger/dagger/blob/fdbf190307776b4cfb8acaa39cc82956d104e310/codegen/generator/templates/src/object.go.tmpl#L40-L44
## Problem
When it's a list of objects you need to select the fields.
I looked the API for a problematic case:
```graphql
type Container {
envVariables: [EnvVariable!]!
}
type EnvVariable {
name: String!
value: String!
}
```
In fact when attempting to call it:
```diff
diff --git a/sdk/go/dagger/client_test.go b/sdk/go/dagger/client_test.go
index bd5fbefd..74263ae0 100644
--- a/sdk/go/dagger/client_test.go
+++ b/sdk/go/dagger/client_test.go
@@ -101,3 +101,23 @@ func TestContainer(t *testing.T) {
require.NoError(t, err)
require.Equal(t, "3.16.2\n", contents)
}
+
+func TestList(t *testing.T) {
+ t.Parallel()
+
+ ctx := context.Background()
+
+ c, err := Connect(ctx)
+ require.NoError(t, err)
+ defer c.Close()
+
+ alpine := c.
+ Core().
+ Container().
+ From("alpine:3.16.2")
+
+ envs, err := alpine.EnvVariables(ctx)
+
+ require.NoError(t, err)
+ require.Equal(t, "PATH", envs[0].Name)
+}
```
I get an error:
```
Error: Received unexpected error:
input:1: Field "envVariables" of type "[EnvVariable!]!" must have a sub selection.
```
/cc @aluzzardi @dolanor
```[tasklist]
### Tasks
- [x] https://github.com/dagger/dagger/pull/4683
- [x] https://github.com/dagger/dagger/pull/5375
- [x] https://github.com/dagger/dagger/pull/5523
```
| https://github.com/dagger/dagger/issues/3457 | https://github.com/dagger/dagger/pull/5375 | 0c8da0a136047f58930ba69d0b5779cfcffb93b7 | 46935c5813bec92b5bccb8253a527d64c9b78dec | "2022-10-20T09:10:03Z" | go | "2023-06-29T16:51:54Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,426 | ["docs/current/sdk/go/275922-guides.md", "docs/current/sdk/go/guides/205271-replace-dockerfile.md", "docs/current/sdk/go/snippets/replace-dockerfile/main.go"] | Replace your Dockerfile with go Guide + Demo Video | A guide that shows how to replace a Dockerfile with Go
**To-do:**
- [ ] Guide
- [ ] Demo Video (don't start recording until guide content is approved) | https://github.com/dagger/dagger/issues/3426 | https://github.com/dagger/dagger/pull/4173 | c5a9cdbdb9d01ad2c882463e4a539b8586f2eb1e | 08d0e858e6c047505aae2b2350397613c16a71a7 | "2022-10-18T22:39:45Z" | go | "2023-01-06T19:10:56Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,417 | ["sdk/python/poetry.lock"] | Prepare `dagger/examples` repo content for Go SDK launch | Today we have some `v0.2` Dagger CUE code examples in https://github.com/dagger/examples. Those are referenced by the copy and paste "templates" here: https://docs.dagger.io/install/#explore-our-templates
We have some samples of Dagger `cloak` code in personal repos, for example:
https://github.com/kpenfound/dagger-demos
https://github.com/jpadams/dagger-jenkins-gradle
* We propose to consolidate the examples in `dagger/examples`.
* We propose to highlight Go SDK examples for the Go launch:
- move existing Go SDK examples from other repos to `examples`
- recreate current examples using Go SDK
* We should add more examples over time as SDKs are released.
* We should preserve examples from `v0.2` to keep the `v0.2` docs consistent:
- https://github.com/dagger/examples/tree/0.2
- https://github.com/dagger/dagger/pull/3408
| https://github.com/dagger/dagger/issues/3417 | https://github.com/dagger/dagger/pull/4754 | d3c6dd9987b7896ecf2de7135196154415391c79 | 076b60be9a01c1e42a47ccf23f81405c2c640c9b | "2022-10-17T22:05:49Z" | go | "2023-03-14T13:19:41Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,407 | ["core/container.go", "core/shim/cmd/main.go"] | Cloak's mount at `/dagger` for `stdout` and `stderr` shadows user content there | I build a Jenkins agent image for running Dagger on Jenkins.
I happened to put the `dagger` binary at `/dagger` on my image (and symlink to it from `/usr/local/bin/dagger`). That works okay because I'm running Dagger *from* my image, but if I run a cloak/Dagger query that uses my image, the fact that we mount to `/dagger` clobbers/shadows my content there.
We should either move this or document it.
Repro:
this works:
```
docker run -it --rm jeremyatdockerhub/cloak-jenkins-agent:15 /dagger/dagger
```
this doesn't:
```
/usr/local/bin/dagger do <<EOF
query JDK {
container {
from(address: "jeremyatdockerhub/cloak-jenkins-agent:15") {
exec(args: ["/dagger/dagger"]) {
stdout {
contents
}
}
}
}
}
EOF
...
#14 /dagger/dagger
#14 ERROR: process "/_shim /dagger/dagger" did not complete successfully: exit code: 1
------
```
because:
```
/usr/local/bin/dagger do <<EOF
query JDK {
container {
from(address: "jeremyatdockerhub/cloak-jenkins-agent:15") {
exec(args: ["ls", "/dagger"]) {
stdout {
contents
}
}
}
}
}
EOF
...
#14 ls /dagger
#0 0.164 stderr
#0 0.164 stdout
#14 DONE 0.2s
{
"container": {
"from": {
"exec": {
"stdout": {
"contents": "stderr\nstdout\n"
}
}
}
}
}
```
fyi @aluzzardi | https://github.com/dagger/dagger/issues/3407 | https://github.com/dagger/dagger/pull/3548 | 26f77b8cd2dd481988986e54b11ec21ec83fad39 | ab7fba6ce6611a5eb0c279f8db42bb45b1cca11f | "2022-10-17T17:25:25Z" | go | "2022-10-25T23:43:46Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,397 | ["core/directory.go", "core/integration/container_test.go", "core/integration/directory_test.go", "core/integration/examples_test.go", "core/schema/directory.go", "core/schema/directory.graphqls", "sdk/go/dagger/api/api.gen.go", "sdk/go/dagger/client_test.go"] | API: contents field can be ambiguous | Both `File` and `Directory` have a `contents` field.
This can be confusing, for instance:
```go
c.Directory().WithNewFile("/foo.txt").Contents(ctx)
```
`WithNewFile()` returns a `Directory` so here we're listing the directory rather than grabbing the contents of `/foo.txt`.
With the builder pattern, it's not obvious to the naked eye which object is being returned.
I suggest renaming `directory.contents` to files perhaps? e.g.
```go
c.Directory().WithNewFile("/foo.txt").Files(ctx) // <-- list files
c.Directory().WithNewFile("/foo.txt").File("/foo.txt").Contents() // <-- get a file's contents
```
/cc @shykes @vito @sipsma | https://github.com/dagger/dagger/issues/3397 | https://github.com/dagger/dagger/pull/3441 | 02450d48aba17b0bb0366d56bb5cef34d0cc5bfa | 744dc4d6b062d193ddd4f2f649bf78fc71c20327 | "2022-10-15T01:18:47Z" | go | "2022-10-19T22:39:18Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,393 | ["core/container.go", "core/integration/container_test.go", "core/schema/container.go"] | Fix build of shim when execing on non-platform specific llb state | from @marcosnils
```
query Build($file: FileID!, $ref: ContainerAddress!) {
container {
withMountedFile(path: "/mnt/dagger", source: $file) {
exec(args: ["cp", "/mnt/dagger", "/dagger"]) {
withEntrypoint(args: ["dagger"]) {
publish(address: $ref)
}
}
}
}
}
```
results in
```
{
"data": null,
"errors": [
{
"message": "build shim: failed to parse target platform unknown: \"unknown\": unknown operating system or architecture: invalid argument",
"locations": [
{
"line": 4,
"column": 7
}
],
"path": [
"container",
"withMountedFile",
"exec"
]
}
]
}
```
The above query should fail since there's no fs on which to execute `cp` but it shouldn't fail by not being able to build the shim.
It's also should be possible in general to, e.g. start at scratch, unpack a static binary and exec it, in which case this shouldn't even be an error case at all. | https://github.com/dagger/dagger/issues/3393 | https://github.com/dagger/dagger/pull/3399 | 51c7941c3c8e7c2ac4242f5c41cec5a56d17e9d3 | f8b3c63637cfcca2ec677fea2e020885664bd301 | "2022-10-14T22:29:08Z" | go | "2022-11-10T06:01:37Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,391 | ["sdk/python/poetry.lock"] | Installing Go SDK is not intuitive | ## Problem
To install the Dagger Go SDK, one has to run the following commands:
```console
go get go.dagger.io/dagger@<version if needed>
go mod edit -replace=github.com/docker/docker=github.com/docker/[email protected]+incompatible
go mod tidy
```
This is 1) verbose, and 2) unusual for Go developers. Therefore it will result in a bad DX. We should boil this down to just `go get`.
## Solution
The solution unfortunately is complex, because it is caused by a conflict between the Moby/Docker and Go projects, respectively. There are four ways we can solve this:
1) Convince Go to revert their decision to break the established tagging convention for go projects. Estimate: impossible.
2) Convince Docker to change their tagging convention to match Go's new tagging mandate. Estimate: unlikely.
3) Convince Go and Docker to find a middle ground. Estimate: unlikely.
4) Solve the problem downstream with a private fork + custom tooling. Estimate: annoying but doable.
Related: https://github.com/dagger/dagger/issues/3367#issuecomment-1278324885
Related: https://github.com/dagger/dagger/issues/3368 | https://github.com/dagger/dagger/issues/3391 | https://github.com/dagger/dagger/pull/4754 | d3c6dd9987b7896ecf2de7135196154415391c79 | 076b60be9a01c1e42a47ccf23f81405c2c640c9b | "2022-10-14T21:11:04Z" | go | "2023-03-14T13:19:41Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,340 | ["core/container.go", "core/integration/container_test.go", "core/schema/container.go", "core/schema/container.graphqls", "sdk/go/dagger/api/api.gen.go"] | API: inline ExecOpts in exec | Would it make sense to move that stuff as optional arguments to `exec`, rather than wrapped in a `ExecOpts` input?
Otherwise it ends up double wrapped:
```go
Exec(dagger.ContainerExecOpts{
Args: []string{"ls"},
Opts: dagger.ExecOpts {
Stdin: "foo",
}
}
```
vs:
```go
Exec(dagger.ContainerExecOpts{
Args: []string{"ls"},
Stdin: "foo",
}
```
/cc @vito @shykes | https://github.com/dagger/dagger/issues/3340 | https://github.com/dagger/dagger/pull/3402 | 1d9236da031514e3c5f8dbcfb186eb87ea3af5d6 | 1cc6d7b558c44d2512f582e4fa6ce447b327cd3c | "2022-10-12T20:15:16Z" | go | "2022-10-18T20:20:37Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,325 | ["sdk/python/requirements/docs.txt"] | Python: add tests | Use pytest.
1. We can start with barebones integration test and hook it into CI like in https://github.com/dagger/dagger/pull/3292.
2. Then keep iterating to add coverage for existing features.
3. Add tests along with new features. | https://github.com/dagger/dagger/issues/3325 | https://github.com/dagger/dagger/pull/6565 | 877ee23c584d79ef949027b4460fafff49ecad7b | 2ce62d60e33330e15a220a086962b10fb4b8f3ca | "2022-10-12T11:53:17Z" | go | "2024-02-01T20:32:56Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,323 | [".changes/unreleased/Added-20230829-002146.yaml", "core/container.go", "core/integration/container_test.go", "core/schema/container.go", "core/schema/container.graphqls", "sdk/elixir/lib/dagger/gen/container.ex", "sdk/go/api.gen.go", "sdk/nodejs/api/client.gen.ts", "sdk/python/src/dagger/client/gen.py", "sdk/rust/crates/dagger-sdk/src/gen.rs"] | Support configuring additional options for secrets | Buildkit's full `SecretInfo` struct is as follows:
```go
type SecretInfo struct {
ID string
Target string
Mode int
UID int
GID int
Optional bool
IsEnv bool
}
```
We already support `ID`, `Target`, and `IsEnv` but maybe folks will have a use for `Mode`, `UID`, `GUID`, and/or `Optional`. | https://github.com/dagger/dagger/issues/3323 | https://github.com/dagger/dagger/pull/5707 | e5feaea7f1d6eb01d834e83b180fc3daed3463ea | 1ddf4ea46492a1aad850906c0c78c58e43d873c4 | "2022-10-11T23:15:04Z" | go | "2023-09-12T06:56:33Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,320 | ["website/yarn.lock"] | Decide if we should package generated `core` SDK with Dagger or rely on user-run codegen | One possibility: we package the core sdk for now. In the future we transitioned to codegen but provide some light tooling to ease the transition. There are already tools for rewriting go imports automatically so I don't think this would require great effort on our part (🤞) | https://github.com/dagger/dagger/issues/3320 | https://github.com/dagger/dagger/pull/1667 | e476908fa3e55b25c06559a283a692aaf896db9e | f08fd16d1cb6a4f264dc000fb1fde51d5a612890 | "2022-10-11T21:52:45Z" | go | "2022-03-01T19:46:34Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,315 | ["core/container.go", "core/integration/container_test.go", "core/shim/cmd/main.go"] | Respect container exec opts (stdio redirects) | `ContainerExecOpts` is currently ignored | https://github.com/dagger/dagger/issues/3315 | https://github.com/dagger/dagger/pull/3331 | d988bac255771bfaa2967fe84ffb9bc421927e4e | c5b941d438bcf744deb8f103657d4f264973ab45 | "2022-10-11T20:01:24Z" | go | "2022-10-13T21:37:08Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,300 | ["examples/python/client-simple/README.md", "examples/python/client-simple/async_query.py", "examples/python/client-simple/query.py", "examples/python/hello/main.py", "sdk/python/dagger/pyproject.toml", "sdk/python/dagger/src/dagger/cli.py", "sdk/python/dagger/src/dagger/client.py", "sdk/python/dagger/src/dagger/engine.py", "sdk/python/dagger/src/dagger/server.py"] | Python: Add async support | Resolvers should be able to use async code if needed (e.g., calling async libraries or running tasks concurrently).
We can also provide a client with an async transport so you can make async queries on an async resolver, or if you use a script in an async environment. To avoid having different `AsyncClient` and `SyncClient` sort of classes, I'm thinking about using a context manager in a proxy to instantiate the correct client so you'd use them like this:
```python
# async
async with dagger.Client() as session:
result = await session.execute(...)
# sync
with dagger.Client() as session:
result = session.execute(...)
``` | https://github.com/dagger/dagger/issues/3300 | https://github.com/dagger/dagger/pull/3301 | 77eed15d356836981e4c0975920674069e315edf | 02450d48aba17b0bb0366d56bb5cef34d0cc5bfa | "2022-10-10T12:01:05Z" | go | "2022-10-19T21:45:35Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,284 | [".changes/unreleased/Added-20231215-115147.yaml", "core/integration/container_test.go", "core/schema/container.go", "core/schema/container.graphqls", "sdk/elixir/lib/dagger/gen/container.ex", "sdk/go/dagger.gen.go", "sdk/nodejs/api/client.gen.ts", "sdk/python/src/dagger/client/gen.py", "sdk/rust/crates/dagger-sdk/src/gen.rs"] | Use `withoutEntrypoint`, `withoutWorkdir`, `withoutUser` and `withoutDefaultArgs` to remove | Currently, passing nil or empty arguments to those function reinit the values.
It's not that explicit and clear.
It will make more API endpoints, but it's gonna be clearer. | https://github.com/dagger/dagger/issues/3284 | https://github.com/dagger/dagger/pull/6278 | 568d802bb892f1e074cf74cfce2a551989418964 | cd825bde699a0beb0adb5c2529da5469118a172b | "2022-10-07T15:00:07Z" | go | "2023-12-19T13:11:01Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,266 | ["core/container.go", "core/integration/container_test.go", "core/integration/secret_test.go", "core/integration/suite_test.go", "core/schema/container.go", "core/schema/container.graphqls"] | Container: add `file` | Symmetrical to `container.directory`: returns a `FileID` while magically traversing mounts by path. | https://github.com/dagger/dagger/issues/3266 | https://github.com/dagger/dagger/pull/3303 | 09c6e1f7a6405646a3c3733e9284ba94e959da36 | 44fb6275fcd9a789c905dc3570a8a506df598c36 | "2022-10-06T02:10:11Z" | go | "2022-10-12T01:34:30Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,257 | ["core/container.go", "core/integration/container_test.go", "core/integration/testdata/codetoschema/main.go", "core/schema/container.go", "core/schema/container.graphqls", "sdk/go/dagger/api/api.gen.go"] | Replace `ContainerAddress` with a regular string | per https://github.com/dagger/dagger/pull/3219#discussion_r987337784
We generally use scalars for opaque values that pass through the client without ever being modified or constructed directly. `ContainerAddress` on the other hand is a user-provided string, and having to cast it to this special type is a little weird.
Also, we currently use regular strings for paths (e.g. `withNewFile(path: String!)`), so it seems a little inconsistent to opt for a scalar type for image addresses but not paths. | https://github.com/dagger/dagger/issues/3257 | https://github.com/dagger/dagger/pull/3443 | 3c9cbd207ec1c5950d3c2ae55fc555356026c682 | 311a1205797776e318bf979c748b538fbf80e2dd | "2022-10-04T22:04:40Z" | go | "2022-10-19T22:59:53Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,241 | ["sdk/python/poetry.lock"] | Port `core.#Export` to Dagger Engine 0.3 | Sub-issue of #3121
This isn't currently implemented by dagger v0.3... and I can see it never being available as is. I might need to deprecate this, or create a new version that only does the export to host. | https://github.com/dagger/dagger/issues/3241 | https://github.com/dagger/dagger/pull/4662 | 609ccaf0871cfe9810c3eb0fc1438ae614077a57 | db8d0f832f72121857e8189e072a3cf88695e5a6 | "2022-10-04T15:14:38Z" | go | "2023-02-28T10:53:15Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,234 | ["sdk/java/pom.xml"] | Port `core.#Merge` to Dagger Engine 0.3 | Sub-issue of #3121
This isn't available in `v0.3` yet. | https://github.com/dagger/dagger/issues/3234 | https://github.com/dagger/dagger/pull/6567 | 6d5f4d1f3d06debe2e3e79e037a5e5c7cfe1221b | c7df6b342ebb1c26c3df54c1473f7e7a38f08311 | "2022-10-04T15:14:25Z" | go | "2024-02-02T08:13:17Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,225 | [".github/workflows/provision.yml", "sdk/go/internal/engineconn/dockerprovision/image.go", "sdk/go/provision_test.go", "sdk/python/tests/engine/test_docker.py"] | Automated tests on macos | There's a lot of tricky details to get right when starting dagger on macos: need to create buildkit running on a VM somewhere (w/ docker desktop by default for now), need to ensure LLB is using the right platform, etc.
It's very easy to miss issues when you don't have a macos machine readily available to test on.
While it's not trivial, we should find a way to run our CI on macos. GHA does have mac os runners, so that's an obvious possible option. | https://github.com/dagger/dagger/issues/3225 | https://github.com/dagger/dagger/pull/3774 | 565ab02881e209372932e1b6dac86552f41b116c | 571c8ae24b913fe00089062d3f918db229505a96 | "2022-10-04T04:53:25Z" | go | "2022-11-29T20:04:42Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,221 | ["sdk/python/poetry.lock"] | Port `core.#Exec` to `cloak` | Sub-issue of #3121 | https://github.com/dagger/dagger/issues/3221 | https://github.com/dagger/dagger/pull/4662 | 609ccaf0871cfe9810c3eb0fc1438ae614077a57 | db8d0f832f72121857e8189e072a3cf88695e5a6 | "2022-10-03T23:03:26Z" | go | "2023-02-28T10:53:15Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,218 | ["engine/engine.go"] | Don't pollute host stdout/stderr | ## Problem
In cloak (0.3) the Dagger engine is embedded in a host program (script or tool), which instruments it to run pipelines.
Currently the dagger engine prints all its output to the standard output of the engine, which is inherited from the host program. The result is that dagger "takes over" the standard output of its host, which is not desirable.
## Solution
When a program is run that embeds the dagger engine, the output of the dagger engine should not pollute the host program's standard output and error streams. Instead, all useful outputs from running a pipeline should be available to the host program by making API calls.
| https://github.com/dagger/dagger/issues/3218 | https://github.com/dagger/dagger/pull/3339 | e9d449ce1b41198eab1bdc980b6bbcf788fc8f16 | 79bed0e2bf2d317e57ab5b51899690f39ffdc66e | "2022-10-03T22:41:44Z" | go | "2022-10-31T18:01:11Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,179 | ["sdk/java/pom.xml"] | finish implementing `Directory` core API | I implemented the first parts of this API in https://github.com/dagger/dagger/pull/3168 but left a few parts unimplemented:
https://github.com/dagger/dagger/blob/03ea15e68fcc46f2c51bc829fd0d24e97d88c576/core/directory.go#L209-L228
* `secret` ~~will need #3178 first.~~ can be removed from the schema per comments below
* `withoutFile` _might_ be a simple application of `llb.Rm` but I've never used that before.
* `withoutDirectory` might be the same assuming `llb.Rm` is just placing a tombstone over a path and doesn't need to be done recursively.
* `diff` is probably just `llb.Diff` of two directory states but I'm a little suspicious this might be more complicated with sub-directory paths. 🤔 | https://github.com/dagger/dagger/issues/3179 | https://github.com/dagger/dagger/pull/6347 | b7f85d14478b32a940857d29a4a54a87ac1cf16c | 6bf18c7e0568f542567c8d63408cde9331f099c8 | "2022-09-29T18:46:35Z" | go | "2024-01-04T10:01:28Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,173 | ["sdk/java/pom.xml"] | finish the services API | The services API is incomplete.
Mainly:
- Convert to New Core API
- Restructure to be multi-process (just like buildkit)
- Support non-interactive mode (e.g. for launching a db etc, we don't want tty streaming etc)
- cloak attach is hardcoded to localhost
- Tests
We should either address this or remove the services API for release.
See #3123 for more details | https://github.com/dagger/dagger/issues/3173 | https://github.com/dagger/dagger/pull/6347 | b7f85d14478b32a940857d29a4a54a87ac1cf16c | 6bf18c7e0568f542567c8d63408cde9331f099c8 | "2022-09-28T23:45:48Z" | go | "2024-01-04T10:01:28Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,170 | ["core/core.go", "core/core.schema.go", "core/filesystem/image.go", "core/integration/old_core.schema_test.go"] | 🐞 ENTRYPOINT/CMD data lost during Dagger image build | ### What is the issue?
The default entrypoint/cmd of a base image is lost when that image is used in a Dagger image build process.
### Log output
_No response_
### Steps to reproduce
Running standard PHP image:
```
$ docker run php:8.1-apache
AH00558: apache2: Could not reliably determine the server's fully qualified domain name, using 172.17.0.3. Set the 'ServerName' directive globally to suppress this message
AH00558: apache2: Could not reliably determine the server's fully qualified domain name, using 172.17.0.3. Set the 'ServerName' directive globally to suppress this message
[Sat Sep 17 06:11:06.065706 2022] [mpm_prefork:notice] [pid 1] AH00163: Apache/2.4.54 (Debian) PHP/8.1.9 configured -- resuming normal operations
[Sat Sep 17 06:11:06.065751 2022] [core:notice] [pid 1] AH00094: Command line: 'apache2 -D FOREGROUND'
```
Building new image based on above image, making no changes, pushing it to registry and running it:
```
query {
core {
image(ref: "php:8.1-apache") {
pushImage(ref:"xxx/testrepo:latest")
}
}
}
$ docker run xxx/testrepo
docker: Error response from daemon: No command specified.
See 'docker run --help'.
```
### Dagger version
cloak devel (97205d987) linux/amd64
### OS version
Linux 5.15.0-47-generic #51-Ubuntu SMP | https://github.com/dagger/dagger/issues/3170 | https://github.com/dagger/dagger/pull/3174 | 8c3d0f8e8468395485fd97bd095e8e4ab809b79c | c9b294a4cf6a0ce994f4014d2d9d76b30bfe6f3d | "2022-09-28T20:41:19Z" | go | "2022-09-29T23:17:00Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,167 | ["sdk/python/poetry.lock"] | configuring file permissions for `directory { withNewFile }` | ### What are you trying to do?
Create a new file with static content through the API with permissions set.
### Why is this important to you?
Some tools are picky about file permissions and will fail if they're too permissive. For example, `~/.ssh/known_hosts`.
### How are you currently working around this?
_No response_ | https://github.com/dagger/dagger/issues/3167 | https://github.com/dagger/dagger/pull/4662 | 609ccaf0871cfe9810c3eb0fc1438ae614077a57 | db8d0f832f72121857e8189e072a3cf88695e5a6 | "2022-09-28T15:56:37Z" | go | "2023-02-28T10:53:15Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,149 | ["sdk/python/poetry.lock"] | 📖 Conditional action execution | ### What are you trying to do?
My use case is a conditional execution of an action depending on a branch name, or other arbitrary condition.
There is this example in [azure devops pipelines](https://learn.microsoft.com/en-us/azure/devops/pipelines/process/conditions?view=azure-devops&tabs=yaml#run-for-the-main-branch-if-succeeding)
```
and(succeeded(), eq(variables['Build.SourceBranch'], 'refs/heads/staging'))
```
Conditions like this are used to perform some operations only on selected branches. I use a general "operations" term since azure devops has several layers of those: pipelines, stages, jobs, steps, tasks, ..... The reason for using conditions could be for example running integration tests only after releasing staging environments (from a staging branch), or create a disposable environment in a cloud for a branch named with a specific prefix.
I'm not clear about whether dagger is designed for it, or even whether it already supports it.
### Why is this important to you?
For most CI systems, yaml based, it is difficult to setup complex conditions and even more difficult to test those conditions, since changes require submitting the pipeline onto a non-local agent. The conditional logic of the pipelines is mixed with the actual application build/deployment, making debugging slow and requiring coming up with ingenious changes to fully cover the pipeline branching. Some changes that trigger only from e.g. main branch can only be tested after the code is commited to main. Locally I could fake the branch I'm on.
Ideally I would like to define the pipeline conditional logic in dagger, including the dependencies between actions https://github.com/dagger/dagger/discussions/2124, and then test the logic https://github.com/dagger/dagger/issues/2141.
### How are you currently working around this?
No workarounds yet. Maybe migrating back to jenkins or buildbot?
Image credits: [Marius](https://www.augmentedmind.de/2022/06/26/speed-up-gitlab-ci-pipelines/) after https://xkcd.com/303/ | https://github.com/dagger/dagger/issues/3149 | https://github.com/dagger/dagger/pull/4662 | 609ccaf0871cfe9810c3eb0fc1438ae614077a57 | db8d0f832f72121857e8189e072a3cf88695e5a6 | "2022-09-26T15:35:20Z" | go | "2023-02-28T10:53:15Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,015 | ["internal/buildkitd/buildkitd.go"] | Better error message when docker is not running | If docker isn't running and tries to spin up the automatic buildkitd, cloak just says `exit status 1`. We should be able to check this situation and give a better error. | https://github.com/dagger/dagger/issues/3015 | https://github.com/dagger/dagger/pull/3185 | c9b294a4cf6a0ce994f4014d2d9d76b30bfe6f3d | 14b6907c376edd5430b30ca5152e3d3988683f5e | "2022-09-14T20:05:21Z" | go | "2022-09-30T02:51:19Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,019 | ["core/integration/project_test.go", "internal/testutil/query.go", "project/gogenerate.go"] | `cloak generate` does nothing when workdir and extension path are the same | If `go.mod` is missing for a go extension, then `go generate` will create the `gen` dir successfully but just skip making the generated go code. This should instead be an error case. | https://github.com/dagger/dagger/issues/3019 | https://github.com/dagger/dagger/pull/3189 | 14b6907c376edd5430b30ca5152e3d3988683f5e | 80808d35abbcf478baa260ea4f9d46bcb92c24a4 | "2022-09-13T16:49:36Z" | go | "2022-09-30T14:34:28Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,025 | ["cmd/shim/main.go", "core/container.go", "core/gateway.go", "core/integration/container_test.go", "core/schema/base.go", "go.mod", "go.sum"] | Include output of failed exec in graphql errors | Right now if an exec fails the graphql error just says that it exited non-zero. This makes it hard to debug unless you go look at the buildkit progress output.
We should instead include the output of the execop in the graphql error to help debugging. The implementation is not incredibly straightforward. Buildkit has the ability to obtain the FS of a failed exec op (including changes made during the command): https://github.com/moby/buildkit/blob/c9a0f4d2de095591e742d7f411d9ed36a03a1c4e/client/build_test.go#L1278-L1310
We will probably need to use that to obtain the output as written to the output files by the shim.
We should also make sure to limit the size of the output included so if there's a failure during a command with many megabytes of output (e.g. compiling a large project) we don't try to transfer all of that in the error. Instead, we can just return the last N bytes. | https://github.com/dagger/dagger/issues/3025 | https://github.com/dagger/dagger/pull/4161 | 5257ac03f6bae55e7f8ac4d0713251b9e0499aa3 | a795bea02f59a980912cf95e04902b5a77cab39a | "2022-09-07T20:42:51Z" | go | "2022-12-12T21:30:21Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 2,990 | ["sdk/python/poetry.lock"] | docker.#Copy fail when exclude is used | ### What is the issue?
I have the following docker.#Copy:
```
docker.#Copy & {
contents: app
dest: "/app"
exclude: [
".gradle/",
".idea/"
]
}
```
### Log output
`failed to execute plan: task failed: actions.build._build._dag."1"._copy: failed to copy file info: failed to chown /var/lib/buildkit/runc-overlayfs/cachemounts/buildkit3698781898/app/.gradle/7.4.2/checksums: lchown /var/lib/buildkit/runc-overlayfs/cachemounts/buildkit3698781898/app/.gradle/7.4.2/checksums: no such file or directory`
### Steps to reproduce
Create a plan with docker.#Copy and use exclude in a directory (Host).
### Dagger version
dagger 0.2.32 (624e5bb94) darwin/arm64
### OS version
MAC OS 12.4 | https://github.com/dagger/dagger/issues/2990 | https://github.com/dagger/dagger/pull/4623 | a8e7cbc812bd496466f9e94d3e8f8608ec9c0bfb | a1d08f36e8f7af26757038e827a05b111ca24d0d | "2022-09-01T16:49:35Z" | go | "2023-02-21T21:23:54Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,090 | ["sdk/java/pom.xml"] | Host key failed while using another @dagger.io/dagger repo | I'm trying to use my fork for the nodejs sdk like this:
```json
"devDependencies": {
"@dagger.io/dagger": "git+ssh://[email protected]:slumbering/cloak.git#demov2-sdk-jf"
}
```
I get the following error:
```sh
dagger/dagger#3064 /_shim yarn install
dagger/dagger#3064 0.274 yarn install v1.22.17
dagger/dagger#3064 0.348 [1/4] Resolving packages...
dagger/dagger#3064 0.722 [2/4] Fetching packages...
dagger/dagger#3064 16.91 info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
dagger/dagger#3064 16.91 error Command failed.
dagger/dagger#3064 16.91 Exit code: 128
dagger/dagger#3064 16.91 Command: git
dagger/dagger#3064 16.91 Arguments: ls-remote --tags --heads [email protected]:slumbering/cloak.git
dagger/dagger#3064 16.91 Directory: /src
dagger/dagger#3064 16.91 Output:
dagger/dagger#3064 16.91 Host key verification failed.
dagger/dagger#3064 16.91 fatal: Could not read from remote repository.
dagger/dagger#3064 16.91
dagger/dagger#3064 16.91 Please make sure you have the correct access rights
dagger/dagger#3064 16.91 and the repository exists.
dagger/dagger#3064 ERROR: process "/_shim yarn install" did not complete successfully: exit code: 128
``` | https://github.com/dagger/dagger/issues/3090 | https://github.com/dagger/dagger/pull/6000 | 6d053580767455219d4c1b65bb562c83920bcae9 | 73eadf183d051e22ae9d56bed962e07e1a02e8cd | "2022-09-01T15:08:31Z" | go | "2023-10-28T14:42:04Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 2,986 | ["pkg/universe.dagger.io/alpha/azure/auth/azlogin.sh", "pkg/universe.dagger.io/alpha/azure/vault/get-secret.sh", "pkg/universe.dagger.io/alpha/azure/vault/image.cue", "pkg/universe.dagger.io/alpha/azure/vault/secret.cue", "pkg/universe.dagger.io/alpha/azure/vault/test/test.cue"] | ✨ action to fetch secrets from azure vault | ### What are you trying to do?
It would be nice to be able to have an action to fetch secrets from azure vault.
### Why is this important to you?
Itcould be used on other steps where sensitive data is required.
### How are you currently working around this?
Using a custom action. | https://github.com/dagger/dagger/issues/2986 | https://github.com/dagger/dagger/pull/2987 | 0efdfbe28183a117cd0b760797d1286b01496a3e | 9fe231280a4ebd99ff27d4ee1cea974143866616 | "2022-08-31T18:04:40Z" | go | "2022-09-01T15:00:07Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,037 | ["sdk/python/poetry.lock"] | Support for Services | Services:
* Run asynchronously (can be started and stopped)
* Aren't cached in their execution
* Can expose sockets (and similar concepts like TTYs).
One classic use case is an e2e test that needs to run against a live database. Also may include use cases like hot-reloading web dev servers, interactive containers hooked up to a user's terminal, etc.
This is a pretty broad issue, should be broken down into subtasks. | https://github.com/dagger/dagger/issues/3037 | https://github.com/dagger/dagger/pull/4623 | a8e7cbc812bd496466f9e94d3e8f8608ec9c0bfb | a1d08f36e8f7af26757038e827a05b111ca24d0d | "2022-08-30T23:22:57Z" | go | "2023-02-21T21:23:54Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,096 | ["sdk/java/pom.xml"] | NodeJS SDK: decide how to package | Two approaches:
1. Monorepo - we keep it in cloak. This may mean we need to move its package.json to the root of the repo (not sure though, this is a requirement when specifying a dep on it using `git+ssh`, but maybe its not needed if we move to use `npm publish`)
2. Own-repo - we move it to something like `dagger/cloak-nodejs-sdk`
cc @slumbering @crjm | https://github.com/dagger/dagger/issues/3096 | https://github.com/dagger/dagger/pull/6000 | 6d053580767455219d4c1b65bb562c83920bcae9 | 73eadf183d051e22ae9d56bed962e07e1a02e8cd | "2022-08-25T18:57:54Z" | go | "2023-10-28T14:42:04Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,099 | ["sdk/java/pom.xml"] | Core API: support cache mounts | There should be a way to mount cache directories when executing a command in a container.
| https://github.com/dagger/dagger/issues/3099 | https://github.com/dagger/dagger/pull/6000 | 6d053580767455219d4c1b65bb562c83920bcae9 | 73eadf183d051e22ae9d56bed962e07e1a02e8cd | "2022-08-25T08:58:12Z" | go | "2023-10-28T14:42:04Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,043 | ["go.mod", "go.sum"] | Core API: support passing stdin to exec | It's possible to retrieve stdout and stderr from an exec, but not to inject stdin. This would be very useful.
```graphql
type Exec {
# This exists:
stdout: String
stderr: String
}
type ExecInput {
# This doesn't exist, but it should :)
stdin: String
}
``` | https://github.com/dagger/dagger/issues/3043 | https://github.com/dagger/dagger/pull/2969 | 8a11ef0dde4351b893d3d968800a79a6c46a1b58 | 24c6b8b33d2a0382aaf2a7b5398434c4e9af46b5 | "2022-08-25T08:08:09Z" | go | "2022-08-24T10:09:06Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,048 | ["website/yarn.lock"] | [Docs] Schema-based Reference Generation | We should implement schema-based API reference generation.
Will add more info as I research more.
Examples:
* [Spectaql](https://github.com/anvilco/spectaql)
* [Docusaurus Plugin](https://www.npmjs.com/package/docusaurus-graphql-plugin)
* [Anvil](https://www.useanvil.com/docs/api/getting-started) | https://github.com/dagger/dagger/issues/3048 | https://github.com/dagger/dagger/pull/996 | fb7cb95b06a9d719d483324a3e8e745ecbfc4e2d | 249a4b4a32a0bcadf6def8d25b61454d6f23d073 | "2022-08-24T18:19:35Z" | go | "2021-09-20T23:17:17Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 2,964 | ["website/yarn.lock"] | website: Review of onboardingv2 | Hey 👋 !
I've spent some time on the new version of our docs. That's an awesome work 👍 🚀 !! I'm sure this will help our users to find the appropriate path.
After using it, I saw minor issues + some suggestions.
## Overview page
- It should be titled **Overview** instead of Welcome. Every other pages are titled regarding their label in the sidebar (Install Dagger, How it works...).
- The image in the overview page (Where does Dagger fit?) looks wrong comparing to the original one. Colors looks purple instead of blue
- Paddings should be like in the mockup
## Quickstart Templates
- Sidebar label should be bold when page is selected
- The title of this section should be **Quickstart Templates** or the other way around, it should be **Explore our templates** in the sidebar.
## How It works
- Titles Core Concepts, References.... are smaller than mockups.
## Header
- We could improve the way we're displaying cta. Currently, we have an input style, a label (blog), two icons and one real button. Visually it looks a bit confusing. Grouping Github icon and toggle light/dark could be a first improvment (link in materialUI, https://mui.com/material-ui/). No need verticals bars if common components are grouped. The search input (which is a button in reality) looks lost in the middle. Like in material-ui, it should be align to the right and smaller.
cc @Camille-Elairin @crjm | https://github.com/dagger/dagger/issues/2964 | https://github.com/dagger/dagger/pull/750 | 66afb327d61c8af40d61f44dba7fdee8744e65a1 | 2d6bf2fa6413ee63ea0a20ba26896632beba3d67 | "2022-08-22T12:36:54Z" | go | "2021-07-01T09:42:07Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,050 | ["sdk/python/poetry.lock"] | `core` `git` should have `keepGitDir` option and perhaps `depth`. Should it be `true` by default? | I've found it confusing that when I see demos of doing a git pull of the `dagger/dagger` repo and a `dockerbuild` that the `docker version` command run afterwards doesn't show a short git hash in the version number like it does when I `git clone` and build `dagger` locally on my machine.
For example:
```
dagger devel (708210f74) darwin/arm64
```
```
dagger devel (708210f74) linux/arm64
```
```graphql
{
core {
git(remote: "https://github.com/dagger/dagger") {
dockerbuild(dockerfile: "Dockerfile") {
exec(input:{args:["dagger", "version"]}) {
stdout
}
}
}
}
}
{
"data": {
"core": {
"git": {
"dockerbuild": {
"exec": {
"stdout": "dagger devel () linux/arm64\n"
}
}
}
}
}
}
```
I expected a `git clone` type functionality. Not sure if other folks are expecting something else. If the size of the `.git` directory is a concern, we could use something like `git clone --depth=1`.
It seems that perhaps the default BuildKit behavior is to not preserve the `.git` directory (not sure), but I see that this is an option in BuildKit LLB land (depending on things like dockerfile frontends and such I think), and so we should have that option in `cloak` to keep the `.git` directory and likely limit the clone depth and other bells and whistles.
https://github.com/dagger/dagger/blob/main/plan/task/gitpull.go#L40-L43
https://github.com/dagger/dagger/blob/main/version/version.go#L16-L30
https://github.com/moby/buildkit/blob/master/frontend/dockerfile/docs/reference.md#example-keep-git-dir | https://github.com/dagger/dagger/issues/3050 | https://github.com/dagger/dagger/pull/4623 | a8e7cbc812bd496466f9e94d3e8f8608ec9c0bfb | a1d08f36e8f7af26757038e827a05b111ca24d0d | "2022-08-22T02:28:04Z" | go | "2023-02-21T21:23:54Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 2,962 | ["sdk/python/poetry.lock"] | can't open `/run/secrets/token` error not explicit enough | I cloned the dagger/todoapp repo, I copy/pasted the content of the workflows, and it failed with:
```
1:35PMINFclient.filesystem."./build".write | completed duration=200ms
1:35PMINFactions.deploy.container._exec | #19 0.364 cat: can't open '/run/secrets/token': No such file or directory
```
It was because I didn't set a `NETLIFY_TOKEN`. But it wasn't explicit about it.
We should intercept this error and make it more explicit:
> a secret seems to have not been set
> secrets have not been set in your CI environment
Of course, I'm open for better wording. | https://github.com/dagger/dagger/issues/2962 | https://github.com/dagger/dagger/pull/4623 | a8e7cbc812bd496466f9e94d3e8f8608ec9c0bfb | a1d08f36e8f7af26757038e827a05b111ca24d0d | "2022-08-19T15:18:23Z" | go | "2023-02-21T21:23:54Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 2,958 | ["docs/core-concepts/1220-vs.md", "docs/core-concepts/1221-action.md", "docs/getting-started/f44rm-how-it-works.mdx"] | Docs: confusing linear flow in "How it Works" | ## Problem
When I go to the new ["How it works" docs page](https://docs.dagger.io/f44rm/how-it-works), I expect that clicking "next" at the bottom of the page will take me linearly through each part of the "How it works". Instead it sends me to an entirely different section. I found that surprising and inconvenient
## Solution
Change the "next" link at the top of "How it works" section so that it allows a linear navigation through the section's contents.
| https://github.com/dagger/dagger/issues/2958 | https://github.com/dagger/dagger/pull/2960 | 00260de34bb3da07befb169ab14b97e3ab86ba62 | ca7328db02c8f8ca2206144b6ea024dd078eef08 | "2022-08-18T19:59:31Z" | go | "2022-08-19T11:47:51Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 2,946 | ["sdk/python/poetry.lock"] | ✨ feat: tooling to check broken links across dagger websites | Internal broken links are not being sufficiently monitered by Docusaurus: every week, we find at least one broken link.
The current best way to check them is to manually follow this command: https://github.com/dagger/dagger/blame/main/docs/README.md#L39.
However, it is not enough:
1. some internal redirections are not being caught when building the docs (relative path inclusion). It is however the recommended behavior from our docs (and theirs): https://docs.dagger.io/1227/contributing/#use-relative-file-paths-for-links
> Last example from yesterday https://github.com/dagger/dagger/pull/2940/files
2. Our tests don't cover the testing of broken links across our websites (especially our cloud one, for example)
_Example:_
I don't trust docusaurus anymore. So, prior each merge, I run `Integrity` on the netlify preview to do a first pass, but it shall be automated
cc @crjm | https://github.com/dagger/dagger/issues/2946 | https://github.com/dagger/dagger/pull/4623 | a8e7cbc812bd496466f9e94d3e8f8608ec9c0bfb | a1d08f36e8f7af26757038e827a05b111ca24d0d | "2022-08-16T16:30:23Z" | go | "2023-02-21T21:23:54Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 2,913 | ["pkg/universe.dagger.io/alpha/azure/aks/auth/kubeconfig.cue", "pkg/universe.dagger.io/alpha/azure/aks/helm/image.cue", "pkg/universe.dagger.io/alpha/azure/aks/helm/test/test.cue", "pkg/universe.dagger.io/alpha/azure/aks/helm/test/testdata/values.base.yaml", "pkg/universe.dagger.io/alpha/azure/aks/helm/test/testdata/values.staging.yaml", "pkg/universe.dagger.io/alpha/azure/aks/helm/upgrade.cue", "pkg/universe.dagger.io/alpha/azure/auth/token.cue", "pkg/universe.dagger.io/alpha/azure/test/test.cue"] | ✨ aks specific helm action with auth handling | ### What are you trying to do?
It would be nice to have a aks specific helm.#Upgrade action that handles the authentication part. If user credentials are used, the kubelogin plugin is required so the regular helm base image is not sufficient.
### Why is this important to you?
I want to be able to deploy to aks without alot of custom code or multiple actions to build an image and handle auth part.
### How are you currently working around this?
I am using custom actions. | https://github.com/dagger/dagger/issues/2913 | https://github.com/dagger/dagger/pull/2914 | f7414cb4cb80400ce2b5dfd8814627b5e32f7be4 | db05c3d8abbd37964856a0eed25069079f9aa913 | "2022-08-08T20:42:10Z" | go | "2022-08-25T21:37:18Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 2,911 | ["docs/README.md"] | docs: Update user docs on how to create docs | - especially new docs
- `npx docusaurus build`
- | https://github.com/dagger/dagger/issues/2911 | https://github.com/dagger/dagger/pull/2934 | ceed9ce9ee3f697824d288f889782a53cc22af36 | f8d597f66a94aecb90c0f0ccbaf34f8342f2ea2c | "2022-08-08T17:07:50Z" | go | "2022-08-12T19:58:50Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,066 | ["core/core.go", "core/core.schema.go", "core/filesystem/filesystem.go", "core/filesystem/image.go", "core/integration/core.schema_test.go"] | Use image config to configure action ExecOps | Right now any env vars (like `PATH`) or other configuration provided as part of an image config w/ the `FS` for a package don't get set when invoking the action, resulting in hacks like this: https://github.com/dagger/cloak/blob/e60aede62917e4e2711cca499d019c857f0b14ed/examples/netlify/ts/index.ts#L17-L17 | https://github.com/dagger/dagger/issues/3066 | https://github.com/dagger/dagger/pull/3137 | b7f3f4fece8cf49da229f395e5914a1c4d01512b | a1308896202d85adb6077c002ff819c07a2d392f | "2022-08-05T21:42:33Z" | go | "2022-09-27T16:38:56Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,077 | ["sdk/java/pom.xml"] | [ts] Implement client libraries | You should be able to use typed generated clients for calling other extensions when using Typescript.
Highly related to the corresponding go issue, could be tackled together possibly: https://github.com/dagger/dagger/issues/3079 | https://github.com/dagger/dagger/issues/3077 | https://github.com/dagger/dagger/pull/6000 | 6d053580767455219d4c1b65bb562c83920bcae9 | 73eadf183d051e22ae9d56bed962e07e1a02e8cd | "2022-08-05T20:33:33Z" | go | "2023-10-28T14:42:04Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,078 | ["sdk/java/pom.xml"] | [ts] Autogenerate implementation stubs | TS authors still have to write implementation from scratch based on their schema. We should support generating the implementation skeleton similar to the go dx today.
Can add support for `--sdk=ts` to `cloak generate` as part of this. | https://github.com/dagger/dagger/issues/3078 | https://github.com/dagger/dagger/pull/6000 | 6d053580767455219d4c1b65bb562c83920bcae9 | 73eadf183d051e22ae9d56bed962e07e1a02e8cd | "2022-08-05T20:31:20Z" | go | "2023-10-28T14:42:04Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 2,891 | ["sdk/python/poetry.lock"] | 🖐️ `"actions.test._template" is not set` BUT _template is just a sub-action not an input | ### Dagger Cloud run URL
https://dagger.cloud/runs/7849c1fd-8788-4b50-a02d-b5fb4b82d886
### What happened? What did you expect to happen?
The actions `Foo` is supposed to run a `Kustomize` action (under template field).
But seems like it at run time expect an input value in my dagger plan.
Why this happen ?
I expect this file to just run (or at least block later) | https://github.com/dagger/dagger/issues/2891 | https://github.com/dagger/dagger/pull/4611 | 6c057914ecc47b4cfb0a09c76f3307e1f9786649 | b26a6d20c8dc922c7b002a02e081a9b981f34082 | "2022-08-03T13:18:34Z" | go | "2023-02-16T13:24:57Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 2,879 | ["docs/core-concepts/1221-action.md"] | docs: usage of term "sub-action" may not be clear. | https://docs.dagger.io/1221/action/#definition
> Note that this action includes one sub-action: core.#WriteFile. An action can incorporate any number of sub-actions.
> "sub-actions" are simply fields which contain another action definition. For example, write is a sub-action.
> A new action is defined in a declarative template called a [CUE definition](https://cuetorials.com/overview/foundations/#definitions). This definition describes the action's inputs, outputs, sub-actions, and the wiring between them. | https://github.com/dagger/dagger/issues/2879 | https://github.com/dagger/dagger/pull/2897 | 43111b93f430bedb93e8ad53df90074b9e687a19 | 27f3dc49ce82e7531edff04972c7e67d0ba86ef3 | "2022-08-01T20:23:29Z" | go | "2022-08-04T17:16:36Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,116 | ["go.mod", "go.sum"] | Decide on resolver caching model | The current caching behavior around resolvers is ill-defined and surprising in certain cases.
Ideal goal (IMO): resolver results should be cached based purely on the inputs to the resolver. In other words, running the same resolver with the same inputs should result in execution being de-duplicated.
Places where we currently diverge:
1. Changing the selection set of a resolver results in the resolver running again.
2. Changing the args of a subresolver results in any ancestor resolvers running again.
3. Implicitly using a default value for an arg is cached different than explicitly providing the exact same default value of that arg.
Many use cases aren't meaningfully impacted by this. However, use cases that make heavy use of expensive operations performed directly in the action implementation (i.e. `netlify` deploy) can be meaningfully impacted. They can end up re-running many times with the exact same implementation running with the exact same inputs.
Various possible solutions for different subcases (not mutually exclusive):
1. Federation likely solves the problem for types being resolved across different services. Resolver input only goes up to the part of the query relevent to that subgraph, so changing the query after that won't change the input and thus won't affect caching.
* It does not impact resolution within a single subgraph though, at least out of the box. It's worth evaluating if we could find a way to re-use federation mechanisms for this case too though.
2. Having our cloak server always request the entire possible selection set can help in cases where there are no subresolvers that take args.
* This can't work when there are subresolvers that take args though
* It also has a downside when there are non-trivial subresolvers that take no args and perform expensive operations, in which case those expensive operations will always run whether or not they are needed for the actual request.
3. Switch from implementing actions as their own graphql servers (subgraphs) to a model where they accept input for a single resolver and call that resolver directly.
* This fixes all the caching problems in every case except for the default args one (`#3` above), both when resolver across different packages and within a single package.
* Major downside is that we use less "off-the-shelf" components in this model. This model is fairly simple, but will require more custom code in each language's SDK because it is specialized to our use case. | https://github.com/dagger/dagger/issues/3116 | https://github.com/dagger/dagger/pull/4891 | 344aa30e79dec7be1859292fa5ccd481b508ace4 | d069976fba5c8a0d385c4739e24e5ce366123ff9 | "2022-08-01T17:47:23Z" | go | "2023-04-12T10:31:31Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 3,117 | ["sdk/python/poetry.lock", "sdk/python/src/dagger/api/base.py", "sdk/python/src/dagger/codegen.py"] | Try moving to federation model | https://github.com/wundergraph/graphql-go-tools is a Go implementation of an apollo federation router. Federation is an existing framework that enables multiple graphql servers to be stitched together behind one unified gateway, which takes care of routing each resolver request to the correct backend "subgraph".
This is one potential route to solving the problem of how to resolve chainable `core` types like `Filesystem` when returned by non-`core` user packages. Early prototype here: https://github.com/dagger/cloak/tree/core-gqlgen | https://github.com/dagger/dagger/issues/3117 | https://github.com/dagger/dagger/pull/4647 | fbf5dc2a847534ac2e9bcdbf29ace8fbbe933db1 | 19c6dd8829a6523a60657a67c65de86a5da5781b | "2022-08-01T17:15:48Z" | go | "2023-02-25T00:20:27Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 2,860 | ["pkg/universe.dagger.io/alpha/azure/aks/auth/akscreds.sh", "pkg/universe.dagger.io/alpha/azure/aks/auth/image.cue", "pkg/universe.dagger.io/alpha/azure/aks/auth/kubeconfig.cue", "pkg/universe.dagger.io/alpha/azure/auth/azlogin.sh", "pkg/universe.dagger.io/alpha/azure/auth/image.cue", "pkg/universe.dagger.io/alpha/azure/auth/token.cue", "pkg/universe.dagger.io/alpha/azure/test/test.cue"] | ✨ AKS authentication | ### What are you trying to do?
It would be nice to have first class support to get a kubeconfig file for AKS and authenticate with something like service principal credentials.
### Why is this important to you?
We are deploying into AKS, and without authentication mechanism its not possible.
### How are you currently working around this?
I have custom scripts/images/actions that handle the auth part for me, so that I can use the resulting kubeconfig in actions that connect to the kubernetes API of the AKS cluster. | https://github.com/dagger/dagger/issues/2860 | https://github.com/dagger/dagger/pull/2871 | 1784000193b9cb31d1fbaaefc7d874a988cab224 | c5f3ca04af915df7a284d23a773b564b05f5f666 | "2022-07-26T18:48:07Z" | go | "2022-08-07T23:50:01Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 2,849 | ["docs/core-concepts/1202-plan.md"] | docs: "It all starts with a plan" -> "A Dagger Plan orchestrates the Actions" | idea to change Plan doc title to explain role of the Plan in relation to Actions versus making the Plan the "starting point" or "central focus".
"It all starts with a plan" -> "A Dagger Plan orchestrates the Actions" | https://github.com/dagger/dagger/issues/2849 | https://github.com/dagger/dagger/pull/2880 | 13baf532346477fe3d1a0f0501739df63b2ff987 | 727be287b77deaff11c4d2264451ed47adb73c11 | "2022-07-24T18:49:34Z" | go | "2022-08-02T12:42:35Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 2,847 | ["docs/getting-started/1201-ci-environment.md", "docs/tests/getting-started/azure-pipelines.yml"] | docs: Azure DevOps / ADO / Azure Pipelines Dagger example | https://github.com/dagger/dagger/discussions/1677#discussioncomment-3209966 | https://github.com/dagger/dagger/issues/2847 | https://github.com/dagger/dagger/pull/2904 | 562d96904c38b21fb7593ea12cc95b3e168d941f | c3ac7a18e590cd715b4f3613bc5ca0344c09f506 | "2022-07-22T22:33:57Z" | go | "2022-08-08T13:47:49Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 2,823 | [".github/workflows/auto-release.yml"] | ✨Publish releases to homebrew directly | ### What are you trying to do?
After dagger releases are crafted, homebrew update should fetch the latest version. There's a GH action that can be used for this.
ref: https://github.com/Homebrew/homebrew-core/pull/105746#issuecomment-1190567751
cc @gerhard
### Why is this important to you?
keep dagger updated
### How are you currently working around this?
downloading the new binary without homebrew. | https://github.com/dagger/dagger/issues/2823 | https://github.com/dagger/dagger/pull/2888 | c20b9396ad92e83ad6be075e4cda718b8c342105 | 41b7d6190bc6d7bde4894d32072e1d62b2a2c89e | "2022-07-20T17:46:54Z" | go | "2022-08-03T12:18:56Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 2,813 | ["docs/guidelines/1226-coding-style.md"] | Doco when it's good/needed to use Raw Strings: `docker.#Dockerfile`, `bash.#Run`, Coding Style, etc | ### What is the issue?
We advise users to generally avoid raw strings here: https://docs.dagger.io/1226/coding-style/#avoid-raw-strings
but they are needed when doing shell style line continuation such as
```
dockerfile: contents: """
FROM ubuntu:18.04 as PHP
ENV DEBIAN_FRONTEND noninteractive
RUN apt-get update && apt-get install -y \
nano \
....
```
where the above throws an error
`ERROR system | failed to load plan: unknown escape sequence:`
the error is corrected by using `#""" ... """#`
Was encountered by user adapting our example here https://docs.dagger.io/1205/container-images/ by adding their own Dockerfile code.
They noticed the issue not as an error message from `dagger do` but from VS Code giving them a red mark on the right. | https://github.com/dagger/dagger/issues/2813 | https://github.com/dagger/dagger/pull/2882 | 13e51b25521bc6fe3dfee2a1dad84b36f54fccad | 13baf532346477fe3d1a0f0501739df63b2ff987 | "2022-07-19T14:55:00Z" | go | "2022-08-02T12:41:49Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 2,804 | ["sdk/python/poetry.lock"] | ✨ exceeded rate limiting for the docker hub | ### What are you trying to do?
Users onboarding on Dagger sometimes need to login to their docker account in order to avoid triggering the rate limiting pull issues on the docker hub. However, most of our packages don't easily enable that.
Issue based on comments: https://github.com/dagger/dagger/issues/2238#issuecomment-1183530615
Solution:
```
The way @helderco suggested it was just to have two settings (e.g., DOCKERHUB_AUTH_USER, DOCKERHUB_AUTH_PASS) to apply in Go if they exist and the image to pull matches the index.docker.io registry, and has no auth.
```
Limitations: https://github.com/dagger/dagger/issues/2238#issuecomment-1183452408
Validated by @shykes: https://github.com/dagger/dagger/issues/2238#issuecomment-1183596368 | https://github.com/dagger/dagger/issues/2804 | https://github.com/dagger/dagger/pull/5105 | cf9aefba7728109f8b4c23cbf45624b2b4d86c37 | 395b0037507d89d441dcb192b5da8a5ad1165072 | "2022-07-16T01:04:46Z" | go | "2023-05-05T15:25:06Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 2,802 | ["pkg/universe.dagger.io/docker/run.cue"] | 🐞 Validator not detecting a valid FS reference | ### What is the issue?
There's an edge case **during plan validation** where `IsReference()` is returning `false`.
```cue
// doesn't work
actions: test: #Foo & {
bar: #Bar
}
#Foo: {
bar: #Bar
}
```
This should be the same as:
```cue
// works
actions: test: #Foo
#Foo: {
bar: #Bar & #Bar
}
```
In this case example, we're doing this (which seems reasonable):
<pre>output: <b>dagger.#FS & _exec.output</b></pre>
`v.ReferencePath()` returns an empty value.
As a workaround we can do this:
```diff
- output: dagger.#FS & _exec.output
+ output: _exec.output
```
But we should still detect this to avoid confusion in users.
### Log output
```console
ERROR system | failed to load plan: "actions.test.bar.output" is not set
```
### Steps to reproduce
```cue
package main
import (
"dagger.io/dagger"
"dagger.io/dagger/core"
)
dagger.#Plan & {
actions: test: #Foo & {
// commenting this line fixes the error
bar: #Bar
}
}
#Foo: {
bar: #Bar
}
#Bar: {
input: dagger.#Scratch
_exec: core.#Nop & {
"input": input
}
output: dagger.#FS & _exec.output
}
```
### Dagger version
dagger devel (dc615d220) darwin/arm64
### OS version
macOS 12.4 | https://github.com/dagger/dagger/issues/2802 | https://github.com/dagger/dagger/pull/2810 | 0a2445d7d8719f38ce55fde1c78d2d2b3a9ddc66 | dc615d2206641343da708741afa2d4889b5c2f2a | "2022-07-15T16:09:58Z" | go | "2022-07-20T11:37:05Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 2,785 | ["sdk/python/poetry.lock"] | ✨ create documentation endpoint at the import URL | ### Checklist
- [X] redirection of "universe.dagger.io/<optional package name>", "dagger.io/dagger", "dagger.io/dagger/core" to GitHub trees
- [ ] catalog/docs with detailed info on usage of packages and their actions
### What are you trying to do?
When people see the CUE code, [some (myself and some other daggernaut as well)](https://discord.com/channels/707636530424053791/709803368318632038/995115047816806410) try to actually access that URL.
Except for now, there is no service running at that address.
### Why is this important to you?
It would be great if we could host some documentation server at that URL, so people could actually explore what there is in this package. It would improve self exploration of the packages documentation.
As a first step, we could just redirect to the github repo, in the correct directory (since anyway, we don't manage URL that are not part of `dagger.io` yet)
### How are you currently working around this?
When I didn't know Dagger at all, I didn't even know where to look. I didn't know the existence of the https://github.com/dagger/dagger/pkg directory, and that it was there that the system was looking. It is not intuitive.
Once you know, you go to github, and look in that directory, but that is bad UX.
Without even taking into account the actual code that is used for this plan that should be in your `cue.mod` directory.
LSP will improve this explorability, but this should also be taken into account, URL that points to nowhere are never useful. | https://github.com/dagger/dagger/issues/2785 | https://github.com/dagger/dagger/pull/5105 | cf9aefba7728109f8b4c23cbf45624b2b4d86c37 | 395b0037507d89d441dcb192b5da8a5ad1165072 | "2022-07-12T11:20:46Z" | go | "2023-05-05T15:25:06Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 2,774 | ["website/yarn.lock"] | ✨ Allow multiple tags in `docker.#Push` and `cli.#Load` | ### What are you trying to do?
Sometimes you want to push an image to multiple tags (e.g., `0.1.0` and `latest`). BuildKit supports this by setting `name` to multiple values split by a comma:
```cue
push: core.#Push & {
dest: "localhost:5042/test1:\(randomString.output),localhost:5042/test1:latest,localhost:5042/test1:random"
input: randomString.image.output
config: env: FOO: randomString.output
}
```
<details><summary>Full plan</summary>
```cue
package main
import (
"dagger.io/dagger"
"dagger.io/dagger/core"
)
dagger.#Plan & {
actions: {
randomString: {
baseImage: core.#Pull & {
source: "alpine:3.15.0@sha256:e7d88de73db3d3fd9b2d63aa7f447a10fd0220b7cbf39803c803f2af9ba256b3"
}
image: core.#Exec & {
input: baseImage.output
args: [
"sh", "-c", "echo -n $RANDOM > /output.txt",
]
}
outputFile: core.#ReadFile & {
input: image.output
path: "/output.txt"
}
output: outputFile.contents
}
// Push image with random content
push: core.#Push & {
dest: "localhost:5042/test1:\(randomString.output),localhost:5042/test1:latest,localhost:5042/test1:random"
input: randomString.image.output
config: env: FOO: randomString.output
}
}
}
```
</details>
This doesn't work only because we're parsing `dest` and normalizing it, but we can change this. Either:
1. Split string by comma, normalize parts and join back with comma to give to BuildKit
2. Allow `dest` to accept a list of values:
```cue
docker.#Push & {
dest: [
"<registry>/<image>:tag1",
"<registry>/<image>:tag2",
"<registry>/<image>:latest",
]
}
```
Question here is how to handle result. Currently we have a single `result: string`. Same as `dest`, it can
1. Be different fields for `string` and `[...string]`
2. Same field with `string | [...string]`
3. Maybe always `[...string]`
Sometimes the _result_ value is used directly somewhere and it needs to handled differently if it's a list. There's also the question of the action's output, since a list won't be shown in plain format (default). But we can support lists with something like this:
```console
➜ dagger do push
[✔] ...
[✔] actions.push
Field Value
result.0 "localhost:5042/example:latest@sha256:47a163eb7b572819d862b4a2c95a399829c8c79fab51f1d40c59708aa0e35331"
result.1 "localhost:5042/example:0.1.0@sha256:47a163eb7b572819d862b4a2c95a399829c8c79fab51f1d40c59708aa0e35331"
```
### Why is this important to you?
This has been asked multiple times in Discord and it's not hard to do.
### How are you currently working around this?
Just using multiple `docker.#Push` in a template or loop with different targets.
With `cli.#Load` there's a bigger performance impact though. I recommended a user in Discord to run `docker tag` after the `cli.#Load` to go around the perfomance hit:
```cue
actions: images: {
img1: tags: {
latest: _
"0.1.0": _
}
img2: tags: {
latest: _
"0.1.0": _
}
img3: tags: {
latest: _
"0.1.0": _
}
[img=string]: {
build: docker.#Dockerfile & {
source: client.filesystem["./images/\(img)"].read.contents
}
load: cli.#Load & {
image: build.output
host: client.network."unix:///var/run/docker.sock".connect
tag: img
}
tags: {
[imagetag=string]: {
tag: cli.#Run & {
host: client.network."unix:///var/run/docker.sock".connect
env: DEP: "\(load.success)"
command: {
name: "tag"
args: [load.tag, "\(img):\(imagetag)"]
}
}
}
}
}
}
``` | https://github.com/dagger/dagger/issues/2774 | https://github.com/dagger/dagger/pull/750 | 66afb327d61c8af40d61f44dba7fdee8744e65a1 | 2d6bf2fa6413ee63ea0a20ba26896632beba3d67 | "2022-07-10T13:20:24Z" | go | "2021-07-01T09:42:07Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 2,771 | ["go.mod", "go.sum"] | 🐞 event log in TTY seems to only update/display 1 group at a time | ### What is the issue?
It seems that log output for each group is somewhat buggy as only 1 group has a live stream of events getting updated.
### Log output
_No response_
### Steps to reproduce
```
dagger do --log-format=tty -p ci.cue test
```
### Dagger version
v0.2.22
### OS version
Ubuntu 20.04 | https://github.com/dagger/dagger/issues/2771 | https://github.com/dagger/dagger/pull/2101 | 48888cf540cca4ed76481e67c5946e9a452d3e0a | b60c21039bdc27c9566c0100e9da6407c1b29eae | "2022-07-09T15:31:43Z" | go | "2022-04-13T19:15:41Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 2,732 | ["sdk/python/poetry.lock"] | ✨ Let core.#Source use a file list for includes/excludes | ### What are you trying to do?
When I use `core.#Source` for a node project, I only want to include files that are actually tracked in git. Conveniently, we already have files that tell git what to ignore ie. `.gitignore`. It would be nice if we had 2 things:
1. Recursive exclude - Currently, excluding "node_modules" only excludes the top level folder, but not any in subfolders
2. The ability to reference a file with a list of files to exclude. In this case, `.gitignore`.
I apologize if this *is* possible in some way. The documentation for built-in actions is pretty much non-existent. This is the closest I could find: https://docs.dagger.io/1222/core-actions-reference. But that doesn't detail anything about what each actions' parameters are or how to use them
### Why is this important to you?
Combining those 2 things, I could easily ignore all "node_modules", "dist", ".git", etc. folders throughout a monorepo. This is a step towards the goal of the local pipeline running the same way it would in CI environment.
### How are you currently working around this?
I have to manually exclude every single file I don't want:
```cue
getSource: core.#Source & {
path: "."
exclude: [
"node_modules",
"client/node_modules",
"shared/node_modules",
"server/node_modules",
"client/dist",
"shared/dist",
"server/dist",
"cue.mod"
]
}
``` | https://github.com/dagger/dagger/issues/2732 | https://github.com/dagger/dagger/pull/4623 | a8e7cbc812bd496466f9e94d3e8f8608ec9c0bfb | a1d08f36e8f7af26757038e827a05b111ca24d0d | "2022-06-30T16:06:44Z" | go | "2023-02-21T21:23:54Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 2,701 | ["docs/core-concepts/1221-action.md"] | docs: Explain Universe packages/actions in Core Concepts/Actions | https://docs.dagger.io/1221/action
Mentions two kinds of actions: core and composite. It should be clear that Universe is a set of ready-to-use (and emulate and extend) composite actions. | https://github.com/dagger/dagger/issues/2701 | https://github.com/dagger/dagger/pull/2897 | 43111b93f430bedb93e8ad53df90074b9e687a19 | 27f3dc49ce82e7531edff04972c7e67d0ba86ef3 | "2022-06-21T20:38:08Z" | go | "2022-08-04T17:16:36Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 2,694 | ["docs/getting-started/index.md", "docs/index.md"] | "Get started" link on homepage is broken | ### What is the issue?
On the https://dagger.io/ page there is a "Get started" link to https://docs.dagger.io/getting-started which shows "Page Not Found." | https://github.com/dagger/dagger/issues/2694 | https://github.com/dagger/dagger/pull/2696 | 64c6a6a23c2edba90cb2649b29ddfb16c1c21a98 | 16db5897273b16a39d5011fb36d78269c5a88225 | "2022-06-21T10:55:22Z" | go | "2022-06-21T18:39:40Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 2,687 | ["docs/getting-started/1200-local-dev.md", "docs/getting-started/1201-ci-environment.md", "docs/getting-started/1240-install.md", "docs/getting-started/index.md", "docs/introduction/1220-vs.md", "docs/introduction/1235-what.md", "docs/introduction/index.md", "website/sidebars.js"] | Getting Started Locally as main entry point to docs | <img width="1550" alt="image" src="https://user-images.githubusercontent.com/3187222/174681816-42b45ef2-6379-4b35-b39f-4494012a22ec.png"> | https://github.com/dagger/dagger/issues/2687 | https://github.com/dagger/dagger/pull/2690 | aa0c649c20d84461bc7449a06fadebcffbadfe39 | 0b89d1f103d398be671305e5670df07b2ffd57b8 | "2022-06-20T19:35:46Z" | go | "2022-06-21T04:03:04Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 2,680 | ["go.mod", "go.sum"] | 🐞 Optional env vars cannot be used as env vars | ### What is the issue?
Environment variables marked as optional cannot be used as environment variables in actions. For example, the following plan would fail:
```cue
package main
import (
"dagger.io/dagger"
"universe.dagger.io/alpine"
"universe.dagger.io/bash"
)
dagger.#Plan & {
client: env: {
TEST_OPTIONAL?: dagger.#Secret
}
actions: {
test: {
run: bash.#Run & {
_image: alpine.#Build & {
packages: {
bash: _
}
}
input: _image.output
script: contents: "test \"$TEST_OPTIONAL\" = foobar"
if client.env.TEST_OPTIONAL != _|_ {
env: TEST_OPTIONAL: client.env.TEST_OPTIONAL
}
}
}
}
}
```
It's not that simple though: if I remove the conditional check, the plan succeeds.
To make matters even more complicated, I tried to submit a failing test: #2679 ....but it doesn't fail.
Based on that, I tried to update the above plan with a snippet from the aformentioned test:
```cue
package main
import (
"dagger.io/dagger"
"dagger.io/dagger/core"
"universe.dagger.io/alpine"
"universe.dagger.io/bash"
)
dagger.#Plan & {
client: env: {
TEST_OPTIONAL?: dagger.#Secret
}
actions: {
image: core.#Pull & {
source: "alpine:3.15.0@sha256:e7d88de73db3d3fd9b2d63aa7f447a10fd0220b7cbf39803c803f2af9ba256b3"
}
test: {
exec: core.#Exec & {
input: image.output
if client.env.TEST_OPTIONAL != _|_ {
env: TEST_OPTIONAL: client.env.TEST_OPTIONAL
}
args: ["sh", "-c", "test $TEST_OPTIONAL = foobar"]
}
run: bash.#Run & {
_image: alpine.#Build & {
packages: {
bash: _
}
}
input: _image.output
script: contents: "test \"$TEST_OPTIONAL\" = foobar"
if client.env.TEST_OPTIONAL != _|_ {
env: TEST_OPTIONAL: client.env.TEST_OPTIONAL
}
}
}
}
}
```
As you might guess, it no longer fails.
### Log output
❯ TEST_OPTIONAL=foobar dagger do -p secrettest.cue test --log-format plain --no-cache
10:55AM INF actions.test.run.script._write | computing
10:55AM INF client.env | computing
10:55AM INF actions.test.run._image._dag."0"._op | computing
10:55AM INF client.env | completed duration=0s
10:55AM INF actions.test.run.script._write | completed duration=0s
10:55AM INF actions.test.run._image._dag."0"._op | completed duration=0s
10:55AM INF actions.test.run._image._dag."1"._exec | computing
10:55AM INF actions.test.run._image._dag."1"._exec | #4 0.081 fetch https://dl-cdn.alpinelinux.org/alpine/v3.15/main/x86_64/APKINDEX.tar.gz
10:55AM INF actions.test.run._image._dag."1"._exec | #4 0.419 fetch https://dl-cdn.alpinelinux.org/alpine/v3.15/community/x86_64/APKINDEX.tar.gz
10:55AM INF actions.test.run._image._dag."1"._exec | #4 0.672 (1/4) Installing ncurses-terminfo-base (6.3_p20211120-r0)
10:55AM INF actions.test.run._image._dag."1"._exec | #4 0.710 (2/4) Installing ncurses-libs (6.3_p20211120-r0)
10:55AM INF actions.test.run._image._dag."1"._exec | #4 0.753 (3/4) Installing readline (8.1.1-r0)
10:55AM INF actions.test.run._image._dag."1"._exec | #4 0.792 (4/4) Installing bash (5.1.16-r0)
10:55AM INF actions.test.run._image._dag."1"._exec | #4 0.909 Executing bash-5.1.16-r0.post-install
10:55AM INF actions.test.run._image._dag."1"._exec | completed duration=1s
10:55AM INF actions.test.run._exec | computing
10:55AM INF actions.test.run._image._dag."1"._exec | #4 0.912 Executing busybox-1.34.1-r3.trigger
10:55AM INF actions.test.run._image._dag."1"._exec | #4 0.917 OK: 8 MiB in 18 packages
10:55AM INF actions.test.run._exec | completed duration=100ms
❯ TEST_OPTIONAL=foobar dagger do -p secrettest.cue test --log-format plain --no-cache
10:55AM INF actions.test.run.script._write | computing
10:55AM INF actions.test.run._image._dag."0"._op | computing
10:55AM INF actions.test.run.script._write | completed duration=0s
10:55AM INF actions.test.run._image._dag."0"._op | completed duration=0s
10:55AM INF actions.test.run._image._dag."1"._exec | computing
10:55AM INF actions.test.run._image._dag."1"._exec | #4 0.082 fetch https://dl-cdn.alpinelinux.org/alpine/v3.15/main/x86_64/APKINDEX.tar.gz
10:55AM INF actions.test.run._image._dag."1"._exec | #4 0.431 fetch https://dl-cdn.alpinelinux.org/alpine/v3.15/community/x86_64/APKINDEX.tar.gz
10:55AM INF actions.test.run._image._dag."1"._exec | #4 0.674 (1/4) Installing ncurses-terminfo-base (6.3_p20211120-r0)
10:55AM INF actions.test.run._image._dag."1"._exec | #4 0.720 (2/4) Installing ncurses-libs (6.3_p20211120-r0)
10:55AM INF actions.test.run._image._dag."1"._exec | #4 0.769 (3/4) Installing readline (8.1.1-r0)
10:55AM INF actions.test.run._image._dag."1"._exec | #4 0.814 (4/4) Installing bash (5.1.16-r0)
10:55AM INF actions.test.run._image._dag."1"._exec | #4 0.933 Executing bash-5.1.16-r0.post-install
10:55AM INF actions.test.run._image._dag."1"._exec | completed duration=1s
10:55AM INF actions.test.run._exec | computing
10:55AM INF actions.test.run._image._dag."1"._exec | #4 0.937 Executing busybox-1.34.1-r3.trigger
10:55AM INF actions.test.run._image._dag."1"._exec | #4 0.941 OK: 8 MiB in 18 packages
10:55AM ERR actions.test.run._exec | failed: process "bash --norc -e -o pipefail /bash/scripts/run.sh" did not complete successfully: exit code: 1
duration=100ms
10:55AM FTL system | failed to execute plan: task failed: actions.test.run._exec: process "bash --norc -e -o pipefail /bash/scripts/run.sh" did not complete successfully: exit code: 1
### Steps to reproduce
See the above plans.
### Dagger version
0.2.19
### OS version
macOS | https://github.com/dagger/dagger/issues/2680 | https://github.com/dagger/dagger/pull/5104 | e4b27f0082c88c9b497296b3e81ee0045a381aa7 | 2ebc67b902de300dcfb647a258b6560cd90552d7 | "2022-06-19T09:06:02Z" | go | "2023-05-05T14:55:28Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 2,677 | ["docs/guides/concepts/4dhu9-api-customizable-image.md", "docs/tests/guides/customizable-image/image_configurable.cue", "docs/tests/guides/customizable-image/image_pip.cue", "docs/tests/guides/customizable-image/image_simple.cue", "docs/tests/guides/customizable-image/run.cue", "docs/tests/guides/customizable-image/run_base.cue", "website/static/_redirects"] | Guide to show how to write Actions with customizable images (registry/repo/version) with good defaults | ### What is the issue?
Today, some Universe Actions have hard-coded images or versions, in general, these should be customizable by the consumer of the package.
Example of solution: https://github.com/dagger/dagger/pull/2632/files
Example of issue: #2604 | https://github.com/dagger/dagger/issues/2677 | https://github.com/dagger/dagger/pull/2924 | 0140e51c3cae567d5a70f73634dc15dea5b40944 | 3c45b6cd0c094214791e9190d8035afb792f78ac | "2022-06-18T18:18:33Z" | go | "2022-08-17T08:52:27Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 2,653 | ["docs/core-concepts/1215-what-is-cue.md"] | CUE docs gotchas updates | ### What is the issue?
need to make sure there are docs on these gotchas:
https://cuelang.org/play/?id=mfAIAXR-uEs#cue@export@cue
template syntax vs array syntax vs string interpolation
template: `flags: [string]: string | bool` where this would be valid
```
flags: {
"--foo": "bar:
"baz": true
}
```
vs array: `args: [...string]` where this would be valid
```
args: ["foo", "bar", "baz"]
```
and `myarg: args[1]` evals to means `myarg` evals to `"bar"`
vs string interpolation: `hello: "Hello \(myarg)"`
vs
non-interpolated string:`hello2: "Hello " + (myarg)`
| https://github.com/dagger/dagger/issues/2653 | https://github.com/dagger/dagger/pull/2875 | 7aa1b8ad5f9fd9a7dcd6523dac2c08333a66c35a | b504d40f162a51a7fea6c995a97fec108792e583 | "2022-06-16T01:11:32Z" | go | "2022-08-01T20:20:03Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 2,650 | ["go.mod", "go.sum"] | Gradle Starter Template | We'd love to have a gradle starter template.
Recommended approach and best practices for creating a starter template - (coming soon with https://github.com/dagger/dagger/issues/2642 ) | https://github.com/dagger/dagger/issues/2650 | https://github.com/dagger/dagger/pull/1669 | 41320b6032041fe691379bacfbc2190af4d91b73 | bcbe5f7f3538ee273ed481fdbc8b0ee8ab16799e | "2022-06-15T21:33:37Z" | go | "2022-02-28T19:20:57Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 2,638 | ["pkg/universe.dagger.io/bash/bash.cue"] | bash package should accept flags in addition to args | null | https://github.com/dagger/dagger/issues/2638 | https://github.com/dagger/dagger/pull/2641 | e3ae60de1517aae047968614bfbd2b0092236b4a | 4714f9156bf597315c6a5f77072a1aa2dde2b800 | "2022-06-15T19:12:02Z" | go | "2022-06-15T21:20:36Z" |
closed | dagger/dagger | https://github.com/dagger/dagger | 2,635 | ["sdk/python/poetry.lock"] | Guide for Universe contribs (alpha, beta, stable) | Either new guide and link from
- https://docs.dagger.io/1227/contributing
or inclusion in that guide
based on https://github.com/dagger/dagger/discussions/2616 | https://github.com/dagger/dagger/issues/2635 | https://github.com/dagger/dagger/pull/5105 | cf9aefba7728109f8b4c23cbf45624b2b4d86c37 | 395b0037507d89d441dcb192b5da8a5ad1165072 | "2022-06-15T17:02:47Z" | go | "2023-05-05T15:25:06Z" |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.