status
stringclasses 1
value | repo_name
stringclasses 13
values | repo_url
stringclasses 13
values | issue_id
int64 1
104k
| updated_files
stringlengths 11
1.76k
| title
stringlengths 4
369
| body
stringlengths 0
254k
⌀ | issue_url
stringlengths 38
55
| pull_url
stringlengths 38
53
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
unknown | language
stringclasses 5
values | commit_datetime
unknown |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed | vercel/next.js | https://github.com/vercel/next.js | 18,337 | ["packages/next/build/webpack/loaders/next-serverless-loader.ts", "packages/next/client/index.tsx", "packages/next/next-server/server/next-server.ts", "test/integration/i18n-support/pages/_app.js", "test/integration/i18n-support/pages/another.js", "test/integration/i18n-support/pages/gsp/fallback/[slug].js", "test/integration/i18n-support/pages/gsp/no-fallback/[slug].js", "test/integration/i18n-support/pages/index.js", "test/integration/i18n-support/pages/links.js", "test/integration/i18n-support/test/index.test.js"] | Wrong defaultLocale on non-index pages on client-side and detected language redirect doesn't work. | # Bug report
## Describe the bug
On non-index pages `defaultLocale` overrided was with detected language, only happend on client-side. At the same time `defaultLocale` was correct on the server-side. Also on non-index pages detected language redirect doesn't work.
## To Reproduce
Check out the [repository](https://github.com/dmitrykozyrenko/next10-i18n-routing-issue)
## Expected behavior
`defaultLocale` should be immutable, detected language redirect should work on non-index pages.
## Screenshots
### pages/index
server-side
client-side
### pages/test
server-side
client-side
## System information
- OS: Windows
- Browser chrome
- Version of Next.js: 10.0.0
- Version of Node.js: 12.16.1 | https://github.com/vercel/next.js/issues/18337 | https://github.com/vercel/next.js/pull/18708 | c8d26edf5794c65a6b9d83b11ffbd6fb8412c9c5 | 7b6a61a750d888a1fa0c213c9b1916db1e21e740 | "2020-10-27T20:50:08Z" | javascript | "2020-11-02T23:00:41Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,332 | ["packages/next/next-server/lib/router/router.ts", "test/integration/i18n-support/pages/frank.js", "test/integration/i18n-support/test/index.test.js"] | next/link & next/router - using getStaticProps with a route that starts with the same characters as defaultLocale | # Bug report
## Describe the bug
When using a `defaultLocale` (e.g. `"de"`) in combination with `getStaticProps` and a route that starts with the same characters as the `defaultLocale` (e.g. `/pages/details/[slug].js`) we cannot visit the page when using `next/link` or `next/router`.
## To Reproduce
Check out the [repository](https://github.com/ankri/next-locale-bug)
1. Create a [next.config.js](https://github.com/ankri/next-locale-bug/blob/main/next.config.js) with `defaultLocale: "de"`
2. Create a page starting with `de`: [/pages/details/[slug].js](https://github.com/ankri/next-locale-bug/blob/main/pages/details/%5Bslug%5D.js)
3. Use next/link or a next/router to [link to the page](https://github.com/ankri/next-locale-bug/blob/main/pages/index.js#L12-L14)
## Expected behavior
When clicking on the `/de/details/slug-1` link (or the router button) the page should load. But instead we get the following error:
## Screenshots
## System information
- NextJS 10.0.0
## Additional context
It works when we bypass the link or router by entering the URL for the page.
The app can be built. The same error occurs in the built version. | https://github.com/vercel/next.js/issues/18332 | https://github.com/vercel/next.js/pull/18712 | 7b6a61a750d888a1fa0c213c9b1916db1e21e740 | 3f84a55ba38649ee81fbc703ccb1173de896d4de | "2020-10-27T20:12:42Z" | javascript | "2020-11-02T23:32:56Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,293 | ["packages/next/build/webpack/loaders/next-serverless-loader.ts", "test/integration/i18n-support/pages/not-found/blocking-fallback/[slug].js", "test/integration/i18n-support/test/index.test.js"] | [9.5.6-canary.17][notFound][Vercel] incorrect props in custom 404-page when using blocking fallback | # Bug report
## Describe the bug
I use the `notFound` feature on SSG pages with enabled **blocking** fallback. The custom 404-page gets incorrect props from `getStaticProps` when `notFound` occurs. This happens only when an app is deployed to Vercel.
## To Reproduce
Repository: [next.js-bug-not-found-props](https://github.com/rokinsky/next.js-bug-not-found-props)
Steps to reproduce the behavior:
1. Deploy the app to Vercel
2. Go to the website, e.g. [https://next-js-bug-not-found-props.vercel.app](https://next-js-bug-not-found-props.vercel.app)
2. See
```json
{
"url": {
"query": {},
"pathname": "/404",
"asPath": "/[[...slug]]"
}
}
```
first and see
```json
{
"url": {
"query": {},
"pathname": "/404",
"asPath": "/"
}
}
```
after hydration
## Expected behavior
Displaying
```json
{
"is404": true
}
```
## Screenshots
N/A
## System information
- OS:macOS
- Browser (if applies): chrome
- Version of Next.js: 9.5.6-canary.17
- Version of Node.js: v10.22.1
## Additional context
Works great locally in dev and prod modes. | https://github.com/vercel/next.js/issues/18293 | https://github.com/vercel/next.js/pull/18300 | f7ba546e8afca0e72c5198aa5e383d1bf85dc655 | 0f2505147031ffa4e767a4cce2a8634a32df42d8 | "2020-10-27T12:38:15Z" | javascript | "2020-10-27T15:11:51Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,275 | ["docs/advanced-features/automatic-static-optimization.md", "docs/api-reference/next.config.js/static-optimization-indicator.md", "docs/manifest.json", "examples/with-magic/next.config.js", "packages/next/build/webpack-config.ts", "packages/next/client/dev/prerender-indicator.js", "packages/next/client/next-dev.js", "packages/next/next-server/server/config.ts", "test/integration/nullish-config/test/index.test.js", "test/isolated/config.test.js"] | Default Static Optimization Indicator to false | # Feature request
For validation of this feature request see [almost all the comments on "How to remove the clickable label "Prerendered Page" and loading Icon ? #7945"](https://github.com/vercel/next.js/issues/7945).
The automatic Static Optimization Indicator is providing important information, but that information is being handled in *an undesirable manner for DX and dev team collaboration.* In many cases, the indication can get in the way of the app's UI during development, creating a frustrating developer experience for Next users.
It also creates a frustrating experience for designers and other non-developer stakeholders, who don't immediately understand that the icon is only visible in development, and think the app is somehow broken or poorly designed.
It creates a frustrating experience for new feature demos, as well.
I understand that you can opt-out, but you shouldn't have to opt-out of obtrusive features, you should have to opt-in to them.
## Describe the solution you'd like
The situation that the indicator is indicating *should* be the default situation for most pages in a Next site. The indicator is intrusively shouting at us "EVERYTHING IS NORMAL AND OK!"
ummm... thanks? Why not warn me when it's abnormal and NOT OK, instead? And why not put the warning in the developer console instead of on the UI screen so we don't give the designers and other non-dev contributors a heart attack?
## Describe alternatives you've considered
Stuff like this would be great in a DevTools extension similar to React or Redux DevTools. Make all the alarming indicators you want *somewhere other than the app UI screen*.
| https://github.com/vercel/next.js/issues/18275 | https://github.com/vercel/next.js/pull/18629 | fb58d95db7a703ba1b0132000882716f44a0200e | 197d46ddb9bebc4a74360e66f50b091edd811ae0 | "2020-10-26T22:21:28Z" | javascript | "2020-11-02T08:27:36Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,228 | ["packages/next/lib/is-serializable-props.ts", "test/unit/is-serializable-props.test.js"] | Nested empty arrays incorrectly detected as cyclical | # Bug report
## Describe the bug
Empty arrays that are nested in other arrays are detected as cyclical, despite no cycle existing.
## To Reproduce
```js
export const getServerSideProps: GetServerSideProps = async (context) => {
const x = [];
return {props: {foo: [x, [x]]}};
};
```
## Expected behavior
The data should be serializable.
## Additional context
google-protobuf produces arrays of this form, and they are not problematic when serialized using `JSON.stringify`. | https://github.com/vercel/next.js/issues/18228 | https://github.com/vercel/next.js/pull/18232 | 91d4aa54506a68a99f99b8edcfea10a73bea2ec2 | bbde18f1203342017e55e652172e459441295c03 | "2020-10-25T18:56:42Z" | javascript | "2020-11-09T14:25:41Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,212 | ["packages/next/next-server/lib/router/router.ts", "packages/next/next-server/server/next-server.ts", "test/integration/i18n-support/pages/404.js", "test/integration/i18n-support/test/index.test.js"] | [9.5.6-canary.14][notFound] incorrect props in custom 404-page when using fallback | # Bug report
## Describe the bug
I use the experimental `unstable_notFound` feature on SSG pages with enabled fallback. The custom 404-page gets incorrect props from `getStaticProps` when `notFound` occurs.
## To Reproduce
Repository: [next.js-bug-not-found-props](https://github.com/rokinsky/next.js-bug-not-found-props)
Steps to reproduce the behavior:
1. Go to [http://localhost:3000](http://localhost:3000)
2. See
```json
{
"statusCode": 404,
"url": {
"query": {},
"pathname": "/[[...slug]]",
"asPath": "/"
}
}
```
## Expected behavior
Displaying
```json
{
"is404": true
}
```
## Screenshots
N/A
## System information
- OS:macOS
- Browser (if applies): chrome
- Version of Next.js: 9.5.6-canary.14
- Version of Node.js: v10.22.1
## Additional context
N/A
| https://github.com/vercel/next.js/issues/18212 | https://github.com/vercel/next.js/pull/18214 | 11fce3a6861c2415ed2dfdc411e428e142373f96 | 9a770bde841d39a5351b9e371b914c7f6dd84e70 | "2020-10-24T22:45:09Z" | javascript | "2020-10-27T09:40:17Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,196 | ["packages/next/next-server/server/next-server.ts", "packages/next/next-server/server/render.tsx", "test/integration/i18n-support/pages/404.js", "test/integration/i18n-support/test/index.test.js", "yarn.lock"] | [9.5.6-canary.13][notFound] custom 404-page rendering crashes in prod mode | # Bug report
## Describe the bug
I use the experimental `unstable_notFound` feature on SSG/ISG pages and it fails in production mode when the custom-404 page uses `getStaticProps`.
## To Reproduce
Repository: [next.js-bug-not-found](https://github.com/rokinsky/next.js-bug-not-found)
Steps to reproduce the behavior:
1. `yarn build && yarn start`
2. Go to [http://localhost:3000](http://localhost:3000)
3. See Internal Server Error
## Expected behavior
Displaying "not-found" with 404 status code.
## Screenshots
<img width="874" alt="Screenshot 2020-10-24 at 17 20 22" src="https://user-images.githubusercontent.com/20644874/97084174-c92d8b80-161d-11eb-9b5d-09f0ac0bf30c.png">
## System information
- OS:macOS
- Browser (if applies): chrome
- Version of Next.js: 9.5.6-canary.13
- Version of Node.js: v10.22.1
## Additional context
Works fine in dev mode.
| https://github.com/vercel/next.js/issues/18196 | https://github.com/vercel/next.js/pull/18205 | 299fba162a539912e05c5000aae68641f3233dc5 | ebee2bafa935b6474d87a45060ffeb9b7770359f | "2020-10-24T14:42:54Z" | javascript | "2020-10-24T19:22:48Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,163 | ["docs/advanced-features/multi-zones.md"] | [Docs] Deprecated @now/next used in code example | On [Multi Zones](https://nextjs.org/docs/advanced-features/multi-zones) we have this code example:
```json
{
"version": 2,
"builds": [
{ "src": "blog/package.json", "use": "@now/next" },
{ "src": "home/package.json", "use": "@now/next" }
],
"routes": [
{ "src": "/blog/_next(.*)", "dest": "blog/_next$1" },
{ "src": "/blog(.*)", "dest": "blog/blog$1" },
{ "src": "(.*)", "dest": "home$1" }
]
}
```
Visiting [npm @now/next](https://www.npmjs.com/package/@now/next), it says that the package is deprecated and you should use _@vercel/next_ instead. I've never used the multi-zones feature but I presume @vercel/next is correct here? | https://github.com/vercel/next.js/issues/18163 | https://github.com/vercel/next.js/pull/18246 | a9984e4026256c7e300678be696221327a0dcdbc | 774286fcc3aea59f7c284c84b78b274eaec4958a | "2020-10-23T09:11:21Z" | javascript | "2020-10-27T12:45:52Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,127 | ["packages/next/src/client/index.tsx"] | next/router - push function changes between renders when called | # Bug report
Depending on the `push` function of `useRouter` causes an infinite loop when the `push` function is called from inside a `useEffect`
## To Reproduce
1. Set up a catch-all optional dynamic route `[[...slug]].js`
2. Render the following component from this page
Example component
```
const BugExample = () => {
useEffect(() => {
push('/[[...slug]]', '/123/test', { shallow: true })
console.log('called');
},[push])
return null
}
```
You will see an infinite loop of `called` in the console
## Expected behavior
Push should be a non-changing reference, so that the react diff algoirithm knows not to call side effects again uneccesarily
## System information
- OS: macOs
- Browser: Chrome
- Version of Next.js: 9.5
- Version of Node.js: 13.2.0
<sub>[NEXT-1375](https://linear.app/vercel/issue/NEXT-1375/nextrouter-push-function-changes-between-renders-when-called)</sub> | https://github.com/vercel/next.js/issues/18127 | https://github.com/vercel/next.js/pull/52177 | 4f75c7993815dac50a6db3e078c51e6ae8d5bbdc | ae3db7ce6b0c09cc9bc3e96105cb180ace516505 | "2020-10-22T10:54:39Z" | javascript | "2023-07-04T09:11:21Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,096 | ["packages/next/build/babel/preset.ts", "test/unit/next-babel.unit.test.js"] | "React is not defined" when using a custom _app.tsx and .babelrc using React 17 | # Bug report
After upgrading to React 17, I can no longer compile my project with a custom `.babelrc` file without importing React in every `*.tsx` file. Having a `_app.tsx` file seems to be required to reproduce the issue. The error returned is:
```
Error occurred prerendering page "/". Read more: https://err.sh/next.js/prerender-error
ReferenceError: React is not defined
at MyApp.render (/home/bruhno/projects/react-not-defined/.next/server/pages/_app.js:297:70)
at d (/home/bruhno/projects/react-not-defined/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:35:231)
at bb (/home/bruhno/projects/react-not-defined/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:36:16)
at a.b.render (/home/bruhno/projects/react-not-defined/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:42:43)
at a.b.read (/home/bruhno/projects/react-not-defined/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:41:83)
at exports.renderToString (/home/bruhno/projects/react-not-defined/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:52:138)
at Object.renderPage (/home/bruhno/projects/react-not-defined/node_modules/next/dist/next-server/server/render.js:50:851)
at Function.getInitialProps (/home/bruhno/projects/react-not-defined/.next/server/pages/_document.js:273:19)
at loadGetInitialProps (/home/bruhno/projects/react-not-defined/node_modules/next/dist/next-server/lib/utils.js:5:101)
at renderToHTML (/home/bruhno/projects/react-not-defined/node_modules/next/dist/next-server/server/render.js:50:1142)
```
I'm not sure if TypeScript is related to the issue, but I've simply copy pasted minimal configuration from my own project which is where I experienced the issue.
## To Reproduce
I've created the following repo to reproduce the error: https://github.com/NBruhno/nextjs-react-not-defined
1. run `yarn`
2. run `yarn dev` or `yarn build`
4. See error in the terminal and on the rendered page
## Expected behavior
I could before React 17 run my repo without having to import React in my .tsx files unless explicitly referring to some functions, with my own custom `.babelrc` file.
## System information
- OS: Windows running WSL: Ubuntu-20.04
- Version of Next.js: 9.5.5
- Version of Node.js: v12.17.0 | https://github.com/vercel/next.js/issues/18096 | https://github.com/vercel/next.js/pull/19136 | 8ff52136146b3276bf53d40c7ee1cfe7f0c9647f | 415d7fd75ebfca4dc796bb7892a348bab3fa4920 | "2020-10-21T16:55:52Z" | javascript | "2020-11-13T07:41:54Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,056 | ["packages/next/compiled/terser-webpack-plugin/cjs.js", "packages/next/compiled/terser/LICENSE", "packages/next/compiled/terser/bundle.min.js", "packages/next/package.json", "yarn.lock"] | Bumping project to 9.5.5 causes build errors | # Bug report
## Describe the bug
Upgrading to 9.5.5 causes `Failed to compile` error when running `next build`
```
static/chunks/228a2a7ba78e3ffd319f6ce5014dd859657e6b72.6c045b2e351579d8c08d.js from Terser
TypeError: e.computed_key is not a function
at Array.some (<anonymous>)
```
## To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
1. Upgrade to [email protected] via `yarn add [email protected]`
2. Run `next build`
3. See error
## Expected behavior
The build to succeed as it has with previous versions.
## System information
- OS: Debian 10
- Browser (if applies) [e.g. chrome, safari]
- Version of Next.js: 9.5.5
- Version of Node.js: 14.14.0
## Additional context
The exact point at which our builds fail is upgrading to 9.5.4. Builds previous to that work.
Any pointers to debugging this issue would be appreciated.
| https://github.com/vercel/next.js/issues/18056 | https://github.com/vercel/next.js/pull/20063 | a5fea53bc8bcfefd0c46df2ab7e598404cbf42ef | 1692e931d97c9c17b5b62080e95697a42b61aab2 | "2020-10-20T16:21:01Z" | javascript | "2020-12-10T16:49:23Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,048 | ["packages/next/package.json", "yarn.lock"] | upgrade resolve-url-loader to 3.1.2 to resolve Prototype Pollution vulnerability | # Bug report
## Describe the bug
resolve-url-loader is a production dependency inside next.
resolve-url-loader relies on adjust-sourcemap-loader as a production dependency.
adjust-sourcemap-loader relies on object-path as a production dependency.
object-path has a high severity vulnerability described here: https://www.npmjs.com/advisories/1573
## To Reproduce
run 'npm audit'
## Screenshot
## Expected behavior
No high severity vulnerability inside production dependencies.
## System information
- OS: Windows
- Version of Next.js: 9.5.5
- Version of Node.js: 12.9.0
## Additional context
Although the vulnerability inside the newest object-path version is fixed: https://github.com/mariocasciaro/object-path,
the author of adjust-sourcemap-loader decided to drop it and replace its function with direct coding here: https://github.com/bholloway/adjust-sourcemap-loader/pull/17
resolve-url-loader is being updated here: https://github.com/bholloway/resolve-url-loader/pull/172
The last step, after the update and upgrade of resolve-url-loader is ready, is to upgrade resolve-url-loader inside next dependencies to resolve the vulnerability. | https://github.com/vercel/next.js/issues/18048 | https://github.com/vercel/next.js/pull/18064 | 48a95d58048c4556417c0e2fbc05799a5b33a9ac | d4f53ec2bcecb0774f1e0c20cd10b353e97dbbf2 | "2020-10-20T09:30:22Z" | javascript | "2020-10-20T20:26:38Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,044 | ["packages/next/package.json", "yarn.lock"] | Audit errors in node-fetch and object-path | # Bug report
## Describe the bug
There are audit errors for 2 transitively used dependencies.
## To Reproduce
1. Install next.js 9.5.5 into an npm project
2. Execute `npm audit`
## Expected behavior
No audit errors should be shown
## Actual behavior
<details>
<summary>`npm audit` output</summary>
```
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ low │ Denial of Service │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package │ node-fetch │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in │ >=2.6.1 <3.0.0-beta.1|| >= 3.0.0-beta.9 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ @wh/search │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path │ @wh/search > next > @ampproject/toolbox-optimizer > │
│ │ @ampproject/toolbox-core > cross-fetch > node-fetch │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info │ https://www.npmjs.com/advisories/1556 │
└───────────────┴──────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ low │ Denial of Service │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package │ node-fetch │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in │ >=2.6.1 <3.0.0-beta.1|| >= 3.0.0-beta.9 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ @wh/jobs │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path │ @wh/jobs > next > @ampproject/toolbox-optimizer > │
│ │ @ampproject/toolbox-core > cross-fetch > node-fetch │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info │ https://www.npmjs.com/advisories/1556 │
└───────────────┴──────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ low │ Denial of Service │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package │ node-fetch │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in │ >=2.6.1 <3.0.0-beta.1|| >= 3.0.0-beta.9 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ @wh/search │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path │ @wh/search > next > @ampproject/toolbox-optimizer > │
│ │ @ampproject/toolbox-runtime-version > │
│ │ @ampproject/toolbox-core > cross-fetch > node-fetch │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info │ https://www.npmjs.com/advisories/1556 │
└───────────────┴──────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ low │ Denial of Service │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package │ node-fetch │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in │ >=2.6.1 <3.0.0-beta.1|| >= 3.0.0-beta.9 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ @wh/jobs │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path │ @wh/jobs > next > @ampproject/toolbox-optimizer > │
│ │ @ampproject/toolbox-runtime-version > │
│ │ @ampproject/toolbox-core > cross-fetch > node-fetch │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info │ https://www.npmjs.com/advisories/1556 │
└───────────────┴──────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ low │ Denial of Service │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package │ node-fetch │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in │ >=2.6.1 <3.0.0-beta.1|| >= 3.0.0-beta.9 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ @wh/search │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path │ @wh/search > next > @ampproject/toolbox-optimizer > │
│ │ @ampproject/toolbox-validator-rules > cross-fetch > │
│ │ node-fetch │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info │ https://www.npmjs.com/advisories/1556 │
└───────────────┴──────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ low │ Denial of Service │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package │ node-fetch │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in │ >=2.6.1 <3.0.0-beta.1|| >= 3.0.0-beta.9 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ @wh/jobs │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path │ @wh/jobs > next > @ampproject/toolbox-optimizer > │
│ │ @ampproject/toolbox-validator-rules > cross-fetch > │
│ │ node-fetch │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info │ https://www.npmjs.com/advisories/1556 │
└───────────────┴──────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ low │ Denial of Service │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package │ node-fetch │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in │ >=2.6.1 <3.0.0-beta.1|| >= 3.0.0-beta.9 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ @wh/search │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path │ @wh/search > next > @ampproject/toolbox-optimizer > │
│ │ cross-fetch > node-fetch │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info │ https://www.npmjs.com/advisories/1556 │
└───────────────┴──────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ low │ Denial of Service │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package │ node-fetch │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in │ >=2.6.1 <3.0.0-beta.1|| >= 3.0.0-beta.9 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ @wh/jobs │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path │ @wh/jobs > next > @ampproject/toolbox-optimizer > │
│ │ cross-fetch > node-fetch │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info │ https://www.npmjs.com/advisories/1556 │
└───────────────┴──────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ low │ Denial of Service │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package │ node-fetch │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in │ >=2.6.1 <3.0.0-beta.1|| >= 3.0.0-beta.9 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ @wh/search │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path │ @wh/search > next > @ampproject/toolbox-optimizer > │
│ │ node-fetch │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info │ https://www.npmjs.com/advisories/1556 │
└───────────────┴──────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ low │ Denial of Service │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package │ node-fetch │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in │ >=2.6.1 <3.0.0-beta.1|| >= 3.0.0-beta.9 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ @wh/jobs │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path │ @wh/jobs > next > @ampproject/toolbox-optimizer > node-fetch │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info │ https://www.npmjs.com/advisories/1556 │
└───────────────┴──────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ high │ Prototype Pollution │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package │ object-path │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in │ >=0.11.5 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ @wh/search │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path │ @wh/search > next > resolve-url-loader > │
│ │ adjust-sourcemap-loader > object-path │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info │ https://www.npmjs.com/advisories/1573 │
└───────────────┴──────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ high │ Prototype Pollution │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package │ object-path │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in │ >=0.11.5 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ @wh/jobs │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path │ @wh/jobs > next > resolve-url-loader > │
│ │ adjust-sourcemap-loader > object-path │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info │ https://www.npmjs.com/advisories/1573 │
└───────────────┴──────────────────────────────────────────────────────────────┘
12 vulnerabilities found - Packages audited: 1904
```
</details>
## System information
- OS: macOS
- Version of Next.js: 9.5.5
- Version of Node.js: 12.18.4
## Additional context
Failing audit errors break our CI pipeline. Currently the only way to work around this is to do manual changes to package-lock.json. | https://github.com/vercel/next.js/issues/18044 | https://github.com/vercel/next.js/pull/18087 | 6212823735dc7e7bd6c4d13ae219ae6430680d58 | 71f3e8db7b4c952f07abe7b781e4497864eb56ea | "2020-10-20T08:40:32Z" | javascript | "2020-10-21T16:04:31Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,023 | ["examples/with-firebase-authentication/utils/auth/mapUserData.js"] | Firebase authentication example not working correctly | # Bug report
## Describe the bug
The repo
https://github.com/vercel/next.js/tree/canary/examples/with-firebase-authentication
allows login but fails to fetch food. I see the following error message:
```
errorInfo: {
code: 'auth/argument-error',
message: 'Decoding Firebase ID token failed. Make sure you passed the entire string JWT which represents an ID token. See https://firebase.google.com/docs/auth/admin/verify-id-tokens for details on how to retrieve an ID token.'
},
codePrefix: 'auth'
```
I've checked around a bit and inside `mapUserDada` the key `token` is always `false`.
## To Reproduce
Just pull the repo and try to log in with an account.
## Expected behavior
After a login fetch food should work.
| https://github.com/vercel/next.js/issues/18023 | https://github.com/vercel/next.js/pull/18074 | 91eb984d58cf4b85269b6ecd5d510700dea780f0 | c28d39e47d7337636e832134b26d6214357fe3d4 | "2020-10-19T18:21:10Z" | javascript | "2020-10-21T01:17:39Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 17,930 | ["packages/next/client/index.tsx", "packages/next/client/page-loader.ts"] | Failed to read the 'cssRules' property from 'CSSStyleSheet': Cannot access rules | # Bug report
## Describe the bug
DOMException: Failed to read the 'cssRules' property from 'CSSStyleSheet': Cannot access rules
## To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
1. Setting assetPrefix to subdomain
2. Use withSass default config, import scss file in a page
3. Handle error componentDidCatch in _app.js
4. Run production mode
## Expected behavior
App render success without catch
## System information
- OS: Windows
- Browser Chrome
- Version of Next.js: 9.5.5
- Version of Node.js: 11.15.0
| https://github.com/vercel/next.js/issues/17930 | https://github.com/vercel/next.js/pull/18723 | b1503e13e8d767105a2e70038e94e695fb42e9fd | 27d7b76a39c23da1aa6455e0c2c36d6e3c1aad6c | "2020-10-16T05:11:06Z" | javascript | "2020-11-03T12:50:15Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 17,828 | ["docs/advanced-features/custom-app.md", "docs/advanced-features/custom-document.md"] | Clarify use of getStaticProps / getServerSideProps with app / document | # Feature request
## Describe the solution you'd like
We currently don't explicitly mention you can't use `getStaticProps` or `getServerSideProps` with `_app.js` or `_document.js` in the docs. These proposals are still in RFC.
We should add a note to both the app and document section of the docs to mention this.
## Additional context
https://nextjs.org/docs/advanced-features/custom-app | https://github.com/vercel/next.js/issues/17828 | https://github.com/vercel/next.js/pull/17839 | d73b34c3fd4008d3a8a175ad52310c83c1e5c8a4 | f1b3818dadab089c9c4faaa2695372c9e07e2c96 | "2020-10-12T21:26:54Z" | javascript | "2020-10-13T19:17:47Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 17,738 | ["packages/next/next-server/lib/router/router.ts", "test/integration/gssp-redirect/test/index.test.js"] | browser back issue of experimental redirects from getServerSideProps / getStaticProps | # Bug report
## Describe the bug
## To Reproduce
Here's simple repo to reproduce
https://github.com/TasukuUno/repro-nextjs-17738
1. Prepare a page using `unstable_redirect` option in GSSP or GSP (the page marked /c in the image above)
2. Navigate to the page from another with client navigation
3. Click go back of browser
4. You will go to the page before of the expected one.
## Expected behavior
## Screenshots
## System information
- OS: macOS
- Browser: Chrome
- Version of Next.js: 9.5.4
- Version of Node.js: 14.3.0
| https://github.com/vercel/next.js/issues/17738 | https://github.com/vercel/next.js/pull/17741 | d2e7f3c76992dc0392acc3ac9e2a023143891cc2 | 3f22490a59bf663e5d20d1c486c8111d64a278f9 | "2020-10-09T07:15:38Z" | javascript | "2020-10-27T05:14:23Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 17,733 | ["packages/create-next-app/helpers/git.ts"] | Change default branch for create-next-app output to be `main` | # Feature request
## Is your feature request related to a problem? Please describe.
Currently, the generated codebase from `npx create-next-app x` yields a project named `x` with git initialized with `master` as the default branch. To match up with GitHub, it should be `main`.
| https://github.com/vercel/next.js/issues/17733 | https://github.com/vercel/next.js/pull/17745 | 266c7ed74c52cfe73c304a1adac7b986f4b723a5 | 19febb10c03280c200a00033a7d59ceded0d7923 | "2020-10-09T03:42:54Z" | javascript | "2020-11-07T14:46:17Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 17,592 | ["errors/invalid-project-dir-casing.md", "errors/manifest.json", "packages/next/cli/next-build.ts", "packages/next/cli/next-dev.ts", "packages/next/cli/next-export.ts", "packages/next/cli/next-lint.ts", "packages/next/cli/next-start.ts", "packages/next/lib/get-project-dir.ts"] | 'Error: Invalid hook call. Hooks can only be called inside of the body of a function component' | # Bug report
## Describe the bug
I keep 'Error: Invalid hook call. Hooks can only be called inside of the body of a function component' after starting the next development server. This is the default next app with no configuration from me at all
## To Reproduce
1. Start a new next app with `npx create-next-app moshood.dev`
2. Start the next development server with `yarn dev`
3. Navigate to localhost:3000 in the browser after starting development server
4. Browser shows 'internal server Error' and terminal shows 'Error: Invalid hook call. Hooks can only be called inside of the body of a function component'
## Expected behavior
Start default next app in the browser successfully.
## Screenshots
## System information
- OS: [Windows]
- Browser [chrome]
- Version of Next.js: [9.5.3]
- Version of Node.js: [e.g. 12.18.2]
- Version of React [16.13.1]
-Version of React-dom [16.13.1] | https://github.com/vercel/next.js/issues/17592 | https://github.com/vercel/next.js/pull/29205 | faa39038ef458f69a3eb6aa9046d97a717532950 | ead56eaab68409e96c19f7d9139747bac1197aa9 | "2020-10-03T17:37:09Z" | javascript | "2021-09-22T21:29:27Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 17,505 | ["docs/basic-features/built-in-css-support.md"] | The docs for global CSS imports from node_modules don't note the required version | The page should have a note saying that global CSS imports from node_modules require Next.js v9.5.4. | https://github.com/vercel/next.js/issues/17505 | https://github.com/vercel/next.js/pull/17506 | f06c58911515d980e25c33874c5f18ade5ac99df | 816798569a56c97108ecff37a85e6a3fd85648ab | "2020-10-01T02:35:00Z" | javascript | "2020-10-01T08:58:22Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 17,454 | ["docs/manifest.json", "docs/migrating/from-create-react-app.md"] | Add migration guide from Create React App | # Feature request
As a user of [x] framework/language, I'd love to see an easy path towards migrating to Next.js
## Describe the solution you'd like
Documentation around common providers and how exactly you can switch to Next.js from them.
## Additional context
Let's start with a few of the most popular and see what others in the community would get value from.
- Create React App
- Gatsby (https://github.com/vercel/next.js/issues/17453)
- Vanilla React (https://github.com/vercel/next.js/issues/17455)
| https://github.com/vercel/next.js/issues/17454 | https://github.com/vercel/next.js/pull/21212 | f8fecf57c3673975fcc33d3a979fc538de149b08 | 5d98874e8fbfde9188090c1b93eeb62cc141f397 | "2020-09-29T18:19:15Z" | javascript | "2021-01-18T23:37:32Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 17,416 | ["packages/next/package.json", "yarn.lock"] | Obsolete and vulnerable dependencies (CVE-2020-15168 and CVE-2019-20149) | # Bug report
Hello. Several vulnerabilities were revealed in the chokidar and ampproject/toolbox-optimizer package dependencies. The packages causing the "security issues" are kind-of and node-fetch. Detailed info about CVE-2019-20149 and CVE-2020-15168 vulnerabilities are available here ([1] and [2]).
[email protected] > [email protected] > readdirp@^2.2.1 > micromatch@^3.1.10 > braces@^2.3.1 > snapdragon@^0.8.1 > base@^0.11.1 > class-utils@^0.3.5 > define-property@^0.2.5 > is-descriptor@^0.1.0 > is-accessor-descriptor@^0.1.6 > kind-of@^3.0.2
[email protected] > @ampproject/[email protected] > [email protected]
[1] https://github.com/jonschlinkert/kind-of/issues/30
[2] https://nvd.nist.gov/vuln/detail/CVE-2020-15168
| https://github.com/vercel/next.js/issues/17416 | https://github.com/vercel/next.js/pull/19722 | 7ae76f4326840fb92cc542d867c5b9c27333a80c | bb1bdbb10fb7f8b4f5d6b05c5e63ba589151cb50 | "2020-09-28T10:31:00Z" | javascript | "2020-12-02T12:55:43Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 17,299 | ["examples/with-redux-wrapper/store/store.js"] | with-redux-wrapper example bug | # Bug report
## Describe the bug
In with-redux-wrapper example index.js page has a code:
```
export const getStaticProps = wrapper.getStaticProps(async ({ store }) => {
store.dispatch(serverRenderClock(true))
store.dispatch(addCount())
})
```
the reducer.js
```
import { countActionTypes } from './action'
const countInitialState = {
count: 0,
}
export default function reducer(state = countInitialState, action) {
switch (action.type) {
case countActionTypes.ADD:
return Object.assign({}, state, {
count: state.count + 1,
})
default:
return state
}
}
```
in getStaticProps code has ``` store.dispatch(addCount())```
so when I run the index.js page the page count must be 1 but is 0 is bug?
 | https://github.com/vercel/next.js/issues/17299 | https://github.com/vercel/next.js/pull/17335 | c45497e1c377ec010fc897406d72f92f5183467a | c388048f3efebff6cf6bdca4a41939e55975f91b | "2020-09-23T02:55:12Z" | javascript | "2020-09-24T19:35:46Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 17,273 | ["packages/next/build/babel/preset.ts", "packages/next/build/swc/options.js", "test/unit/next-babel-loader-prod.test.ts"] | [9.5.4-canary.20] default loader doesn't transpile nullish coalescing and optional chaining | # Bug report
## Describe the bug
Loader `next-babel-loader` doesn't transpile nullish coalescing operator and optional chaining on canary
## To Reproduce
Repository: [next.js-bug-nullish-coalescing](https://github.com/rokinsky/next.js-bug-nullish-coalescing)
Steps to reproduce the behavior:
1. Go to [http://localhost:3000](http://localhost:3000)
2. See error
3. Go to [http://localhost:3000/about](http://localhost:3000/about)
4. See error
## Expected behavior
Don't see the errors.
## Screenshots
<img width="810" alt="Screenshot 2020-09-22 at 02 47 57" src="https://user-images.githubusercontent.com/20644874/93832383-3b592c00-fc7e-11ea-8f35-fcb16bc288bc.png">
<img width="810" alt="Screenshot 2020-09-22 at 03 04 22" src="https://user-images.githubusercontent.com/20644874/93833145-79efe600-fc80-11ea-843d-6e12358a1538.png">
## System information
- OS: macOS
- Browser (if applies): chrome
- Version of Next.js: `9.5.4-canary.20`
- Version of Node.js: `14.2.0`
## Additional context
Works with `9.5.3`
| https://github.com/vercel/next.js/issues/17273 | https://github.com/vercel/next.js/pull/35976 | fe6e74dc57a811f83a4908bc2a138ce087b31be3 | 3ae571d97b429e9d7b57fb21d5e4dab4f39735e7 | "2020-09-21T23:50:24Z" | javascript | "2022-04-16T02:48:43Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 17,242 | ["packages/next/build/webpack/config/blocks/css/loaders/global.ts", "packages/next/build/webpack/config/blocks/css/loaders/modules.ts", "packages/next/build/webpack/plugins/css-minimizer-plugin.ts", "packages/next/package.json", "packages/next/types/misc.d.ts", "yarn.lock"] | PostCSS 8 | # Bug report
## Describe the bug
Update PostCSS 7 → 8.
## Expected behavior
Without PostCSS 8, Next.js will not be able to load PostCSS 8 plugins (for instance, [Autoprefixer 10 doesn’t work in Nuxt.js](https://github.com/vercel/next.js/issues/17236)).
## Additional context
[PostCSS 8 changelog](https://github.com/postcss/postcss/releases/tag/8.0.0)
The only breaking changes important for Next.js is dropping Node.js 6 and 8 support. | https://github.com/vercel/next.js/issues/17242 | https://github.com/vercel/next.js/pull/17415 | 80bf81a3cf8a99f569210670fe618f0b7cdc1d23 | b89d417b3714e98f6b8cef3baa0b6979cf1bb7d7 | "2020-09-20T14:36:51Z" | javascript | "2020-10-21T10:31:07Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 17,220 | ["packages/next/build/webpack/loaders/next-serverless-loader.ts"] | "Optional catch all routes" is not working when deploying to Vercel | # Bug report
## Describe the bug
"Optional catch all routes" is not working when deploying to Vercel
## To Reproduce
- I have a page: `pages/the-loai/[[...slug]].tsx`
- When starts production server in local (http://localhost:3000/the-loai) => props: `"page":"/the-loai/[[...slug]]","query":{},"buildId":"vsDb98I1lSnwfBqQ1KKgX"`
- When deploy to Vercel (https://story-react.vercel.app/the-loai) => props: `"page":"/the-loai/[[...slug]]","query":{"slug":["[[...slug]]"]},"buildId":"XBGtXp4fTtSIAp5Xvhv-B"`
## Expected behavior
`query` should be `{}`
## Screenshots
view-source:https://story-react.vercel.app/the-loai
 | https://github.com/vercel/next.js/issues/17220 | https://github.com/vercel/next.js/pull/17551 | 782b7e48ecfb0dddf5ea89b61881632d2aaa8c39 | b42be17593d69854b3f3cbed7b1ed14e999444dc | "2020-09-19T10:11:50Z" | javascript | "2020-10-05T07:34:50Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 17,200 | ["docs/advanced-features/preview-mode.md", "docs/api-routes/dynamic-api-routes.md", "docs/api-routes/introduction.md", "docs/api-routes/response-helpers.md"] | [Feature](Docs) Give names to anonymous arrow functions in docs examples | For example, in [api-routes](https://nextjs.org/docs/api-routes/introduction)
we have this example
```js
export default (req, res) => {
res.statusCode = 200
res.setHeader('Content-Type', 'application/json')
res.end(JSON.stringify({ name: 'John Doe' }))
}
```
Exporting **anonymous** functions is arguably bad practice. If this agreed upon, I think any examples containing anonymous exports should be changed to use named functions | https://github.com/vercel/next.js/issues/17200 | https://github.com/vercel/next.js/pull/17510 | 1659e4da617db3effc63f1dd919ce628eb59e135 | 7dec91175cb69f773fa623417e0e497acc606dc2 | "2020-09-18T13:05:19Z" | javascript | "2020-10-05T21:16:47Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 17,113 | ["packages/next/build/webpack/loaders/next-serverless-loader.ts", "packages/next/next-server/server/next-server.ts", "packages/next/next-server/server/render.tsx", "test/integration/getserversideprops/pages/blog/[post]/index.js", "test/integration/getserversideprops/pages/something.js", "test/integration/getserversideprops/test/index.test.js"] | [9.5.4-canary.18] Different router.asPath between server and client. | # Bug report
From `9.5.4-canary.18` `router.asPath` in the sever-side return incorrect value.
## Describe the bug
```js
// next.config.js
module.exports = {
rewrites() {
return [
{
source: "/my-post",
destination: "/post"
}
];
}
};
```
## To Reproduce
https://codesandbox.io/s/sharp-cannon-kcsio?file=/pages/post.js
Directly access `/my-post` url
<img width="1009" alt="Screen Shot 2020-09-15 at 21 30 53" src="https://user-images.githubusercontent.com/4768095/93224362-36d2d600-f79b-11ea-8c91-3b4073ba9c08.png">
## Expected behavior
The `router.asPath` always return `/my-post`.
## Additional context
https://github.com/vercel/next.js/pull/17082 | https://github.com/vercel/next.js/issues/17113 | https://github.com/vercel/next.js/pull/17121 | 6a4c256491f4643bf6baf456487dcde542244c25 | 2cf1d1c191923f7f1a8edbbc684da5cf9b3bdebf | "2020-09-15T14:40:09Z" | javascript | "2020-09-15T19:19:07Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 17,096 | ["packages/next/server/base-server.ts", "test/e2e/dynamic-route-interpolation/index.test.ts"] | dynamic routes param value is not defined for server side render when literal dynamic route value is provided as the pathname | # Bug report
## Describe the bug
When using [dynamic routes](https://nextjs.org/docs/routing/dynamic-routes) the `param` value is not defined when navigating to a page whose pathname is the string literal value for the dynamic route.
From the dynamic routes example:
Given a page defined as `pages/post/[pid].js`, navigating to `/post/[pid]` will _not_ set the `pid` param value for the server side render _if_ `getInitialProps` is defined for the page.
If `getInitialProps` is not provided, then the router correctly extracts the `pid` `param`. When `getInitialProps` is provided, the router does not extract the `pid` param, and the `context` argument for `getInitialProps` will not include `pid` in the `query` attribute.
Note: This only occurs for the server side render. When navigating client side, everything works as expected.
## To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
1. Go to https://3q2nu.sse.codesandbox.io/
2. Click on the `[day]` link
3. Observe the values for `router` and `gIP` (both are `[day]` as expected)
4. Reload the page (https://3q2nu.sse.codesandbox.io/days/[day])
5. Observe the values for `router` and `gIP` (both are `undefined`)
codesandbox: https://codesandbox.io/s/romantic-raman-3q2nu
Note:
Removing `DayPage.getInitialProps` from the sandbox above will cause the `router` value to be correct both when navigating on the client and on the sever side render.
## Expected behavior
The query param value should always be set.
Given a page defined as `pages/post/[pid].js`, navigating to `/post/[pid]` should set the `pid` param value to `[pid]` in both server and client side contexts.
## Screenshots
If applicable, add screenshots to help explain your problem.
## System information
- OS: [macOs]
- Browser [N/A]
- Version of Next.js: [9.5.3, present on latest]
- Version of Node.js: [12.x] | https://github.com/vercel/next.js/issues/17096 | https://github.com/vercel/next.js/pull/33808 | 39d3210776d37e7dc11e77b54a65b33b5454c0ce | 965d26eba373e760c5440054c76d77ea20d96fef | "2020-09-14T23:29:29Z" | javascript | "2022-02-02T02:57:04Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 17,073 | ["packages/next/client/index.tsx", "packages/next/next-server/lib/router/router.ts", "test/integration/build-output/test/index.test.js"] | Experimental scrollRestoration + Sentry causes performance issues | # Bug report
## Describe the bug
Every scroll event is apparently watched by Sentry which registers it as `navigation` breadcrumb event.
## To Reproduce
1. enable `scrollRestoration` in `next.config.js`
2. initialize Sentry in the application and observe `__SENTRY__.hub._stack[0].scope._breadcrumbs` changing
## Expected behavior
Navigation changes are only fired when an url change occurs.
## Screenshots
The first console entry is the site right after loading.
The second after scrolling a single time via mousewheel.
I presume the 10ms timeout here is too low.
Those are all `Sentry.addBreadcrumb` due to the `scroll` event being fired:
## System information
- OS: Android on OnePlus 3, Windows 10 on multiple machines
- Browser (if applies): chrome, firefox mobile, chrome mobile
- Version of Next.js: latest stable
## Additional context
Latest sentry releases:
```
"@sentry/minimal": "5.23.0",
"@sentry/node": "5.23.0",
"@sentry/react": "5.23.0",
``` | https://github.com/vercel/next.js/issues/17073 | https://github.com/vercel/next.js/pull/20633 | 380afbfba2a277ed19bc69a608cf5053c44cdcf7 | dbe1e626f877a9ef7bbffc2f360bae809874790d | "2020-09-14T07:55:10Z" | javascript | "2020-12-31T16:08:12Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 17,066 | ["packages/next/package.json", "yarn.lock"] | Disable cssnano's postcss-calc | # Bug report
`next build` messes up complex css calc that works as expected in `next dev`
## To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
1. Clone https://github.com/theMosaad/tailwindcss-capsize
2. On the dev server `npm run dev` the calc function works as expected https://prnt.sc/ugllip
3. When using `npm run build` then `npm run start` it shortens the calc function from
```css
.text-6xl::before {
margin-top: calc(-1em * ((var(--ascent-scale) - var(--cap-height-scale) + var(--line-gap-scale) / 2) - (((var(--line-height-scale) * (var(--font-size-rem) * var(--root-font-size-px)) - (var(--line-height-rem) * var(--root-font-size-px)) - (var(--line-height-unitless) * (var(--font-size-rem) * var(--root-font-size-px))) - var(--line-height-px)) / 2) / (var(--font-size-rem) * var(--root-font-size-px))) + (.05 / (var(--font-size-rem) * var(--root-font-size-px)))));
}
```
to
```css
.text-6xl::before {
margin-top: calc(-1em*(var(--ascent-scale) - var(--cap-height-scale) + .05));
}
```
That's when I added the following to postcss.config.js
```js
module.exports = {
plugins: {
cssnano: {
preset: ['default', { calc: false }],
},
},
}
```
## Expected behavior
Expected the full calc function when using `npm run build`
## System information
- OS: Windows 10
- Version of Next.js: 9.5.3
- Version of Node.js: 12.18.2
## Additional context
I tried the same cssnano options on a gulp configuration and it disabled calc.
```js
const gulp = require('gulp')
const postcss = require('gulp-postcss')
const cssnano = require('cssnano')
gulp.task('css', function () {
return gulp
.src('input.css')
.pipe(
postcss([
cssnano({
preset: ['default', { calc: false }],
}),
])
)
.pipe(gulp.dest('dist'))
})
```
| https://github.com/vercel/next.js/issues/17066 | https://github.com/vercel/next.js/pull/18879 | db0587c4ac186d46709878500382127abee0281e | 6b8903f1b74e1f0e6704397afb08343d444d616c | "2020-09-13T18:02:15Z" | javascript | "2020-11-06T05:46:19Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,988 | ["package.json", "packages/next/build/webpack-config.ts", "test/package-managers-tests/basic-pnpm/pages/about.js", "test/package-managers-tests/basic-pnpm/pages/about2.js", "test/package-managers-tests/basic-pnpm/pages/day/index.js", "test/package-managers-tests/basic-pnpm/pages/index.js", "test/package-managers-tests/basic-pnpm/test/index.test.js", "yarn.lock"] | 9.5.x build fails if `node_modules` folder is a symlink and imported packages use hooks | # Bug report
## Describe the bug
Next.js 9.5.x build and dev modes fail with "Invalid hook call" error if `node_modules` folder is a symlink to another folder and imported packages use hooks:
```
Error: Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons:
1. You might have mismatching versions of React and the renderer (such as React DOM)
2. You might be breaking the Rules of Hooks
3. You might have more than one copy of React in the same app
See https://fb.me/react-invalid-hook-call for tips about how to debug and fix this problem.
```
Next.js 9.4.x builds work correctly.
## To Reproduce
I have created a repository that reproduces the failing build with Next.js 9.5.3, Formik, and `./node_modules` symlinked to `./tmp/node_modules`:
https://github.com/illarionvk/next-9-5-symlinked-node-modules
## Expected behavior
The build should complete successfully, just like in 9.4.x.
## System information
- OS: macOS, Debian Linux
- Version of Next.js: 9.5.x
- Version of Node.js: 12.18.x
## Additional context
We develop our Next.js projects using Docker Desktop for Mac. [Folder sharing is notoriously slow](https://docs.docker.com/docker-for-mac/osxfs-caching/#performance-implications-of-host-container-file-system-consistency) because Docker for Mac runs in a virtual machines, so we keep `node_modules` folder in a Docker volume and symlink it to the project folder to drastically improve module install times.
This issue is related #9022, but it's not a duplicate.
It looks like this bug also occurs if the project uses [pnpm package manager](https://pnpm.js.org/en/), even without Docker (see #15616).
Pull-request #16369 might resolve the issues.
| https://github.com/vercel/next.js/issues/16988 | https://github.com/vercel/next.js/pull/17279 | fad07cc09a485f5e8a0d25df6269146397191476 | 5c4d0bded684c2bec3073c0c78fea9f7d95037fa | "2020-09-10T10:24:41Z" | javascript | "2020-10-14T11:36:59Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,974 | ["packages/next/next-server/lib/router/router.ts", "packages/next/next-server/lib/router/utils/resolve-rewrites.ts", "test/integration/custom-routes/pages/auto-export/[slug].js", "test/integration/custom-routes/pages/nav.js", "test/integration/custom-routes/test/index.test.js"] | Supplying a rewrite to next/link should resolve correctly without href and as | When supplying only a `href` with a rewrite we should resolve the correct page automatically without triggering a full navigation, e.g.
```jsx
<Link href="/my-post/1?another=another">
<a>Post 1</a>
</Link>
```
with the page `post.js` and the rewrite
```js
// next.config.js
module.exports = {
rewrites() {
return [
{
source: "/my-post/:id",
destination: "/post"
}
];
}
};
```
This was noticed to not being working properly in https://github.com/vercel/next.js/issues/16825#issuecomment-688587383 by @nghiepit | https://github.com/vercel/next.js/issues/16974 | https://github.com/vercel/next.js/pull/16975 | 72b78f3be3ce7c1c6ecc99f1822c04ceed86d922 | dcdcf49a87f28f0b90991b7e44280803baa1e5f7 | "2020-09-09T21:03:20Z" | javascript | "2020-09-10T00:55:22Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,950 | ["packages/next/pages/_document.tsx", "test/integration/production/components/dynamic-css/with-css.js", "test/integration/production/components/dynamic-css/with-css.module.css", "test/integration/production/pages/dynamic/pagechange1.js", "test/integration/production/pages/dynamic/pagechange2.js", "test/integration/production/test/dynamic.js"] | CSS module removed when navigating pages that contain the same next/dynamic component | # Bug report
## Describe the bug
Components that use next/dynamic to load and that have a CSS module lose their CSS when navigating to another page that contains the same dynamically loaded component.
## To Reproduce
Here is a [repo](https://github.com/adamayres/next-dynamic-css-issue) that contains the minimal amount of code to reproduce.
1. Create a Component that includes a CSS module.
2. Create two pages.
3. Using next/dynamic add the component to each page, as well as add a link to the other page.
4. Start the app and view the first page and then click the link to the second page.
## Expected behavior
The styles for the dynamically included component will persist when navigating to other pages the component lives on.
## Screenshots
The styles for the dynamically included component do not persist when navigating to other pages the component lives on.
## System information
- OS: macOS
- Browser: Chrome
- Version of Next.js: 9.5.3
- Version of Node.js: 12
## Additional context
This issue only occurs when navigating via page links, direct access to the `index` or `other-page` load the CSS correctly.
This bug appears to have been introduced as a regression from #12843 that fixed a related issue, #10557, where there is a flash of unstyled content when navigating to a page that contains a dynamically loaded component. I verified that this new issue is not present in 9.5.3-canary.20, but is present on 9.5.3-canary.21 and is currently present in 9.5.3. See this [comment](https://github.com/vercel/next.js/pull/12843#issuecomment-688285826) thread for more details on potential solutions. | https://github.com/vercel/next.js/issues/16950 | https://github.com/vercel/next.js/pull/17173 | 56bd46486180e596aadfe48918151d1e62beed52 | b1503e13e8d767105a2e70038e94e695fb42e9fd | "2020-09-08T20:35:40Z" | javascript | "2020-11-03T05:23:31Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,944 | ["errors/href-interpolation-failed.md", "packages/next/next-server/lib/router/router.ts", "test/integration/build-output/test/index.test.js", "test/integration/dynamic-routing/pages/index.js", "test/integration/dynamic-routing/test/index.test.js"] | When href interpolation fails we should error properly | Another thing I noticed: when I provide fewer params than necessary, the url resolves to the index page without warning, e.g. {pathname: „/[locale]/blog/[id]“, query: {id: 1}} (locale missing) becomes /?id=1. Maybe in this case a warning should be logged or an even error thrown?
_Originally posted by @herrstucki in https://github.com/vercel/next.js/issues/16851#issuecomment-688478883_
<hr />
If interpolation fails we need to throw an error instead of returning an invalid URL since this can result in unexpected behavior.
| https://github.com/vercel/next.js/issues/16944 | https://github.com/vercel/next.js/pull/16946 | c12afa066e08a1aa0984f18dc4b7c2141367f6aa | 47d983f71f90a4c3fccd43479505b0270f7fb258 | "2020-09-08T16:36:29Z" | javascript | "2020-09-10T20:05:02Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,938 | ["packages/next/server/hot-reloader.ts", "test/integration/gssp-ssr-change-reloading/pages/another/index.js", "test/integration/gssp-ssr-change-reloading/pages/index.js", "test/integration/gssp-ssr-change-reloading/test/index.test.js"] | GS(S)P data refreshing doesn't trigger properly for `/index` routes | We need to make sure to normalize the page path correctly when collecting the changed GS(S)P pages so that the data refreshing is triggered for normalized pages like `/index` and `/another/index` | https://github.com/vercel/next.js/issues/16938 | https://github.com/vercel/next.js/pull/16939 | ac0c892acc700ef36986f9e16492b8020c34f285 | f46ddc693302b2f32c5aadfb91d82d9975ee014a | "2020-09-08T15:25:19Z" | javascript | "2020-09-08T16:00:05Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,932 | ["packages/next/client/page-loader.ts", "test/integration/css-client-nav/test/index.test.js", "test/integration/css-fixtures/composes-ordering/pages/index.js", "test/integration/css/test/index.test.js"] | Unused CSS preload | I've only just started getting this problem with a new nextjs app, where css files aren't preloaded, and therefore not used at all:
```
A preload for 'https://*******.vercel.app/_next/static/css/db098983a22a0aa338df.css' is found, but is not used because the request credentials mode does not match. Consider taking a look at crossorigin attribute.
```
I'm using sass modules, and this is with nextjs 9.5.3 and webpack 5 (but the same issue occurs with webpack 4). Any ideas?
_Originally posted by @howells in https://github.com/vercel/next.js/discussions/16850_ | https://github.com/vercel/next.js/issues/16932 | https://github.com/vercel/next.js/pull/18846 | ac54573b74d50469c826d438d72929cfc34ad369 | e9054744d84638555c10a33a76949c845d175fe0 | "2020-09-08T13:36:28Z" | javascript | "2020-11-06T16:24:02Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,851 | ["packages/next/client/page-loader.ts", "packages/next/next-server/lib/router/router.ts", "test/integration/build-output/test/index.test.js", "test/integration/dynamic-routing/pages/[name]/index.js", "test/integration/dynamic-routing/pages/index.js", "test/integration/dynamic-routing/test/index.test.js"] | Interpolating dynamic href values doesn't preserve extra query params | # Bug report
This is a feedback to #16774 which I'm very excited about since it solves a big pain point in most apps I've been writing!
## Describe the bug
Adding extra query params to the `href` prop doesn't construct the expected URL; only the dynamic params are interpolated, while the extra query params are omitted.
## To Reproduce
Create a Next.js Link with more params than specified by the dynamic route.
```
<Link href={ pathname: "/posts/[id]", query: { id: 1, anotherParam: 2 } }><a>...</a></Link>
```
Navigates to the URL `/posts/1` and creates the link `<a href="/posts/1">...</a>`, omitting `anotherParam`.
## Expected behavior
As I wrote in https://github.com/vercel/next.js/issues/14959 :
`{ pathname: "/posts/[id]", query: { id: 1, anotherParam: 2 } }` should create the URL `/posts/1?anotherParam=2` and the link should be `<a href="/posts/1?anotherParam=2">...</a>`.
## System information
- Version of Next.js: 9.5.4-canary.1
| https://github.com/vercel/next.js/issues/16851 | https://github.com/vercel/next.js/pull/16878 | 2058c9f8de898aac032663c1620efe25d035bc1c | f942d9e89295b98cb48eee3e1fbf074c936a98f9 | "2020-09-04T12:32:23Z" | javascript | "2020-09-07T11:09:02Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,828 | ["examples/with-rebass/package.json"] | Fix or remove the with-rebass example | # Bug report
## Describe the bug
The current `with-rebass` example is broken.
## To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
1. Download the with-rebass example of clone the Next.js repo and go to examples/with-rebass
2. Install deps and run the example
4. See error
## Expected behavior
The example should work as expected or be removed if no one is using it. | https://github.com/vercel/next.js/issues/16828 | https://github.com/vercel/next.js/pull/16839 | eaea7a8793723493d9284d69fe90e33e22c760c9 | 2e87e22731017551e5f2582b9c0475faf5cf9aed | "2020-09-03T18:05:59Z" | javascript | "2020-09-21T02:16:15Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,825 | ["packages/next/next-server/lib/router/router.ts", "test/integration/custom-routes/pages/nav.js", "test/integration/custom-routes/pages/with-params.js", "test/integration/custom-routes/test/index.test.js", "test/integration/dynamic-routing/pages/another.js"] | [9.5.3 - Rewrites] Navigating route with dynamic routes no longer work properly | ## Describe the bug
```js
// next.config.js
module.exports = {
rewrites() {
return [
{
source: "/my-post/:id",
destination: "/post"
}
];
}
};
```
Navigating via `Link` or `router.push`
```js
<Link
href={{
pathname: "/post",
query: {
id: 1,
another: "another"
}
}}
as="/my-post/1?another=another"
>
<a>Post 1</a>
</Link>
```
When custom the `as` path with `params` then `router.query.id` no longer true.
Actual: `id=1?another=another`
Expected: `id=1`
## To Reproduce
https://codesandbox.io/s/aged-sky-nzs6j?file=/pages/index.js
| https://github.com/vercel/next.js/issues/16825 | https://github.com/vercel/next.js/pull/16860 | 1c7cc60b8adc2119e0780afc53c367ff2eaaea73 | 6233ef7ed89b9d369580a2ac13b6119bc4b18a1c | "2020-09-03T14:38:34Z" | javascript | "2020-09-04T19:19:17Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,792 | ["docs/basic-features/data-fetching.md"] | Docs on preview say `false` but code says `undefined` | # Bug report
## Describe the bug
Docs and code are out of sync. See
https://nextjs.org/docs/basic-features/data-fetching#getstaticprops-static-generation
and
https://github.com/Timer/next.js/blob/canary/packages/next/next-server/server/render.tsx#L611
## To Reproduce
```
export async function getStaticProps(ctx: any) {
console.log(ctx) // no `preview` at all in ctx
```
## Expected behavior
See https://nextjs.org/docs/basic-features/data-fetching#getstaticprops-static-generation .
"preview is true if the page is in the preview mode and false otherwise. See the Preview Mode documentation"
| https://github.com/vercel/next.js/issues/16792 | https://github.com/vercel/next.js/pull/16843 | f46ddc693302b2f32c5aadfb91d82d9975ee014a | b22769194262a700728be9b912cce2f63383bca0 | "2020-09-02T17:44:59Z" | javascript | "2020-09-08T16:29:42Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,790 | ["packages/next/client/dev/dev-build-watcher.js", "packages/next/client/next-dev.js", "test/integration/gssp-ssr-change-reloading/pages/gsp-blog/[post].js", "test/integration/gssp-ssr-change-reloading/test/index.test.js"] | Show the build/activity indicator while re-fetching data for GS(S)P being edited | As a follow-up to https://github.com/vercel/next.js/pull/16744 we should also show the build/activity indicator while the data is being re-fetched so the user knows something is happening | https://github.com/vercel/next.js/issues/16790 | https://github.com/vercel/next.js/pull/16789 | 064917682f9b26c3a895dee6168a2167be83ba2a | 8426f13713c6a1ac498562479d864633cf355c6d | "2020-09-02T17:29:29Z" | javascript | "2020-09-03T12:27:08Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,775 | ["packages/next/build/babel/plugins/next-page-config.ts", "test/integration/page-config/pages/valid/config-import.js", "test/integration/page-config/pages/valid/not-config-export.js", "test/integration/page-config/pages/valid/not-config-import-export.js"] | import config in _app raises https://err.sh/vercel/next.js/invalid-page-config | # Bug report
## Describe the bug
I use the package `@fortawesome/fontawesome-svg-core` and since nextjs **9.5.3** it causes an error, due to this code in `_app`:
```
import { config } from '@fortawesome/fontawesome-svg-core';
config.autoAddCss = false;
```
The error:
```
error - ./pages/_app.js
Error: C:\Projects\nextapp\pages\_app.js: Invalid page config export found. Expected object but got import in file \pages\_app.js. See: https://err.sh/vercel/next.js/invalid-page-config
```
Is this behavior expected?
## Workaround
An alias named import solves the issue:
```
import { config as fontawesomeConfig } from '@fortawesome/fontawesome-svg-core';
fontawesomeConfig.autoAddCss = false;
``` | https://github.com/vercel/next.js/issues/16775 | https://github.com/vercel/next.js/pull/16834 | 3c992063135f553b507dd49d28d2b19aebed3ac6 | d97237a292b3a0740ea1ee90e93be8e44c22673c | "2020-09-02T08:28:54Z" | javascript | "2020-09-04T13:19:12Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,771 | ["packages/next/client/link.tsx", "packages/next/client/page-loader.ts", "packages/next/next-server/lib/router/router.ts", "test/integration/dynamic-routing/pages/index.js", "test/integration/dynamic-routing/test/index.test.js"] | We should handle interpolating dynamic href values correctly | When the dynamic route is provided with the query params we should support interpolating the values automatically.
Example:
```jsx
<Link href={{
pathname: '/blog/[slug]'
query: { slug: 'post-1' }
}}>
<a>To /blog/post-1</a>
</Link>
```
x-ref: https://github.com/vercel/next.js/pull/16634 | https://github.com/vercel/next.js/issues/16771 | https://github.com/vercel/next.js/pull/16774 | 22800319159d8594224e22766c33ca387761d05c | f8d92a67f04481cba7e8a3ac1ebc5a6b7dadc873 | "2020-09-02T07:21:39Z" | javascript | "2020-09-02T16:23:26Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,752 | ["examples/with-react-intl/lang/en-GB.json", "examples/with-react-intl/lang/zh-Hans-CN.json", "examples/with-react-intl/lang/zh-Hant-HK.json", "examples/with-react-intl/package.json", "examples/with-react-intl/pages/_app.tsx", "examples/with-react-intl/pages/_document.tsx"] | [examples, react-intl] Application cannot be deployed using serverless target (Vercel, Netlify) | # Bug report
The current version of the `react-intl` example was simplified by @longlho in #16215 but it keeps the usage of a custom server
## Describe the bug
The custom server prevents usage of the serverless build target, which also prevents it from using it with Vercel.
I'm currently running a version of the previous example without the custom server by moving all the detection logic client-side.
This works but sacrifices UX by reloading languages and rerendering when loading a page.
I would prefer to find a solution using `react-intl` as I find it's API to be better than what next/react-i18next offer.
## To Reproduce
not applicable
## Expected behavior
Ideally we reach a similar solution to [`next-i18next`](https://github.com/isaachinman/next-i18next) which makes this possible across all targets supported by Next.js
## Screenshots
not applicable
## System information
- Version of Next.js: 9.5.2
- Version of Node.js: 14 (development), 12 (Netlify functions)
## Additional context
I'm currently researching solutions to this problem for a project that might move to blitz-js, and found this to be an open issue there, blitz-js/blitz#279 | https://github.com/vercel/next.js/issues/16752 | https://github.com/vercel/next.js/pull/16806 | 4ba768e22c56141d5488f8ee1f1d78d703b0fbfd | 67b67b28b229fca0bd937d154270c6a6312e2bce | "2020-09-01T15:13:41Z" | javascript | "2020-09-16T23:01:21Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,725 | ["examples/ssr-caching/package.json", "examples/ssr-caching/server.js"] | SSR caching example is broken (UnhandledPromiseRejectionWarning: TypeError: argument entity is required) | # Bug report
## Describe the bug
The SSR caching login is broken with the error below.
```
(node:14465) UnhandledPromiseRejectionWarning: TypeError: argument entity is required
at etag (/home/omar/Desktop/ssr-caching-app/node_modules/etag/index.js:72:11)
at /home/omar/Desktop/ssr-caching-app/node_modules/cacheable-response/index.js:95:32
at runMicrotasks (<anonymous>)
at processTicksAndRejections (internal/process/task_queues.js:97:5)
(node:14465) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:14465) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
```
## To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
1. Go to https://github.com/vercel/next.js/tree/canary/examples/ssr-caching
2. Run locally
3. Access the website
4. See error in the terminal (notice the speed and the missing headers in the response)
## Expected behavior
It should cache pages normally.
## System information
- OS: Ubuntu 18.04
- Browser (if applies): Chrome
- Version of Next.js: 9.5.2(latest)
- Version of Node.js: 12.16.2
## Additional context
It was working fine on our project, until it didn't when I upgraded to v9.5.2 from v9.5.1
So I thought of testing the official example, just to find out the same issue! | https://github.com/vercel/next.js/issues/16725 | https://github.com/vercel/next.js/pull/18786 | 1773b991bc300ea1943e2c94434bc2f16857181a | fb843a5577fb9382203702926391a9628582c706 | "2020-08-31T14:43:45Z" | javascript | "2021-02-07T18:20:00Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,715 | ["packages/next-polyfill-module/src/index.js"] | Edge 18 (Object.fromEntries) not supported even with correct polyfills | # Bug report
using the following `.babel.rc` leads to a build that should in theory support edge 18.
```
{
"presets": [
[
"next/babel",
{
"preset-env": {
"targets": "> 0.25%"
}
}
]
],
"plugins": [
["styled-components", { "ssr": true }],
[
"module-resolver",
{
"root": ["."],
"alias": {
"@/Components": "components",
...
"@/Functions": "components/Concepts/Functions"
}
}
]
]
}
```
This can be confirmed by running `npx browserslist "> 0.25%"`. However, when testing live via browserstack (as its pretty hard to actually install edge 18), it seems like this is not the case, as the following bug pops up:
```
TypeError
Object doesn't support property or method 'fromEntries'
```
## To Reproduce
Unfortunately, it's pretty hard for me to reliably reproduce the bug in a minimal example as I can't even run edge 18 locally. However, navigating to https://staging-viteach.com/concepts/rational%20numbers with edge 18 AND logging in - no validation required - will produce the bug.
## Expected behavior
Would think that the config creates the correct polyfill.
## Screenshots
## System information
- OS: Windows 10 (runtime)
- Browser (if applies) edge 18 (runtime)
- Version of Next.js: 9.4.4 (buildtime)
- Version of Node.js: 13.13 (buildtime)
| https://github.com/vercel/next.js/issues/16715 | https://github.com/vercel/next.js/pull/36426 | ab48f547864a1e325dd92bfb4790833917e1d71f | 4199da09b8211a6687ca1ea4acbde6a1d597c576 | "2020-08-31T09:36:58Z" | javascript | "2022-08-08T05:04:19Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,690 | ["packages/next/client/index.tsx", "packages/next/next-server/lib/router/router.ts", "test/integration/build-output/test/index.test.js"] | Experimental scrollRestoration flag causes browser to make a favicon request on every scroll event | # Bug report
## Describe the bug
When the `experimental.scrollRestoration: true` feature is enabled, the resulting `replaceState` triggered by each scroll event will (potentially depending on caching, I assume) cause Chrome to re-request the favicon URL.
(I'm not sure why Chrome would re-request that just for a `replaceState`, that doesn't seem necessary, but it's happening nonetheless.)
## To Reproduce
1. Enable `experimental.scrollRestoration: true` in your app.
2. Start the app and open the Network panel.
3. Scroll the page.
## Expected behavior
Scrolling should not cause network requests.
## Screenshots
## System information
- macOS
- Chrome (maybe others)
- Next.js 9.5.2
## Additional context
Maybe a solution would be to capture the scroll position the moment before the page changes, instead of on every scroll event? Was that tried already?
| https://github.com/vercel/next.js/issues/16690 | https://github.com/vercel/next.js/pull/20633 | 380afbfba2a277ed19bc69a608cf5053c44cdcf7 | dbe1e626f877a9ef7bbffc2f360bae809874790d | "2020-08-29T22:36:17Z" | javascript | "2020-12-31T16:08:12Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,689 | ["examples/with-react-intl/lang/en.json", "examples/with-react-intl/lang/fr.json", "examples/with-react-intl/package.json", "examples/with-react-intl/pages/_app.tsx", "examples/with-react-intl/pages/_document.tsx", "examples/with-react-intl/server.ts"] | [Example] Fix latest with-react-intl | # Bug report
## Describe the bug
The latest `with-react-intl` example https://github.com/vercel/next.js/pull/16215 has a few issues:
- The extracted message ids don't match the ones produced in the `.next` cache. The compiled langs are therefore not used and default to the ones defined in the components.
```json
{
"65a8e": "Hello, World!",
}
```
```js
__jsx("p", null, __jsx(react_intl__WEBPACK_IMPORTED_MODULE_1__["FormattedMessage"], {
id: "N015Sp",
defaultMessage: [{
"type": 0,
"value": "Hello, World!"
}]
}))
```
- The translation happens only client side.
- When navigating to a different page the locale is undefined and defaults back to `en`.
## To Reproduce
1. Install the latest `with-react-intl` example
2. `yarn build && yarn start`
3. Switch your browser language to French
4. The messages are still the default ones (in English)
5. Fix the ids in `.next` cache to match those in `compiled-lang`
6. The messages are first rendered in English, then change to French client side
7. Naviguate to another page, the messages are back to English
## Expected behavior
- Expect to have matching compiled ids
- Expect to return compiled messages in SSR
- Expect to keep the same locale when navigating
## Screenshots
<img src="https://user-images.githubusercontent.com/233639/91645714-6bae0180-ea15-11ea-8664-14cbdde371b9.gif">
## System information
- Version of Next.js: 9.5.2
- Version of Node.js: 14.7.0 | https://github.com/vercel/next.js/issues/16689 | https://github.com/vercel/next.js/pull/16692 | f1c4cb8b3b9c1ae7ab3b6632130e00de1e25d78f | 6f60a2237785f2594d376990da4db88b346d2078 | "2020-08-29T22:12:07Z" | javascript | "2020-09-01T01:33:24Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,661 | ["docs/advanced-features/preview-mode.md"] | Preview mode should include API Routes on docs | API Routes also have access to the preview data added by Preview Mode in `req.previewData`. Our docs should be updated to reflect that. | https://github.com/vercel/next.js/issues/16661 | https://github.com/vercel/next.js/pull/16705 | ce994365b74b89d97dff90707158bb63c99687de | f1c4cb8b3b9c1ae7ab3b6632130e00de1e25d78f | "2020-08-28T19:43:24Z" | javascript | "2020-08-31T03:02:24Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,649 | ["examples/with-framer-motion/components/Gallery.js", "examples/with-framer-motion/components/SingleImage.js", "examples/with-framer-motion/constants.js", "examples/with-framer-motion/pages/image/[index].js"] | Missing images in with-framer-motion example | # Bug report
Images referenced in the `with-framer-motion` example link to an expired site on squarespace.
The example is broken.
## Describe the bug
The `SingleImage` component generates this kind of URLs :
```
https://static1.squarespace.com/static/5b475b2c50a54f54f9b4e1dc/t/5b5a3938562fa764113169a6/1532639559620/DSCF3338.jpg?format=1500w
```
...and it outputs a **404** with the following message :
```
Website Expired. This account has expired. If you are the site owner, click below to login.
```
## To Reproduce
Clone the example and run it .
## Expected behavior
The images should load.
Maybe they could be hosted on Vercel ?
| https://github.com/vercel/next.js/issues/16649 | https://github.com/vercel/next.js/pull/16714 | 1c45f709528e77d758129bcff5d593161b848028 | 808d6b94eb8d806e60bc46623e61996e8e0348d9 | "2020-08-28T12:08:57Z" | javascript | "2020-09-01T18:03:41Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,633 | ["docs/api-reference/next.config.js/basepath.md", "docs/api-reference/next/link.md", "docs/api-reference/next/router.md", "docs/routing/dynamic-routes.md", "docs/routing/introduction.md"] | Update docs for linking to dynamic routes | In our current `canary` release `Link` no longer requires to know the path of a page for client side transitions. We should update our docs to reflect that the usage of the `as` parameter is now optional. | https://github.com/vercel/next.js/issues/16633 | https://github.com/vercel/next.js/pull/16634 | 4c5c7cd2daf0f88a060b098c4f7906936bbeb883 | ea2df6c0c28cc753b81b25c2f57a13a624a30fee | "2020-08-27T20:44:40Z" | javascript | "2020-09-07T16:35:30Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,624 | ["packages/next/client/page-loader.ts"] | [Next 9.5] Prefetch related Uncaught Exceptions on Firefox | # Bug report
## Describe the bug
Whenever a dynamic route is referenced in a page through the use of the `next/link` with prefetching enabled, **on a production build**, Firefox throws `Uncaught Exceptions` for each one of the `<link link="..." rel="prefetch" as="fetch" />` entries.
An example image can be found below. Also, you can refer to [this repository](https://github.com/araujoigor/nextjs9.5-firefox-prefetch-exception) if you want to reproduce the issue.
No behavior is impacted but this is specifically annoying since it may trigger alerts on monitoring platforms such as `Sentry`. If you have enough links, it may even trigger rate limiting on these services.
## To Reproduce
In order to reproduce the issue, simply open the following repository and follow the instructions:
https://github.com/araujoigor/nextjs9.5-firefox-prefetch-exception
## Expected behavior
The expected behavior is simply to not have these Uncaught Exceptions to occur.
## Screenshots
## System information
- OS: macOS 10.15.6
- Browser: Firefox
- Version of Next.js: 9.5.2
- Version of Node.js: 12.18.2
## Additional context
This issue didn't exist in previous versions of Next.
| https://github.com/vercel/next.js/issues/16624 | https://github.com/vercel/next.js/pull/16757 | 808d6b94eb8d806e60bc46623e61996e8e0348d9 | e34e5e09d91f6e33867ed0b0eec9648680ffa024 | "2020-08-27T11:56:40Z" | javascript | "2020-09-01T18:09:25Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,610 | ["packages/next/client/index.tsx", "packages/next/client/page-loader.ts"] | Do not rely on browser `cssText` field | https://github.com/vercel/next.js/issues/16610 | https://github.com/vercel/next.js/pull/16611 | 42e8dcf281526b5dde27448010e96edcd5ceb196 | 328abb72ca83d47dd1ae0e7c4237de281e33e5d6 | "2020-08-26T19:38:10Z" | javascript | "2020-08-27T02:13:28Z" |
|
closed | vercel/next.js | https://github.com/vercel/next.js | 16,566 | [".github/workflows/build_test_deploy.yml", "packages/next/build/webpack/plugins/font-stylesheet-gathering-plugin.ts"] | Webpack 5 Builds Break with optimizeFonts | # Bug report
## Describe the bug
Unclear if this warrants a bug report since it's an experimental feature, but if you use optimizeFonts with webpack 5, it breaks when deploying to Vercel.
## To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
Repro: https://github.com/laugharn/webpack-5-optimize-fonts-repro
Failed Deployment: https://vercel.com/laugharn/webpack-5-optimize-fonts-repro/acy7b5afi
## Expected behavior
A successful build.
| https://github.com/vercel/next.js/issues/16566 | https://github.com/vercel/next.js/pull/17450 | 1c4aecbeaf9de44cec3484f76d23ec8103f3bc50 | 71d798ce889932311f2ef575c4c80b09ad57bb6f | "2020-08-25T17:29:57Z" | javascript | "2020-10-12T18:58:09Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,563 | ["docs/basic-features/built-in-css-support.md", "packages/next/build/webpack/config/blocks/css/index.ts", "test/integration/css-fixtures/import-global-from-module/node_modules/example/index.css", "test/integration/css-fixtures/import-global-from-module/node_modules/example/index.js", "test/integration/css-fixtures/import-global-from-module/node_modules/example/index.mjs", "test/integration/css-fixtures/import-global-from-module/node_modules/example/package.json", "test/integration/css-fixtures/import-global-from-module/pages/index.js", "test/integration/css/test/index.test.js"] | Flag to let components load global styles | # Feature request
Ability to load 3rd party global styles either conditionally or directly from a component.
## Problem description
Forcing the use of .module.css or global.css in app is great when it comes to organizing and practicing healthy css structure, but it starts to be limiting when it comes to 3rd party plugins. (source: https://nextjs.org/docs/basic-features/built-in-css-support#adding-a-global-stylesheet)
### Usecase:
I'm trying to implement the great https://github.com/jackocnr/intl-tel-input to make my `<input type="tel"/>` look nicer. I came up with small re-usable component
```js
import React, {useRef, useEffect} from 'react'
import intlTelInput from 'intl-tel-input'
export default function TelInput(props) {
const input = useRef(null)
useEffect(() => {
intlTelInput(input.current)
}, [])
return (
<input type="tel" ref={input}/>
)
}
```
This instantiate the plugin correctly, but the styles are missing. If I import the styles from the components:
```js
// ...
import 'intl-tel-input/build/css/intlTelInput.css'
export default function TelInput(props) {
// ...
```
I get the (expected) error:
```
./node_modules/intl-tel-input/build/css/intlTelInput.css
Global CSS cannot be imported from files other than your Custom <App>. Please move all global CSS imports to pages/_app.js. Or convert the import to Component-Level CSS (CSS Modules).
Read more: https://err.sh/next.js/css-global
Location: components/ui/Form/Fields/Tel/Tel.js
```
As expected, if I add it to my _app.js, it does work.
The issue is that the styles for the plugins will be loaded on each and every page even if TelInput is not present, which essentially breaks the re-usability of my component by making it it dependent on context (App).
Ultimately it's not a big deal to have this one plugin CSS loaded globally, but given the number of plugins out there that require some form of styles import, this could eventually bloat the global style.
## Describe the solution you'd like
Potential solutions:
### Ideal solution: Scoped flag for import
```sass
// Tel.module.sass
.telInput
@import "intl-tel-input/build/css/intlTelInput" !scoped
```
Which would render
```css
.telInput__H@Sh .global-declaration { color: red; }
```
Instead of
```css
.telInput__H@Sh .global-declaration__hAsH { color: red; }
```
### Scope a global import by the given class class:
```html
<style scoped="CustomClass">
.global-declaration { color: red; }
</style>
```
Renders
```html
<style>
.CustomClass__H@Sh .global-declaration { color: red; }
</style>
```
### Allow global import from node_modules within components, maybe with a flag like
`import 'intl-tel-input/build/css/intlTelInput.css' !global`
### A getStaticStyles implementation which lets you load & compile additional styles for a given page
```js
export async function getStaticStyles() {
import 'intl-tel-input/build/css/intlTelInput.css'
}
```
| https://github.com/vercel/next.js/issues/16563 | https://github.com/vercel/next.js/pull/16993 | 5aed1d2e353a1e49db49a69405ab6cd17328743a | 1ea674510665f950509e6a63ea080cf33fa8990d | "2020-08-25T15:54:32Z" | javascript | "2020-09-10T17:45:30Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,551 | ["packages/next/types/index.d.ts"] | Feature request: Export a "GetStaticPathsResult" Typescript type | # Feature request
NextJS currently exports the `GetStaticPropsResult` and `GetStaticPropsContext` types which helps us to type our module boundaries like so:
```ts
import { GetStaticPropsContext, GetStaticPropsResult } from "next";
export async function getStaticProps(
context: GetStaticPropsContext
): Promise<GetStaticPropsResult> {
// …
}
```
My request is for the `GetStaticPathsResult` type to be exported as well, so we can do the following:
```ts
export async function getStaticPaths(): Promise<GetStaticPathsResult> {
// …
}
``` | https://github.com/vercel/next.js/issues/16551 | https://github.com/vercel/next.js/pull/16580 | d59f12c41600d001e6ed6d1df98892fb4fb17995 | d20dbd6c2ecd0544ae737614db266b069028ed4f | "2020-08-25T09:50:07Z" | javascript | "2020-09-01T17:20:17Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,550 | ["examples/with-typescript-graphql/lib/resolvers.ts", "examples/with-typescript-graphql/lib/type-defs.graphqls", "examples/with-typescript-graphql/lib/viewer.graphql", "examples/with-typescript-graphql/pages/index.tsx", "examples/with-typescript-graphql/test/__snapshots__/index.test.tsx.snap"] | add graphql-let mutation sample code i | # Feature request
add graphql-let mutation sample code in this example. https://github.com/vercel/next.js/blob/canary/examples/with-typescript-graphql/README.md#readme
## Is your feature request related to a problem? Please describe.
A clear and concise description of what you want and what your use case is.
## Describe the solution you'd like
A clear and concise description of what you want to happen.
## Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
## Additional context
Add any other context or screenshots about the feature request here.
| https://github.com/vercel/next.js/issues/16550 | https://github.com/vercel/next.js/pull/16742 | 530b14616f64071b7207fb7aa0184673eae74fd6 | a2bea9b49293c33fd7f2f68baa103aa18c623ebe | "2020-08-25T09:47:45Z" | javascript | "2020-11-10T21:10:54Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,542 | ["packages/next/build/webpack/loaders/next-serverless-loader.ts", "packages/next/next-server/server/next-server.ts", "packages/next/next-server/server/render.tsx", "test/integration/getserversideprops/test/index.test.js", "test/integration/revalidate-as-path/pages/_app.js", "test/integration/revalidate-as-path/pages/another/index/index.js", "test/integration/revalidate-as-path/pages/index.js", "test/integration/revalidate-as-path/server.js", "test/integration/revalidate-as-path/test/index.test.js"] | deploying to Vercel causes conditional statements to evaluate incorrectly | # Bug report
## Describe the bug
When rendering a page using Incremental Static Regeneration a *conditional statement is erroneously applied to the wrong element.
*I'm referring to conditional rendering expressions of the following form:
```jsx
<div>
{true && <div />}
<div />
</div>
```
## To Reproduce
1. go to my repo, https://github.com/AHBruns/vercel-repro
2. clone it, `npm install`, and *`npm run dev`
3. inspect element
4. you'll see the following, which is correct:
```html
<div>
<div class="SHOW"></div>
</div>
```
5. deploy the repo to Vercel
6. go to the deployed site
7. inspect element
8. you'll see the following, which is incorrect:
```html
<div>
<div class="NO_SHOW"></div>
</div>
```
*`npm run build && npm run start` yields the same problem
## Expected behavior
A single div with the class `SHOW` should be added to the DOM regardless of the environment.
## System information
- Version of Next.js: v9.5.2
- Version of Node.js: v14.3.0
| https://github.com/vercel/next.js/issues/16542 | https://github.com/vercel/next.js/pull/17081 | 80000f42383af03e2f21cf1ba60b860ee78ffb08 | 94a5bd6109b84ef55c1a07b0be019ea32a559390 | "2020-08-25T03:35:31Z" | javascript | "2020-09-14T16:48:04Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,495 | ["packages/next/build/babel/plugins/no-anonymous-default-export.ts"] | Link Fash Refresh warning to codemod | Update the Fast Refresh warning to include a link to the next-codemod: https://nextjs.org/docs/advanced-features/codemods#name-default-component
| https://github.com/vercel/next.js/issues/16495 | https://github.com/vercel/next.js/pull/16496 | a7550bf1d7b2a2c4075b4ba958a03e21612e93ad | 735aab6f03a9b70dd8c2cb70c8702bd86e6c9005 | "2020-08-23T16:59:02Z" | javascript | "2020-08-24T03:04:25Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,482 | ["packages/next/build/webpack/loaders/next-serverless-loader.ts", "packages/next/next-server/server/render.tsx", "test/integration/fallback-route-params/pages/[slug].js", "test/integration/fallback-route-params/test/index.test.js"] | Fallback SSG pages have incorrect default dynamic route params in production | In production fallback SSG pages' dynamic route params should be undefined for initial render although they currently are provided as the params path part e.g. `{ id: '[id]' }`, this only occurs in serverless mode currently | https://github.com/vercel/next.js/issues/16482 | https://github.com/vercel/next.js/pull/16485 | 32ee65efa1a28f2c0a9b9199af58c2b8b4daed33 | 4e0b40145d289736a7c67bbf26d8c8e10fa6fe99 | "2020-08-23T00:47:21Z" | javascript | "2020-08-23T12:35:30Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,481 | ["packages/next/build/webpack/loaders/next-serverless-loader.ts", "packages/next/next-server/server/render.tsx", "test/integration/fallback-route-params/pages/[slug].js", "test/integration/fallback-route-params/test/index.test.js"] | Fallback SSG pages don't have undefined dynamic route params in dev mode | During development we aren't matching production behavior currently and dynamic route params are available during the initial render when they won't be in production for fallback SSG pages | https://github.com/vercel/next.js/issues/16481 | https://github.com/vercel/next.js/pull/16485 | 32ee65efa1a28f2c0a9b9199af58c2b8b4daed33 | 4e0b40145d289736a7c67bbf26d8c8e10fa6fe99 | "2020-08-23T00:45:34Z" | javascript | "2020-08-23T12:35:30Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,478 | ["docs/advanced-features/module-path-aliases.md"] | Update documentation on module path aliases | The [module path alias documentation](https://nextjs.org/docs/advanced-features/module-path-aliases) is incomplete. It will cause a "Module not found" error at build time. You also have to update the webpack configuration, i.e. https://github.com/vercel/next.js/issues/10929
This webpack configuration update should be included in the documentation. | https://github.com/vercel/next.js/issues/16478 | https://github.com/vercel/next.js/pull/16479 | 85d58298a3e324eabe8f27a2b243928d1edbe652 | 4d0d09ba9da07fcfe4825ca4e3118dabfae9c45f | "2020-08-22T19:18:42Z" | javascript | "2020-08-22T21:28:47Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,454 | ["packages/next/next-server/lib/router/router.ts", "packages/next/next-server/lib/router/utils/resolve-rewrites.ts", "test/integration/rewrites-client-resolving/next.config.js", "test/integration/rewrites-client-resolving/pages/404.js", "test/integration/rewrites-client-resolving/pages/category/[...slug].js", "test/integration/rewrites-client-resolving/pages/category/index.js", "test/integration/rewrites-client-resolving/pages/index.js", "test/integration/rewrites-client-resolving/pages/product/[productId].js", "test/integration/rewrites-client-resolving/pages/product/index.js", "test/integration/rewrites-client-resolving/test/index.test.js"] | Rewrites resolving on the client should break after matching dynamic route | When using the rewrite `{ source: '/:path*', destination: '/path*' }` the rewrites chain should be broken on the client same as on the server when a dynamic route or page file is matched after.
| https://github.com/vercel/next.js/issues/16454 | https://github.com/vercel/next.js/pull/16455 | 42e1d5b5dc9c33b07319bdc1952fdddcf7c15aca | 8a1c9937b67c4ba6611d44fb6309215a8235f5ca | "2020-08-21T19:20:59Z" | javascript | "2020-08-22T05:15:45Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,445 | ["packages/next/client/index.tsx", "packages/next/next-server/lib/router/router.ts", "test/integration/route-load-cancel-css/next.config.js", "test/integration/route-load-cancel-css/pages/index.js", "test/integration/route-load-cancel-css/pages/page1.js", "test/integration/route-load-cancel-css/pages/page1.module.css", "test/integration/route-load-cancel-css/pages/page2.js", "test/integration/route-load-cancel-css/server.js", "test/integration/route-load-cancel-css/test/index.test.js"] | [experimental react] Next throws on cancelled renders | PR fixing https://github.com/vercel/next.js/pull/16424 | https://github.com/vercel/next.js/issues/16445 | https://github.com/vercel/next.js/pull/16462 | 8a1c9937b67c4ba6611d44fb6309215a8235f5ca | 9acd001e092b7d3e96de92e39c006f43e6083352 | "2020-08-21T13:58:05Z" | javascript | "2020-08-22T11:47:21Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,444 | ["docs/api-reference/next.config.js/cdn-support-with-asset-prefix.md"] | getServerSideProps disables staticPrefix | # Bug report
## Describe the bug
When using getServerSideProps, the staticPrefix seems to be disabled for that page.
## To Reproduce
Enable staticPrefix in next.config.js
```js
export async function getServerSideProps(context) {
return {
props: { translations: [] },
}
}
```
## Expected behavior
The page keeps working and applies the staticPrefix.
## Actual behavior
The page requests the static resources without the prefix applied.
## System information
- OS: Azure
- Browser (if applies): Chrome
- Version of Next.js: 9.5.2
- Version of Node.js: 12
## Additional context
I have not debugged thoroughly, but removing `getServerSideProps` fixed the problem. | https://github.com/vercel/next.js/issues/16444 | https://github.com/vercel/next.js/pull/16998 | fa9523c0632b7bdfb06e98a87c9d3638abe78cfd | 6ecb740415bff7e45a62bfd39908ec38d610f7ca | "2020-08-21T13:52:13Z" | javascript | "2020-09-10T17:46:37Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,442 | ["docs/advanced-features/debugging.md"] | Incorrect / missing documentation for debugging client-side javascript in VS Code | # Bug report
## Describe the bug
As best as I can tell, the documentation at https://nextjs.org/docs/advanced-features/debugging only describes how to configure debugging for the `node` process in vscode. It doesn't provide any specific instructions on how to debug code that is run in browser, in chrome at the client side.
I think this is problematic because (speaking for myself) **most** of the debugging I want to do is client-side debugging. `nextjs` is mostly a black box to me, and I am blissfully unaware.
It does, however, offer instructions on how to use chrome devtools to remotely debug the nextjs process... which I find a little confusing and misleading. It seems to suggest that this will somehow allow you to debug client-side javascript by simply attaching to the node process. I think this should be clarified.
If you are assuming the user is on the latest version of `vscode-js-debug` (https://github.com/microsoft/vscode-js-debug) and are assuming the user is clicking on the `ready - started server on http://localhost:3000` in a `Javascript Debug Terminal`, then this should also explicitly be explained. These are new features and not obvious.
I think the documentation should also point out a valid launch configuration for those who are using `Debugger for Chrome` and want to debug the client-side javascript only, also showing how to modify it when using `/src` or when the app is at a subpath from the `${workspaceFolder}`.
In particular, the need to use a custom `sourceMapPathOverrides` should be mentioned, as of `9.5.2` (or possibly earlier) the following properties in the configuration in `launch.json` is necessary for client-side sourceMaps to be resolved and for breakpoints set in vscode to bind:
```
"webRoot": "${workspaceFolder}/pathto/app",
"sourceMapPathOverrides": {
"webpack://_N_E/*": "${webRoot}/*"
}
```
When clicking on links in a `Javascript Debug Terminal`, then these properties need to be set in VSCode's settings here:
I found all this out the hard way, chronicling my adventures here:
https://stackoverflow.com/questions/63523469/how-can-i-configure-chrome-debugging-in-vscode-for-nextjs-9-5-2
In summary:
- [ ] make a distinction between client-side and server-side debugging instructions
- [ ] when using the (latest) `vscode-js-debug` plugin:
- [ ] point out the need to open a Javascript Debug Terminal and click on the served link
- [ ] point out the need to set webRoot (if at a subpath) and sourceMapOverrides in VSCode settings
- [ ] when using `Debugger for Chrome`
- [ ] provide a valid example launch configuration
- [ ] include the sourceMapOverride
- [ ] point out the need to add webRoot if at a subpath
Hope my points are valid and I'm not missing something blatantly obvious with all of this :) | https://github.com/vercel/next.js/issues/16442 | https://github.com/vercel/next.js/pull/28815 | c491adfe12dfad89581be3cd751d30ddb3855477 | c7e187f893bb399f5f8d51f35afea6e7ec869162 | "2020-08-21T13:42:24Z" | javascript | "2021-09-16T07:07:56Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,440 | ["packages/next/build/webpack/loaders/next-serverless-loader.ts", "packages/next/next-server/lib/router/utils/path-match.ts", "packages/next/next-server/lib/router/utils/resolve-rewrites.ts", "packages/next/next-server/server/next-server.ts", "packages/next/next-server/server/router.ts", "test/integration/production-nav/next.config.js", "test/integration/production/next.config.js"] | Spread operator not working in Safari 11.0.3 | # Bug report
## Describe the bug
A user has reported this issue for our site, which is running on nextjs 9.4.0. This also happens on vercel.com/login. Certain elements on the site fails to load on with console error `SyntaxError: Unexpected token '...'. Expected a property name.`.
For our site, our mapbox based map doesn't load, while on vercel's login page, the "Continue with..." buttons do not render.
We are unable to replicate exactly on our side as we don't have access to Safari 11.0.3 currently. Using browserstack, it works fine on Safari 11.1, but not on 10.1
According to https://github.com/vercel/next.js/issues/11507, this might be due to a node_module not being polyfilled
## To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
1. Get a mac running Safari 11.0.3
2. Go to 'https://vercel.com/login'
3. See that "Continue with ..." buttons do not render properly
## Expected behavior
Nextjs 9.4.0 to render properly with polyfills, but if that version of Safari is no longer supported, then I'll close this
## Screenshots
Sorry for lack of proper screenshots, this was provided by a user.
## System information
- OS: macOS
- Browser (if applies) Safari
- Version of Next.js: 9.4.0
## Additional context
| https://github.com/vercel/next.js/issues/16440 | https://github.com/vercel/next.js/pull/16453 | 7c7ecaa6369690987876f3fc61479b8331f5bbb5 | 78ef13914a732b2a74255e685ecca2b022418e45 | "2020-08-21T13:13:22Z" | javascript | "2020-08-21T19:11:25Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,426 | ["packages/eslint-plugin-next/lib/rules/no-html-link-for-pages.js"] | no-html-link-for-pages eslint rule should work with src/pages folder | # Bug report
## Describe the bug
currently, the `no-html-link-for-pages` eslint-rule by default only looks in the `pages` folder for pages. it should also look [in `src/pages`](https://nextjs.org/docs/advanced-features/src-directory).
## To Reproduce
1. yarn create next-app .
2. yarn add -D eslint @next/eslint-plugin-next
3. mkdir src && mv pages src
4. echo '{"extends":"plugin:@next/next/recommended","env":{"es6":true},"parserOptions":{"sourceType":"module"}}' > .eslintrc.json
5. yarn eslint .
6. Error:
```
Error: Error while loading rule '@next/next/no-html-link-for-pages': Pages directory cannot be found at /data/Development/playground/th/pages, if using a custom path, please configure with the no-html-link-for-pages rule
```
## Expected behavior
Should work with `src/pages` folder
## System information
- OS: Ubuntu 20.04
- Version of Next.js: 9.5.2
- Version of Node.js: 12.18.3
## Additional context
while it is possible to configure the `no-html-link-for-pages` to look for pages in any custom folder, i think `src/pages` should be supported ootb. | https://github.com/vercel/next.js/issues/16426 | https://github.com/vercel/next.js/pull/16743 | 67b67b28b229fca0bd937d154270c6a6312e2bce | fa0351639a184264375e7ecbe44db3a15c0917ca | "2020-08-21T07:58:26Z" | javascript | "2020-09-18T00:09:25Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,407 | ["docs/basic-features/data-fetching.md", "packages/next/build/webpack/loaders/next-serverless-loader.ts", "packages/next/next-server/server/next-server.ts", "packages/next/next-server/server/render.tsx", "packages/next/types/index.d.ts", "test/integration/getserversideprops/next.config.js", "test/integration/getserversideprops/pages/blog/[post]/index.js", "test/integration/getserversideprops/pages/something.js", "test/integration/getserversideprops/test/index.test.js"] | Add "asPath" (or similar) in getServerSideProps | # Feature request
Add in `getServerSideProps`'s function a parameter similar to `asPath` from `getInitialProps`, which would contain the URL path the user will see in it's browser.
Use cases include path logging and dynamic path analysis.
## Describe the solution you'd like
For a file `./pages/items-search/[[...slug]].js`, this parameter would show what the user will see after `getServerSideProps` returns, such as:
* `/items-search/`
* `/items-search/?order=asc`
* `/items-search/category-one/`
* `/items-search/category-one/sub-category-two/`
* `/items-search/category-one/?order=asc`
* `/items-search/category-one/sub-category-two/?order=desc&query=super%20item`
The parameter does not need to be necessarily named `asPath`.
## Describe alternatives you've considered
It is technically possible to build the desired value by joining the folders+file name with the slug parameters and querystring.
It works, but I didn't find an easy way of **dynamically** retrieving the current path prefix (i.e. folders+file name, without including slug parameters or querystring).
`req.url` can help, but it becomes something like `/_next/data/BUILD_ID/PAGE_NAME.json?a=b` during CSR requests.
| https://github.com/vercel/next.js/issues/16407 | https://github.com/vercel/next.js/pull/17082 | 71a01815728303c5dd4dd1a840568a9f251909ce | d3f4a4cb2afc9e18a82609d907d50a311578470f | "2020-08-20T18:07:33Z" | javascript | "2020-09-14T21:01:04Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,335 | ["packages/next/client/index.tsx", "test/integration/production/pages/css-and-back.js", "test/integration/production/pages/css-modules.js", "test/integration/production/test/index.test.js"] | Fix IE11 compatibility on `next@canary` | Currently, `next@canary` errors in IE11 with the following error:
(remove, ignore append)
 | https://github.com/vercel/next.js/issues/16335 | https://github.com/vercel/next.js/pull/16336 | 25fa1653bd27fff79acd61d5cb28659e878f0111 | 9746043354c57f4d40ab0b8b58282268a3bf9caf | "2020-08-19T05:00:16Z" | javascript | "2020-08-19T06:34:44Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,333 | ["packages/next/client/page-loader.ts", "test/integration/client-404/pages/missing.js", "test/integration/client-404/pages/to-missing-link.js", "test/integration/client-404/test/client-navigation.js", "test/integration/client-404/test/index.test.js"] | Next.js router can sometimes hang for existing users on app after a new deployment | The Next.js router can sometimes hang (an edge case) when a user is on the app and a new deployment is made. This causes routing assets to go missing, and under certain conditions, prevents Next.js from automatically reloading to the new version. | https://github.com/vercel/next.js/issues/16333 | https://github.com/vercel/next.js/pull/16334 | 8ef253fd021c516279fbbd59cc84423a6d55f2b3 | 0a72d14deb2249d6f03e6d2eb370ff8394db4189 | "2020-08-19T02:59:11Z" | javascript | "2020-08-19T11:41:01Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,283 | ["packages/next/client/index.tsx"] | [internal] [canary only] Fix IE 11 compat | The latest canary is failing on IE 11. | https://github.com/vercel/next.js/issues/16283 | https://github.com/vercel/next.js/pull/16282 | d824189bcd40913d2961764dc62d0e273d600e83 | 9aadd1aa36eef8d09232eda3e8b4da5625a265b0 | "2020-08-18T03:55:14Z" | javascript | "2020-08-18T03:56:14Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,269 | ["packages/next/build/webpack/loaders/next-serverless-loader.ts", "test/integration/prerender-fallback-aspath/next.config.js", "test/integration/prerender-fallback-aspath/pages/blog/[post]/[comment].js", "test/integration/prerender-fallback-aspath/pages/blog/[post]/index.js", "test/integration/prerender-fallback-aspath/server.js", "test/integration/prerender-fallback-aspath/test/index.test.js"] | Fallback SSG pages have inconsistent asPath values | I use router.asPath in _app in order to set alternate link tags. i.e.: for the page /pages/article/[id].js SSR returns /article/123, but in case of SSG it return /article/[id]. I see this behavior on the Vercel platform, not locally.
I use Next.js 9.5.2.
_Originally posted by @hk86 in #16256_
<hr />
We need to interpolate the dynamic values and rebuild the request URL for fallback SSG pages since the proxy uses the output path for non-prerendered pages on Vercel
| https://github.com/vercel/next.js/issues/16269 | https://github.com/vercel/next.js/pull/16352 | 1388aa41d5309525eecdf6c70aa52c6346a965cc | 67482914c686e2a660eaea157475ad5e80bae1a8 | "2020-08-17T19:01:11Z" | javascript | "2020-08-19T15:23:02Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,260 | ["packages/next/client/page-loader.ts", "packages/next/next-server/lib/router/router.ts"] | Legacy TypeScript version support | The latest `canary` Next.js is publishing types not compatible with old TS versions:
```
yarn run v1.22.4
$ cross-env NODE_ENV=production next build
info - Loaded env from /Users/z/projects/front/.env.production
Failed to compile.
./node_modules/next/dist/next-server/lib/router/router.d.ts:5:13
Type error: '=' expected.
3 | import { ComponentType } from 'react';
4 | import { UrlObject } from 'url';
> 5 | import type { GoodPageCache } from '../../../client/page-loader';
| ^
6 | import { MittEmitter } from '../mitt';
7 | import { NextPageContext } from '../utils';
8 | interface TransitionOptions {
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
```
This support was added in TypeScript 3.8. | https://github.com/vercel/next.js/issues/16260 | https://github.com/vercel/next.js/pull/16288 | 0fbc9d23ef3f9c6f9bc70617ae511797b880a166 | 8916e401a2dc482ef56ff112b8d164f6e5bd9ff5 | "2020-08-17T14:02:48Z" | javascript | "2020-08-18T14:06:10Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,259 | ["package.json", "packages/next/build/webpack-config.ts", "test/integration/build-output/fixtures/with-crypto/pages/index.js", "test/integration/build-output/test/index.test.js", "yarn.lock"] | After upgrading to to 9.5.2, client bundle includes unnecessary browser-node-polyfills | # Bug report
## Describe the bug
After upgrading to [email protected], client bundle includes `browser polyfils for Node.js`, probably related to #16022.
As far as I can tell, no code relies on these modules, because doing
```js
delete config.resolve.alias.crypto;
delete config.resolve.alias.stream;
delete config.resolve.alias.path;
delete config.resolve.alias.buffer;
delete config.resolve.alias.vm;
```
in `next.config.js` removes the modules from the bundle, but the code still works.
## To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
1. Upgrade to next 9.5.2
2. Bundle your code
3. Inspect the output
I realise that this will not be easy to debug, since it probably is related to our setup, which is closed source (sorry).
## Expected behavior
Unnecessary browser node polyfills should not be in the bundle
## Screenshots
<img width="611" alt="Screenshot 2020-08-17 at 14 59 16" src="https://user-images.githubusercontent.com/7705041/90398800-4aa2f380-e09a-11ea-9226-92022dbccfc1.png">
## System information
- OS:macOS
- Version of Next.js: 9.5.2
- Version of Node.js: 12.18.3
## Additional context
My best guess is that some code only running on the server causes this to be bundled, even though it is not used on the client.
Any help with further debugging would be awesome, just knowing why these are ending up being a part of the bundle. What dependency triggers these to be bundled.
| https://github.com/vercel/next.js/issues/16259 | https://github.com/vercel/next.js/pull/16452 | 450742274a5b37131f77f89f9d3c46ad8ced34b6 | 7c7ecaa6369690987876f3fc61479b8331f5bbb5 | "2020-08-17T13:03:38Z" | javascript | "2020-08-21T18:50:24Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,197 | ["examples/with-sentry/next.config.js"] | BasePath causes withSourceMaps to fail in with-sentry example | # Bug report
## Describe the bug
Using a `basePath` different from null on the webpack config makes the sourcemaps plugin fail
## To Reproduce
Steps to reproduce the behavior:
1. git clone [email protected]:Agupane/next.js-1.git
2. Install the dependencies
3. Setup the env variables for a sentry project:
```
NEXT_PUBLIC_SENTRY_DSN=
SENTRY_ORG
SENTRY_PROJECT=
SENTRY_AUTH_TOKEN=
VERCEL_GITHUB_COMMIT_SHA=
COMMIT_SHA=
```
4. Go to http://localhost:3000
5. Click on the button `This button will make the app throw an error`
6. Go to sentry and see that the sourcemaps are not displayed
## Expected behavior
I expect to be able to change the default basePath of webpack and see the sourcemaps on sentry
## Screenshots
With basePath different from empty:
With empty basePath:
## System information
- OS: macOS
- Browser: Chrome
- Version of Next.js: 9.5.2
- Version of Node.js: 10.16.3
## Additional context
Add any other context about the problem here.
| https://github.com/vercel/next.js/issues/16197 | https://github.com/vercel/next.js/pull/16376 | f2ba97d866863b46b3dcb68c9652a78d9fa0c4a9 | c97e53efe1a9741bb8762659aaac339961318b73 | "2020-08-14T19:02:28Z" | javascript | "2020-08-24T02:00:43Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,182 | ["packages/next/next-server/lib/utils.ts", "packages/next/next-server/server/render.tsx", "packages/next/pages/_document.tsx"] | [internal] Refactor /_document to rely on BuildManifest | Currently, `/_document` relies on information from the `BuildManifest` being passed to it instead of directly reading the `BuildManifest` itself. | https://github.com/vercel/next.js/issues/16182 | https://github.com/vercel/next.js/pull/16184 | db40a39f5ec260d29b245d2f5ea54441e9b2cdc4 | 9fcf39acd45966d8a6c362bec62e49a53dcd8581 | "2020-08-14T03:37:35Z" | javascript | "2020-08-14T14:20:03Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,173 | ["packages/next/bin/next.ts", "test/integration/cli/test/index.test.js", "test/lib/next-test-utils.js"] | Handle SIGTERM to allow graceful process exit | # Bug report
## Describe the bug
Server process won't handle SIGTERM / SIGINT anymore, exiting with code 1.
The change was introduce by https://github.com/vercel/next.js/pull/6450
With the new addition of custom Headers in `getStaticProps` pages, I was looking to get rid of my custom server and stumbled with this issue
## To Reproduce
1. Run: `yarn build`
2. Run: `yarn start &` (& to get the process ID)
3. Run: `kill ${PROCESS_ID}`
4. See how the process exits with status code 1
## Expected behavior
Process should exit with code 0
| https://github.com/vercel/next.js/issues/16173 | https://github.com/vercel/next.js/pull/19433 | f4bf8a4696af6f9a0b64636205356ba207fb1ea9 | 397a375b37ca7727f13d73b36fcc80df61cfc66a | "2020-08-13T21:14:50Z" | javascript | "2020-11-25T13:30:06Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,166 | ["packages/next/client/index.tsx", "packages/next/next-server/lib/router/router.ts"] | [internal] Convert `next/client` to TypeScript | https://github.com/vercel/next.js/issues/16166 | https://github.com/vercel/next.js/pull/16167 | 09afc376cd67357949d1e1d2ae52aeb82e654a1b | 0e48ea3938a6d57bc85c2d903f8401d147bfc4f6 | "2020-08-13T16:28:16Z" | javascript | "2020-08-13T17:39:33Z" |
|
closed | vercel/next.js | https://github.com/vercel/next.js | 16,147 | ["packages/next/next-server/lib/router/utils/querystring.ts", "test/integration/build-output/test/index.test.js", "test/integration/client-navigation/pages/nav/query-params.js", "test/integration/client-navigation/pages/query.js", "test/integration/client-navigation/test/index.test.js", "test/integration/size-limit/test/index.test.js"] | [9.5.2] The query string doesn't cleanup undefined value | # Bug report
## Describe the bug
Navigating router via `push`:
```js
router.push({
pathname: "/page-a",
query: {
param1: "ok",
param2: undefined
}
})
```
```js
// /pages/page-2
const router = useRouter();
console.log(router.query);
```
Result
```js
{
param1: "ok",
param2: "undefined"
}
```
In the `page-a`: The `param2` is an `undefined` string value.
## Expected behavior
Result
```js
{
param1: "ok"
}
```
The `param2` should be an `undefined` value.
## System information
- OS: [macOS]
- Browser (if applies) [chrome]
- Version of Next.js: [9.5.2]
- Version of Node.js: [14]
## Additional context
https://github.com/vercel/next.js/pull/15378 | https://github.com/vercel/next.js/issues/16147 | https://github.com/vercel/next.js/pull/16608 | ca986abd95b39b876236815490bcb2d591ddff5d | 5aed1d2e353a1e49db49a69405ab6cd17328743a | "2020-08-13T04:02:04Z" | javascript | "2020-09-10T15:12:37Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,143 | ["packages/next/client/head-manager.ts"] | [internal] Strongly type Head Manager | https://github.com/vercel/next.js/issues/16143 | https://github.com/vercel/next.js/pull/16144 | 9e65c6a958baad321f118c52907c117511cb239e | 16e4f9e79ef804221b7a761ced2971842fff98a5 | "2020-08-13T03:32:07Z" | javascript | "2020-08-13T03:54:48Z" |
|
closed | vercel/next.js | https://github.com/vercel/next.js | 16,131 | ["packages/next/build/index.ts", "packages/next/build/webpack/plugins/build-manifest-plugin.ts", "packages/next/client/page-loader.ts"] | [internal] Strongly type page loader | This will let us make changes to the page loader with more confidence. | https://github.com/vercel/next.js/issues/16131 | https://github.com/vercel/next.js/pull/16132 | e72ac7642235d37891deba08fdad31e9963f164c | 9e65c6a958baad321f118c52907c117511cb239e | "2020-08-12T20:04:11Z" | javascript | "2020-08-12T20:42:05Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,107 | ["packages/next/client/link.tsx", "packages/next/package.json", "test/acceptance/ReactRefreshLogBox.test.js", "yarn.lock"] | Link without href throws error | # Bug report
Server Error
TypeError: Cannot destructure property 'auth' of 'urlObj' as it is undefined.
## Describe the bug
Link without passed href results in this bug
## To Reproduce
Use Link without href.
## Expected behavior
Even though that typescript indicates the error, maybe a more helpful error message would be better?
## Screenshots
| https://github.com/vercel/next.js/issues/16107 | https://github.com/vercel/next.js/pull/15953 | b0d2a80a18645b5b7278c8e72829e76063b91945 | ff33e07afe875a29a32b4942564cbb379fa7935e | "2020-08-12T09:19:54Z" | javascript | "2020-08-18T16:36:40Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,088 | ["docs/api-reference/next.config.js/headers.md"] | Docs should mention headers overriding behavior | We should add a note to the headers documentation mentioning that if a header is already set successive ones with the same key will override the value | https://github.com/vercel/next.js/issues/16088 | https://github.com/vercel/next.js/pull/16089 | 2301331703c118927b8d09811802d9d081a392a0 | ceeb6c3fce983cf96c6a9d8844a5cded2eedd9a3 | "2020-08-11T18:14:01Z" | javascript | "2020-08-12T04:27:31Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,074 | ["docs/basic-features/data-fetching.md"] | Documentation needs to mention writing server-side code in GS(S)P props earlier | Lots of users miss that they can write server side code in `getStaticProps` and `getServerSideProps`.
We also see numerous issues about people trying to fetch API routes. We need to fix this in the documentation by making this one of the **first things** we have in the docs. | https://github.com/vercel/next.js/issues/16074 | https://github.com/vercel/next.js/pull/16198 | bb8374126f03e1cb27438b48deda44f1edc28655 | 512782ee2916bd03725af249f7718a0f643bc095 | "2020-08-11T13:11:13Z" | javascript | "2020-08-18T05:14:26Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,073 | ["docs/advanced-features/codemods.md", "docs/manifest.json", "packages/next-codemod/README.md"] | Add `@next/codemod` documentation | https://github.com/vercel/next.js/issues/16073 | https://github.com/vercel/next.js/pull/16067 | b8662d57665ac4e410aab6cd97a0f43c7de91d83 | 16345f631e380afa836c12e4918ad4ea68fb4e7d | "2020-08-11T12:57:52Z" | javascript | "2020-08-11T13:12:00Z" |
|
closed | vercel/next.js | https://github.com/vercel/next.js | 16,066 | ["docs/api-reference/create-next-app.md", "docs/getting-started.md", "docs/manifest.json"] | link is not working `you can review the create-next-app documentation` | # Bug report
## Describe the bug
On https://nextjs.org/docs page 'create-next-app documentation' on click link is not working
A clear and concise description of what the bug is.
## To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
1. Go to the setup section
2. Click on 'create-next-app documentation'
3. See error page redirect to 404
## Expected behavior
A clear and concise description of what you expected to happen.
## Screenshots
If applicable, add screenshots to help explain your problem.
[screenshot link](https://prnt.sc/txm0jc)
| https://github.com/vercel/next.js/issues/16066 | https://github.com/vercel/next.js/pull/16069 | 9e70b3de4405d91c7489e5af29a7f34708a86999 | b8662d57665ac4e410aab6cd97a0f43c7de91d83 | "2020-08-11T08:14:12Z" | javascript | "2020-08-11T10:08:43Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,028 | ["packages/next/next-server/lib/router/router.ts", "test/integration/client-shallow-routing/pages/[slug].js", "test/integration/client-shallow-routing/test/index.test.js"] | Navigating Between Dynamic Routes with Browser Back Button Breaks After Shallow Routing | # Bug report
## Describe the bug
I have a `/movie/[movieId]` page. It has `getServerSideProps` function for SEO purposes and fetches base movie info at server-side. In this page, there is an image list and when you click an image it opens a modal by adding a query string like `?view=/xXBnM6uSTk6qqCf0SRZKXcga9Ba.jpg`. To prevent unnecessary SSR, I use shallow routing like this:
```ts
const query = { view: "/xXBnM6uSTk6qqCf0SRZKXcga9Ba.jpg" };
router.push(
pathname: "/movie/[movieId]", query },
pathname: `/movie/${movie.id}`, query },
{ shallow: true },
);
```
and when user closes the modal, it routes to the movie page like this:
```ts
const query = { };
router.push(
pathname: "/movie/[movieId]", query },
pathname: `/movie/${movie.id}`, query },
{ shallow: true },
);
```
After that, user clicks another movie and navigates to its page (without shallow routing). Still no problem. But when we go back with browser's back button, `getServerSideProps` is not called, so we have the movie info from the previous movie (before clicking the back button).
At client-side, `router` has the right params etc, so I can check if the id of data from SSR and `router`'s current `movieId` are same or not and then fetch proper info at client-side. But it adds a little bit of overhead for more complex scenarios. Another solution is, when I disable shallow routing for closing the modal, there is no problem too but it ends up with unnecessary SSR.
I've seen similar issues but many of them were about `getInitialProps` and I'm not sure if they were a match for this issue.
Thanks for your hard work and thanks for this great framework!
## To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
1. Go to https://tmdb-explorer.vercel.app/movie/516486
2. Scroll a bit down, get to "Images" section.
3. Click one of the images. It will open a modal for viewing the selected image (with shallow routing).
4. Click close button at the top right of the screen. This will trigger a shallow routing too.
5. There is "Recommendations" section at the right (or at the bottom if you are on a small device). Click one of the movies. Wait for new page to load. (This is not shallow routing.)
6. Click back button of your browser.
7. Now we have the previous movie's info at the top of screen. Title, genres, overview, poster etc. Videos and Recommendations are proper. Because they are fetched at client-side with current `movieId` param. But "Images" list is wrong too. Because it depends on the fetched movie info.
Note: I use `swr` for client-side data fetching. So, if you unfocus and focus back to that browser tab, it will fetch the proper movie info at client-side. Of course you already know that, `swr` is one of your own packages, but if you unfocus/focus to follow these steps, the error may not occur. So, I wanted to point it out anyway.
Repository: https://github.com/onderonur/tmdb-explorer
Note: This repo needs an API key from TMDb API, so if you want I can try to create a much simpler repo with dummy data etc.
## Expected behavior
The last routing before we click the browser's back button is not shallow. So, I guess the back button should not trigger a shallow routing like here. Removing `shallow: true` solves this of course, but it may be hard to keep everything in place for much complex scenarios and it results in unnecessary SSR. Or if this is not a proper usage for shallow routing, please add its right usages etc to the docs. Docs are already great but if this is some expected behavior and there are recipes for this kind of scenarios, that would be absolutely helpful.
## System information
- OS: Windows 10
- Browser: Chrome Version 84.0.4147.105 (Official Build) (64-bit)
- Version of Next.js: 9.5.2
- Version of Node.js: 12.18.0
| https://github.com/vercel/next.js/issues/16028 | https://github.com/vercel/next.js/pull/16477 | 120b41ec8a304ebec7c34648bc0fd4ecc8e9a778 | 32ee65efa1a28f2c0a9b9199af58c2b8b4daed33 | "2020-08-09T23:05:12Z" | javascript | "2020-08-22T21:51:14Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 16,020 | ["test/integration/preview-fallback/pages/api/disable.js", "test/integration/preview-fallback/pages/api/enable.js", "test/integration/preview-fallback/pages/fallback/[post].js", "test/integration/preview-fallback/pages/index.js", "test/integration/preview-fallback/pages/no-fallback/[post].js", "test/integration/preview-fallback/test/index.test.js"] | Preview mode pages can be accessed publicly | ## Description
I have a post in draft, path for which is `/posts/id`. I want for rebuild it on request since data is new.
So I made it a preview url using preview mode feature. Now the url is `/api/preview?secret=token&slug=/posts/id`.
Now when I make this request this page is generated and stored on disk and any one with url `/posts/id` can visit this.
## To Reproduce
Steps to reproduce
This sandbox is not working because it says res.redirect is not a function (which we can ignore) but you can see code or check [repo](https://github.com/contactyash/nextjs-bug) also.
Go to [this sandbox](https://codesandbox.io/s/epic-babbage-03z7h?file=/pages/api/preview.js) and check
## Expected behavior
I am no expert but I think it should not write preview pages on disk, it should serve them from memory. when someone visit `/posts/id` it should return 404.
## System information
- OS [ Windows]
- Version of Next.js: [lates]
| https://github.com/vercel/next.js/issues/16020 | https://github.com/vercel/next.js/pull/16579 | 5fbe50c49ace43edc95f5ca91483bbe6a9e9501a | 990c1792d2af53e1c178ca675a3b40e11c6b159d | "2020-08-09T14:13:54Z" | javascript | "2020-08-26T11:07:32Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 15,979 | ["packages/next/package.json", "yarn.lock"] | Styles not getting passed to Amp Toolbox after Next update to 9.5 | # Bug report
Looks like styles may not be passed to apmtoolbox after updating to 9.5
## Describe the bug
Error thrown
TypeError: Cannot read property 'data' of undefined
This error happened while generating the page. Any console logs will be displayed in the terminal window.
Call Stack
ApplyCommonAttributes.applyToCustomStyles
file:///Users/ghankerson/code/mprnews/node_modules/@ampproject/toolbox-optimizer/lib/transformers/ApplyCommonAttributes.js (261:26)
ServerSideRendering.transform
file:///Users/ghankerson/code/mprnews/node_modules/@ampproject/toolbox-optimizer/lib/transformers/ServerSideRendering.js (142:27)
sequence
file:///Users/ghankerson/code/mprnews/node_modules/@ampproject/toolbox-optimizer/lib/DomTransformer.js (143:26)
process._tickCallback
internal/process/next_tick.js (68:7)
A clear and concise description of what the bug is.
## To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
See https://github.com/APMG/mprnews/blob/master/pages/amp/story/%5B...slug%5D.js
and
https://github.com/APMG/mprnews/blob/master/endpoints/AmpStory/AmpStory.js
and especially how we do amp styes: https://github.com/APMG/mprnews/blob/master/components/AmpContent/AmpContentHeader.js#L7
## Expected behavior
A rendered Amp page
## Screenshots
<img width="1187" alt="Screen Shot 2020-08-07 at 12 40 22 PM" src="https://user-images.githubusercontent.com/1874117/89672985-35b0ae00-d8ab-11ea-8a84-892b96de6f23.png">
## System information
- OS: MacOS, CentOs
- Browser Any (ssr)
- Version of Next.js
- Version of Node.js: v10.17.0 (also 12 on our servers)
## Additional context
This worked fined under 9.4.4 and other recent versions before 9.5 . Do I need to add something to my webpack config ?
| https://github.com/vercel/next.js/issues/15979 | https://github.com/vercel/next.js/pull/16043 | e08b633c3acf4f7f7f16d1eef1cbfa02753c1c7c | d6ad0d084308c6c11aadf87164f7b9f04fc8b017 | "2020-08-07T17:46:00Z" | javascript | "2020-08-10T16:06:00Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 15,948 | ["packages/next/build/webpack-config.ts", "packages/next/package.json", "test/integration/basic/pages/node-browser-polyfills.js", "test/integration/basic/test/index.test.js", "test/integration/production/pages/node-browser-polyfills.js", "test/integration/production/test/index.test.js", "yarn.lock"] | Polyfill common Node.js packages for webpack 5 | Webpack 5 stopped polyfilling Node.js packages, however, their usage is prolific throughout the npm ecosystem.
We should provide default polyfills for the most common usages:
- [x] Add `process` and `buffer`: https://github.com/vercel/next.js/pull/15499
- [x] [`path`](https://github.com/vercel/next.js/issues/13341#issuecomment-669937493) | https://github.com/vercel/next.js/issues/15948 | https://github.com/vercel/next.js/pull/16022 | 394e24073d0439f4e277ab2a194cd6cbaf3052e7 | 843d58425b65fc00cfc1b416128fdd3343a3b083 | "2020-08-06T17:33:53Z" | javascript | "2020-08-10T01:26:21Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 15,947 | ["packages/next/build/webpack/plugins/mini-css-extract-plugin/src/index.js", "packages/next/build/webpack/plugins/mini-css-extract-plugin/src/loader.js", "packages/react-dev-overlay/src/middleware.ts"] | Fix webpack 5 deprecation warnings | Next.js fully supports webpack 5, however, some of our plugins are using deprecated APIs.
Before we can consider webpack 5 stable, we should completely eliminate deprecated webpack 5 API usage.
Known warnings:
- [x] https://github.com/webpack-contrib/terser-webpack-plugin/pull/283
- [x] https://github.com/webpack-contrib/mini-css-extract-plugin (most warnings come from this plugin)
- [x] Next.js internal webpack plugins warnings
- [x] https://github.com/vercel/next.js/pull/15797
- [x] https://github.com/vercel/next.js/pull/15806 | https://github.com/vercel/next.js/issues/15947 | https://github.com/vercel/next.js/pull/16390 | 3e81809df44e5c36a52abc89b46bc53f18b83695 | 08ab3ac6c14db1d4c7dfd204e96e4f9cf7e83128 | "2020-08-06T17:32:22Z" | javascript | "2020-08-20T13:56:52Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 15,940 | ["packages/next/build/webpack/loaders/next-serverless-loader.ts", "test/integration/dynamic-optional-routing/pages/about.js", "test/integration/dynamic-optional-routing/server.js", "test/integration/dynamic-optional-routing/test/index.test.js"] | Serverless wrapper error | Trying this out, I got the following error on a non-dynamic route page:
```
defaultRouteRegex is not defined
```
_Originally posted by @kevva in https://github.com/vercel/next.js/pull/15914#issuecomment-669774302_ | https://github.com/vercel/next.js/issues/15940 | https://github.com/vercel/next.js/pull/15960 | db69e4747a1feb96b09c393385555b391a6006c7 | b1ef76df3133988bb86eb8b3ee174eb4ef937d6c | "2020-08-06T14:31:07Z" | javascript | "2020-08-07T07:01:34Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 15,928 | ["packages/next/cli/next-dev.ts", "test/integration/cli/test/index.test.js"] | Development server reports boot too early | # Bug report
## Describe the bug
```
❯ yarn next dev examples/z-experimental-refresh/
yarn run v1.22.4
$ node --trace-deprecation packages/next/dist/bin/next dev examples/z-experimental-refresh/
ready - started server on http://localhost:3000
Port 3000 is already in use.
Use `npm run dev -- -p <some other port>`.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
```
## To Reproduce
Run a Next.js app on a port that is already in use.
## Expected behavior
```
❯ yarn next dev examples/z-experimental-refresh/ ✘ 1
yarn run v1.22.4
$ node --trace-deprecation packages/next/dist/bin/next dev examples/z-experimental-refresh/
Port 3000 is already in use.
Use `npm run dev -- -p <some other port>`.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
``` | https://github.com/vercel/next.js/issues/15928 | https://github.com/vercel/next.js/pull/15929 | 817d558a6d6aafd2bbd5c37ddabd79c1d9cf2b91 | 2d42b8e0765050bc61cb2f6efadd1f5825a41f6c | "2020-08-06T03:48:46Z" | javascript | "2020-08-06T06:47:01Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 15,913 | ["package.json", "packages/next/types/index.d.ts", "pnpm-lock.yaml", "test/unit/infer-get-server-side-props-type.test.ts", "test/unit/infer-get-static-props.test.ts"] | Infer Types leading to `props: never` | ## Describe the bug
```ts
export const getServerSideProps = async ({ params }) => {
return {
props: { foo: "bar" }
}
};
export const Page = (props: InferGetServerSidePropsType<typeof getServerSideProps>) => { ... }
```
causes `props: never`
however the following works fine:
```ts
export const getServerSideProps = async ({ params }: GetServerSidePropsContext) => {
return {
props: { foo: "bar" }
}
};
export const Page = (props: InferGetServerSidePropsType<typeof getServerSideProps>) => { ... }
```
as does:
```ts
export const getServerSideProps = async (ctx) => {
const params = ctx.params;
return {
props: { foo: "bar" }
}
};
export const Page = (props: InferGetServerSidePropsType<typeof getServerSideProps>) => { ... }
```
| https://github.com/vercel/next.js/issues/15913 | https://github.com/vercel/next.js/pull/40635 | c2f48ea86d448c8be1982b46f184b1d2f2d6cd50 | 3943b20f554ba6558fa2f8262a302c14c42c134e | "2020-08-05T18:28:12Z" | javascript | "2022-09-20T22:25:01Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 15,906 | ["docs/api-reference/next.config.js/runtime-configuration.md"] | Runtime configuration docs incorrectly state that serverless build are not supported | # Bug report
According to https://nextjs.org/docs/api-reference/next.config.js/runtime-configuration, `Runtime configuration is not available when using the serverless target.`.
This is incorrect, it has been supported since `9.2.2` see: https://github.com/vercel/next.js/pull/10365
# Describe the bug
N/A
## To Reproduce
N/A
## Expected behavior
N/A
## Screenshots
## System information
N/A
## Additional context
N/A | https://github.com/vercel/next.js/issues/15906 | https://github.com/vercel/next.js/pull/15907 | 026785d5adc2e721d3a77254ed657c1bfb178b4e | abf6e74e8d79c096f2c035d4187fbae86c1b4ac0 | "2020-08-05T15:50:36Z" | javascript | "2020-08-05T16:11:01Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 15,904 | ["errors/export-all-in-page.md", "packages/next/build/babel/plugins/next-page-disallow-re-export-all-exports.ts", "packages/next/build/webpack/loaders/next-babel-loader.js", "test/integration/re-export-all-exports-from-page-disallowed/component/child.js", "test/integration/re-export-all-exports-from-page-disallowed/component/test.js", "test/integration/re-export-all-exports-from-page-disallowed/pages/about.js", "test/integration/re-export-all-exports-from-page-disallowed/pages/contact.js", "test/integration/re-export-all-exports-from-page-disallowed/pages/index.js", "test/integration/re-export-all-exports-from-page-disallowed/test/index.test.js", "test/integration/re-export-all-exports-from-page-disallowed/world.txt"] | getServerSideProps not called when exported for multiple pages. | # Bug report
## Describe the bug
When a common react component is exported from multiple pages, `getServerSideProps` is not called except when revisiting the page that the component was initially visited.
## To Reproduce
Repository Structure
```
pages
- index.ts
- home.ts
views
Home.tsx
```
index.ts __AND__ home.ts
```
export * from '../views/Home';
export { default } from '../views/Home';
```
Home.tsx
```
import { NextPage, GetServerSidePropsContext, GetServerSidePropsResult } from 'next';
import Link from 'next/link';
interface HomeCubeProps {
name: string;
description: string;
}
export interface HomeProps {
words: HomeCubeProps[];
}
const Home: NextPage<HomeProps> = (props: HomeProps) => {
return (
<div>
<Link href="/">
<a>Root</a>
</Link>
<Link href="/home">
<a>Home</a>
</Link>
User Home.
<div>
{props.words.map((cube) => {
return <div key={cube.name}>{cube.description}</div>;
})}
</div>
</div>
);
};
export async function getServerSideProps(
context: GetServerSidePropsContext
): Promise<GetServerSidePropsResult<HomeProps>> {
return {
props: {
words: [
{
name: 'big cube',
description: 'These are words'
},
{
name: 'little cube',
description: 'These are more words'
}
]
}
};
}
export default Home;
```
1. Start Next.js (Dev or Prod)
2. Navigate to `localhost:3000` or `localhost:3000/home`
3. Click root if you're at `/home`, click home if you're at `/`.
4. Error because getServerSideProps is not providing props.
## Expected behavior
I expected getServerSideProps to be called for all pages that this component is exported.
## System information
- OS: Windows
- Browser (if applies) Chrome and Edge (Chromium)
- Version of Next.js: 9.4.4
- Version of Node.js: 12.18.3
| https://github.com/vercel/next.js/issues/15904 | https://github.com/vercel/next.js/pull/14325 | 3c04111c9c48065890fcf08cdc4890093ef9d996 | 0fd1958ae465e6b22c77ad786601a8ba05ea36a1 | "2020-08-05T14:40:08Z" | javascript | "2020-08-05T20:21:40Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 15,879 | ["packages/next/build/webpack/loaders/next-serverless-loader.ts", "test/integration/dynamic-optional-routing/pages/[[...optionalName]].js", "test/integration/dynamic-optional-routing/pages/nested/[[...optionalName]].js", "test/integration/dynamic-optional-routing/test/index.test.js"] | Vercel deployments include query string in `asPath` | 
Reproduction:
https://github.com/MJHLS/slug-test
https://slug-test.vercel.app/yeet | https://github.com/vercel/next.js/issues/15879 | https://github.com/vercel/next.js/pull/15914 | 405e42e41ef5df28ef69c035c9ae611139d8ec21 | 7d7a8fc3000bb830a24225bc362a73a65bda3936 | "2020-08-04T19:36:19Z" | javascript | "2020-08-05T19:29:38Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 15,877 | ["examples/with-cxs/pages/_document.js", "examples/with-glamor/pages/_document.js", "examples/with-goober/pages/_document.js", "examples/with-react-native-web/pages/_document.js", "examples/with-tailwindcss-emotion/pages/_document.js", "examples/with-typestyle/pages/_document.js"] | Update examples for TypeScript compat & renderPage() call | Examples currently don't always await `renderPage()` even though we say it can return a Promise. | https://github.com/vercel/next.js/issues/15877 | https://github.com/vercel/next.js/pull/15528 | 1968f7f552989e05c636fc834b365e46c99afcfe | fcc4d8cd50eb2170fda9fbac6f9853799ceb9959 | "2020-08-04T17:27:22Z" | javascript | "2020-08-04T18:46:40Z" |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.