status
stringclasses 1
value | repo_name
stringclasses 13
values | repo_url
stringclasses 13
values | issue_id
int64 1
104k
| updated_files
stringlengths 11
1.76k
| title
stringlengths 4
369
| body
stringlengths 0
254k
⌀ | issue_url
stringlengths 38
55
| pull_url
stringlengths 38
53
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
unknown | language
stringclasses 5
values | commit_datetime
unknown |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed | vercel/next.js | https://github.com/vercel/next.js | 19,703 | ["docs/api-reference/next.config.js/headers.md", "docs/api-reference/next.config.js/redirects.md", "docs/api-reference/next.config.js/rewrites.md"] | [i18n + redirects] redirect with locale: false returning 404 for source | # Bug report
## Describe the bug
Redirect with `locale: false` returning 404 for `source`.
## To Reproduce
1. Create i18n config like this `i18n: { locales: ["en", "de", "fr"], defaultLocale: "en" }`
2. Create redirects config like this `async redirects() { return [{ source: "/test", destination: "/", locale: false, permanent: true }] }`
3. Then try to get `/test` page and u will see 404 error.
## Expected behavior
Redirect with `locale: false` should correctly redirect to `destination`
## System information
- OS: Windows, Linux
- Browser: Chrome
- Version of Next.js: 10.0.3
- Version of Node.js: 12.16.1
- Deployment: dev, next start, Vercel | https://github.com/vercel/next.js/issues/19703 | https://github.com/vercel/next.js/pull/19765 | 42385f48dbd9bf6b95c0a01614ce422f3db5f81f | e6c1aa6483ecc98aaaa42cce50ee94ef274aa883 | "2020-12-01T09:23:29Z" | javascript | "2020-12-04T13:32:50Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,612 | ["docs/basic-features/image-optimization.md", "errors/manifest.json", "errors/next-image-missing-loader-width.md", "errors/next-image-missing-loader.md", "packages/next/client/image.tsx", "packages/next/server/image-config.ts", "test/integration/export-image-loader/pages/index.js", "test/integration/export-image-loader/test/index.test.js", "test/integration/image-optimizer/test/index.test.js"] | When marking Next Images as Unoptimized, "next export" still fails | <!-- NOTE: This template is not optional. If you remove it or leave out sections there is a high likelihood it will be moved to the GitHub Discussions "Help" section -->
# Bug report
## Describe the bug
I am building a static site with `next build & next export`, upon marking Next's Image's component with `unoptimized={true}` I would have expected the `next export` to succeed, yet it still fails.
## To Reproduce
then issue the `next build & next export` command.
1. Use Next's Image component with `unoptimized={true}`
2. Then issue the `next build & next export`
3. See the error
## Expected behavior
Since we are not optimizing the images, `next export` should succeed, without any third-party loaders.
## Screenshots
## System information
- OS: macOS 11.0.1
- Version of Next.js: 10.0.3
- Version of Node.js: [e.g. 12.0.0]
- Deployment: next build & next export, for a static server
| https://github.com/vercel/next.js/issues/19612 | https://github.com/vercel/next.js/pull/26998 | 1c2b171322ae257c6e3796600857b73b8d62ce09 | 1a8ad1408928a2fbb8b9e5670c0b7251a503cb8b | "2020-11-27T23:47:58Z" | javascript | "2021-07-08T19:35:19Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,588 | ["packages/create-next-app/create-app.ts"] | Improve error message when using create-next-app | <!-- NOTE: This template is not optional. If you remove it or leave out sections there is a high likelihood it will be moved to the GitHub Discussions "Help" section -->
# Bug report
## Describe the bug
Running `npx create-next-app --example with-mongodb with-mongodb` produces the error:
"Could not locate an example named "with-mongodb". Please check your spelling and try again."
Even though the example is here:
https://github.com/vercel/next.js/tree/canary/examples/with-mongodb
## To Reproduce
^
## Expected behavior
Create example
## Screenshots
If applicable, add screenshots to help explain your problem.
## System information
- OS: macOS
- Version of Next.js: npx
- Version of Node.js: v12.18.3
| https://github.com/vercel/next.js/issues/19588 | https://github.com/vercel/next.js/pull/26980 | 1dd19f57760fc32415546e593469e0659dfd8426 | caca389cc1b0f5df43128750097844a5dcadf320 | "2020-11-27T09:23:10Z" | javascript | "2021-07-07T11:12:58Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,571 | ["examples/with-firebase/firebase/clientApp.js"] | missing import 'firebase/performance' in with-firebase example | <!-- NOTE: This template is not optional. If you remove it or leave out sections there is a high likelihood it will be moved to the GitHub Discussions "Help" section -->
# Bug report
## Describe the bug
When setting up the [with-firebase](https://github.com/vercel/next.js/blob/canary/examples/with-firebase) example, the project will crash because the import : `import 'firebase/performance'` does not exist.
Underlying error:
```
next-dev.js?53bc:89 Error was not caught TypeError: firebase_app__WEBPACK_IMPORTED_MODULE_0__.default.performance is not a function
at Module.eval (VM5719 clientApp.tsx:33)
at eval (VM5719 clientApp.tsx:94)
at Module../firebase/clientApp.tsx (_app.js?ts=1606414488750:36)
at __webpack_require__ (webpack.js?ts=1606414488750:873)
at fn (webpack.js?ts=1606414488750:151)
at Module.eval (VM5717 AppContext.tsx:10)
at eval (VM5717 AppContext.tsx:244)
at Module../components/AppContext.tsx (_app.js?ts=1606414488750:24)
at __webpack_require__ (webpack.js?ts=1606414488750:873)
at fn (webpack.js?ts=1606414488750:151)
at Module.eval (_app.tsx:11)
at eval (_app.tsx?7216:22)
at Module../pages/_app.tsx (_app.js?ts=1606414488750:1546)
at __webpack_require__ (webpack.js?ts=1606414488750:873)
at fn (webpack.js?ts=1606414488750:151)
at eval (next-client-pages-loader.js?7ae7:5)
at eval (route-loader.ts?8a46:274)
```
## To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
Simply clone and run the example
| https://github.com/vercel/next.js/issues/19571 | https://github.com/vercel/next.js/pull/19572 | 9dd5ff2baa716a6b12f681ff09559a3c8dd7b5cd | 9f07d2dcfb9f59a1446d19b94ced64ea4cb55d4d | "2020-11-26T18:14:07Z" | javascript | "2020-11-26T23:06:05Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,527 | ["errors/conflicting-ssg-paths.md", "packages/next/build/index.ts", "packages/next/build/utils.ts", "test/integration/conflicting-ssg-paths/test/index.test.js"] | Build fails with catch all and predefined route conflict | # Bug report
## Describe the bug
Creating this bug for visibility of this bug #12717. I get the same issue on 10.0.3.
When having a predefined route and catch all where getStaticPaths returns the same path, `next build` fails
## To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
1. Go to https://codesandbox.io/s/catch-all-conflict-57hub?file=/pages/%5B...slug%5D.js
2. Go to the about page in the app browser
3. See that it says 'About us'
4. Open a new terminal and run 'yarn build'
5. See the error.
6. Go the file '[...slug].js' and remove the "About" entry in the getStaticPaths function.
7. Run yarn build again
## Expected behavior
Given these rules https://nextjs.org/docs/routing/dynamic-routes#caveats. I would expect the build to pass with /about using the predefined route and /test using the catch all route.
| https://github.com/vercel/next.js/issues/19527 | https://github.com/vercel/next.js/pull/20918 | e0a44d98ef89db82bb0e0ffe911aff1862ed82fa | 9caca2784c972a1bf92df1db62e5a58deee97ecf | "2020-11-25T15:13:54Z" | javascript | "2021-01-11T20:50:17Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,503 | ["docs/routing/dynamic-routes.md"] | Remove mentions of the Next.js site repo from docs | https://github.com/vercel/next.js/issues/19503 | https://github.com/vercel/next.js/pull/19504 | 0ed815285857f2210271f02635b3b713f051b28d | 86a0c7b0f7133362b5a5358428fe8ca334fe394e | "2020-11-24T23:42:25Z" | javascript | "2020-11-25T01:21:51Z" |
|
closed | vercel/next.js | https://github.com/vercel/next.js | 19,486 | ["docs/advanced-features/i18n-routing.md", "docs/advanced-features/static-html-export.md"] | [Docs] Mention that i18n is not supported by next export. | Currently mentioned in https://nextjs.org/docs/advanced-features/i18n-routing at the end of the page. But because it's a long page it's not enough. It should be mentioned in https://nextjs.org/docs/advanced-features/static-html-export too | https://github.com/vercel/next.js/issues/19486 | https://github.com/vercel/next.js/pull/19491 | a5917317f026af4d6b5d3a85c7c8f7d7e5ed2d38 | af5b8ceb7a85af7f145641629485fd30a0486191 | "2020-11-24T17:15:08Z" | javascript | "2020-11-24T19:23:39Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,481 | ["docs/basic-features/data-fetching.md"] | [Docs] Wrong type on getServerSideProps query | # Bug report
## Describe the bug
On the [next docs for getServerSideProps](https://nextjs.org/docs/basic-features/data-fetching#getserversideprops-server-side-rendering) the `query` key from `context` is defined as of type *string*. As far as I can tell this is incorrect, based on [this definition](https://github.com/jeffreywescott/DefinitelyTyped/blob/59e1039b5696ab9be1a4fd1e068b126587eb7d9f/types/node/index.d.ts#L1095) the correct type definition seems to be
```ts
[key: string]: string | string[] | undefined;
```
## To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
1. Create a new Next.js app `npx create-next-app .`
2. Create a new page with **getServerSideProps** and log `context.query`
3. Visit the page you created with query params ex: `localhost:3000/page?test=hello`
4. Observe that context.query is an object and not a string
## Expected behavior
Docs to have the correct type
## Screenshots
If applicable, add screenshots to help explain your problem.
## System information (not applicable)
- OS: [e.g. macOS, Windows]
- Browser (if applies) [e.g. chrome, safari]
- Version of Next.js: [e.g. 10.0.1]
- Version of Node.js: [e.g. 12.0.0]
- Deployment: [e.g. next start, next export, Vercel, other platform]
## Additional context
I'm new to TS so I hope I haven't missed something obvious
| https://github.com/vercel/next.js/issues/19481 | https://github.com/vercel/next.js/pull/20327 | 87c97fd3e77f9d1137e16258d5826075eeb2fadd | 0d98f370aaa6873e40d301b73948b48d58219ce1 | "2020-11-24T14:27:51Z" | javascript | "2021-01-04T21:58:56Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,448 | ["packages/next/build/babel/preset.ts"] | [email protected] breaks builds that rely on @babel/runtime being resolved relatively. | <!-- NOTE: This template is not optional. If you remove it or leave out sections there is a high likelihood it will be moved to the GitHub Discussions "Help" section -->
# Bug report
## Describe the bug
Next has changed the way it imports `@babel/runtime`
**[email protected]**
```js
var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefault");
```
**[email protected]**
```js
var _interopRequireDefault = require("/home/USER/PROJECT/node_modules/@babel/runtime/helpers/interopRequireDefault");
```
This has broken our deployments, as we build on one image and deploy on a different one, which would require a different absolute path.
We now get MODULE_NOT_FOUND errors.
## To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
1. This happens by default on all Next.js builds
## Expected behavior
`@babel/runtime` is required with a relative path, so we don't have to worry about external environment.
## Screenshots
If applicable, add screenshots to help explain your problem.
## System information
- OS: Ubuntu (probably all OSes)
- Browser (if applies) [e.g. chrome, safari]
- Version of Next.js: 10.0.2
- Version of Node.js: 12
## Additional context
| https://github.com/vercel/next.js/issues/19448 | https://github.com/vercel/next.js/pull/19538 | b3a631305d5b350ed1732fcc7c380a35e149a08b | 4e3eb733c83f69314d12c85961f42be77e42a209 | "2020-11-23T17:06:36Z" | javascript | "2021-01-11T14:21:58Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,437 | ["packages/next/next-server/lib/router/router.ts", "test/integration/basepath/test/index.test.js"] | Configuring `basePath` and using query parameters breaks routing in frontend. | # Bug report
## Describe the bug
When configuring the `basePath` in the `next.config.js` and then accessing the index page with a query parameter, the next frontend rewrites the URL in a broken way. The configured `basePath` is appended a second time, so that we are on `/basePath/basePath?foo=bar`, which is not actually a working page.
## To Reproduce
I created a repository here: https://github.com/Lynbarry/next-basepath-bug
All I did in there was use `npx create-next-app` and add a `next.config.js` with the following content:
```
module.exports = {
basePath: "/basePath",
};
```
To reproduce the behavior:
1. Run `npm run dev`
2. Go to `localhost:3000/basePath?foo=bar`
3. Notice that the URL changes to `localhost:3000/basePath/basePath?foo=bar` in the frontend
4. Reload the page to get a 404
## Expected behavior
Don't add the basePath a second time. The URL should stay `localhost:3000/basePath?foo=bar`
## System information
- OS: macOS
- Browser: chrome, firefox (probably any browser)
- Version of Next.js: 10.0.2
- Version of Node.js: v12.13.1 | https://github.com/vercel/next.js/issues/19437 | https://github.com/vercel/next.js/pull/20596 | 949657675e9691934f0c8e9d08ae813a1aab5e86 | 97e9d54f2edb4435ef9b803898d69b97817306fa | "2020-11-23T10:51:16Z" | javascript | "2020-12-30T05:37:26Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,428 | ["errors/incompatible-href-as.md", "errors/invalid-relative-url-external-as.md", "packages/next/next-server/lib/router/router.ts", "packages/next/next-server/lib/router/utils/parse-relative-url.ts", "test/integration/build-output/test/index.test.js", "test/integration/invalid-href/pages/invalid-relative.js", "test/integration/invalid-href/test/index.test.js"] | Invariant: invalid relative URL - Next.js i18n + Link | <!-- NOTE: This template is not optional. If you remove it or leave out sections there is a high likelihood it will be moved to the GitHub Discussions "Help" section -->
# Bug report
## Describe the bug
I'm building an app with Next.js using react-bootstrap and recently introduced Next.js i18n for localization. I have 3 languages available.
When I wrap the `Nav.Link` component (react-bootstrap) with `Link` (from `next/link`), I'm getting invariant: invalid relative URL.
I believe this might be related to this recent PR:
https://github.com/vercel/next.js/pull/16650/files
## To Reproduce
```
<Navbar.Collapse id="basic-navbar-nav">
<Nav className="ml-auto" onSelect={setActiveLanguage}>
==== START
<Link href="/stores" passHref>
<Nav.Link as="a" className="mr-4">
{t(namespace + 'header.menu_label_stores')}
</Nav.Link>
</Link>
===== END
<Link href={`mailto:${R.consts.CONTACT_US_EMAIL}`} passHref>
<Nav.Link as="a" active={false} className="mr-5">
{t(namespace + 'header.menu_label_contact_us')}
</Nav.Link>
</Link>
<NavDropdown title={t(Utils.translations.getLanguageKey(lang))} id="basic-nav-dropdown">
{availableLanguages}
</NavDropdown>
</Nav>
</Navbar.Collapse>
```
## Expected behavior
I'm expecting to navigate to the `/store` page (including the i18n path) without any errors appearing.
## Screenshots
If applicable, add screenshots to help explain your problem.
## System information
- OS: MacOS
- Browser (if applies) Chrome
- Version of Next.js: 10.0.2
- Version of Node.js: 14.7.0
- Deployment: next dev
| https://github.com/vercel/next.js/issues/19428 | https://github.com/vercel/next.js/pull/20658 | fad325609115108575ab52daee2757dc3b44ceb6 | 8b803d79a95322885fd89a187a979eee564caebd | "2020-11-22T23:55:43Z" | javascript | "2021-01-01T18:14:42Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,426 | ["docs/api-reference/data-fetching/getInitialProps.md"] | getInitialProps runs server side on page transitions | # Bug report
## Describe the bug
When putting `getInitialProps` in `_app.js`, and client-side-transitioning to a page with `getServerSideProps`, the code in `getInitialProps` runs server-side.
This conflicts with the [documentation](https://nextjs.org/docs/api-reference/data-fetching/getInitialProps):
> For the initial page load, getInitialProps will run on the server only. getInitialProps will then run on the client when navigating to a different route via the next/link component or by using next/router.
## Expected behavior
`getInitialProps` should only run client-side when doing a client-side page transition. Or, the documentation should be updated to account for this exception.
(We discovered this because we assumed we could use the documented behavior of `getInitialProps` to ensure something only runs on server side app load. See corresponding discussion: https://github.com/vercel/next.js/discussions/19425 )
## System information
- OS: macOS
- Version of Next.js: 9.5.5
- Version of Node.js: 12.16.3
| https://github.com/vercel/next.js/issues/19426 | https://github.com/vercel/next.js/pull/19506 | 86a0c7b0f7133362b5a5358428fe8ca334fe394e | f4bf8a4696af6f9a0b64636205356ba207fb1ea9 | "2020-11-22T22:23:39Z" | javascript | "2020-11-25T11:23:04Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,420 | ["docs/basic-features/environment-variables.md"] | Error: process is not defined on destructuring assignment from process.env | <!-- NOTE: This template is not optional. If you remove it or leave out sections there is a high likelihood it will be moved to the GitHub Discussions "Help" section -->
# Bug report
## Describe the bug
This code will make error
```
export const { BACKEND_URL, API_URL, CDN_URL, NEXT_PUBLIC_ROOT_URL } = process.env;
```
This code works as expected:
```ts
export const BACKEND_URL = process.env.BACKEND_URL;
export const API_URL = process.env.API_URL;
export const CDN_URL = process.env.CDN_URL;
export const NEXT_PUBLIC_ROOT_URL = process.env.NEXT_PUBLIC_ROOT_URL;
```
## Expected behavior
I use tslint/eslint and I have automatically formatted code when constant name is equal from name of nested property of object.
After next.js upgrade to webpack 5 this error occurred on client-side.
## Screenshots
If applicable, add screenshots to help explain your problem.
## System information
- OS: MacOs Catalina
- Browser (if applies) any
- Version of Next.js: latest (10.0.3-canary.0)
- Version of Node.js: v12.12.0
- Deployment: tested in dev mode
My question is - why this error occurred?
| https://github.com/vercel/next.js/issues/19420 | https://github.com/vercel/next.js/pull/20869 | 5e701daab9ed4fe0cfd7ae8aeacd7e3d9f314a04 | 4d282f929f4475299aba0b496ba99b6398fc9b1a | "2020-11-22T18:45:18Z" | javascript | "2021-01-11T10:13:24Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,405 | ["packages/next/export/worker.ts", "packages/next/lib/load-custom-routes.ts", "packages/next/next-server/server/config.ts", "test/integration/i18n-support-base-path/next.config.js", "test/integration/i18n-support/next.config.js", "test/integration/i18n-support/test/shared.js"] | [i18n + redirects] unnecessary redirect for index page | # Bug report
## Describe the bug
Unnecessary redirect for index page.
i18n config: `{ locales: ['en', 'fr', 'zh'], defaultLocale: 'en' }`
redirects config: `{ source: '/first-page', destination: '/', permanent: true }`
In this case we have three redirects instead of two: `/first-page` -> `/en/` -> `/en`, `/fr/first-page` -> `/fr/` -> `/fr`
## To Reproduce
Described in the `Describe the bug` section.
## Expected behavior
For index page we should redirect only once, from `/first-page` -> `/en`
## System information
- OS: Windows
- Browser: Chrome
- Version of Next.js: 10.0.3-canary.0
- Version of Node.js: 12.16.1
- Deployment: dev, next start, Vercel
| https://github.com/vercel/next.js/issues/19405 | https://github.com/vercel/next.js/pull/20397 | eeb2838511a89b0176d68891b578d04f81c0de9f | 118588b027ec33af0935fec481d6155fa593d257 | "2020-11-21T20:23:35Z" | javascript | "2020-12-22T17:12:53Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,399 | ["packages/next/client/index.tsx", "test/integration/hydrate-then-render/pages/_app.js", "test/integration/hydrate-then-render/pages/index.js", "test/integration/hydrate-then-render/pages/other.js", "test/integration/hydrate-then-render/test/index.test.js"] | Using Preact, some components get rendered multiple times as duplicates | <!-- NOTE: This template is not optional. If you remove it or leave out sections there is a high likelihood it will be moved to the GitHub Discussions "Help" section -->
# Bug report
## Describe the bug
When using Preact (via `next-plugin-preact`), some components get rendered multiple times as duplicates.
Unfortunately, I still haven't found the root cause. The only information I have right now is that the issue doesn't occur if I use React instead.
## To Reproduce
Please see the following video (it's only about 1 minute) to see how to reproduce it.
https://streamable.com/nbkpuz
For references:
1. This is the site that is using preact in the video:
- https://jackyef-git-using-preact.jackyef.vercel.app/posts/6-things-i-learned-during-my-remote-job-search
- code: https://github.com/jackyef/my-site/pull/40
2. This is the site that is using react:
- https://jackyef-git-using-react.jackyef.vercel.app/posts/6-things-i-learned-during-my-remote-job-search
- code: https://github.com/jackyef/my-site/pull/39
## Expected behavior
Using Preact should have the same result with using React.
## System information
- OS: Windows
- Browser: Chrome
- Version of Next.js: 10.0.2
- Version of Node.js: 12.18.0
- Deployment: Vercel
## Additional context
Add any other context about the problem here.
The duplicated component was rendered lazily using a combination of IntersectionObserver and `next/dynamic`. The code for the component can be seen [here](https://github.com/jackyef/my-site/blob/master/src/components/Webmention/LazyWebmentionWidget.tsx) and it is rendered [here](https://github.com/jackyef/my-site/blob/master/src/components/Blog/Post/Post.tsx#L63). The component basically fetches data from an API using `react-query` and then renders some UI. | https://github.com/vercel/next.js/issues/19399 | https://github.com/vercel/next.js/pull/19442 | f637c8a2ccdb9a3ac695a0c303bd34f14655633d | c96c13a71b61b93c87ed34f11ae7d37ede44eaec | "2020-11-21T18:07:58Z" | javascript | "2020-11-23T15:04:12Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,369 | ["test/integration/dist-dir/test/index.test.js"] | dist-dir test suite doesn't properly clean up artifacts from previous run | We should ensure this test can be run multiple times without manually cleaning up artifacts | https://github.com/vercel/next.js/issues/19369 | https://github.com/vercel/next.js/pull/19370 | b28b8b29138793279a2a67e337683ed101298e71 | 53a4458baef5854ad926ec94288d220fa4dd16c8 | "2020-11-20T20:17:52Z" | javascript | "2020-11-21T17:19:19Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,313 | ["examples/auth0/.env.local.example", "examples/auth0/README.md", "examples/auth0/lib/auth0.js", "examples/auth0/package.json"] | Auth0 example doesn't work with trailingSlash set to true | <!-- NOTE: This template is not optional. If you remove it or leave out sections there is a high likelihood it will be moved to the GitHub Discussions "Help" section -->
# Bug report
## Describe the bug
When you try to login with the auth0 example app and trailingSlash is set to true you will get an error "Error: Invalid request, an initial state could not be found". This is the error i get in the auth0 example app at least. In my real app i get a "state mismatch" error but i can't reproduce that in the example app.
I have tried to set the callback url with both a trailing slash and without and have both as callback urls in my app on auth0.
## To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
1. Run the auth0 example app with `trailingSlash: true`
2. Login
3. Get the error
## Expected behavior
It should work :)
## System information
- OS: Windows
- Browser (if applies) [e.g. chrome, safari]
- Version of Next.js: 10.0.1
- Version of Node.js: 14.15
- Deployment: dev on local machine
| https://github.com/vercel/next.js/issues/19313 | https://github.com/vercel/next.js/pull/27010 | 841ea04d20a4d65308d039e519f0dd794a58bd0c | 5e6b92059fa9bac0f8a54bd4a1cc02ce6effb597 | "2020-11-19T13:45:51Z" | javascript | "2021-07-08T15:54:21Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,300 | ["packages/next/build/utils.ts", "packages/next/build/webpack-config.ts", "packages/next/client/index.tsx", "packages/next/client/page-loader.ts", "packages/next/client/route-loader.ts", "packages/next/export/index.ts", "packages/next/server/hot-middleware.ts"] | v10.0.2 causing a type error | <!-- NOTE: This template is not optional. If you remove it or leave out sections there is a high likelihood it will be moved to the GitHub Discussions "Help" section -->
# Bug report
## Describe the bug
I'm getting the following issue when deploying 10.0.2 to vercel (the same code is deploying perfectly fine with v10.0.1):
```
22:09:54.840 | Failed to compile.
-- | --
22:09:54.840 | ./node_modules/next/dist/client/route-loader.d.ts:2:13
22:09:54.840 | Type error: '=' expected.
22:09:54.840 | [0m [90m 1 \| [39m[36mimport[39m { [33mComponentType[39m } from [32m'react'[39m[33m;[39m[0m
22:09:54.841 | [0m[31m[1m>[22m[39m[90m 2 \| [39m[36mimport[39m type { [33mClientBuildManifest[39m } from [32m'../build/webpack/plugins/build-manifest-plugin'[39m[33m;[39m[0m
22:09:54.841 | [0m [90m \| [39m [31m[1m^[22m[39m[0m
22:09:54.841 | [0m [90m 3 \| [39mdeclare global {[0m
22:09:54.841 | [0m [90m 4 \| [39m interface [33mWindow[39m {[0m
22:09:54.841 | [0m [90m 5 \| [39m __BUILD_MANIFEST[33m?[39m[33m:[39m [33mClientBuildManifest[39m[33m;[39m[0m
22:09:54.864 | error Command failed with exit code 1.
22:09:54.864 | info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
22:09:54.873 | Error: Command "yarn run build" exited with 1
22:09:56.951 | Done with "package.json"
```
## Expected behavior
I expect it to be a patch release, and not break :)
| https://github.com/vercel/next.js/issues/19300 | https://github.com/vercel/next.js/pull/20379 | aacb529f4863f5fd52b21e6b0c70f4c6cf1d3d08 | c98db81bf45c220db4dcf08cb4f05515e51c0ae0 | "2020-11-19T06:19:43Z" | javascript | "2020-12-28T22:04:51Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,294 | ["packages/next/next-server/lib/router/router.ts", "test/integration/basepath/test/index.test.js"] | Routing with queries in root url is not working with basePath setting | <!-- NOTE: This template is not optional. If you remove it or leave out sections there is a high likelihood it will be moved to the GitHub Discussions "Help" section -->
# Bug report
## Describe the bug
To add new query-strings to current URL, I used `Router.push` with query string. However, when called routing method like `push` or `replace` in root URL, error is raised.
```
The provided as value (/) is incompatible with the href value (/[fooId]).
```
When I disable the basePath configuration, the error does not appear. Also, no errors found in other urls.
## To Reproduce
https://github.com/titicacadev/next-routing-bug-reproduction
1. Go to http://localhost:3000/foo
2. Click buttons.
## Expected behavior
URL should become `/foo?foo=bar`
## System information
- OS: macOS
- Browser (if applies) chrome
- Version of Next.js: 10.0.1
- Version of Node.js: 12.18.3
- Deployment: [e.g. next start, next export, Vercel, other platform] | https://github.com/vercel/next.js/issues/19294 | https://github.com/vercel/next.js/pull/20596 | 949657675e9691934f0c8e9d08ae813a1aab5e86 | 97e9d54f2edb4435ef9b803898d69b97817306fa | "2020-11-19T04:26:59Z" | javascript | "2020-12-30T05:37:26Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,245 | ["docs/api-reference/next/link.md"] | Don't recommend the usage of next/link without `href` on docs | This section in docs: https://nextjs.org/docs/api-reference/next/link#using-a-component-that-supports-onclick shows how `Link` can be used without `href`, however adding links without `href` is not recommended at all. Removing that section should be enough as use cases using a tag other than `a` are already covered in other sections of the same page. | https://github.com/vercel/next.js/issues/19245 | https://github.com/vercel/next.js/pull/19247 | 0f5db2a583213f71333fc85695213c8e7d107039 | b955268dbb911bd8e8504ce847a434ca344908ca | "2020-11-17T17:36:26Z" | javascript | "2020-11-18T12:39:35Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,243 | ["packages/next/next-server/lib/router/router.ts", "test/integration/getserversideprops/test/index.test.js", "test/integration/i18n-support-index-rewrite/test/index.test.js", "test/integration/i18n-support/test/shared.js"] | SSG_DATA_NOT_FOUND_ERROR shouldn't be unhandled | When a user returns `notFound: true`, we need to make the `SSG_DATA_NOT_FOUND_ERROR` error silently handled since it's an intentional control flow. | https://github.com/vercel/next.js/issues/19243 | https://github.com/vercel/next.js/pull/20594 | 8bab640ef63fcdf690f8431ea20351ebc5cb4864 | 949657675e9691934f0c8e9d08ae813a1aab5e86 | "2020-11-17T16:57:33Z" | javascript | "2020-12-30T05:17:10Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,242 | ["packages/next/package.json", "test/integration/client-navigation/lib/colored-blue.js", "test/integration/client-navigation/pages/styled-jsx-external.js", "test/integration/client-navigation/test/index.test.js", "test/integration/client-navigation/test/rendering.js", "yarn.lock"] | Upgrade `styled-jsx` to fix React 17 compat | https://github.com/vercel/next.js/issues/19242 | https://github.com/vercel/next.js/pull/19241 | c283442ef09364de4891ed8da888544c39ee26ce | ab0e2744eeb5082ced09330bf27e8f7ff1393519 | "2020-11-17T16:34:53Z" | javascript | "2020-11-17T16:53:35Z" |
|
closed | vercel/next.js | https://github.com/vercel/next.js | 19,238 | ["packages/next/next-server/lib/router/router.ts", "test/integration/build-output/test/index.test.js", "test/integration/getserversideprops/pages/index.js", "test/integration/getserversideprops/pages/slow/index.js", "test/integration/getserversideprops/test/index.test.js"] | Data fetching could be deduped if already in-flight | This was for a `getServerSideProps` route:
We could dedupe this call as an optimization. | https://github.com/vercel/next.js/issues/19238 | https://github.com/vercel/next.js/pull/22781 | afc8ce4d0dd324135ea3f5b4d65ecd95fb455299 | 2d207fb11d16c02d6d7f419f4001a63dcbe7c944 | "2020-11-17T15:59:02Z" | javascript | "2021-03-05T17:16:02Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,230 | ["packages/next/server/dev/hot-reloader.ts", "packages/next/types/webpack.d.ts", "test/development/basic/gssp-ssr-change-reloading/lib/data.json", "test/development/basic/gssp-ssr-change-reloading/pages/another/index.js", "test/development/basic/gssp-ssr-change-reloading/pages/gsp-blog/[post].js", "test/development/basic/gssp-ssr-change-reloading/pages/gssp-blog/[post].js", "test/development/basic/gssp-ssr-change-reloading/pages/index.js", "test/development/basic/gssp-ssr-change-reloading/test/index.test.ts", "test/integration/gssp-ssr-change-reloading/test/index.test.js"] | Fast Refresh not working with getStaticProps | <!-- NOTE: This template is not optional. If you remove it or leave out sections there is a high likelihood it will be moved to the GitHub Discussions "Help" section -->
# Bug report
## Describe the bug
Working with Next.js 10.0. According to the release docs, any changes made in the getStaticProps function will automatically reflect on the page without a need to refresh but that does not seem to be happening.
## To Reproduce
Create a route with the code supplied below, change/add any key to the object being returned and save. Check whether the page rendered on the browser changes automatically or not.
Steps to reproduce the behavior, please provide code snippets or a repository:
``` jsx
import Head from 'next/head'
import styles from '../styles/Home.module.css'
export default function TestImage({data}) {
console.log('props passed :', data);
return (
<div className={styles.container}>
<Head>
<title>Create Next App</title>
<link rel="icon" href="/favicon.ico" />
</Head>
<main className={styles.main}>
<h1 className={styles.title}>
Hey There! <code className={styles.codelarge}>I'm {data.name}</code>
</h1>
<h1 className={styles.title}>
I'm a <code className={styles.codelarge}>{data.age}</code> years old {data.job}.
</h1>
</main>
<footer className={styles.footer}>
<a
href="https://vercel.com?utm_source=create-next-app&utm_medium=default-template&utm_campaign=create-next-app"
target="_blank"
rel="noopener noreferrer"
>
Powered by{' '}
<img src="/vercel.svg" alt="Vercel Logo" className={styles.logo} />
</a>
</footer>
</div>
)
}
export async function getStaticProps() {
// Get external data from the file system, API, DB, etc.
const data = {
name: 'John',
age: 28,
job: 'actor'
}
// The value of the `props` key will be
// passed to the `Home` component
return {
props: {data}
}
}
```
## Expected behavior
Upon changing any value for any key that is returned from inside of getStaticProps, the page should reflect the same upon saving.
## System information
- OS: macOs
- Browser Chrome
- Version of Next.js: 10.0.1
- Version of Node.js: 10.16.0
| https://github.com/vercel/next.js/issues/19230 | https://github.com/vercel/next.js/pull/34298 | d288d43f19d9360e9676c638badc2ecd52649713 | 59714db16deee949b426af3184f38ee243c89b8d | "2020-11-17T07:23:44Z" | javascript | "2022-02-16T22:32:24Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,223 | ["packages/next/client/image.tsx", "test/integration/image-component/default/test/index.test.js", "test/unit/image-rendering.unit.test.js"] | Next/image component does not display image when JS is disabled | <!-- NOTE: This template is not optional. If you remove it or leave out sections there is a high likelihood it will be moved to the GitHub Discussions "Help" section -->
# Bug report
## Describe the bug
When javascript is disabled in the browser and the `loading` property is set to `lazy`, which is the default value, `next/image` fails to display an image. Setting the `loading` prop to `eager`, or setting the `priority` prop to `true` results in the image being rendered. The `unoptimized` prop does not impact whether the image is displayed or not.
## To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
1. Go to <https://next-image-js-disabled-lazy-load.vercel.app>
2. Disable javascript for the site (can be done through the browser dev tools).
3. Refresh the page to display the page without any javascript.
## Expected behavior
The first image on the site, the one using the default behavior of `loading='lazy'` is displayed.
## Screenshots
Not applicable.
## System information
- OS: [e.g. macOS, Windows] macOS
- Browser (if applies) [e.g. chrome, safari] chrome, firefox, safari
- Version of Next.js: [e.g. 6.0.2] canary (10.0.2-canary.18)
- Version of Node.js: [e.g. 10.10.0] 12.13.0
## Additional context
[The code to produce the example site can be viewed by clicking here](https://github.com/JeffersonBledsoe/next-image-js-disabled-lazy-load). | https://github.com/vercel/next.js/issues/19223 | https://github.com/vercel/next.js/pull/19052 | 9cc6ba93aba7319afd562312ecb463afeeb1a2af | 48dd9954d8b8cf257e5f1f47709c5dfe8c428345 | "2020-11-16T23:15:27Z" | javascript | "2021-03-23T19:25:00Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,214 | ["packages/next/next-server/lib/router/router.ts", "packages/next/next-server/server/next-server.ts", "test/integration/build-output/test/index.test.js", "test/integration/i18n-support/test/index.test.js", "test/integration/i18n-support/test/shared.js"] | [i18n] next/link can navigate to unconfigured locale | <!-- NOTE: This template is not optional. If you remove it or leave out sections there is a high likelihood it will be moved to the GitHub Discussions "Help" section -->
# Bug report
## Describe the bug
It's possible to navigate to a locale that is not configured using next/link.
## To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
1. Go to https://codesandbox.io/s/suspicious-jackson-qh7qr
2. Click on the "About (FR)" link
3. The page shows up, instead of displaying a 404 immediately
4. After a page refresh, the 404 is shown correctly
## Expected behavior
Links to non-configured locales should show a 404 page when clicking on them.
Optionally, a dev warning could be shown when using a `locale` prop that is not valid.
## Screenshots
If applicable, add screenshots to help explain your problem.
## System information
- Version of Next.js: 10.0.2-canary.18
| https://github.com/vercel/next.js/issues/19214 | https://github.com/vercel/next.js/pull/19338 | fc9fa106187d0fd7e4a83b8d1ddfcd6ca8185c33 | 5959f184312c3693099165bf8f781f14cb6206a7 | "2020-11-16T17:14:50Z" | javascript | "2020-11-20T15:07:00Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,127 | ["docs/advanced-features/i18n-routing.md"] | Impossible to programmatically switch language via router.push in dynamic routes | # Bug report
## Describe the bug
I currently have a menu bar with a switch language button globally in my code. There, I'm using the push strategy suggested in the docs [`Transition between locales`](https://nextjs.org/docs/advanced-features/i18n-routing#transition-between-locales):
```
router.push('/another', '/another', { locale: 'fr' })
```
This approach works for most of my site but for dynamic routes.
In some cases I have the same page (`/tag/[slug]`) in both PT and EN:
- `/tag/css/`
- `/pt/tag/css`
It would work fine by just doing:
```
const { pathname, push } = useRouter()
const switchLocale = nextLocale => push(pathname, pathname, { locale: nextLocale })
```
However I get an error:
```
Unhandled Runtime Error
Error: The provided `href` (/blog/[slug]) value is missing query values (slug) to be interpolated properly. Read more: https://err.sh/vercel/next.js/href-interpolation-failed
```
My first guess would be pass `query` as options, however it does not accept it.
## To Reproduce
1. Access this codesandbox: https://codesandbox.io/s/next-js-dynamic-route-push-bug-cx1zd
2. Click to navigate to `/blog/foo` (Post in English)
3. Than click in the button to switch to portuguese
4. See error
## Expected behavior
Be able to pass to push the `query` params so I can have a consistent way to transition between locales.
## Screenshots
## System information
- Version of Next.js: 10.0.2-canary.12
| https://github.com/vercel/next.js/issues/19127 | https://github.com/vercel/next.js/pull/29632 | 61409dd61599ed54e70a4a0bf5da04187ebe2cfb | 9c0578519d5d60d4ba2e506ec2b498658630ec98 | "2020-11-12T21:54:59Z" | javascript | "2021-10-05T23:36:16Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,120 | ["docs/api-reference/next/image.md", "packages/next/client/image.tsx", "test/integration/image-component/default/pages/sizes.js", "test/integration/image-component/default/test/index.test.js"] | The HTML generated by Image component is missing sizes | 
We should fix this so we pass validation. | https://github.com/vercel/next.js/issues/19120 | https://github.com/vercel/next.js/pull/19128 | 9174b7a337b181a6db1f0f20dd03325b6e1cc1c3 | 20ab35128ccab50ec08f90d8360044adec66c95d | "2020-11-12T19:32:41Z" | javascript | "2020-11-13T04:30:41Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,100 | ["packages/next/next-server/server/image-optimizer.ts", "test/integration/image-optimizer/test/index.test.js"] | Cache folder isn't created when using (Image Component) + SVG images | # Bug report
## Describe the bug
According to https://nextjs.org/docs/basic-features/image-optimization#caching Next.js populates a cache dir when using the new `<Image />` component. This is not the case when using SVG files. This results in a performance penalty.
## To Reproduce
1. Use the new `<Image />` component in combination with an SVG image.
2. Build for production `npm run build`
3. Start your app `npm start`
4. Visit the page
5. Check `<distDir>/cache/images`
6. No files have been generated!
## Expected behavior
I'd expect to see the generated files in the cache directory. Even when the files can't be optimized the files should be served from the filesystem on subsequent calls.
## System information
- OS: Ubuntu
- Browser (if applies) chrome
- Version of Next.js: 10.0.1
- Version of Node.js: 12.19.0
| https://github.com/vercel/next.js/issues/19100 | https://github.com/vercel/next.js/pull/20480 | 69ff95f50eece2e7dbd0c7a33f038da9c4a83572 | e1184fb0607363f710f40de02130e95b6c58b563 | "2020-11-12T13:18:11Z" | javascript | "2021-01-13T18:06:04Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,099 | ["docs/api-reference/next.config.js/basepath.md"] | Router push basePath ignored | # Bug report
## Describe the bug
We are using basePath for our frontend and when calling Router.push() the basePath is ignored. This seems to only be an issues in a docker image.
## Expected behavior
Calling router.push("/ac") with basePath "/resource-finder" in config it should redirect to "/resource-finder/ac".
## System information
- OS: Windows
- Version of Next.js: 10.0.2-canary.12
- Version of Node.js: 15.1.0
## Additional context
I already opened a ticket for same behavior with SSR #18984
| https://github.com/vercel/next.js/issues/19099 | https://github.com/vercel/next.js/pull/19111 | 62633b1af56b230a9d3c35f1d93ab2bdb11ee71e | 6c282a3df4df178ea121234baa1a7868c0389b82 | "2020-11-12T12:38:56Z" | javascript | "2020-11-12T17:48:37Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,095 | ["packages/next/build/utils.ts", "packages/next/next-server/server/incremental-cache.ts", "packages/next/next-server/server/next-server.ts", "test/integration/i18n-support-catchall/pages/[[...slug]].js", "test/integration/i18n-support-catchall/test/index.test.js"] | SSG static generation with fallback false, i18n and catch-all route missing root page on vercel | # Bug report
## Describe the bug
Using SSG with catch-all route and i18n I get no page (directory listing) on vercel. It's working ok in local environment
## To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
1. Clone repository https://github.com/vonschau/next-i18n-catchall
2. Deploy it to vercel
3. There's directory listing instead of root page (in all locales)
App has 2 locales - cs (default) and en.
You can see it on https://next-i18n-catchall.vercel.app/ or https://next-i18n-catchall.vercel.app/en.
Subpages are displayed correctly (ie. https://next-i18n-catchall.vercel.app/en/blog)
## Expected behavior
Root page is correctly displayed on vercel.
## Screenshots
## System information
- OS: macOS
- Version of Next.js: 10.0.2-canary.12
- Version of Node.js: v14.8.0
## Additional context
I think the root pages are incorrectly generated as ".html" & ".json" files instead of index.html & index.json.
| https://github.com/vercel/next.js/issues/19095 | https://github.com/vercel/next.js/pull/19116 | c88872cea059b520913d8c9eb08bb1063dd85a7b | 4866c47d9d9b39515d6e57118955e86c85630c4c | "2020-11-12T10:28:48Z" | javascript | "2020-11-12T18:50:32Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,093 | ["examples/with-apollo-and-redux/README.md", "examples/with-apollo-and-redux/components/PostList.js", "examples/with-apollo-and-redux/components/PostUpvoter.js", "examples/with-apollo-and-redux/components/Submit.js", "examples/with-apollo-and-redux/lib/apollo.js", "examples/with-apollo-and-redux/package.json"] | With-apollo-and-redux - Error: Unexpected token < in JSON at position 0 | # Bug report
## Can't build or run page, throws error
Log:
```
C:\Users\Nizomidin\Desktop\with-apollo-and-redux>yarn build
yarn run v1.22.10
$ next build
info - Creating an optimized production build
info - Compiled successfully
info - Collecting page data
[ ==] info - Generating static pages (2/4)
Error occurred prerendering page "/apollo". Read more: https://err.sh/next.js/prerender-error
Error: Unexpected token < in JSON at position 0
at new ApolloError (C:\Users\Nizomidin\Desktop\with-apollo-and-redux\node_modules\@apollo\client\errors\errors.cjs.js:31:28)
at C:\Users\Nizomidin\Desktop\with-apollo-and-redux\node_modules\@apollo\client\core\core.cjs.js:1457:19
at C:\Users\Nizomidin\Desktop\with-apollo-and-redux\node_modules\@apollo\client\utilities\utilities.cjs.js:936:69
at new Promise (<anonymous>)
at Object.error (C:\Users\Nizomidin\Desktop\with-apollo-and-redux\node_modules\@apollo\client\utilities\utilities.cjs.js:936:21)
at notifySubscription (C:\Users\Nizomidin\Desktop\with-apollo-and-redux\node_modules\zen-observable\lib\Observable.js:140:18)
at onNotify (C:\Users\Nizomidin\Desktop\with-apollo-and-redux\node_modules\zen-observable\lib\Observable.js:179:3)
at SubscriptionObserver.error (C:\Users\Nizomidin\Desktop\with-apollo-and-redux\node_modules\zen-observable\lib\Observable.js:240:7)
at C:\Users\Nizomidin\Desktop\with-apollo-and-redux\node_modules\@apollo\client\utilities\utilities.cjs.js:924:68
at Array.forEach (<anonymous>)
Error occurred prerendering page "/". Read more: https://err.sh/next.js/prerender-error
Error: Unexpected token < in JSON at position 0
at new ApolloError (C:\Users\Nizomidin\Desktop\with-apollo-and-redux\node_modules\@apollo\client\errors\errors.cjs.js:31:28)
at C:\Users\Nizomidin\Desktop\with-apollo-and-redux\node_modules\@apollo\client\core\core.cjs.js:1457:19
at C:\Users\Nizomidin\Desktop\with-apollo-and-redux\node_modules\@apollo\client\utilities\utilities.cjs.js:936:69
at new Promise (<anonymous>)
at Object.error (C:\Users\Nizomidin\Desktop\with-apollo-and-redux\node_modules\@apollo\client\utilities\utilities.cjs.js:936:21)
at notifySubscription (C:\Users\Nizomidin\Desktop\with-apollo-and-redux\node_modules\zen-observable\lib\Observable.js:140:18)
at onNotify (C:\Users\Nizomidin\Desktop\with-apollo-and-redux\node_modules\zen-observable\lib\Observable.js:179:3)
at SubscriptionObserver.error (C:\Users\Nizomidin\Desktop\with-apollo-and-redux\node_modules\zen-observable\lib\Observable.js:240:7)
at C:\Users\Nizomidin\Desktop\with-apollo-and-redux\node_modules\@apollo\client\utilities\utilities.cjs.js:924:68
at Array.forEach (<anonymous>)
info - Generating static pages (4/4)
> Build error occurred
Error: Export encountered errors on following paths:
/
/apollo
at exportApp (C:\Users\Nizomidin\Desktop\with-apollo-and-redux\node_modules\next\dist\export\index.js:25:1103)
at processTicksAndRejections (internal/process/task_queues.js:93:5)
at async build (C:\Users\Nizomidin\Desktop\with-apollo-and-redux\node_modules\next\dist\build\index.js:39:69)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
```
## To Reproduce
Steps to reproduce the behavior:
1. Open terminal
2. Run `create-next-app with-apollo-and-redux -e with-apollo-and-redux`
3. Run `yarn build`
4. See error
## Expected behavior
Builded page
## System information
- OS: Windows 10 - 2004 (build20185.1000)
- Version of Next.js: 10.0.1
- Version of Node.js: 14.15.0
| https://github.com/vercel/next.js/issues/19093 | https://github.com/vercel/next.js/pull/19248 | 3924b0047865f7a1c11694e5940d2491252d1003 | 20949612dfb56e44a623498eb3237a69177229e5 | "2020-11-12T09:26:25Z" | javascript | "2020-12-02T19:45:31Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,079 | ["examples/with-firebase-cloud-messaging/utils/webPush.js"] | examples/with-firebase-cloud-messaging: replace deprecated method | `messaging.requestPermission()` is now deprecated (https://firebase.google.com/docs/reference/js/firebase.messaging.Messaging#requestpermission)
Use `Notification.requestPermission()` instead
| https://github.com/vercel/next.js/issues/19079 | https://github.com/vercel/next.js/pull/19080 | f226a376b139b7285ee1d1dbc1600f15eb4cf2c1 | e6a6beb38d71a4b165a40ae211636baf6cfb5c27 | "2020-11-11T23:33:56Z" | javascript | "2020-11-11T23:41:37Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,074 | ["packages/next/client/image.tsx", "test/integration/image-component/basic/pages/lazy.js", "test/integration/image-component/basic/test/index.test.js"] | [next/image] Repeated images rerender on every page switch. | # Bug report
Repeated [Next/Image] included images rerenders when switching between pages even if has been already used in components like layout/header.
## Describe the bug
When including an image using next/image, in every page switch it rerender even if was rendered before, like a Header component with logo.
If we see the network tab in developer tooks, we can confirm that isn't a "thing" related to network/cache because the image/assets isn't downloaded multiple times.
Personally, actually don't know how exactly next/image works, but with the Gatsby equivalent (gatsby-image) it didn't happen using a similar "repeated component" approach.
## To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
1. Go to 'https://mhhk5.sse.codesandbox.io/'
2. Click on 'Go to first page / Go to second page'
3. Repeat multiple times step 2 quickly
## Expected behavior
The image shouldn't rerender, and works like a normal <img />.
## System information
Not necessary, because was tested on Vercel, Codesandbox and my own PC
- OS: Windows 10
- Browser: Edge/Chrome Last version
- Version of Next.js: 10.0.1 / 10.0.2-canary.8 (Tested in both, same result)
- Version of Node.js: 14.7.0
PD: Sorry if my english isn't good enough. | https://github.com/vercel/next.js/issues/19074 | https://github.com/vercel/next.js/pull/26968 | f1e6bc9e6b5d9204757fe14a0cb1bb885a246c9d | 8066e423a7c51e8c670e8328beac91e80da2fc0a | "2020-11-11T21:20:44Z" | javascript | "2021-07-07T17:51:16Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,071 | ["packages/next/build/webpack/loaders/next-serverless-loader.ts", "packages/next/build/webpack/loaders/next-serverless-loader/api-handler.ts", "packages/next/build/webpack/loaders/next-serverless-loader/index.ts", "packages/next/build/webpack/loaders/next-serverless-loader/page-handler.ts", "packages/next/build/webpack/loaders/next-serverless-loader/utils.ts", "packages/next/next-server/lib/router/utils/route-regex.ts"] | Strongly type Next.js' serverless loader | It's currently incorrectly using `sendPayload` (sending a boolean instead of object) and missing behavior. We should fix this via TypeScript. | https://github.com/vercel/next.js/issues/19071 | https://github.com/vercel/next.js/pull/19511 | 453adc68648b716ed1311f99bd5301f35fbb596b | 899a29cade19ab16f4c5105f9bcb8514577395de | "2020-11-11T20:23:33Z" | javascript | "2020-11-25T19:56:18Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,069 | ["packages/next/next-server/server/next-server.ts", "packages/next/next-server/server/router.ts", "test/integration/i18n-support/next.config.js", "test/integration/i18n-support/test/index.test.js"] | trailingSlash + i18n causing redirect issue on index | # Bug report
## Describe the bug
Setting `i18n` and `trailingSlash: true` in next config results in too many redirects error when visiting the index route in development.
## To Reproduce
1. Using next config of
```
i18n: {
locales: ['en', 'fr'],
defaultLocale: 'en'
},
trailingSlash: true
```
2. Visit `/` and the page loads
3. Visit `/fr/` and the error occurs
If you remove the prop `trailingSlash: true` it then works.
Here is a repo of a default create-next-app with the config above: https://github.com/edbrett/i18n-demo
## Expected behavior
The page should load.
## Screenshots
<img width="673" alt="Screenshot 2020-11-11 at 18 48 49" src="https://user-images.githubusercontent.com/20288774/98851713-958c9700-244e-11eb-8a30-61ea985df729.png">
## System information
- OS: macOS
- Browser chrome
- Version of Next.js: 10.0.1
- Version of Node.js: 12.16.2
| https://github.com/vercel/next.js/issues/19069 | https://github.com/vercel/next.js/pull/19149 | 2750880546dd27eb59756de9a5683f7fecaa33ee | ca590c4cb91cef4fb164c6e1211386145038eded | "2020-11-11T18:51:00Z" | javascript | "2020-11-17T21:46:46Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,068 | ["packages/next/build/webpack/loaders/next-serverless-loader.ts", "test/integration/prerender/test/index.test.js"] | Investigate error case | 
We shouldn't be emitting the argument entity bug. | https://github.com/vercel/next.js/issues/19068 | https://github.com/vercel/next.js/pull/19288 | ce7ca2487b6bc439e54eada104296b07e9498c21 | 8193df5309da45cef33b23fdf7605b36798c188d | "2020-11-11T18:45:43Z" | javascript | "2020-11-19T16:25:54Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,059 | ["packages/next/build/webpack/loaders/next-serverless-loader.ts", "packages/next/client/page-loader.ts", "packages/next/next-server/lib/router/router.ts", "packages/next/next-server/server/next-server.ts", "test/integration/i18n-support-catchall/next.config.js", "test/integration/i18n-support-catchall/pages/[[...slug]].js", "test/integration/i18n-support-catchall/test/index.test.js"] | Different behavior of context params in vercel platform and in local environment with optional catch-all route and i18n | # Bug report
## Describe the bug
In vercel, next.js app adds locale to the params caught by optional catch-all route (what is imho incorrect).
## To Reproduce
1. Clone repo https://github.com/vonschau/next-i18n-catchall
2. Run `npm install`
3. Run `npm dev`
4. Open `http://localhost:3000`
5. It should log `{"params":{},"locales":["cs","en"],"locale":"cs","defaultLocale":"cs"}` to the console (terminal)
If you deploy the same repo to the vercel, logged line is `{"params":{"slug":["cs"]},"locales":["cs","en"],"locale":"cs","defaultLocale":"cs"}`
## Expected behavior
The same output (`{"params":{},"locales":["cs","en"],"locale":"cs","defaultLocale":"cs"}`) in vercel.
## Screenshots
Localhost:
Vercel:
## System information
- OS: macOS
- Version of Next.js: 10.0.2-canary.8
- Version of Node.js: v14.8.0
## Additional context
I think local version is correct and the vercel's one is not correct. It should not add locale to the "catch-all" params in the context.
| https://github.com/vercel/next.js/issues/19059 | https://github.com/vercel/next.js/pull/19063 | 44932612f82638207ab9bebdf159e10d0152fdce | d1036539d680c8578e4ad8f98d55e6f99f1e7362 | "2020-11-11T15:09:39Z" | javascript | "2020-11-11T20:33:44Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,048 | ["packages/next/client/link.tsx", "test/integration/i18n-support-base-path/pages/mixed.js", "test/integration/i18n-support-catchall/pages/[[...slug]].js", "test/integration/i18n-support-catchall/test/index.test.js", "test/integration/i18n-support/pages/mixed.js", "test/integration/i18n-support/test/shared.js"] | prefetch in combination with i18n and next/link locale:false result in 404 of defaultLocale | # Bug report
## Describe the bug
Use of i18n and defaultLocale returns in prefetched links in the defaultLocale to be 404 not found.
## To Reproduce
Use i18n and SSG mode the prefetched links inside of the default locale are wrong.
## Expected behavior
The generated refetch URL is wrong, defaultLocale === en
```
/_next/data/Zs6ypKU6jWKL8TDFyfTqC/home.json
instead of:
/_next/data/Zs6ypKU6jWKL8TDFyfTqC/en/home.json
```
https://storyblok-mui-planettraining-dohomi.lumenmedia1.vercel.app/
## System information
- OS: every
- Browser every
- Version of Next.js: 10.0.1
- Version of Node.js: 12.x
## Additional context
It seems that the defaultLocale is missing the defaultLocale inside of the PATH of the generated prefetch data links
| https://github.com/vercel/next.js/issues/19048 | https://github.com/vercel/next.js/pull/19085 | ab0e2744eeb5082ced09330bf27e8f7ff1393519 | 99e10a07fb9dd992c039cb0d9d4761935b91e547 | "2020-11-11T08:47:50Z" | javascript | "2020-11-17T18:04:07Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,041 | ["packages/next/client/image.tsx", "test/integration/image-component/default/pages/drop-srcset.js", "test/integration/image-component/default/test/index.test.js"] | Image srcSet flashes then switches back to src image | # Bug report
## Describe the bug
I use srcSet to display 2 different images: one on desktop and a different one mobile. My hero image needs to take full width of the container so I use `layout="fill"`. The bug I encounter is that on mobile the image flashes to the srcSet specified on that size then flash back to the desktop image.
## To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
I've written an example on codesandbox to explain what I am talking about:
1. Go to 'https://codesandbox.io/s/mutable-river-wi0uj'
2. Open in new window.
3. toggle device toolbar & use Iphone X for example, then refresh the page.
4. You will notice the `moving-truck-mobile.jpg` flashes then switches to `moving-truck.jpg`
## Expected behavior
The expected behaviour should display the `moving-truck-mobile.jpg` on mobile, knowing that it works for me when I use the html `img`
```js
<img
src="/moving-truck.jpg"
srcSet="/moving-truck-mobile.jpg 375w,
/moving-truck-mobile.jpg 640w,
/moving-truck.jpg"
sizes="(max-width: 375px) 375px, 100%"
width="100%"
/>
```
## System information
- Browser : chrome
- Version of Next.js: 10.0.1
| https://github.com/vercel/next.js/issues/19041 | https://github.com/vercel/next.js/pull/20651 | 088f374c16d2f1fdcc4d0d541d52e68df844763f | 29b591b2bc4e47773ed2405120f2d5aee09ff701 | "2020-11-11T03:14:46Z" | javascript | "2020-12-31T21:08:57Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,026 | ["packages/next/build/babel/preset.ts", "test/unit/next-babel.unit.test.js"] | Failed to resolve "@babel/runtime" with Yarn 2 and Next.js canary | # Bug report
## Describe the bug
I can't use Yarn 2.3.3 with Next.js canary.
## To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
1. `yarn create next-app my-app`
2. `cd my-app`
3. `yarn dev`: everything works!
4. `yarn set version berry && yarn set version latest`
5. `yarn dev`: there's this output:
```
ready - started server on http://localhost:3000
error - ./.yarn/$$virtual/next-virtual-6b6cc49c53/0/cache/next-npm-10.0.2-canary.7-b861c3bd6e-81131dbf83.zip/node_modules/next/dist/client/dev/amp-dev.js
Error: [BABEL] /private/tmp/my-app/.yarn/$$virtual/next-virtual-6b6cc49c53/0/cache/next-npm-10.0.2-canary.7-b861c3bd6e-81131dbf83.zip/node_modules/next/dist/client/dev/amp-dev.js: Failed to resolve "@babel/runtime" relative to "/private/tmp/my-app/.yarn/$$virtual/next-virtual-6b6cc49c53/0/cache/next-npm-10.0.2-canary.7-b861c3bd6e-81131dbf83.zip/node_modules/next/dist/build/babel" (While processing: "programmatic item$5")
at Generator.next (<anonymous>)
at Generator.next (<anonymous>)
```
and `localhost:3000` hangs and doesn't render anything
## Expected behavior
no errors and the page renders fine. the following work as expected:
- Next.js 10.0.1 and Yarn 1.22.10
- Next.js 10.0.1 and Yarn 2.3.3
- Next.js 10.0.2-canary.7 and Yarn 1.22.10
but *not* Next.js 10.0.2-canary.7 and Yarn 2.3.3
## Screenshots
N/A
## System information
- OS: macOS 11.0 Beta (20A5395g)
- Browser: Chrome 86.0.4240.183, Safari 14.0.1 (16610.2.8.1.1), Firefox 81.0.1
- Version of Next.js: 10.0.1
- Version of React: 17.0.1
- Version of Node.js: 12.14.1
## Additional context
initially reported at https://github.com/vercel/next.js/issues/18913#issuecomment-724090647
| https://github.com/vercel/next.js/issues/19026 | https://github.com/vercel/next.js/pull/18921 | a03fcbf7eb944031171aec3a2cdc1003b30a8da1 | d40d7d65623105bd5f028b1eb1bc5f0fbebfce01 | "2020-11-10T17:59:06Z" | javascript | "2020-11-11T15:18:33Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 19,001 | ["packages/next/build/babel/preset.ts", "packages/next/build/webpack-config.ts", "test/unit/next-babel-loader.unit.test.js", "test/unit/next-babel.unit.test.js"] | Bad `next build` when using new JSX transform & NODE_ENV=development | # Bug report
## Describe the bug
When creating a production build in development (Weird use case, I know, but I use this to test a compiled app with development settings), next appears to be confused about whether to use jsx or jsxDEV.
The app appears to have SSG rendered fine (I get a brief flash of content,) however when hydration is triggered on the client, the #__next div is emptied, and an infinite error loop occurs. Thousands of `TypeError: Object(...) is not a function` (`Object(o.jsxDEV)(...)` in source) errors appear in the console.
I don't know how next handles the JSX transform, but my guess is `next build` doesn't include `jsxDEV` on the client, somehow breaking the app.
<details>
<summary>Full trace</summary>
```
TypeError: Object(...) is not a function
at r.default (_app-b6e6c2c671f93d19d381.js:1)
at no (framework.4ed712e956e4440973f2.js:1)
at ju (framework.4ed712e956e4440973f2.js:1)
at xi (framework.4ed712e956e4440973f2.js:1)
at Si (framework.4ed712e956e4440973f2.js:1)
at ki (framework.4ed712e956e4440973f2.js:1)
at pi (framework.4ed712e956e4440973f2.js:1)
at ii (framework.4ed712e956e4440973f2.js:1)
at Ki (framework.4ed712e956e4440973f2.js:1)
at framework.4ed712e956e4440973f2.js:1
```
Compiled source:
```js
r.default = function(e) {
var r = e.Component
, t = e.pageProps;
// Error occurs here:
return Object(o.jsxDEV)(r, function(e) {
for (var r = 1; r < arguments.length; r++) {
var t = null != arguments[r] ? arguments[r] : {};
r % 2 ? c(Object(t), !0).forEach((function(r) {
n(e, r, t[r])
}
)) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : c(Object(t)).forEach((function(r) {
Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r))
}
))
}
return e
}({}, t), void 0, !1, {
fileName: "[...]/jsxdev-repro/pages/_app.js",
lineNumber: 4,
columnNumber: 10
}, this)
}
```
</details>
## To Reproduce
Pretty straightforward to reproduce:
```shell
npx create-next-app jsxdev-repro
cd jsxdev-repro
NODE_ENV=development npm run build
npm start
```
Open site in a browser
## Expected behavior
- Client should correctly compile with jsx or jsxDEV
- Hydration should not fail into a blank page state
- Hydration should not enter an infinite loop
## Screenshots
## System information
- macOS
- Tested in firefox & chrome
- Next 10.0.1
- React(-dom) 17.0.1
- Node 14.13
## Additional context
Add any other context about the problem here.
| https://github.com/vercel/next.js/issues/19001 | https://github.com/vercel/next.js/pull/20679 | 984ac96dc63bc4556f4f4f9e00b225577a8fb005 | 58ea3bb47966ba7ae0f12a9267b54f79a5b4c9fc | "2020-11-10T02:26:35Z" | javascript | "2021-01-02T00:36:16Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,970 | ["packages/next/build/webpack/loaders/next-serverless-loader.ts", "packages/next/next-server/lib/router/utils/prepare-destination.ts", "packages/next/next-server/server/incremental-cache.ts", "packages/next/next-server/server/next-server.ts", "packages/next/next-server/server/render.tsx", "test/integration/i18n-support/pages/frank.js", "test/integration/i18n-support/pages/gssp/index.js", "test/integration/i18n-support/test/index.test.js"] | Incorrect defaultLocale on server side domain routing. | # Bug report
Getting incorrect `defaultLocale` on server side domain routing.
## Describe the bug
Getting incorrect `defaultLocale` when accessing locale information via the `getServerSideProps`'s context. Seems like it is getting the fallback `defaultLocale` instead of the `defaultLocale` assigned to the domain.
## To Reproduce
```javascript
// next.config.js
module.exports = {
i18n: {
locales: ["en", "ar"],
defaultLocale: "en",
domains: [
{
domain: "example.com",
defaultLocale: "en",
},
{
domain: "example.ae",
defaultLocale: "ar",
},
{
domain: "sa.example.com",
defaultLocale: "ar",
},
],
},
};
```
```javascript
// when on domain "example.ae"
import type { NextPage, GetServerSideProps } from "next";
import { useRouter } from "next/router";
const Home: NextPage = () => {
const router = useRouter();
// router.defaultLocale returns "ar" which is correct.
return <div></div>;
};
export const getServerSideProps: GetServerSideProps = async (context) => {
// context.defaultLocale returns "en" which is incorrect.
return {
props: {},
};
};
export default Home;
```
## Expected behavior
I would expect it to return the `defaultLocale` of the domain instead of the fallback `defaultLocale`.
## System information
- OS: macOS
- Browser: chrome
- Version of Next.js: 10.0.1
- Version of Node.js: 12.4.0
| https://github.com/vercel/next.js/issues/18970 | https://github.com/vercel/next.js/pull/19040 | 6de34e7557fd247118d74fbfb91da29576c4d61c | a429a47fe0585c1b3d28f5a8c366238b36439642 | "2020-11-09T09:34:31Z" | javascript | "2020-11-11T02:09:45Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,941 | ["examples/with-chakra-ui/src/components/CTA.js", "examples/with-chakra-ui/src/pages/_app.js"] | nextjs with-chakra-ui example failing | # Bug report
## Describe the bug
When starting a fresh install of the example, i get this error:
`TypeError: Cannot read property 'useSystemColorMode' of undefined`
And it refuses to start, when opening the site, it shows this.
## To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
1. Run `yarn create next-app --example with-chakra-ui with-chakra-ui-app`
(This is the suggested command from [with-chakra-ui](https://github.com/vercel/next.js/tree/canary/examples/with-chakra-ui))
2. `cd with-chakra-ui-app`
3. `yarn dev`
## Expected behavior
It was supposed to start the frontend application, and open it in browser at `localhost:3000`
## System information
- OS: [Arch Linux]
- Browser (doesn't apply)
- Version of Next.js: [9.5.5]
- Version of Node.js: [14.12.0]
| https://github.com/vercel/next.js/issues/18941 | https://github.com/vercel/next.js/pull/18954 | 38a24a9b91e066bbb8bec3d1684098173a7c9178 | 50a416a53cbd622b75f22b841f2741fb38ef8996 | "2020-11-08T10:48:32Z" | javascript | "2020-11-09T03:03:26Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,929 | ["packages/next/build/babel/preset.ts", "packages/next/build/webpack-config.ts", "test/unit/next-babel-loader.unit.test.js", "test/unit/next-babel.unit.test.js"] | next start not working with React 17 on default create-next-app | # Bug report
After creating app with `yarn create next-app` and running `yarn build && yarn start` browser page hangs.
When I remove `_app.js` file and return only one jsx string, I get this error:
```
TypeError: Object(...) is not a function
at o (index-54f93a3aba2589cf692d.js:1)
at no (framework.4ed712e956e4440973f2.js:1)
at ju (framework.4ed712e956e4440973f2.js:1)
at xi (framework.4ed712e956e4440973f2.js:1)
at Si (framework.4ed712e956e4440973f2.js:1)
at ki (framework.4ed712e956e4440973f2.js:1)
at pi (framework.4ed712e956e4440973f2.js:1)
at ii (framework.4ed712e956e4440973f2.js:1)
at Ki (framework.4ed712e956e4440973f2.js:1)
at framework.4ed712e956e4440973f2.js:1
```
The line in index.js file is `return Object(i.jsxDEV)...`.
Without any jsx and in development mode (`yarn dev`) there are no errors, so it's probably bug in build script.
After changing react to version 16 everything is working normally.
## To Reproduce
1. Create next app with `yarn create next-app`
2. Run `yarn build && yarn start`
3. Open browser
## Expected behavior
App should build and run without problems
## System information
- OS: Linux
- Browser: chrome, firefox
- Version of Next.js: 10.0.2
- Version of Node.js: 14.15.0 | https://github.com/vercel/next.js/issues/18929 | https://github.com/vercel/next.js/pull/20679 | 984ac96dc63bc4556f4f4f9e00b225577a8fb005 | 58ea3bb47966ba7ae0f12a9267b54f79a5b4c9fc | "2020-11-07T17:51:01Z" | javascript | "2021-01-02T00:36:16Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,917 | [".github/workflows/build_test_deploy.yml", "packages/next/build/webpack/plugins/nextjs-require-cache-hot-reloader.ts", "test/integration/ssr-ctx/context.js", "test/integration/ssr-ctx/pages/_app.js", "test/integration/ssr-ctx/pages/index.js", "test/integration/ssr-ctx/test/index.test.js"] | Context declared in _app undefined during SSR in dev | # Bug report
## Describe the bug
Running into basically this issue #4194 here _sometimes_, only in dev.
It's a fresh app, not much happening as of yet. A single context provider wrapping `Component` in app, and a index page using the context through a custom hook.
The contexts initial value is null, but its filled through the provider. The custom hook throws on empty context value.
## To Reproduce
Repo: https://github.com/ljosberinn/AuctionCraftSniper/blob/518d537557/src/pages/_app.tsx
Steps to reproduce the behavior, please provide code snippets or a repository:
1. Check that repo out (branch `next`)
2. `yarn dev`
3. click the link in the console to localhost:3000
4. first render will work
5. F5, crashes
## Expected behavior
Context should not be empty.
## Screenshots
_app:
AuthContextProvider rendering _with a value present_
index calling hook:
Breakpoint where error is thrown:
Call Stack in VSCode Debugger:
Call Stack in Browser:
Call Stack in Console:
## System information
- OS: Win 10
- Browser (if applies) Chrome
- Version of Next.js: latest
- Version of Node.js: 15.0.1
| https://github.com/vercel/next.js/issues/18917 | https://github.com/vercel/next.js/pull/20652 | 16d464caf6607859b6ddd9a819bfe94acbf962ce | 9c8d04654ef0163f8dbc0794a50112f8d40b9e88 | "2020-11-07T01:13:51Z" | javascript | "2021-01-01T17:39:39Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,910 | ["packages/create-next-app/package.json", "packages/next-env/package.json", "packages/next/compiled/web-vitals/web-vitals.es5.umd.min.js", "packages/next/package.json", "packages/next/taskfile.js", "yarn.lock"] | Fix IE11 support with new ncc changes | IE11 fails with the latest ncc changes so we need to ensure the updates are compatible still! | https://github.com/vercel/next.js/issues/18910 | https://github.com/vercel/next.js/pull/18905 | e9054744d84638555c10a33a76949c845d175fe0 | f02f70478bfb8435d84667925ea740dd86124593 | "2020-11-06T21:03:37Z" | javascript | "2020-11-06T21:02:28Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,908 | ["examples/image-component/components/view-source.js", "examples/image-component/components/view-source.module.css", "examples/image-component/package.json", "examples/image-component/pages/background.js", "examples/image-component/pages/index.js", "examples/image-component/pages/layout-fill.js", "examples/image-component/pages/layout-fixed.js", "examples/image-component/pages/layout-intrinsic.js", "examples/image-component/pages/layout-responsive.js"] | Link from image component example back to source code | We can use something like [github-corners](https://github.com/tholman/github-corners) on each example page so that users viewing the example from the deployment can view the source code. | https://github.com/vercel/next.js/issues/18908 | https://github.com/vercel/next.js/pull/18909 | 39453bba69d83167d72373b01fd3229a8479985b | 37fb0ad220116181a059a38560dc95667830557e | "2020-11-06T20:43:59Z" | javascript | "2020-11-06T22:13:01Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,869 | ["docs/basic-features/data-fetching.md"] | Update docs for `notFound` and `redirect` | Our current docs for `notFound` and `redirect` don't include eaxmples of the usage, only explain them, and that can be confusing for new users. The docs for `notFound` are also linking to a section in docs that doesn't provide any more details. | https://github.com/vercel/next.js/issues/18869 | https://github.com/vercel/next.js/pull/18870 | 8221c180a55828b39a7e1e01811365bfaaa0dd19 | d87bc3de980b23c1f616c043c522eb87432f2cc4 | "2020-11-05T23:18:59Z" | javascript | "2020-11-06T03:15:08Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,867 | ["examples/with-webassembly/package.json"] | The example `with-webassembly` fails with invalid hook | # Bug report
## Describe the bug
The example `with-webassembly` fails with with: `Error: Invalid hook call.`
## To Reproduce
`npx create-next-app --example with-webassembly with-webassembly-app`
install Rust
`npm run build-rust`
`npm run dev`
## Expected behavior
`npm run dev` starts without error
## System information
- OS: Archlinux
- Chrome
Version 86.0.4240.183 (Official Build) Arch Linux (64-bit)
- Version of Next.js: 10.0.1
- Version of Node.js: 15.0.1
| https://github.com/vercel/next.js/issues/18867 | https://github.com/vercel/next.js/pull/18916 | f1a6a36b3ee6e06d7ded55ab31f788bd5d40f2af | 782046840186ef4ad1bb61f4af360bc6958d2a25 | "2020-11-05T22:21:12Z" | javascript | "2020-11-07T18:13:24Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,856 | ["packages/next/client/link.tsx", "test/integration/font-optimization/test/index.test.js", "test/integration/preload-viewport/pages/prefetch-disabled-ssg.js", "test/integration/preload-viewport/pages/prefetch-disabled.js", "test/integration/preload-viewport/test/index.test.js", "test/integration/prerender/pages/blog/[post]/index.js"] | Prefetching on hover is broken | # Bug report
## Describe the bug
Next.js is supposed to prefetch the next page, even when prefetching is disabled, when a `<Link>` is **hovered**. The automated prefetch disabling is only supposed to affect the in-viewport prefetch.
## To Reproduce
```tsx
<Link prefetch={false} ...>
```
## Expected behavior
Prefetch on hover! | https://github.com/vercel/next.js/issues/18856 | https://github.com/vercel/next.js/pull/18859 | d04186e48052831523acdfa5d3a58ebc6239c100 | 80468ad4c21647a45188f7793ee2924385689300 | "2020-11-05T20:36:51Z" | javascript | "2020-11-06T02:12:22Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,850 | ["packages/next/client/image.tsx", "packages/next/next-server/lib/to-base-64.ts", "test/integration/image-component/basic/test/index.test.js"] | next/image produces invalid HTML according to W3C | # Bug report
## Describe the bug
After implementing on our website, we noticed that our pages were now reporting invalid HTML errors on the W3C Markup Validation Service.
Error: Bad value data:image/svg+xml;charset=utf-8,<svg width="510" height="510" xmlns="http://www.w3.org/2000/svg" version="1.1"/> for attribute src on element img: Illegal character in scheme data: < is not allowed.
Error: Element img is missing required attribute src.
## To Reproduce
Create a blank page using next/image component and check it on the W3C Validator.
https://validator.w3.org/
## Expected behavior
No Errors.
## Screenshots
## System information
N/A
## Additional context
Great work! If we can resolve this, it will be one of my favorite components!
| https://github.com/vercel/next.js/issues/18850 | https://github.com/vercel/next.js/pull/18903 | 19febb10c03280c200a00033a7d59ceded0d7923 | b2a8a2f99e769638b1bb647e7f9fdc6ba5f1467b | "2020-11-05T18:09:18Z" | javascript | "2020-11-07T17:39:14Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,827 | ["packages/next/client/image.tsx"] | next/image IE11 support - fallback | # Bug report
## Describe the bug
Yeah I know, IE11 support. Since next.js adds polyfills for IE11, I assumed the new next/image component works somehow with a fallback to the original image for IE11 browser too, but it doesn't work.
I saw a pull request `Fix image format for Safari and old browsers` #18646, it's included in 10.0.1 but it's not affecting IE11.
## To Reproduce
Steps to reproduce the behavior:
1. Clone the image-component example, https://github.com/vercel/next.js/tree/canary/examples/image-component
2. Open it with IE11
3. See no images
## HTML from IE11 Inspector
```html
<div
style="
margin: 0px;
overflow: hidden;
display: inline-block;
position: relative;
max-width: 100%;
box-sizing: border-box;
"
>
<div style="display: block; max-width: 100%; box-sizing: border-box">
<img
role="presentation"
aria-hidden="true"
style="display: block; max-width: 100%"
alt=""
src='data:image/svg+xml;charset=utf-8,<svg width="1000" height="1000" xmlns="http://www.w3.org/2000/svg" version="1.1"/>'
/>
</div>
<img
class="__lazy"
style="
margin: auto;
padding: 0px;
border: currentColor;
border-image: none;
left: 0px;
top: 0px;
width: 0px;
height: 0px;
right: 0px;
bottom: 0px;
display: block;
visibility: hidden;
position: absolute;
min-height: 100%;
max-height: 100%;
min-width: 100%;
max-width: 100%;
box-sizing: border-box;
"
alt="Vercel logo"
decoding="async"
data-srcset="/_next/image?url=%2Fvercel.png&w=1080&q=75 1x, /_next/image?url=%2Fvercel.png&w=2048&q=75 2x, /_next/image?url=%2Fvercel.png&w=3840&q=75 3x"
data-src="/_next/image?url=%2Fvercel.png&w=3840&q=75"
/>
</div>
```
## Expected behavior
Show the images
## Screenshots
## System information
- OS: Windows
- Browser: IE11
- Version of Next.js: 10.0.1
- Version of Node.js: v12.13.1
| https://github.com/vercel/next.js/issues/18827 | https://github.com/vercel/next.js/pull/18868 | 4dbb65d0f1196f9e2f7dedffd3c0e8eb26e448a6 | d04186e48052831523acdfa5d3a58ebc6239c100 | "2020-11-05T08:05:42Z" | javascript | "2020-11-06T01:34:25Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,826 | ["docs/advanced-features/i18n-routing.md"] | [i18n] Clarification in docs regarding Support for Domain Internationalised Routing for multilingual countries (Belgium, Switzerland, etc) | # Feature request
Currently, documentation is showing a scenario where we have a single defaultLocale assigned to a specific domain. Automatic Locale Detection will redirect to a specific domain if the user's Accept-Language header is matching with defaultLocale.
Base on my tests - (didn't go through the source code) when the config is set to this:
```
module.exports = {
i18n: {
locales: ['nl-NL', 'nl-BE', 'fr-BE'],
defaultLocale: 'en-US',
domains: [
{
domain: 'example.nl',
defaultLocale: 'nl-NL',
},
{
domain: 'example.be',
defaultLocale: 'nl-BE',
locales: ['nl-BE', 'fr-BE'],
}
],
},
}
```
and when my browser's locale is set to fr-BE and I go to `example.com` I am being redirected to `example.be/fr-BE`.
This behavior hasn't been described in the documentation.
## Describe the solution you'd like
This behavior and example configuration should be in the documentation. At this stage, it is not clear if it is intentional.
| https://github.com/vercel/next.js/issues/18826 | https://github.com/vercel/next.js/pull/18845 | 907888c70adccdf1fdcd250add8f7f40db12fc97 | 6fbe5b439dc9725af8cd4889b9bb662a53c07e82 | "2020-11-05T05:34:07Z" | javascript | "2020-11-05T16:35:22Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,794 | ["docs/api-reference/next/image.md", "examples/image-component/pages/background.js", "examples/image-component/pages/layout-fill.js", "examples/image-component/styles.module.css", "packages/next/client/image.tsx", "test/integration/image-component/default/pages/layout-fill.js", "test/integration/image-component/default/test/index.test.js", "test/integration/image-component/typescript/pages/valid.tsx"] | Add `next/image` props for object-fit and object-position | # Feature request
### Problem
When using `layout=fill`, you usually want to avoid stretching the image.
So its common to use [`object-fit`](https://developer.mozilla.org/en-US/docs/Web/CSS/object-fit) and [`object-position`](https://developer.mozilla.org/en-US/docs/Web/CSS/object-position) CSS.
However, since the `style` prop is omitted from the underlying `<img>`, you currently must use CSS modules via the `className` prop.
### Solution
This is a proposal to add separate props to the Image component for `objectFit` and `objectPosition` as a way to inline these common styles without using the `style` prop.
### Related
- Related to #18739
- Related to #18780
- Related to #18637
- Related to #18796
| https://github.com/vercel/next.js/issues/18794 | https://github.com/vercel/next.js/pull/18849 | 8e9e9494dd4bc241f4cae06a77f582def81ba719 | b684b110e458ed1f3fa36c7d3e1911c3a55f8100 | "2020-11-04T15:43:28Z" | javascript | "2020-11-05T19:42:55Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,793 | ["packages/next/client/image.tsx", "test/integration/image-component/typescript-style/next.config.js", "test/integration/image-component/typescript-style/pages/invalid.tsx", "test/integration/image-component/typescript-style/test/index.test.js", "test/integration/image-component/typescript-style/tsconfig.json"] | `<Image />` accepts the `style` property even though it is ignored | # Bug report
## Describe the bug
`<Image />` accepts the `style` property even though it is ignored.
## To Reproduce
In a TypeScript file, try to build the following code:
```tsx
<Image layout='fill' src='...' style={{}} />
```
## Expected behavior
A TypeScript error should occur.
| https://github.com/vercel/next.js/issues/18793 | https://github.com/vercel/next.js/pull/18796 | 37ed2d23bbb769306ef5c04a5dd93ca1750ade16 | bb8a49ec8308ee4801261f965bf45f9f7b0feb05 | "2020-11-04T15:35:43Z" | javascript | "2020-11-04T16:13:07Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,782 | ["docs/api-reference/next/router.md"] | [i18n] asPath doesn't contain locale | # Bug report
## Describe the bug
`asPath` doesn't contain locale
## To Reproduce
Define i18n config in `next.config.js`, create pages, then go to `/[locale]/some-page` and check `asPath` in router.
## Expected behavior
`asPath` should contain locale as noted in [docs](https://nextjs.org/docs/api-reference/next/router#router-object)
> asPath - Actual path (including the query) shown in the browser.
## System information
- OS: Windows, Linux
- Browser: Chrome
- Version of Next.js: 10.0.1
- Version of Node.js: 12.16.1
| https://github.com/vercel/next.js/issues/18782 | https://github.com/vercel/next.js/pull/18807 | 5e9d1aae3d1c078878b3d8cdf81c307ad33552e7 | cdaf837f7c1a73eafb78c6fd9e56d4eed45a698b | "2020-11-04T11:21:46Z" | javascript | "2020-11-04T19:44:57Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,756 | ["docs/api-reference/next/image.md", "packages/next/client/image.tsx", "test/integration/image-component/basic/test/index.test.js", "test/integration/image-component/default/pages/priority.js", "test/integration/image-component/default/test/index.test.js"] | v 10 - low Largest Content Painting score with new Image | # Bug report
I had an issue with LCP on previous versions and was eagerly waiting the `Image` feature. I was expecting issue to disappear with the new `Image` component, but not so.
## Describe the bug
The page has only one image, a 2Kb png before any optimization by `Image`. I mean, I am not talking here about any huge hero image. This is as small/light as it gets.
## To Reproduce
<Image
src="/images/main-logo.png"
alt="quiamo logo"
className={classes.branding}
width="180"
height="60"
loading="eager"
priority
/>
1. Go to `https://www.webpagetest.org/lighthouse`
2. Enter `https://quiamo-client.vercel.app/`
3. choose`Germany` as test location
4. See error
## Expected behavior
I was expecting the new `Image` feature to ace Lighthouse, being conceived together with the Google team and all.
## Screenshots
## System information
not relevant
## Additional context
na
| https://github.com/vercel/next.js/issues/18756 | https://github.com/vercel/next.js/pull/20615 | 4e27e00c304b3bf4bac7b76278d75f061f8249e6 | 45b87aa23a63d6c18389fb5be63d0407c55b7e83 | "2020-11-03T18:29:47Z" | javascript | "2020-12-30T21:10:28Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,747 | ["packages/next/next-server/server/render.tsx", "test/integration/gssp-redirect/pages/gsp-blog/[post].js", "test/integration/gssp-redirect/pages/gssp-blog/[post].js"] | When redirecting in GS(S)P pages we should not render the page un-necessarily | When a redirect is returned from `getStaticProps` and `getServerSideProps` the page doesn't need to render so we should return before this point | https://github.com/vercel/next.js/issues/18747 | https://github.com/vercel/next.js/pull/18749 | b87b2d46eacccc09cc81e37e7904427d4fcc990b | f791577569234655823a78999d52467be84aeb95 | "2020-11-03T16:15:34Z" | javascript | "2020-11-03T16:40:50Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,735 | ["packages/next/build/webpack/loaders/next-serverless-loader.ts", "packages/next/lib/load-custom-routes.ts", "packages/next/next-server/server/incremental-cache.ts", "packages/next/next-server/server/next-server.ts", "packages/next/next-server/server/render.tsx", "test/integration/gssp-redirect/pages/index.js", "test/integration/gssp-redirect/test/index.test.js", "test/lib/next-webdriver.js"] | Redirect from getStaticProps only redirects once | # Bug report
## Describe the bug
When I go to a page that should be redirected with `getStaticProps` redirect, it is redirected.
Going to the page that should be redirected again, I get some props that look to be internal, and also get an error in the terminal.
## To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
1. clone https://github.com/balazsorban44/next-example
2. build with `yarn build` and run in production mode with `yarn start`
3. Go to http://localhost:3000/should-redirect
4. You will be redirected to http://localhost:3000/redirected
5. Go to http://localhost:3000/should-redirect again
6. You will stay on http://localhost:3000/should-redirect, and some potentially internal props are shown
7. The terminal also shows an `Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client` error. (see scrennshot for more details)
## Expected behavior
Whenever I go to a page that returns a redirect property, I expect the page to redirect to `destination`
## Screenshots
If applicable, add screenshots to help explain your problem.
A screenshot of what is shown the second time I go to an url that should redirect. The first time, the redirect happened, and I am presented with `/redirected` both in the URL and in the content.
Note: I am using a `pre` tag to show all the `props` sent to the page component
```sh
Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client
at ServerResponse.setHeader (_http_outgoing.js:526:11)
at handleRedirect (/home/balazs/projects/redirect-gsp/node_modules/next/dist/next-server/server/render.js:17:1734)
at renderToHTML (/home/balazs/projects/redirect-gsp/node_modules/next/dist/next-server/server/render.js:28:1094)
at processTicksAndRejections (internal/process/task_queues.js:97:5)
at async /home/balazs/projects/redirect-gsp/node_modules/next/dist/next-server/server/next-server.js:100:66
at async __wrapper (/home/balazs/projects/redirect-gsp/node_modules/next/dist/lib/coalesced-function.js:1:330)
at async Server.renderToHTMLWithComponents (/home/balazs/projects/redirect-gsp/node_modules/next/dist/next-server/server/next-server.js:125:376)
at async Server.renderToHTML (/home/balazs/projects/redirect-gsp/node_modules/next/dist/next-server/server/next-server.js:126:711)
at async Server.render (/home/balazs/projects/redirect-gsp/node_modules/next/dist/next-server/server/next-server.js:69:236)
at async Object.fn (/home/balazs/projects/redirect-gsp/node_modules/next/dist/next-server/server/next-server.js:54:264) {
code: 'ERR_HTTP_HEADERS_SENT'
}
```
## System information
- OS: Ubuntu 20.04
- Browser: Chrome 88.0.4300.0 (Official Build) dev (64-bit) *AND* Firefox 82.0 (64-bit)
- Version of Next.js: 10.0.0
- Version of Node.js: v12.19.0
## Additional context
I have used `create-next-app` for this example, but it occurs in my other Next.js projects that I currently upgraded to next@10 as well. (Meaning it is not `create-next-app` specific)
Question in addition. How is trailing slash handled in these cases? If I go to `http://localhost:3000/should-redirect/` would this have any different effect? As far as I understand, pages with a trailing slash are automatically redirected to their non-trailing slash counterpart. Would this mess something up here? | https://github.com/vercel/next.js/issues/18735 | https://github.com/vercel/next.js/pull/18806 | 8f7f1018d2d2a17caeced66d0130d280e4ae8b00 | a5cb28d907ad34865085d38d008130aaa4667427 | "2020-11-03T11:43:22Z" | javascript | "2020-11-04T22:18:44Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,727 | ["errors/gssp-mixed-not-found-redirect.md", "packages/next/next-server/server/render.tsx", "test/integration/i18n-support/pages/gsp/fallback/[slug].js", "test/integration/i18n-support/test/index.test.js"] | [10.0.0][redirect][notFound] redirect must have a higher priority than notFound | # Bug report
## Describe the bug
In the case where both `redirect` and `notFound` are returned, `notFound` currently has a higher priority. If I redirect somewhere, of course, this page probably doesn't exist.
## To Reproduce
Repository: [next.js-bug-redirect-not-found](https://github.com/rokinsky/next.js-bug-redirect-not-found)
Steps to reproduce the behavior:
1. Go to [http://localhost:3000](http://localhost:3000)
2. See 404 page
## Expected behavior
Displaying
```json
{
"hello": "world"
}
```
with `/redirected` path and `307` status code
## Screenshots
N/A
## System information
- OS: macOS
- Browser (if applies): chrome
- Version of Next.js: 10.0.0
- Version of Node.js: v10.22.1
## Additional context
N/A | https://github.com/vercel/next.js/issues/18727 | https://github.com/vercel/next.js/pull/19076 | d1036539d680c8578e4ad8f98d55e6f99f1e7362 | 9f6d5b14df8cb4eda1c5bb49a744faf3841aa8b0 | "2020-11-03T10:08:28Z" | javascript | "2020-11-11T22:02:11Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,720 | ["docs/api-reference/next/image.md", "packages/next/client/image.tsx", "test/integration/image-component/basic/test/index.test.js", "test/integration/image-component/default/pages/priority.js", "test/integration/image-component/default/test/index.test.js"] | `next/image` priority preloads the largest size | See this thread: https://twitter.com/AdrienHarnay/status/1323384957360918533?s=20
This isn't optimal for mobile devices. | https://github.com/vercel/next.js/issues/18720 | https://github.com/vercel/next.js/pull/20615 | 4e27e00c304b3bf4bac7b76278d75f061f8249e6 | 45b87aa23a63d6c18389fb5be63d0407c55b7e83 | "2020-11-03T03:05:55Z" | javascript | "2020-12-30T21:10:28Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,698 | ["packages/next/client/image.tsx", "packages/next/client/link.tsx", "packages/next/client/use-intersection.tsx", "test/integration/image-component/basic/test/index.test.js", "test/integration/image-component/default/pages/update.js", "test/integration/image-component/default/test/index.test.js", "test/integration/size-limit/test/index.test.js"] | Prop updates for next/image doesn't work | # Bug report
## Describe the bug
When using `next/image` <Image /> component, after changing `src` prop, nothing happens. If `width` or `height` props are modified, image aspect ratio changes. But changing `src` has no effect.
## To Reproduce
Here's sample repo: https://github.com/cactoo/next-image-dynamic-props-issue
Here's deployed sample: https://next-image-dynamic-props-issue.vercel.app/blog/post-1
1. Go to [localhost:3000](localhost:3000)
2. Click `Image 2` then `Image 1` (just have a play with it)
3. Image props are changing, but no effect on image below (well, it changes aspect ratio, but not actual picture)
And 2nd version, that's where I found this bug:
1. Go to [localhost:3000/blog/post-1](localhost:3000/blog/post-1)
2. Then click 'Blog post 2'
3. Page path (param) is changing, but same as above: image changes aspect ratio but not actual picture
## Expected behavior
When updating <Image /> `src`, it should update. Allow dynamic image replacement.
## System information
- OS: macOS
- Browser (if applies) Chrome
- Version of Next.js: 10.0.0
- Version of Node.js: 12.18.3
## Screenshots
GIF below:
## Additional context
It's useful when you for example navigate from one blog post to the other. | https://github.com/vercel/next.js/issues/18698 | https://github.com/vercel/next.js/pull/18904 | 37fb0ad220116181a059a38560dc95667830557e | c8fa2848544b16fe3ab301be91bb05d2f7382596 | "2020-11-02T18:15:12Z" | javascript | "2020-11-06T23:03:15Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,694 | ["docs/advanced-features/i18n-routing.md"] | localeDetection: false behavior should be documented for i18n | > Also note that localeDetection is not mentioned anywhere in the docs. It was just mentioned in the RFC.
Original posted by @javiercr | https://github.com/vercel/next.js/issues/18694 | https://github.com/vercel/next.js/pull/18696 | a8d8f9aef9f39f4c59de85a846400537c77147ba | d07b25a963e42d96356fb633790e2412e1cc743b | "2020-11-02T17:47:49Z" | javascript | "2020-11-02T21:26:01Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,692 | ["packages/next/client/image.tsx", "test/integration/image-component/default/test/index.test.js", "test/integration/image-component/typescript/pages/valid.tsx", "test/integration/image-component/typescript/test/index.test.js"] | Investigate failing image-component tests | These tests appear to be failing sometimes and should be stabilized https://github.com/vercel/next.js/pull/18687#pullrequestreview-521780495 | https://github.com/vercel/next.js/issues/18692 | https://github.com/vercel/next.js/pull/18804 | 80fd3d5d17d398dc9e7ca81c4a214a5d1f7b7272 | b9bf68638b49fb593cea04d7a0c244e7f0dc8c53 | "2020-11-02T16:22:28Z" | javascript | "2020-11-04T21:14:55Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,691 | ["docs/basic-features/data-fetching.md"] | Ensure redirect and notFound return values are documented | We should make sure these new return values are documented for `getStaticProps` and `getServerSideProps`
x-ref: https://github.com/vercel/next.js/pull/16642
x-ref: https://github.com/vercel/next.js/pull/18241 | https://github.com/vercel/next.js/issues/18691 | https://github.com/vercel/next.js/pull/18690 | 85e143e943de2e13afa3c84a9a4e4217cbd3ca7a | ee6b7cab4e333eec9d77b6760298ca0f01476cfb | "2020-11-02T16:19:10Z" | javascript | "2020-11-02T16:58:13Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,680 | ["packages/react-dev-overlay/src/internal/components/CodeFrame/styles.tsx", "packages/react-dev-overlay/src/internal/components/Dialog/styles.ts", "packages/react-dev-overlay/src/internal/components/Toast/styles.ts", "packages/react-dev-overlay/src/internal/styles/Base.tsx", "packages/react-dev-overlay/src/internal/styles/CssReset.tsx"] | Overlay font size with global styles | 
>The font size is affected by the user’s style sheet (I had a global style for pre)
```css
html, body { font-size: 20px }
``` | https://github.com/vercel/next.js/issues/18680 | https://github.com/vercel/next.js/pull/17723 | e4a744653da0567edca794553536f3262b128b6d | 088f374c16d2f1fdcc4d0d541d52e68df844763f | "2020-11-02T14:43:33Z" | javascript | "2020-12-31T19:27:15Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,679 | [".eslintignore", ".github/workflows/build_test_deploy.yml", ".gitignore", ".prettierignore", "azure-pipelines.yml", "run-tests.js", "test/integration/build-output/test/index.test.js"] | Fix Windows CI | https://github.com/vercel/next.js/issues/18679 | https://github.com/vercel/next.js/pull/18931 | 9e59a6b57a0566d0424d3008f80259f1fd829e64 | 3cece4d2adc80c0b3bdea26561adf5e9ab2dbae1 | "2020-11-02T14:41:58Z" | javascript | "2020-11-09T05:56:39Z" |
|
closed | vercel/next.js | https://github.com/vercel/next.js | 18,678 | [".github/workflows/build_test_deploy.yml", "packages/next/build/webpack-config.ts", "packages/next/build/webpack/plugins/font-stylesheet-gathering-plugin.ts"] | Fix React 17/Webpack 5 CI | Webpack 5 seems to have a new HMR behavior. | https://github.com/vercel/next.js/issues/18678 | https://github.com/vercel/next.js/pull/20543 | f02bf210ce4cdb9aaff35dbe2676147fbe54af35 | 5f311cddd263e7312ef29a042febad48ece959b7 | "2020-11-02T14:41:39Z" | javascript | "2020-12-28T19:18:51Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,673 | ["packages/next/build/plugins/collect-plugins.ts", "test/integration/next-plugins/test/index.test.js"] | Experimental Next.js plugin version locking | Our experimental Next.js Plugin system should force the version of a plugin to match that of Next.js, and refuse to run `next build`, `next dev`, or `next start` otherwise. | https://github.com/vercel/next.js/issues/18673 | https://github.com/vercel/next.js/pull/19084 | d2b017c5196c5705a11bc8b67a2ed5cad50d4327 | 41866a135c83cc42d52950d44188d0566b80625b | "2020-11-02T14:10:33Z" | javascript | "2020-11-12T04:59:57Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,672 | ["packages/next/client/link.tsx", "packages/next/client/page-loader.ts", "packages/next/next-server/lib/router/router.ts", "test/integration/build-output/test/index.test.js", "test/integration/i18n-support/test/index.test.js", "test/integration/size-limit/test/index.test.js"] | Fix i18n preload edge-cases | > Noticed while investigating #18503 that preloads can be incorrectly generated when using the locale option since it isn't passed correctly to prefetchData and href and as aren't properly normalized to handle the locale option there. This corrects the behavior and adds tests ensuring the preloads are generated correctly.
Originally posted by @ijjk | https://github.com/vercel/next.js/issues/18672 | https://github.com/vercel/next.js/pull/18511 | ee6b7cab4e333eec9d77b6760298ca0f01476cfb | a529e6736f42af7a458f0e350a49fba97ec8f52a | "2020-11-02T13:46:01Z" | javascript | "2020-11-02T17:22:40Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,651 | ["packages/next/next-server/server/next-server.ts", "packages/next/next-server/server/render.tsx", "packages/next/next-server/server/send-payload.ts", "test/integration/not-found-revalidate/pages/404.js", "test/integration/not-found-revalidate/pages/fallback-blocking/[slug].js", "test/integration/not-found-revalidate/pages/fallback-true/[slug].js", "test/integration/not-found-revalidate/test/index.test.js"] | 404 pages in a SSG site are not revalidated in Next 10 | # Bug report
## Describe the bug
When using Next 9.5, I had an optional catch all route in the root of my `pages` directory `[[...slug]].tsx` which made use of `getStaticPaths` (fallback: false) and `getStaticProps` (revalidate: 30).
This meant that any pages that did not exist in my site would throw the 404 page, which I had a template for in `pages/404.tsx`. That also had a `revalidate: 30`.
With this set up, if I visited mysite.com/cool-page and it 404'd, it would 404. However, if I created /cool-page and revisited it after it had the change to revalidate, I would then see /cool-page.
In Next 10, this is not happening and is preventing me from being able to upgrade to the latest version. When I try in Next 10, I am stuck with a 404 page all of the time, even after creating /cool-page.
## To Reproduce
If you require access to my test Contentful, please reach out and I can provide log in to the CMS and also provide access keys for the env vars (privately)
Run the below code in Next 9.5.5 and also in Next 10
Build the site `npm run build` and run it `npm run start`
go to a non-existent page, you should get a 404 (e.g. /my-page)
In the CMS, change one the pages to have the url from above (e.g. /my-page)
Reload the page, let it revalidate, reload again.
in 9.5.5 it fetches /my-page
in 10 it still 404's
`pages/[[...slug]].tsx`
```
const Index = ({page}) => {
return (
<div>
{page.title}
</div>
)
}
const parsedUrlQueryAsUrlString = (params) => {
const { slug, ...query } = params
let url = '/'
if (Array.isArray(slug)) {
url = `/${slug.join('/')}`
}
else if (typeof slug === 'string') {
url = `/${slug}`
}
return {
url,
query
}
}
export const getStaticProps = async ({ params }) => {
const req = await fetch(`https://cdn.contentful.com/spaces/${process.env.C_SPACE_ID}/environments/master/entries?access_token=${process.env.C_ACCESS_TOKEN}&content_type=standardPage`)
const routes = await req.json()
let { url } = parsedUrlQueryAsUrlString(params)
console.log('url', url)
let pageData
const page = routes.items.find((item) => {
console.log('item', item)
return item.fields.urlPath === url
})
if (page) {
const reqPage = await fetch(`https://cdn.contentful.com/spaces/${process.env.C_SPACE_ID}/environments/master/entries?access_token=${process.env.C_ACCESS_TOKEN}&sys.id=${page.sys.id}`)
pageData = await reqPage.json()
}
return {
props: pageData && {page: pageData.items[0].fields} || {},
revalidate: 5,
}
}
export async function getStaticPaths() {
const req = await fetch(`https://cdn.contentful.com/spaces/${process.env.C_SPACE_ID}/environments/master/entries?access_token=${process.env.C_ACCESS_TOKEN}&content_type=standardPage`)
const routes = await req.json()
const params = routes.items.map((route) => {
// We need to supply false for the root most route
// (e.g. "/" and not "/some/page")
if (route.fields.urlPath === '/') {
return { params: { slug: false } }
}
return {
params: {
slug: route.fields.urlPath.replace('/', '').split('/'),
},
}
})
return {
paths: params,
fallback: false,
}
}
export default Index
```
`404.tsx`
```
const NotFound = () => {
return (
<div>
<p>not found</p>
</div>
)
}
export async function getStaticProps() {
return {
props: {},
revalidate: 5
}
}
export default NotFound
```
## Expected behavior
In Next 10, I was expecting to have the 404.tsx revalidate pages when they become existant like in version 9.5.5
## System information
- OS: macOs
- Browser (if applies) [e.g. chrome, safari]
- Version of Next.js: 9.5.5 and 10
- Version of Node.js: 12.19.0 | https://github.com/vercel/next.js/issues/18651 | https://github.com/vercel/next.js/pull/19165 | c1d2c328524636f2b466508abbdf2fce8532f257 | a32b1f487062c2976aa953a81f46069be2584425 | "2020-11-02T00:14:00Z" | javascript | "2020-11-14T07:12:47Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,648 | ["packages/next/client/image.tsx", "test/integration/image-component/basic/test/index.test.js"] | Bug with 3rd party loaders upscaling images | In PR #18147, we fixed the default loader to prevent upscaling images but we also need to fix for 3rd party loaders. | https://github.com/vercel/next.js/issues/18648 | https://github.com/vercel/next.js/pull/18647 | 377aa4b6509b5ef5a2ebc8af68dd920351c172fa | 3fd1cc3ebb6fc94b890daa790353f998c416cfaf | "2020-11-02T00:01:11Z" | javascript | "2020-11-02T00:30:17Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,643 | ["packages/next/next-server/server/image-optimizer.ts", "test/integration/image-component/default/pages/rotated.js", "test/integration/image-component/default/public/exif-rotation.jpg", "test/integration/image-component/default/test/index.test.js"] | Next.js removes EXIF rotation data | Possibly related, running locally appears to [remove EXIF rotation data](https://github.com/michrome/images/commit/5b36409bb63f708ba3fbb89b38abda1688dd10b6) from images but [all's well when deployed to Vercel](https://images-sigma-rosy.vercel.app/exif). There's some mismatch between local (10.0.0) and Vercel.
<img width="1179" alt="Screenshot 2020-11-01 at 22 39 00" src="https://user-images.githubusercontent.com/596770/97817277-392db880-1c93-11eb-8e5b-6fab57fca4ca.png">
_Originally posted by @michrome in https://github.com/vercel/next.js/issues/18509#issuecomment-720163305_ | https://github.com/vercel/next.js/issues/18643 | https://github.com/vercel/next.js/pull/18687 | 2d5dbc480dce325b1eca79c320797e12e7d3f514 | 85e143e943de2e13afa3c84a9a4e4217cbd3ca7a | "2020-11-01T23:24:07Z" | javascript | "2020-11-02T16:26:03Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,639 | ["packages/next/client/page-loader.ts", "packages/next/next-server/lib/router/router.ts", "test/integration/basepath/test/index.test.js", "test/integration/i18n-support/test/index.test.js", "test/integration/preload-viewport/test/index.test.js", "test/integration/prerender/test/index.test.js"] | Stop prefetching non-static assets (like _next/data) with `<link rel=prefetch>` | # Feature Request
Next.js shouldn't fetch non-static assets with `<link rel=prefetch>`. There are a few things we fetch with `<link rel=prefetch as=fetch>`, which should be ran as `fetch()` themselves.
The `fetch()` API is already low priority, so this change won't introduce asset priority issues.
This has the wonderful side effect of making sure our **data prefetching** works on Safari.
## Additional context
We'd like to start serving all non-static assets with `Cache-Control: no-store`, but this stops `<link rel=prefetch>` from working, thus, we need to eliminate it! | https://github.com/vercel/next.js/issues/18639 | https://github.com/vercel/next.js/pull/18813 | 5d80e684cd022d566c8201b8e0e3f4d248e67956 | bc2282fa38a47accf93131570696c90affa6a994 | "2020-11-01T22:10:12Z" | javascript | "2020-11-05T09:51:24Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,633 | ["packages/next/build/webpack/loaders/next-serverless-loader.ts", "packages/next/client/page-loader.ts", "packages/next/next-server/lib/router/router.ts", "packages/next/next-server/server/next-server.ts", "test/integration/i18n-support-catchall/next.config.js", "test/integration/i18n-support-catchall/pages/[[...slug]].js", "test/integration/i18n-support-catchall/test/index.test.js"] | [10.0.1-canary.4][i18n] undefined locale when navigating to root page | # Bug report
## Describe the bug
I use the `i18n` feature on SSG pages with enabled fallback (`blocking` strategy). The variable `locale` is `undefined` and `params` is not empty in `getStaticProps` context when navigating to the root page using `next/link`.
## To Reproduce
Repository: [next.js-bug-i18n-root-params](https://github.com/rokinsky/next.js-bug-i18n-root-params)
Steps to reproduce the behavior:
1. Go to [http://localhost:3000](http://localhost:3000)
2. Click on `/nl-nl` link
3. See
```json
{
"params": {
"slug": [
"nl-nl"
]
},
"locale": "undefined"
}
```
## Expected behavior
Displaying
```json
{
"params": {},
"locale": "nl-nl"
}
```
## Screenshots
N/A
## System information
- OS: macOS
- Browser (if applies): chrome
- Version of Next.js: 10.0.1-canary.4
- Version of Node.js: v10.22.1
## Additional context
N/A
| https://github.com/vercel/next.js/issues/18633 | https://github.com/vercel/next.js/pull/19063 | 44932612f82638207ab9bebdf159e10d0152fdce | d1036539d680c8578e4ad8f98d55e6f99f1e7362 | "2020-11-01T18:53:20Z" | javascript | "2020-11-11T20:33:44Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,602 | ["packages/next/build/webpack/loaders/next-serverless-loader.ts", "test/integration/serverless/test/index.test.js"] | i18n routing disables incremental static regeneration | I'm trying to find out why static revalidation seems to be disabled while using i18n routing.
Here is a quick demo: https://nextjs-i18n-static-error.wiesson.vercel.app, here is the repo: https://github.com/wiesson/nextjs-i18n-static-error/blob/fix/pre-generation/pages/posts/%5Bslug%5D.js
https://nextjs-i18n-static-error.wiesson.vercel.app/posts/123_a or https://nextjs-i18n-static-error.wiesson.vercel.app/en/posts/123_a does not regenerate with the code below.
In order to trigger regeneration, I have added `const revalidatedAt = new Date().toISOString()` so that the props will be updated every time I visit the page.
```Javascript
import { useRouter } from "next/router";
import posts from "../../posts";
function Post(props) {
const router = useRouter();
if (router.isFallback) {
return <div>Loading...</div>;
}
return (
<div>
Hello from {props.slug} with id: {props.id} at {props.revalidatedAt},
locale {props.locale}
</div>
);
}
export const getStaticPaths = async ({ locales }) => {
const paths = locales.reduce(
(acc, next) => [
...acc,
...posts.map((slug) => ({
params: {
slug,
},
locale: next,
})),
],
[]
);
return {
paths,
fallback: true,
};
};
export const getStaticProps = async ({ params, locale }) => {
const { slug } = params;
if (!slug) {
console.log("slug not found");
console.log({ params, locale });
return {
notFound: true,
};
}
const id = slug.match(/\d{3}/)[0];
// fake some updated props to trigger regeneration
const revalidatedAt = new Date().toISOString();
const props = { slug, id, locale, revalidatedAt };
console.log(props);
return {
props,
revalidate: 1,
};
};
export default Post;
```
I have noticed that during the build on vercel (or in general), the first item that `getStaticProps` receives is empty (but locale is set) and the paths from `getStaticPaths` are valid.
_Originally posted by @wiesson in https://github.com/vercel/next.js/discussions/18443_ | https://github.com/vercel/next.js/issues/18602 | https://github.com/vercel/next.js/pull/18569 | c0ae2041a153c5b65a09da71e065e345db16b097 | fb07e958471c963c01a95cf09dcd47547b692393 | "2020-11-01T04:25:04Z" | javascript | "2020-11-01T04:49:48Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,601 | ["test/integration/dynamic-routing/pages/index.js", "test/integration/dynamic-routing/test/index.test.js"] | router.push() with hash does not work properly | # Bug report
## Describe the bug
When using next/router's `router.push()` (and presumably other methods) with a `hash` parameter, the hash does not properly appear or the url ends up improperly interpolated (in the case of dynamic routes).
## To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
1. Go to https://codesandbox.io/s/nextjs-router-push-with-hash-589dd
2. Click on `Static page with hash (good)` button
* Notice URL changes with hash properly appended
3. Click on `Dynamic page with hash (bad)` **button**
* Notice URL does _not_ have hash appended <-- bad!
3. Click on `Dynamic page with hash (bad)` **button** again
* Notice URL is not properly interpolated with dynamic route params, although hash is added <-- bad!
3. Click on `Dynamic page with hash (bad)` **link**
* Notice URL changes with hash properly appended (just to showcase <Link> works properly)
## Expected behavior
The URL should have the hash properly appended the first time the dynamic page button is clicked, and the URL should stay properly interpolated with dynamic route params the second time the dynamic page button is clicked.
## Screenshots
If applicable, add screenshots to help explain your problem.
## System information
- OS: Windows
- Browser (if applies) Chrome
- Version of Next.js: 10.0.0
- Version of Node.js: v10.21.0
## Additional context
Add any other context about the problem here.
| https://github.com/vercel/next.js/issues/18601 | https://github.com/vercel/next.js/pull/21363 | a1b8fb49e61da91f1ca15bba0ccc8588ec2675a4 | f6304cde92c7a9fc20ff21b64d1a3900e153e3c5 | "2020-11-01T03:59:05Z" | javascript | "2021-01-20T09:45:58Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,600 | ["test/integration/image-optimizer/public/test.ico", "test/integration/image-optimizer/test/index.test.js"] | .ico support for next/image | # Feature request
## Is your feature request related to a problem? Please describe.
The `Image` component from `next/image` should allow `.ico` files. Currently using a `.ico` file gives the error: `Input buffer contains unsupported image format`, which seems to come from `sharp`.
## Describe the solution you'd like
`next/image` should support `.ico` files as the optimization step can be skipped for `.ico` files. | https://github.com/vercel/next.js/issues/18600 | https://github.com/vercel/next.js/pull/19025 | 18494fe3fb84a81fb895de0ac4ced28bc9747f51 | 530b14616f64071b7207fb7aa0184673eae74fd6 | "2020-11-01T03:10:13Z" | javascript | "2020-11-10T17:49:37Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,596 | ["packages/next/client/image.tsx", "test/integration/image-component/default/pages/layout-responsive.js", "test/integration/image-component/default/test/index.test.js"] | Respond with all image widths for responsive images | # Feature request
We should make both layout=fill and layout=responsive use all deviceWidths in the srcset.
| https://github.com/vercel/next.js/issues/18596 | https://github.com/vercel/next.js/pull/18594 | 9569f5a31ac627f271260ab2f30572036ce3fa5b | f8c32e556cd25efe56fa3e10eaaad8d753310151 | "2020-11-01T00:24:05Z" | javascript | "2020-11-01T00:26:57Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,563 | ["packages/next/next-server/server/api-utils.ts", "packages/next/next-server/server/image-optimizer.ts", "packages/next/next-server/server/send-payload.ts", "test/integration/image-optimizer/test/index.test.js"] | Cache-Control not automatically generating ETags and Last-Modified, RE: Image Optimization Next10 | # Bug report
When using the new Image Optimization feature, it appears as though even though Cache-Control is being set, the response headers aren't including what should be automatically generated.
## Describe the bug
As an example for all my static images, I am adding cache-control.
e.g.
```
const setHeadersForImages = (req, res) => {
res.setHeader('Cache-Control', 'public,max-age=2592000000,immutable')
return handle(req, res)
}
//This is how I was adding the headers PRE NEW IMAGE OPTIMIZATION
server.get('*.jpg', (req, res) => setHeadersForImages(req, res))
server.get('*.svg', (req, res) => setHeadersForImages(req, res))
server.get('*.png', (req, res) => setHeadersForImages(req, res))
//This is how I am adding the headers POST NEW IMAGE OPTIMIZATION
server.get(/^\/_next\/image/, (req, res) => setHeadersForImages(req, res))
```
I can see in the response headers that the cache control is being added just fine. But pre using the new Image Optimization, my response headers looked like:
```
cache-control: max-age=31536000
content-length: 774746
content-type: image/png
date: Fri, 30 Oct 2020 20:32:17 GMT
etag: "92703e9f4803a0755947a4b150c7d9af"
last-modified: Mon, 28 Sep 2020 14:56:05 GMT
```
**and now while using the new feature they look like.**
```
Cache-Control: public,max-age=2592000000,immutable
Connection: keep-alive
Content-Type: image/webp
Date: Fri, 30 Oct 2020 20:39:42 GMT
Transfer-Encoding: chunked
X-Powered-By: Express
```
The ETag and date last modified is missing...hmmmm.
## To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
1. Implement a new Image Optimization component, using a static image.
2. Ensure in server.js you are doing
```
const setHeadersForImages = (req, res) => {
// res.setHeader('Last-Modified', (new Date()).toUTCString())
// res.setHeader('ETag', etag(req.originalUrl, { weak: true }))
res.setHeader('Cache-Control', 'public,max-age=2592000000,immutable')
return handle(req, res)
}
server.get(/^\/_next\/image/, (req, res) => setHeadersForImages(req, res))
```
3. Check your response headers for the image in the network tab. See that ETag and Last-Modified are not present.
## Expected behavior
Expected behaviour is that the ETag and Last-Modified would be generated as they normally are when normal images are used, using the normal img tag.
## System information
- OS: macOS
- Browser Chrome
- Version of Next.js: [e.g. 10.0.0]
- Version of Node.js: [e.g. 12.18.3]
| https://github.com/vercel/next.js/issues/18563 | https://github.com/vercel/next.js/pull/18986 | d5daa06654d95730354d04635d033f875aa22bed | 9573426599860dd839b25eec2a27fec2c9d85f5a | "2020-10-30T20:51:32Z" | javascript | "2020-11-10T04:40:26Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,541 | ["docs/api-reference/next/image.md", "packages/next/client/image.tsx", "test/integration/image-component/default/pages/index.js", "test/integration/image-component/default/pages/invalid-src.js", "test/integration/image-component/default/pages/invalid-unsized.js", "test/integration/image-component/default/pages/layout-fill.js", "test/integration/image-component/default/test/index.test.js", "test/integration/image-component/typescript/pages/invalid.tsx", "test/integration/image-component/typescript/pages/valid.tsx", "test/integration/image-component/typescript/test/index.test.js"] | Add layout=fill to Image component | Add new option, `layout=fill`, to stretch image to the parent container
This will cover the remaining cases for `unsized` so we can probably use this instead of #18469.
Additionally, we should make both `layout=fill` and `layout=responsive` use all `deviceWidths` in the srcset. | https://github.com/vercel/next.js/issues/18541 | https://github.com/vercel/next.js/pull/18562 | 9de734a299dbc66095a918240a7bc933145a2bf9 | 9569f5a31ac627f271260ab2f30572036ce3fa5b | "2020-10-30T14:47:20Z" | javascript | "2020-10-31T22:34:06Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,536 | ["packages/next/client/image.tsx", "test/integration/image-component/default/pages/invalid-src-proto-relative.js", "test/integration/image-component/default/test/index.test.js"] | Image component fails with leading double slash (protocol-relative URLs) | Out of curiosity, I was browsing the image optimiser code that landed in Next.js 10 (congrats and thank you!) when I noticed a potential bug in the `isAbsolute` condition branch:
https://github.com/vercel/next.js/blob/426331883638911dec6f93517d6b5406abac1d97/packages/next/next-server/server/image-optimizer.ts#L67
This assumes that [protocol-relative URLs](https://www.paulirish.com/2010/the-protocol-relative-url/) won't be passed to the optimiser, for example `//url.com/image.jpg` will request `https` when the caller is on `https`, and `http` when the caller is on `http`.
This might be an edge case, but consider any folks migrating from their current `img` tags to the `next/image` component and using protocol-relative URLs; they'll encounter a bug where `next-server/image-optimizer` treats the URL as a file path.
An alternative would be to test a regex pattern for URLs:
```ts
if (!/^(https?:)?\/\//.test(url)) {
// Relative URL/path
} else {
// Absolute URL/path
}
``` | https://github.com/vercel/next.js/issues/18536 | https://github.com/vercel/next.js/pull/18809 | cdaf837f7c1a73eafb78c6fd9e56d4eed45a698b | 80fd3d5d17d398dc9e7ca81c4a214a5d1f7b7272 | "2020-10-30T13:04:04Z" | javascript | "2020-11-04T20:47:49Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,523 | ["examples/i18n-routing/README.md"] | i18n-routing Vercel button is not correct | # Bug report
## Describe the bug
Deploy buttons on i18n-routing examples currently have URLs like this:
https://vercel.com/import/project?template=https://github.com/vercel/next.js/tree/canary/examples/amp
so now this is for examples/amp.
## Expected URLs
The should be for i18n-routing and URLs should be like this
https://vercel.com/import/project?template=https://github.com/vercel/next.js/tree/canary/examples/i18n-routing | https://github.com/vercel/next.js/issues/18523 | https://github.com/vercel/next.js/pull/18524 | b7daae418bc1f447a786709cc89ab33ec982ce80 | 61981da9e00493da9aa1cfa8c95ed7a75fde27ee | "2020-10-30T08:22:37Z" | javascript | "2020-10-30T15:44:21Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,510 | ["packages/next/build/webpack/loaders/next-serverless-loader.ts", "packages/next/client/index.tsx", "packages/next/next-server/server/next-server.ts", "test/integration/i18n-support/pages/_app.js", "test/integration/i18n-support/pages/another.js", "test/integration/i18n-support/pages/gsp/fallback/[slug].js", "test/integration/i18n-support/pages/gsp/no-fallback/[slug].js", "test/integration/i18n-support/pages/index.js", "test/integration/i18n-support/pages/links.js", "test/integration/i18n-support/test/index.test.js"] | [10.0.0][i18n] Desync between client and server with new internationalized routing | # Bug report
There seems to be a desync between the client and the server when accessing a route other than '/' with a locale different from the locale that is automatically selected by the framework. Also, I'm not sure if it's related but a desync also happens when you reload the index page with a "#". For example, reloading the url "http://localhost:3000/en#" gives a desync warning too.
## To Reproduce
Steps to reproduce the behavior:
1. Clone this repo https://github.com/SelvinM/i18n-example
2. Make sure your browser language is english
3. Run the project with "yarn dev"
4. Go to this route "http://localhost:3000/gssp""
5. Reload
## Expected behavior
No desync should happen.
## Screenshots
I get this warning on the project I'm working on:
This warning happens after you follow the steps I described earlier:
## System information
- OS: Windows 10
- Browser Chrome
- Version of Next.js: 10.0.0
- Version of Node.js: 14.11.0
## Additional context
This desync can become the culprit of bugs. For example, on the project I'm working on, I think the desync is the reason as to why the Link component in a language selector is not routing to the correct route after a server side redirect. | https://github.com/vercel/next.js/issues/18510 | https://github.com/vercel/next.js/pull/18708 | c8d26edf5794c65a6b9d83b11ffbd6fb8412c9c5 | 7b6a61a750d888a1fa0c213c9b1916db1e21e740 | "2020-10-30T00:46:06Z" | javascript | "2020-11-02T23:00:41Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,509 | ["packages/next/next-server/server/image-optimizer.ts", "test/integration/image-optimizer/test/index.test.js"] | next/image serving large PNGs to Safari | # Bug report
## Describe the bug
next/image is serving (large) PNG images to Safari when JPEG should be used.
## To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
1. Edit the [Next Image Component Example](https://github.com/vercel/next.js/tree/canary/examples/image-component) to include a JPEG file (see [commit](https://github.com/michrome/images/commit/3f26a7410795457942b5e148e05d9ae26d3fa37d)).
2. `npm run dev` or `npm run build && npm run start`
3. Inspect or copy the JPEG image from Safari
4. See a large PNG is returned
## Expected behavior
A JPEG to be served. Notes:
1. A JPEG is correctly served when deployed to Vercel.
2. this behaviour only affects Safari: Firefox is correctly serving WEBP.
## Screenshots
[video.mov.zip](https://github.com/vercel/next.js/files/5461835/video.mov.zip)
## System information
- OS: macOS Catalina 10.15.7
- Browser: Safari v14.0
- Version of Next.js: v10.0.0
- Version of Node.js: v12.18.2
## Other information
<img width="930" alt="Screenshot 2020-10-29 at 23 35 00" src="https://user-images.githubusercontent.com/596770/97643406-77329e80-1a3f-11eb-9905-1ed99ff763a7.png">
| https://github.com/vercel/next.js/issues/18509 | https://github.com/vercel/next.js/pull/18646 | 5c97b9775517705eeed88623097343d43b64f760 | 377aa4b6509b5ef5a2ebc8af68dd920351c172fa | "2020-10-29T23:36:42Z" | javascript | "2020-11-01T23:53:36Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,505 | ["packages/next/build/webpack/loaders/next-serverless-loader.ts", "test/integration/i18n-support/pages/404.js", "test/integration/i18n-support/test/index.test.js"] | [10.0.0][i18n][notFound][Vercel] undefined locale and locales in getStaticProps on custom 404-page | # Bug report
## Describe the bug
I use the `notFound` and `i18n` features on SSG pages with enabled fallback (`blocking` strategy). Variables `locale` and `locales` are `undefined` in `getStaticProps` context when `notFound` occurs. This happens only when an app is deployed to Vercel.
## To Reproduce
Repository: [next.js-bug-i18n-not-found](https://github.com/rokinsky/next.js-bug-i18n-not-found)
Steps to reproduce the behavior:
1. Deploy the app to Vercel
2. Go to the website, e.g. [https://next-js-bug-i18n-not-found.vercel.app](https://next-js-bug-i18n-not-found.vercel.app)
2. See
```json
{
"is404": true,
"locale": "",
"locales": []
}
```
## Expected behavior
Displaying
```json
{
"is404": true,
"locale": "en",
"locales": [
"en",
"nl-nl",
"de-de"
]
}
```
## Screenshots
N/A
## System information
- OS: macOS
- Browser (if applies): chrome
- Version of Next.js: 10.0.0
- Version of Node.js: v10.22.1
## Additional context
Works fine locally in dev and prod modes. | https://github.com/vercel/next.js/issues/18505 | https://github.com/vercel/next.js/pull/18513 | 629884af7d3ced97b8c2ec7aebdfb1a3a5d808f0 | 426331883638911dec6f93517d6b5406abac1d97 | "2020-10-29T21:52:37Z" | javascript | "2020-10-30T01:42:28Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,468 | ["docs/basic-features/data-fetching.md"] | Add documentation for `fallback: 'blocking'` | These docs still have to be added 👍 | https://github.com/vercel/next.js/issues/18468 | https://github.com/vercel/next.js/pull/18568 | d10a6eca46e4132e7ae8e76062acc1f666e8cdf9 | 38a24a9b91e066bbb8bec3d1684098173a7c9178 | "2020-10-29T12:16:53Z" | javascript | "2020-11-09T02:38:04Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,452 | ["packages/next/next-server/lib/router/router.ts", "test/integration/i18n-support/test/index.test.js"] | Internationalized Routing Error: lang attribute of <html> is not updated after router.push(...,{ locale: 'XX' }) in a non-dynamic getStaticProps page | # Bug report
Internationalized Routing Error: The lang attribute of <html> is not updated after router.push(...,{ locale: 'XX' }) in a non-dynamic getStaticProps page
## Describe the bug
I have activated the internationlized routing with sub-path routing as described in https://nextjs.org/docs/advanced-features/i18n-routing
I am testing it within a static generated page (with getStaticProps), where through a button there will be a routing to another locale of the same page (via router.push(...,{ locale: 'XX' })):
```
router.push(
router.pathname,
router.asPath,
{ locale: menuItem.value }
);
```
By checking with the inspector of the browser, I realize that the routing works (the page with the new locale is shown), but the lang attribute of <html> is not updated.
```
<html lang="en">
```
And after router.push(...,{ locale: "fr" }) it shows still:
```
<html lang="en">
```
## Expected behavior
The expected behaviour would be to have initially
```
<html lang="en">
```
And after router.push(...,{ locale: "fr" }) it would show:
```
<html lang="fr">
```
## System information
- OS: Windows 10
- Browser: chrome, firefox <any>
- Version of Next.js: 10.0.0
- Version of Node.js: 12.19.0
| https://github.com/vercel/next.js/issues/18452 | https://github.com/vercel/next.js/pull/18699 | a529e6736f42af7a458f0e350a49fba97ec8f52a | 4e7835c95d4280a231f6d813777c1fa79d6b6c08 | "2020-10-29T09:50:50Z" | javascript | "2020-11-02T18:54:20Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,416 | ["packages/next/pages/_document.tsx", "test/integration/image-component/basic/pages/index.js", "test/integration/image-component/basic/public/styles.css", "test/integration/image-component/basic/test/index.test.js"] | Image component preload prioritizes image above CSS | # Bug report
## Describe the bug
The image component, when used with the `priority` attribute places the <link rel="preload"> higher than the preload tag for CSS. This can cause a large delay in FCP.
## To Reproduce
See any page using a priority image, such as https://demo.vercel.store/
## Expected behavior
The image preload should appear **between the css preloads and the javascript preloads**
| https://github.com/vercel/next.js/issues/18416 | https://github.com/vercel/next.js/pull/18864 | cc0dcf96d5a64b393138bda9d35ef26a0f72d9d5 | 74909ecfd40412132e6dda7bdebd76c2dcc05274 | "2020-10-28T19:58:56Z" | javascript | "2020-12-30T22:12:46Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,415 | ["packages/next/client/image.tsx", "packages/next/next-server/server/config.ts", "packages/next/next-server/server/image-config.ts", "packages/next/next-server/server/image-optimizer.ts", "test/integration/image-optimizer/test/index.test.js", "test/unit/image-rendering.unit.test.js"] | Unable to test components that import "next/image" | # Bug report
## Describe the bug
Using jest and react-testing-library, tests that run on components that use the new Image component fail with the following error:
```
TypeError: Cannot destructure property 'deviceSizes' of 'imageData' as it is undefined.
> 1 | import Image from "next/image";
| ^
2 |
```
## To Reproduce
As far as my testing has gone just simply running a test against any component that imports Image from "next/image" causes this error. I've setup a simple vanilla nextjs repo that adds jest and react-testing-library, along with a component that uses the Image component here: https://github.com/spencewood/next-image-test. Running the tests on this repo yields the above error:
```
> yarn test
```
## Expected behavior
I would expect the tests to run normally.
## System information
- OS: macOS 10.15
- Version of Next.js: 10.0
- Version of Node.js: 12.18
| https://github.com/vercel/next.js/issues/18415 | https://github.com/vercel/next.js/pull/19107 | 4866c47d9d9b39515d6e57118955e86c85630c4c | 5562daf7a160e62fd4f78eca257ba957ad64074c | "2020-10-28T19:54:27Z" | javascript | "2020-11-12T19:24:08Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,413 | ["docs/api-reference/next/image.md", "packages/next/client/image.tsx", "test/integration/image-component/default/pages/sizes.js", "test/integration/image-component/default/test/index.test.js"] | Image component `sizes` property does not work | # Bug report
## Describe the bug
When using the Image component, the `sizes` property doesn't work as described in the docs.
When using the Image component, the image is resized to match the container width which is size of the `width` attributes that we passed, or fit 100% of the viewport if the image is larger than the screen, ignoring the `sizes` attribute completely.
Example of code:
```js
<Image
width="800px"
height="456.8px"
sizes="(max-width: 500px) 100px"
src="/next.png"
alt="Next.js"
/>
```
## To Reproduce
I created a codesandbox example with the exact problem:
1. Go to https://codesandbox.io/s/elated-neumann-u81mr?file=/pages/index.js
2. Resize the browser window width to be bigger than 500px to see that the image is the size of `width 800px` and `height 456.8px`
3. Resize the browser window width to be smaller than 500px to see that the image will fit to 100% of the screen, not respecting the `sizes` prop that should tell the image to be `100px`
## Expected behavior
I expect the image to have exactly a 100px when the view port is smaller then 500px, respecting the sizes attribute.
## Screenshots
**Bigger viewport width**
**Smaller viewport width**
## System information
- OS: Ubuntu 20.04
- Browser: Chrome
- Version of Next.js: 10.0.0
- Version of Node.js: v12.18.3
| https://github.com/vercel/next.js/issues/18413 | https://github.com/vercel/next.js/pull/19128 | 9174b7a337b181a6db1f0f20dd03325b6e1cc1c3 | 20ab35128ccab50ec08f90d8360044adec66c95d | "2020-10-28T19:51:50Z" | javascript | "2020-11-13T04:30:41Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,398 | ["docs/api-reference/next/image.md", "packages/next/client/image.tsx", "test/e2e/next-image-forward-ref/app/images/test.png", "test/e2e/next-image-forward-ref/app/pages/framer-motion.js", "test/e2e/next-image-forward-ref/index.test.ts"] | Image Component doesn't forwardsRef | # Bug report
## Describe the bug
Refs aren't properly supported in Image.
```
import React, { useState, useCallback } from 'react'
import Image from 'next/image'
const NextImage = ({ src }) => {
const [width, setWidth] = useState(0)
const [height, setHeight] = useState(0)
const ref = useCallback((node) => {
console.log(node)
}, [])
return <Image ref={ref} src={src} width={width} height={height} />
}
```
This code shows that Image does not forwardRef to img DOM element.
## To Reproduce
1. Add Image component to your page
2. Add ref via `useCallback` hook
3. Try to do something within callback function
## Expected behavior
Image component should pass ref function to img element.
## System information
- OS: macOS
- Browser (if applies) [Chrome, Safari]
- Version of Next.js: 10.0.0
- Version of Node.js: 15.0.0
| https://github.com/vercel/next.js/issues/18398 | https://github.com/vercel/next.js/pull/43193 | 0f195f0270c0be1099bca5a8bbf870b5194d6b08 | c4b6bb85219dea4068234aedd0f935f2879bdc44 | "2020-10-28T16:02:07Z" | javascript | "2022-11-25T15:08:50Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,397 | ["packages/next/next-server/server/next-server.ts", "test/integration/i18n-support/pages/dynamic/[slug].js", "test/integration/i18n-support/pages/index.js", "test/integration/i18n-support/test/index.test.js"] | Local sub-route with param renders 404 in production app | I have a route with a param (`/src/pages/items/[id].tsx`), and am testing the built-in i18n routing.
```
// next.config.js
module.exports = {
i18n: {
locales: [
'fr',
'en-US',
],
defaultLocale: 'fr'
}
};
```
The app renders correctly the page `/en-US/items/0` in local. However, in production it returns a 404 (app hosted on Vercel). If I navigate to this url from within the app, it works correctly though. It really happens with routes with params, a page `/en-US/items` renders fine.
Is it a bug or I am doing something wrong ? | https://github.com/vercel/next.js/issues/18397 | https://github.com/vercel/next.js/pull/18930 | 782046840186ef4ad1bb61f4af360bc6958d2a25 | 90a86e672385c3aa9d1774de61c222fe3c20c227 | "2020-10-28T16:01:53Z" | javascript | "2020-11-08T02:18:13Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,372 | ["packages/next/client/image.tsx", "test/integration/image-component/default/test/index.test.js", "test/integration/image-component/typescript/pages/valid.tsx", "test/integration/image-component/typescript/test/index.test.js"] | Image component fails when using image data URI | # Bug report
## Describe the bug
When passing an image data URI to the Next.js image component an error is thrown.
## To Reproduce
Pass data URI to the Next.js image component:
Example:
```javascript
import Image from 'next/image';
<Image src="data:image/gif;base64,R0lGODlhAQABAAD/ACwAAAAAAQABAAACADs=">
```
## Expected behavior
The simplest solution and expectation would be to pass the URI directly to the `img` tag without any modification or optimization.
## Screenshots
Not applicable but error reported on the debug overlay is:
```
Error: Invalid src prop (data:image/gif;base64,R0lGODlhAQABAAD/ACwAAAAAAQABAAACADs=) on `next/image`, hostname is not configured under images in your `next.config.js`
```
## System information
- OS: Windows
- Browser (if applies) Chrome, Firefox, Edge
- Version of Next.js: 10.0.0
- Version of Node.js: 12.9.0
## Additional context
None.
| https://github.com/vercel/next.js/issues/18372 | https://github.com/vercel/next.js/pull/18804 | 80fd3d5d17d398dc9e7ca81c4a214a5d1f7b7272 | b9bf68638b49fb593cea04d7a0c244e7f0dc8c53 | "2020-10-28T09:00:22Z" | javascript | "2020-11-04T21:14:55Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,369 | ["packages/next/client/image.tsx", "packages/next/client/link.tsx", "packages/next/client/use-intersection.tsx", "test/integration/image-component/basic/test/index.test.js", "test/integration/image-component/default/pages/update.js", "test/integration/image-component/default/test/index.test.js", "test/integration/size-limit/test/index.test.js"] | [next/image] Image doesn't update on page change | # Bug report
## Describe the bug
I'm currently building a website that shows information about tv shows. In the tv show page, when can see all information such as pictures, name, etc. When clicking on a similar tv show, next/link redirects to the correct page, the title updates but the images stay the same, they never update. I need to _hard reload_ the page to see image change.
## To Reproduce
(Reproducing will not longer work since I implement the fix on my website, refer to the video below to see the bug)
1. Go to [soononnetflix.vercel.app](https://soononnetflix.vercel.app)
2. Click on any show, for exemple [this one](https://soononnetflix.vercel.app/show/21/the-crown)
3. Scroll down to 'similar tv shows' and click on one.
4. You'll see the cover image stay the same as the previous one.
This project is not open sourced but if you got issues to reproduce the bug, I'll make a little repository to help you reproduce it.
## Expected behavior
It should update to the correct image that match the show. Reload the page in your browser to see the right images.
## Screenshots
I've made [this video](https://youtu.be/LYvolLWbtuc) that shows the bug.
## System information
- OS: macOs
- Browser : chrome
- Version of Next.js: 10.0.0
- Version of Node.js: 12.13.0
| https://github.com/vercel/next.js/issues/18369 | https://github.com/vercel/next.js/pull/18904 | 37fb0ad220116181a059a38560dc95667830557e | c8fa2848544b16fe3ab301be91bb05d2f7382596 | "2020-10-28T08:50:03Z" | javascript | "2020-11-06T23:03:15Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,360 | ["examples/with-next-page-transitions/pages/about.js"] | [with-next-page-transitions example] Loading spinner does not show up | # Bug report
## Describe the bug
When I install and run the example, no loading spinner is visible. The "hello world" page fades out, I see a white screen for about 2 seconds, and then the "about us" page appears.
## To Reproduce
`npm i && npm run dev` then click on the "About us" button.
## Expected behavior
I expect to see a loading spinner before "about us" page appears.
## System information
- OS: Windows 10
- Browser: Chrome 86.0.4240.111
- Version of Next.js: 10.0.0
- Version of Node.js: 12.18.3
| https://github.com/vercel/next.js/issues/18360 | https://github.com/vercel/next.js/pull/18527 | 3bbb35c323592ed195559fead31a0f2f21b6b721 | a6660729ea82fbcb26cfe7c89637b1af37255c9f | "2020-10-28T03:30:10Z" | javascript | "2020-10-30T18:48:55Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,351 | ["docs/api-reference/next/image.md", "packages/next/client/image.tsx", "test/integration/image-component/default/pages/layout-fixed.js", "test/integration/image-component/default/pages/layout-intrinsic.js", "test/integration/image-component/default/pages/layout-responsive.js", "test/integration/image-component/default/public/wide.png", "test/integration/image-component/default/test/index.test.js", "test/lib/next-webdriver.d.ts", "test/lib/wd-chain.js"] | Image component isn't fluid | # Bug report
## Describe the bug
The Image component wrapper has a fixed width and can't be changed.
## To Reproduce
I created a codesandbox to illustrate the issue.
https://codesandbox.io/s/image-component-isnt-fluid-vsho0
This is a really common layout, images in columns. They have a final width but they should still be fluid.
If I remove the `width` and `height` props then the `Image` component will use the `deviceSizes` setting which is not ideal as those are generic.
## Expected behavior
I was wondering if we could turn that fixed size off as the padding on the internal wrapper already takes care of maintaining the image ratio.
## Additional context
I understand why that is there, it helps mitigate layout shifting, and I appreciate that but it's really rare when an image is fixed, 100% of the time. The web has passed that point long ago.
I also wanna start a conversation. Should the `Image` component use the `sizes` attribute and respect media queries? Using this codesandbox as an example, these images should probably be served as the following `sizes="(max-width: 768px) 768px, 269px"`. We want a bigger image that will be 100% of the viewport and then go back to their max size.
| https://github.com/vercel/next.js/issues/18351 | https://github.com/vercel/next.js/pull/18491 | 426331883638911dec6f93517d6b5406abac1d97 | afa04d22dbbe78c20479e72d26e3f07a958924ad | "2020-10-27T23:28:28Z" | javascript | "2020-10-30T14:33:34Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,342 | ["packages/next/client/index.tsx", "test/integration/css-fixtures/transition-react/pages/index.js", "test/integration/css-fixtures/transition-react/pages/other.js", "test/integration/css-fixtures/transition-react/pages/other.module.css", "test/integration/css/test/index.test.js", "test/integration/size-limit/test/index.test.js"] | CSS is reset on route change in production build | # Bug report
## Describe the bug
When you navigate to a different route in Next.js 10.0.0 module specific css is reset. This is problematic, because I keep the component mounted for a bit longer to do some animations with `framer-motion`. In Next.js 9 this was not an issue.
Edit: By the comments it seems like this bug first occured in 9.5.5
## To Reproduce
Here is a very basic example. If you run the app in dev mode it works fine, but the production build doesn't. The css is immediately removed if you click on the link.
https://v10-test.vercel.app/
Source code: https://github.com/mxmtsk/v10-test
To keep the page component mounted until the animation is finished, I'm using `AnimatePresence` from `framer-motion`
Edit: Here's the same example using Next 9.5.1, where everything works fine: https://v10-test-git-v9.mxmtsk.vercel.app/
## Expected behavior
CSS should not be reset.
## System information
- OS: macOS
- All Browsers
- Version of Next.js: 10.0.0
- Version of Node.js: 12.13.1
| https://github.com/vercel/next.js/issues/18342 | https://github.com/vercel/next.js/pull/19125 | f108dbf2c9acf37e8be0477a312f22b763761237 | 9174b7a337b181a6db1f0f20dd03325b6e1cc1c3 | "2020-10-27T21:27:24Z" | javascript | "2020-11-13T03:57:15Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 18,338 | ["packages/next/next-server/lib/router/router.ts", "test/integration/trailing-slashes/pages/external-linker.js", "test/integration/trailing-slashes/test/index.test.js"] | Trailing slashes appends slashes to external links | # Bug report
## Describe the bug
Using the configuration Trailing slashes true, <Link></Link> components append the slash to external URLs.
## To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
Repo: https://github.com/conanbatt/nextjs-export-slashes
Steps:
```
// next.config.js
module.exports = {
trailingSlash: true,
}
```
And
```
// pages/index.js
<Link href="https://example.com">Without slash</Link>
```
## Expected behavior
1- External links do not append trailing slashes.
2- Export and next dev exhibit the same behavior? (```next dev``` does not append trailing slash)
## Screenshots
Result
```
<h1 class="Home_title__3DjR7">Welcome to <a href="https://nextjs.org">Without slash</a></h1>
<h1 class="Home_title__3DjR7">Welcome to <a href="https://nextjs.org/">With slash?</a></h1>
```
## Additional context
If I remember right, Link components should not be used for external urls. This used to be caught by Next. It would be nice to detect external or absolute paths for trailing slash purposes.
| https://github.com/vercel/next.js/issues/18338 | https://github.com/vercel/next.js/pull/18595 | 6c282a3df4df178ea121234baa1a7868c0389b82 | c88872cea059b520913d8c9eb08bb1063dd85a7b | "2020-10-27T20:52:36Z" | javascript | "2020-11-12T18:10:40Z" |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.