status
stringclasses 1
value | repo_name
stringclasses 13
values | repo_url
stringclasses 13
values | issue_id
int64 1
104k
| updated_files
stringlengths 11
1.76k
| title
stringlengths 4
369
| body
stringlengths 0
254k
⌀ | issue_url
stringlengths 38
55
| pull_url
stringlengths 38
53
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
unknown | language
stringclasses 5
values | commit_datetime
unknown |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed | odoo/odoo | https://github.com/odoo/odoo | 13,687 | ["addons/purchase/purchase.py", "addons/sale/sale.py"] | [9.0] Different Tax Computation for Sales Order and Invoice | Impacted versions:
[9.0]
Tested in runbot http://174550-9-0-10dcec.runbot10.odoo.com/
Steps to reproduce:
Set the Tax Calculation Rounding Method to "Round Globally"
Create a Sales Order with the following lines with 7% taxes
1) 5,095.20
2) 523.20
3) 80.64
4) 54.12
5) 182.00
6) 186.20
Create a Sales Invoice with the same lines with 7% taxes
Current behavior:
The total taxes in Sales Order are $477.48
The total taxes in Sales Invoice are $477.50
Expected behavior:
Both the total taxes in Sales Order and Sales Invoice should be 477.50
Video/Screenshot link (optional):
| https://github.com/odoo/odoo/issues/13687 | https://github.com/odoo/odoo/pull/15019 | 2c66f7bc7f3b84d5386a3ab6866aa4349ea0a1c0 | 291a94192c77e75e1f338a92ccc71898d7484433 | "2016-10-06T07:37:29Z" | python | "2017-01-11T10:45:05Z" |
closed | odoo/odoo | https://github.com/odoo/odoo | 13,242 | ["addons/point_of_sale/data/point_of_sale_data.xml", "addons/point_of_sale/models/pos_config.py", "addons/point_of_sale/models/pos_order.py", "addons/point_of_sale/models/pos_session.py", "addons/point_of_sale/tests/test_frontend.py", "addons/point_of_sale/views/pos_config_view.xml"] | On closing POS "Next Number" is taken from selected Sales Journal Sequence | Impacted versions:
9.0x
Steps to reproduce:
1. Go to Accounting, create customer invoice and validate. Check the Invoice-Number (for example: INV/2016/0010)
2. Go to Point of Sale and select New Session
3. Add any product or just close & confirm the session
4. Close the POS Session (Validate Closing & Post Entries)
5. Create new customer invoice and validate it. Check the Invoice-Number.
Current behavior:
Gap between the first and the last invoice because of the closed POS-Session.
Expected behavior:
No Gap between the two invoices like in Version 8.
I've tested this behaviour on a 8 and a 9 runbot and my own system. There is no gap on 8 but on 9. I think this is not a feature but a bug. I can't find the missing sequence-numbers in any Journals or in the invoice-list.
The only way to avoid this, is to select another Sales Journal in the POS-Configuration. But then you can't create an invoice from the POS.
Is it possible to get the "lost" invoice-numbers somewhere? We are not allowed to have gaps in the invoice-numbering here in Germany.
| https://github.com/odoo/odoo/issues/13242 | https://github.com/odoo/odoo/pull/13627 | 9674d9ce846bb6b2fe23da50d278e740e2176011 | b5b0d36b31606e6c462a83080c66ec06b326ed45 | "2016-08-22T09:49:27Z" | python | "2016-09-29T13:50:12Z" |
closed | odoo/odoo | https://github.com/odoo/odoo | 12,872 | ["addons/website_sale/views/templates.xml", "addons/website_sale_delivery/models/sale_order.py"] | [8.0] website_sale_delivery ecommerce delivery price is shown without tax | Impacted versions: 8.0, tested on runbot
Steps to reproduce: set the tax for the product "delivery" as included in the price
Current behavior: on the cart and checkout pages of the ecommerce you see the price of delivery without tax
Expected behavior: delivery price should be shown with tax included
| https://github.com/odoo/odoo/issues/12872 | https://github.com/odoo/odoo/pull/23746 | 75d9a2b4db9fbad00114832186b7d4e3983124ba | b77ff40e931b18011f8ae5ee4f22d9706377eb2b | "2016-07-21T16:22:21Z" | python | "2018-03-20T13:29:59Z" |
closed | odoo/odoo | https://github.com/odoo/odoo | 12,832 | ["addons/hr_payroll_account/hr_payroll_account.py"] | [9.0] Payslip Does not correctly calculate or use "Date Account" | Impacted versions:
9.0c/e
Steps to reproduce:
Install hr_payroll_account.
Create a Payslip with a period earlier in the year.
Confirm Payslip
Current behavior:
"Account Date" (on accounting tab an on journal entries) is today
Expected behavior:
"Account Date" should be a date in the period (presumably the last day) as the help for this field describes. "Keep empty to use the period of the validation(Payslip) date."
Also, filling the date in advance (while its draft) gives you the incorrect assumption that it will be honored at all. It will not.
I will submit a pull request to fix for this shortly.
| https://github.com/odoo/odoo/issues/12832 | https://github.com/odoo/odoo/pull/13021 | 566e0a27063bef95b0f99f49d9631f2de97dfcf5 | 36026bc7719eda42eabc9f3aa3711b56b0e22f09 | "2016-07-18T18:43:27Z" | python | "2016-08-04T10:56:26Z" |
closed | odoo/odoo | https://github.com/odoo/odoo | 12,827 | ["addons/sale_stock/i18n/sale_stock.pot", "addons/sale_stock/sale_stock.py"] | [sale_stock] Quantities in "Picking Information" warning not showing enough decimal places | We have a customer whose base unit for selling stuff is in thousands. However stock can be as low as 0.001 thousands, but that last decimal place isn't displayed in the Picking Information warning.
Impacted versions:
- 8.0
## Steps to reproduce:
- New database
- Edit admin user: Enable Technical Features
- Install 'stock' and 'sale'
- UK accounting chart with defaults (though probably doesn't matter)
- Settings -> Configuration -> Warehouse, tick:
- Use packages: pallets, boxes, ...
- Manage different units of measure for products
- Allow to define several packaging methods on products
- Create a unit of measure with:
- Name: Thousand(s)
- Product Category: Unit
- Type: Bigger than the reference Unit of Measure
- Bigger Ratio: 1000
- Rounding Precision: 0.00100
- Create product:
- Name: Widget
- Product Type: Stockable Product
- Unit of Measure: Thousand(s)
- Inventory tab:
- Packaging / Configurations: Add new item:
- Quantity by Package: 1
- Package Logistic unit: Create and Edit... :
- Name: Pack of 1000
- Type: Pack
- Height: 10
- Width: 10
- Length: 10
- Empty package weight: 0.5
- Save
- Edit product
- Inventory Tab:
- Quantity On Hand -> Update
- 10
- Apply
- Sales -> Quotations -> Create:
- Customer: Create and Edit
- Is a company: ticked
- Name: Acme
- Order Lines: Add an item
- Product: Widget
- Quantity: 0.5 Thousand(s)
- Packaging: Pack of 1000
## Current behavior:
Warning message strips out decimal places and appears to use wrong UoM name:
```
Picking Information ! : You selected a quantity of 0 Units.
But it's not compatible with the selected packaging.
Here is a proposition of quantities according to the packaging:
EAN: (n/a) Quantity: 1.0 Type of ul: Pack of 1000
```
## Expected behavior
Use the chosen UoM name, and the number of decimal places specified in that
UoM's "Rounding Precision" field (which as 0.00100, so should have three d.p.)
```
Picking Information ! : You selected a quantity of 0.500 Thousand(s).
But it's not compatible with the selected packaging.
Here is a proposition of quantities according to the packaging:
EAN: (n/a) Quantity: 1.000 Type of ul: Pack of 1000
```
| https://github.com/odoo/odoo/issues/12827 | https://github.com/odoo/odoo/pull/12944 | 8ceb9438d13cc4b947d70b629552d0d9c5f57fa4 | f57f55966df338c78e19403f0ace932c64585852 | "2016-07-18T14:00:03Z" | python | "2016-07-28T11:36:30Z" |
closed | odoo/odoo | https://github.com/odoo/odoo | 12,644 | ["addons/delivery/stock.py"] | [8.0] Delivery method - Invoices | Impacted versions:
8.0
Steps to reproduce:
1. Go to a runbot instance
2. Activate the following options
*\* Settings > Warehouse > Products > Manage different units of measure for products
*\* Settings > Accounting > Accounting & Finance > Analytic accouting
3. Desactivate the following option
*\* Settings > Accounting > Analytic accouting > Sale > Use multiple analytic accounts on sales
4. Create a Sale order
*\* Add 2 qty of the product iMac
*\* Add in quote the delivery method "Normal Delivery Charges" and set 2 qty
*\* Set an analytic account under Contract/Analytic
*\* Set the field Create Invoice to "On delivery Order"
5. Deliver only 1 quantity of the iMac and then create the invoice
6. Deliver the last quantity of the iMac and then create the invoice
Current behavior:
The first invoice contains 2 qty of the Transport
The second invoice contains 1 qty of the Transport, has no analytic account set, has no UOM set
Expected behavior:
The behavior should be consistent for both invoices
Option 1) On both invoices 2 qty of the transport with analytic, UOM, etc
Option 2) On the first invoices 2 qty of the transport but no transport on the second invoices because its considered as already invoiced.
Video/Screenshot link (optional):
| https://github.com/odoo/odoo/issues/12644 | https://github.com/odoo/odoo/pull/12697 | ef83f798d5ca15c470976571184c809fe99f4724 | 965024902db880af005a9688a277b28e076a4a7e | "2016-06-30T14:22:02Z" | python | "2016-07-11T12:30:16Z" |
closed | odoo/odoo | https://github.com/odoo/odoo | 12,629 | ["addons/sale_stock/i18n/sale_stock.pot", "addons/sale_stock/models/sale_order.py"] | [sale_stock] Quantities in "Not enough stock" warning don't honour rounding precision on Unit of Measure | We have a customer whose base unit for selling stuff is in thousands. However stock can be as low as 0.001 thousands, but that last decimal place isn't displayed in the stock warning.
As you'll see from the example of "actual behaviour" below this is confusing.
Impacted versions:
- 8.0
Steps to reproduce:
- Install product and sale
- Create a unit of measure with:
- Name: Thousand(s)
- Product Category: Unit
- Type: Bigger than the reference Unit of Measure
- Bigger Ratio: 1000
- Rounding Precision: 0.00100
- Create a product 'Widget' with
- type = Stockable Product
- UoM = Thousand(s)
- Create a Quotation
- Add to the Sales Order a line
- Choose Product: Widget
- Change Quantity to: 0.001 Thousand(s)
Current behavior:
Configuration Error!
```
Not enough stock ! : You plan to sell 0.00 Thousand(s) but you only have 0.00 Thousand(s) available !
The real stock is 0.00 Thousand(s). (without reservations)
```
Expected behavior:
Configuration Error!
```
Not enough stock ! : You plan to sell 0.001 Thousand(s) but you only have 0.000 Thousand(s) available !
The real stock is 0.000 Thousand(s). (without reservations)
```
| https://github.com/odoo/odoo/issues/12629 | https://github.com/odoo/odoo/pull/12949 | 5982b857f867c97e7a252db103088e38a9eca062 | 9975e5272309363d55d0e8bcfe1e55b9459f8242 | "2016-06-29T16:09:04Z" | python | "2016-07-28T13:28:43Z" |
closed | odoo/odoo | https://github.com/odoo/odoo | 12,312 | ["openerp/tools/translate.py"] | [9.0] Semi-critical /web formatting issue after latest commit (Reproducible on Runbots) | <h1>Impacted versions:</h1>
9.0
<h1>Environment:</h1>
All Major Browsers (latest versions of Chrome, Safari, Firefox)
Runbot - latest 9.0 commit
<h1>Steps to reproduce:</h1>
<ol>
<li>Login to backend</li>
<li>View Sale Order List View (fonts and some formatting have been lost)</li>
<li>View inside a Sale Order - massive formatting problems, sale order document/page view is corrupted</li>
</ol>
<h1>Current behavior:</h1>
<ol>
<li>Huge formatting problems in the backend when related to fonts, icons, etc..</li>
<li>View inside a Sale Order - massive formatting problems, sale order document/page view is corrupted</li>
</ol>
<h1>Expected behavior:</h1>
Backend /web views are as they have always been, without formatting problems.
<h1>Video/Screenshot link (optional):</h1>
<img src="https://cloud.githubusercontent.com/assets/2337666/15846044/ceff033c-2cab-11e6-8455-af2ca5ac765c.gif"/>
| https://github.com/odoo/odoo/issues/12312 | https://github.com/odoo/odoo/pull/12316 | 2179f53a65865f43c4847bedfc99cf5eb6a56018 | 3d9ccef81d4ccdc314957b304fe61940282a3d2c | "2016-06-07T04:32:18Z" | python | "2016-06-07T12:16:12Z" |
closed | odoo/odoo | https://github.com/odoo/odoo | 12,163 | ["addons/stock_account/stock_account.py"] | [9.0] wrong value used in average cost if exchange rate has moved | Impacted versions:
9.0
Steps to reproduce:
- Create a product with costing method set to average
- Create a purchase order for the product in a foreign currency, and validate
- Change the exchange rate for the currency in question
- Receive the product
Current behavior:
- Stock quants get the correct cost behind the scene (PO value at current rate)
- Accounting journals get the correct value
- Stock move price unit has been updated to the correct value
- **Average cost on product file is the PO value at old rate**
Expected behavior:
- Average should have been updated in line with the new rate
Video/Screenshot link (optional):
| https://github.com/odoo/odoo/issues/12163 | https://github.com/odoo/odoo/pull/12165 | 5b299a20941e008b610511f9b327a6da201f7ed2 | 31f50efe0a10cb5aff27e38255eee967bdf0b829 | "2016-05-25T05:45:57Z" | python | "2016-05-25T08:54:09Z" |
closed | odoo/odoo | https://github.com/odoo/odoo | 12,096 | ["addons/website_forum/controllers/main.py", "doc/api_integration.rst"] | Odoo Forum Notification: Missing subject and link to the question | Impacted versions:
Latest Odoo Forum
Steps to reproduce:
Get a nofitication from the Odoo forum (by subscription or by a comment to your posting)
Current behavior:
The notification email contain the subject: "Re: False" and contains no link to the forum post.
Expected behavior:
The notification email contains the title of the forum post and a link to the forum post.
Video/Screenshot link (optional):
| https://github.com/odoo/odoo/issues/12096 | https://github.com/odoo/odoo/pull/12139 | 5da59c248b117fc51bb738fd822d6700cf12a76e | e32ba845de73a251fba4f12af45c880898cb4344 | "2016-05-19T05:36:38Z" | python | "2016-05-27T09:30:40Z" |
closed | odoo/odoo | https://github.com/odoo/odoo | 11,919 | ["addons/account/models/account_move.py"] | Error 'Cannot create unbalanced entry' thrown when duplicating journal entries | Impacted versions: 9.0, 9.0 enterprise
Steps to reproduce:
On current runbot duplicate any posted journal entry which is balanced
Current behavior:
Error message "Cannot create unbalanced entry" is shown
Expected behavior:
New Journal entry is created in state 'draft'
Video/Screenshot link (optional):
| https://github.com/odoo/odoo/issues/11919 | https://github.com/odoo/odoo/pull/12331 | dd1e67d263b08ce7ff54d8a8cc76a4f409fab76a | af2c69f0e5acae89372c6aead7f02af2d38f6820 | "2016-05-04T07:24:53Z" | python | "2016-06-09T08:03:05Z" |
closed | odoo/odoo | https://github.com/odoo/odoo | 11,902 | ["addons/mail/mail_message.py"] | [8.0] Security error when you add a user without access to a document type to an object of that type. | Impacted versions:
8.0
Steps to reproduce:
To reproduce this one, you have to configure outgoing and incoming server and mail aliases
see https://youtu.be/-HzDGh9C9Jc
Current behavior:
If you add a user which has no acces on a object (purchase.order in this case) as follower on a record of this object **AFTER someone has responded by email on this record**, and if you send an message on this record, an exception is raised at the connection of the user added as a follower.
Expected behavior:
No exceptions should be raised at the connection of the user added as a follower.
Video/Screenshot link (optional):
https://youtu.be/-HzDGh9C9Jc
| https://github.com/odoo/odoo/issues/11902 | https://github.com/odoo/odoo/pull/12090 | 0fc73a20675e7fc8d21a521d5b95e9397a368220 | fac04424caa095511b0f809b351fc2af0a5942cc | "2016-05-03T09:05:28Z" | python | "2016-05-18T12:07:54Z" |
closed | odoo/odoo | https://github.com/odoo/odoo | 11,876 | ["addons/web/static/src/js/framework/formats.js", "addons/web/static/src/js/views/search_inputs.js", "addons/web/static/test/search.js"] | [9.0C & 9.0E] Date format for specific languages is fully ignored in searches | Impacted versions: 9.0 Community & 9.0 Enterprise.
Steps to reproduce:
- Install the Dutch language
- Change the user its active language to Dutch
- Go to a search view and search for the current date (02/05/2016 in Dutch)
Example supplier invoices:
The date is the second of may, 2016. The system converts this to the 5th of february 2016.
This problem is found all across Odoo: at supplier invoices, customer invoices, journal entries, ...:
Current behavior:
Date formats are not converting to the active language its date format.
Expected behavior:
Date formats convert to the active language its date format, not the native format.
| https://github.com/odoo/odoo/issues/11876 | https://github.com/odoo/odoo/pull/11971 | a775f437c872747b59777873a5c959a70789c8d1 | 50b94ef079b2fd9f4e9201ea8f977fadab109aea | "2016-05-02T10:55:38Z" | python | "2016-05-10T09:19:22Z" |
closed | odoo/odoo | https://github.com/odoo/odoo | 11,602 | ["addons/product/product.py"] | Can't sort attribute values by attribute | Impacted versions: 8.0
Steps to reproduce:
- Create a database with demo data
- Go to sales, product categories & attributes, attribute values
- Click on 'attribute' column name
Current behavior:
Attribute values are sorted by attribute database ID
Expected behavior:
Attribute values are sorted by attribute name
| https://github.com/odoo/odoo/issues/11602 | https://github.com/odoo/odoo/pull/11951 | c8dc4c8daf8a3a2f8e52448c164a30d3cbeb524c | 48a35ca8f9469c47da40157005d5ec09afe7b511 | "2016-04-05T15:41:12Z" | python | "2016-05-06T14:38:47Z" |
closed | odoo/odoo | https://github.com/odoo/odoo | 11,396 | ["addons/project_issue/project_dashboard.xml", "addons/project_issue/project_issue.py"] | [9.0C & 9.0E] Opening project issues randomly opens project tasks view | Impacted versions:
9.0 Community & 9.0 Enterprise
Steps to reproduce:
- Open up a V9 runbot
- Go to projects and click on the issues item, for example for the project 'Research & Development':
- The project tasks view is opened in place of the project issues. (notice that this only happens every once in a while, about once in five attempts) Example:
Current behavior:
Every once in a while (about one out of five attempts) after clicking on the issues button it will open up the project tasks, not the issues.
Expected behavior:
When you click on the issues the view with all issues opens, not the view for all tasks.
| https://github.com/odoo/odoo/issues/11396 | https://github.com/odoo/odoo/pull/11572 | b3cfec189bf42abcb89b5c157c08f92ce45a3d01 | 5de3900258b458a4f5af964c78c0c644518bd9d7 | "2016-03-18T09:28:31Z" | python | "2016-04-01T09:55:18Z" |
closed | odoo/odoo | https://github.com/odoo/odoo | 11,395 | ["addons/project_issue/project_issue.py"] | [9.0C & 9.0E] Contact onchange is ignored when creating new project issue | Impacted versions:
9.0 Community & 9.0 Enterprise
Steps to reproduce:
- Open up a V9 Enteprise Runbot
- Go to projects and open up the issues for the project 'Data Import/Export Plugin'
- Click on 'Create' to create a new issue. You will see the following form:
Notice how the Contact is filled in with the name 'Delta PC' and that no e-mail is filled in. When you open up this contact its form you will see he has an e-mail filled in:
- Remove the contact on the issue, click somewhere else and now fill in the contact again. The moment you add the contact again the onchange function goes off and the e-mail is filled in automatically:
Current behavior:
When clicking on 'Create' for creating a new issue on a project the customer its e-mail is not automatically filled in because the onchange does not seem to have an effect on the record.
Expected behavior:
When click on 'Create' for creating a new issue on a project the customer his e-mail is filled in automatically (provided there is one).
| https://github.com/odoo/odoo/issues/11395 | https://github.com/odoo/odoo/pull/11570 | d3557de74604536aac4a4529dae424b07800f11c | 1d0b9da3f0cc5a639b4997d19f31d8abf765db0c | "2016-03-18T09:20:43Z" | python | "2016-04-01T09:12:39Z" |
closed | odoo/odoo | https://github.com/odoo/odoo | 11,342 | ["addons/warning/warning.py", "addons/warning/warning_view.xml"] | [9.0] onchange_picking_type not called anymore on a change of a partner after installing warning module | #### Impacted versions:
[9.0]
#### Steps to reproduce:
1) Create a new database with demo data
2) Install warning module
3) Go in Inventory app
4) Create a new delivery order
5) Select the partner "Steven Hamilton" (My Company, Chicago, Steven Hamilton)
#### Current behavior:
The Destination Location Zone (location_dest_id) doesn't change. It stays at "Partner Locations/Customers"
#### Expected behavior:
The destination location should be changed to "Physical Locations/My Company, Chicago: Transit Location".
6) Remove the warning module
7) Go in Inventory app
8) Create a new delivery order
9) Select the partner "Steven Hamilton" (My Company, Chicago, Steven Hamilton). See the Destination Location Zone changing.
#### Problem
The warning module override the on_change of stock module. Therefore it inhibit the execution of the original on_change.
I didn't look at the code, but I'm fairly sure the on_change on partner_id in stock module was added after the warning module was done. By testing this addition in the stock module alone it worked fine, but with warning module, it doesn't.
Very easy to break a module in both directions (parent and child)! The new @api.onchange works better because each module can have their own onchange method with different name without having to override any method. Very sad that we need to rewrite code in v7 when we hit a module that already have an onchange method on a field!
| https://github.com/odoo/odoo/issues/11342 | https://github.com/odoo/odoo/pull/11525 | 11d3aaf8485ea25dcb45716c18df75fb13d0ba7e | 04f896b135f3054496b0badc2b07afd2e8f03c19 | "2016-03-15T16:59:18Z" | python | "2016-03-29T14:00:31Z" |
closed | odoo/odoo | https://github.com/odoo/odoo | 10,538 | ["addons/account/models/account.py", "addons/account/tests/test_tax.py", "addons/point_of_sale/static/src/js/models.js"] | [9.0][Enterprise] Base calculation amount is wrong when multiple taxes | **Base calculation amount is wrong when multiple taxes**
Impacted versions:
- 9.0 Enterprise (code from 2016/01/18)
Steps to reproduce:
I need to be able to have multiple taxes as followed:
- Customer Price 1000
- Base calculation for VAT $ 870 (reversed tax)
- IVA 13.00% 21402 DÉBITO FISCAL $ 130.00
- IT 3% 2140106 Impuesto a las Transacciones (Calculated on Price+VAT) $ 30.00
- IT2 3% 5310901 Impuesto a las Transacciones (Calculated on Price+VAT) $ -30.00
Current behavior:
Setup VAT:
SO is correct only using the VAT:
IT setup:
Besides the tax group sequence is
- impuestos =0
- IT = 20
Now adding the IT as second
Invoice is incorrect as well:
Finally accounting Entries:
Expected behavior:
Taxes amount are properly calculated but not base calculation.
in SO, invoice and accounting entry the base calculation is wrong (1000 instead of 870 expected)
It seems that the value is overidden when the second tax is computed.
| https://github.com/odoo/odoo/issues/10538 | https://github.com/odoo/odoo/pull/18275 | dc5bb0d6b2806e81d1dd32839e6a600c8782bad3 | 5afb5ecd04cf49be6bedb655b187b19a65e1e02d | "2016-01-20T02:06:40Z" | python | "2017-10-16T09:35:08Z" |
closed | odoo/odoo | https://github.com/odoo/odoo | 8,934 | ["addons/l10n_ca/account_chart.xml"] | [9.0] Canadian Chart of Accounts: Incorrect Type for Tax receivable and Tax to pay | With the Canadian Chart of Account, the following tax accounts are created with the wrong Type.
118100 - GST receivable, PST/GST receivable and all HST receivable are created with an account Type set to Current Liabilities. This is incorrect, the Type should be Current Assets.
213100 - GST to pay, PST/GST to pay and all HST to pay are created with an account Type set to Current Assets. This is incorrect, the Type should be Current Liabilities.
| https://github.com/odoo/odoo/issues/8934 | https://github.com/odoo/odoo/pull/8959 | bcad465c93adf119a1a017c89f6f3d4b9954a80b | df3192ef87d07ab305169e0d0056bebabecf1314 | "2015-10-07T00:40:30Z" | python | "2018-04-04T13:46:51Z" |
closed | odoo/odoo | https://github.com/odoo/odoo | 8,923 | ["addons/account/report/report_vat.py"] | [8.0] Tax codes report raise QWebException: "chart_tax_id" while evaluating | Impacted versions:
- 8.0
Steps to reproduce:
1. open Accounting / Configuration / Taxes / Tax Codes
2. open any Tax Code
3. press Print / Account Tax
Current behavior:
QWebException: "chart_tax_id" while evaluating
"get_lines(data['form']['based_on'], data['form']['company_id'], data['form']['chart_tax_id'])"
Details: http://paste.ubuntu.com/12689915/
Expected behavior:
- Tax Code report
Test on:
- different 8.0 instances
- runbot: http://105817-8-0-6b6d73.runbot8.odoo.com/web
| https://github.com/odoo/odoo/issues/8923 | https://github.com/odoo/odoo/pull/14795 | e8019a23c2d83d77e4b4a45cd56894e2397abc4d | a3ee4d19147fe14fbc8791e4d5f7bb5750a46c6d | "2015-10-06T13:43:51Z" | python | "2016-12-21T09:05:12Z" |
closed | odoo/odoo | https://github.com/odoo/odoo | 5,479 | ["addons/stock/views/stock_quant_views.xml"] | Consumable products should not follow real time valuation | Hello, according tot he following post:
https://www.odoo.com/forum/how-to/warehouse-management-6/whats-the-difference-between-quants-lots-and-products-55243
, consumable products do not follow inventory valuation. I can understand that, because for those products, such as office supplies, you are not really interested to maintain a valuated inventory, but probably you want to use them as a stockable item in your warehouse (because it's a physical item).
You then should recognize the expense in the supplier invoice for the value of the products ordered, and from then on those products should remain un-valuated in your inventory.
However I can see that in Odoo 8.0 you can create a consumable product with real time inventory valuation. The system then keeps posting accounting entries when the product is received into inventory, or when it's issued.
Unexperienced users tend to make mistakes, and can create inconsistent consumable products with real-time inventory valuation set. In my opinion the application should prevent this from happening.
| https://github.com/odoo/odoo/issues/5479 | https://github.com/odoo/odoo/pull/20456 | 33a04354eb2b3897035c7206411fa0130b312313 | afccad3578b49a6c097f8e42c848683138acf8a2 | "2015-02-26T09:37:19Z" | python | "2017-10-25T08:52:09Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 59,669 | ["docs/03-pages/01-building-your-application/03-data-fetching/03-get-server-side-props.mdx"] | Docs: Grammar error in `getServerSideProps` page | ### What is the improvement or update you wish to see?
To update the following sentence:
> `getServerSideProps` is a Next.js function that can be used fetch data and render the contents of a page at request time.
to be:
> `getServerSideProps` is a Next.js function that can be used to fetch data and render the contents of a page at request time.
### Is there any context that might help us understand?
n/a
### Does the docs page already exist? Please link to it.
https://nextjs.org/docs/pages/building-your-application/data-fetching/get-server-side-props | https://github.com/vercel/next.js/issues/59669 | https://github.com/vercel/next.js/pull/59670 | 3e6edbf8508661339993fc7c8344c94b52ccefed | 10a4ffcc10de681ad5c3ee39586f0983035a081c | "2023-12-15T20:29:47Z" | javascript | "2023-12-18T17:44:52Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 59,333 | ["packages/next/src/server/web/edge-route-module-wrapper.ts", "test/e2e/app-dir/edge-route-catchall/app/edge/[[...slug]]/route.ts", "test/e2e/app-dir/edge-route-catchall/app/layout.tsx", "test/e2e/app-dir/edge-route-catchall/edge-route-catchall.test.ts", "test/e2e/app-dir/edge-route-catchall/next.config.js"] | Catchall route incorrectly maps the route to the slug for edge runtime | ### Link to the code that reproduces this issue
https://github.com/mastoj/slugstripping/tree/main
### To Reproduce
1. Run application
2. Go to http://localhost:3000/api/edge/one/two
### Current vs. Expected behavior
**Current behavior:**
Output is: `{"slug":["two"]}`
**Expected behavior:**
Output should be: {"slug":["one","two"]}
You can see expected behavior if you go to http://localhost:3000/api/node/one/two
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 22.5.0: Thu Jun 8 22:22:23 PDT 2023; root:xnu-8796.121.3~7/RELEASE_ARM64_T6020
Binaries:
Node: 18.17.0
npm: 9.6.7
Yarn: N/A
pnpm: 8.6.10
Relevant Packages:
next: 14.0.4-canary.45
eslint-config-next: 14.0.3
react: 18.2.0
react-dom: 18.2.0
typescript: 5.3.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
App Router
### Additional context
This is in the current canary version, 14.0.4-canary.45, but not in 14.0.3. It is also only present in the edge runtime. | https://github.com/vercel/next.js/issues/59333 | https://github.com/vercel/next.js/pull/59343 | 61b825be3937dc1f095cde942d623c79559b2c53 | 7a733dfd3440ac121ea3c5ff277ee732539e39ed | "2023-12-06T13:44:04Z" | javascript | "2023-12-06T20:21:28Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 59,310 | ["packages/next-swc/crates/core/src/optimize_server_react.rs", "packages/next-swc/crates/core/tests/fixture/optimize_server_react/2/output.js", "packages/next-swc/crates/core/tests/fixture/optimize_server_react/3/output.js", "packages/next-swc/crates/core/tests/fixture/optimize_server_react/6/input.js", "packages/next-swc/crates/core/tests/fixture/optimize_server_react/6/output.js", "packages/next-swc/crates/core/tests/fixture/optimize_server_react/7/input.js", "packages/next-swc/crates/core/tests/fixture/optimize_server_react/7/output.js"] | optimize server react not working in some cases | ### Link to the code that reproduces this issue
i test it on next.js repo
### To Reproduce
1. add the following failed test cases in `next-swc/creates/core/tests/fixture/optimize_server_react`
2. cargo test
failed case 1
```tsx
import { useState, useEffect, useLayoutEffect } from 'react';
import React from 'react';
const Component = ({ children, fallback })=>{
const [mounted, setMounted] = useState(false);
useEffect(()=>setMounted(true), []);
if (!mounted) {
return fallback ?? /* @__PURE__ */ jsx(Fragment, {});
}
return children;
};
export { Component };
```
failed case 2
```tsx
import { useEffect, useLayoutEffect, useMemo } from 'react'
import * as React from 'react'
export default function App() {
useEffect(() => {
console.log('Hello World')
}, [])
useLayoutEffect(() => {
function foo() {}
return () => {}
}, [1, 2, App])
useLayoutEffect(() => {}, [runSideEffect()])
useEffect(() => {}, [1, runSideEffect(), 2])
useEffect(() => {}, getArray())
const a = useMemo(() => {
return 1
}, [])
React.useEffect(() => {
console.log('Hello World')
})
return (
<div>
<h1>Hello World</h1>
</div>
)
}
```
### Current vs. Expected behavior
Should remove `useEffect & useLayout` in `failed case 1 & 2`
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 23.1.0: Mon Oct 9 21:27:24 PDT 2023; root:xnu-10002.41.9~6/RELEASE_ARM64_T6000
Binaries:
Node: 18.18.0
npm: 9.8.1
Yarn: 1.22.19
pnpm: 7.29.1
Relevant Packages:
next: 13.4.12
eslint-config-next: N/A
react: 18.2.0
react-dom: 18.2.0
typescript: 5.1.6
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Not sure
### Additional context
_No response_ | https://github.com/vercel/next.js/issues/59310 | https://github.com/vercel/next.js/pull/59390 | d5291fad497bfefc246543d907bcadc9038b1c20 | b141f3b278f08e7979181a76aaab5f6624eddd76 | "2023-12-06T02:37:34Z" | javascript | "2023-12-08T11:44:25Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 59,195 | ["Cargo.lock", "Cargo.toml", "packages/next/package.json", "pnpm-lock.yaml", "test/turbopack-tests-manifest.json"] | `next dev --turbo` leads to OOM with usage of `transpilePackages` | ### Link to the code that reproduces this issue
https://github.com/miselin/next-turbo-oom-example
### To Reproduce
1. `npm run dev`
2. Visit http://localhost:3000/ - this should compile and load correctly
3. Visit http://localhost:3000/oom - this will hang and the `next-server` process memory usage will grow until the process is terminated
4. Terminate the process
5. Comment out `"@react-dnd/invariant",` line in `next.config.js`
6. `npm run dev`
7. Visit http://localhost:3000/oom - this will compile much faster now and not lead to an OOM
### Current vs. Expected behavior
I expect that this compiles correctly or throws an error, rather than appearing to hang and continuing to consume memory in the background. On my Mac laptop, this leads to memory pressure. On my Linux system, this eventually consumes all memory and leads to an OOM (or swapping, if it were enabled).
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 22.6.0: Thu Nov 2 07:43:57 PDT 2023; root:xnu-8796.141.3.701.17~6/RELEASE_ARM64_T6000
Binaries:
Node: 20.10.0
npm: 10.2.3
Yarn: 1.22.19
pnpm: 8.11.0
Relevant Packages:
next: 14.0.4-canary.35
eslint-config-next: N/A
react: 18.2.0
react-dom: 18.2.0
typescript: 5.3.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Turbopack (--turbo)
### Additional context
This is a minimal reproduction of a problem we're facing on a much larger codebase - discussed a little [on Twitter](https://x.com/matt_iselin/status/1731026946069602712?s=20).
This only happens with `--turbo`.
Profiles from failed compiles show up like this if it helps zone in on the potential root cause faster:
<img width="1396" alt="image" src="https://github.com/vercel/next.js/assets/73127/aafeac8d-29ba-4d96-9cee-16bf611cf1ce"> | https://github.com/vercel/next.js/issues/59195 | https://github.com/vercel/next.js/pull/59232 | b089529caff6a610b549e5a26543801d85439d94 | 669a48cb4d219a78182ef24f91f8758d4cf1d758 | "2023-12-02T20:03:45Z" | javascript | "2023-12-04T09:50:15Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 59,053 | ["packages/next/src/build/webpack/loaders/next-app-loader.ts", "packages/next/src/build/webpack/plugins/flight-client-entry-plugin.ts", "packages/next/src/server/app-render/entry-base.ts", "test/e2e/app-dir/global-error/catch-all/app/[lang]/[...slug]/page.js", "test/e2e/app-dir/global-error/catch-all/app/[lang]/global-error.js", "test/e2e/app-dir/global-error/catch-all/app/[lang]/layout.js", "test/e2e/app-dir/global-error/catch-all/index.test.ts", "test/e2e/app-dir/global-error/next.config.js"] | Build error while using global-error file inside app/[lang] folder | ### Link to the code that reproduces this issue
https://github.com/mertafor/next-error-template-issue
### To Reproduce
Try to build the minimal repo and get a build error
```
> [email protected] build /Users/mertdaglaroglu/Documents/WebProjects/Reactive/comnet/next-error-template-issue
> next build
⚠ Invalid next.config.mjs options detected:
⚠ Expected object, received boolean at "experimental.serverActions"
⚠ See more info here: https://nextjs.org/docs/messages/invalid-next-config
⚠ Server Actions are available by default now, `experimental.serverActions` option can be safely removed.
▲ Next.js 14.0.4-canary.25
✓ Creating an optimized production build
✓ Compiled successfully
✓ Linting and checking validity of types
✓ Collecting page data
Generating static pages (0/5) [ ]Error: Could not find the module "/Users/mertdaglaroglu/Documents/WebProjects/Reactive/comnet/next-error-template-issue/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/client/components/error-boundary.js#" in the React Client Manifest. This is probably a bug in the React Server Components bundler.
at eS (/Users/mertdaglaroglu/Documents/WebProjects/Reactive/comnet/next-error-template-issue/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:129803)
at /Users/mertdaglaroglu/Documents/WebProjects/Reactive/comnet/next-error-template-issue/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:142519
at Object.toJSON (/Users/mertdaglaroglu/Documents/WebProjects/Reactive/comnet/next-error-template-issue/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:143612)
at stringify (<anonymous>)
at eE (/Users/mertdaglaroglu/Documents/WebProjects/Reactive/comnet/next-error-template-issue/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:131997)
at eR (/Users/mertdaglaroglu/Documents/WebProjects/Reactive/comnet/next-error-template-issue/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:132440)
at Timeout._onTimeout (/Users/mertdaglaroglu/Documents/WebProjects/Reactive/comnet/next-error-template-issue/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:129220)
at listOnTimeout (node:internal/timers:573:17)
at process.processTimers (node:internal/timers:514:7)
Error: Could not find the module "/Users/mertdaglaroglu/Documents/WebProjects/Reactive/comnet/next-error-template-issue/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/client/components/error-boundary.js#" in the React Client Manifest. This is probably a bug in the React Server Components bundler.
at eS (/Users/mertdaglaroglu/Documents/WebProjects/Reactive/comnet/next-error-template-issue/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:129803)
at /Users/mertdaglaroglu/Documents/WebProjects/Reactive/comnet/next-error-template-issue/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:142519
at Object.toJSON (/Users/mertdaglaroglu/Documents/WebProjects/Reactive/comnet/next-error-template-issue/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:143612)
at stringify (<anonymous>)
at eE (/Users/mertdaglaroglu/Documents/WebProjects/Reactive/comnet/next-error-template-issue/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:131997)
at eR (/Users/mertdaglaroglu/Documents/WebProjects/Reactive/comnet/next-error-template-issue/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:132440)
at Timeout._onTimeout (/Users/mertdaglaroglu/Documents/WebProjects/Reactive/comnet/next-error-template-issue/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:129220)
at listOnTimeout (node:internal/timers:573:17)
at process.processTimers (node:internal/timers:514:7)
[Error: An error occurred in the Server Components render. The specific message is omitted in production builds to avoid leaking sensitive details. A digest property is included on this error instance which may provide additional details about the nature of the error.] {
digest: '910671031'
}
Error occurred prerendering page "/_not-found". Read more: https://nextjs.org/docs/messages/prerender-error
Error: An error occurred in the Server Components render. The specific message is omitted in production builds to avoid leaking sensitive details. A digest property is included on this error instance which may provide additional details about the nature of the error.
✓ Generating static pages (5/5)
> Export encountered errors on following paths:
/_not-found
ELIFECYCLE Command failed with exit code 1.
```
### Current vs. Expected behavior
Nextjs docs recommends placing global-error file inside app folder. However there is no instructions for internalization. Placing this file inside app/[lang] folder works just fine in dev environment yet it throws build error during static route generation. This looks like a build error rather than global-error file.
I've already created an issue about this along with not-found errors 2 months back and many reported same problem. However there is no solution to this problem yet (updated to the latest canary):
https://github.com/vercel/next.js/issues/56259
Due to missing global error file, website displays this on production build (browser's default JS error I guess):
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 23.1.0: Mon Oct 9 21:28:45 PDT 2023; root:xnu-10002.41.9~6/RELEASE_ARM64_T6020
Binaries:
Node: 20.5.1
npm: 9.8.0
Yarn: 1.22.19
pnpm: 8.11.0
Relevant Packages:
next: 14.0.4-canary.25
eslint-config-next: 14.0.3
react: 18.2.0
react-dom: 18.2.0
typescript: 5.3.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
App Router
### Additional context
I tested this with latest canary 14.0.4-canary.25 and problem still exist.
It works before v13.4.20-canary.12 | https://github.com/vercel/next.js/issues/59053 | https://github.com/vercel/next.js/pull/59085 | 956636c86f508bb79cfc10c6a9bc40039de6366c | d37b5076297e39e11b81e9154ccb8fef3dafa56c | "2023-11-29T08:22:18Z" | javascript | "2023-11-30T15:36:14Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 59,011 | ["packages/next/src/shared/lib/router/action-queue.ts", "test/e2e/app-dir/actions/app-action.test.ts", "test/e2e/app-dir/actions/app/use-transition/action.js", "test/e2e/app-dir/actions/app/use-transition/page.js"] | React transition stuck in "pending" state | ### Link to the code that reproduces this issue
https://github.com/siffogh/next-sandbox
### To Reproduce
1. Start the application in development mode `next dev`
2. Open the homepage and press the "Trigger action" button multiple times in a row (at least 5)
https://github.com/vercel/next.js/assets/4761023/5f7f9b0b-1ba7-4ae1-9134-eae4e7af01ed
### Current vs. Expected behavior
Current behaviour: The transition is stuck in "pending" state forever.
Expected behaviour: The transition is **not** stuck in "pending" state forever.
https://github.com/vercel/next.js/assets/4761023/2f81955d-a604-46ac-9263-c7a729d55998
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 21.6.0: Mon Aug 22 20:19:52 PDT 2022; root:xnu-8020.140.49~2/RELEASE_ARM64_T6000
Binaries:
Node: 18.17.0
npm: 9.6.7
Yarn: 1.22.19
pnpm: 8.6.10
Relevant Packages:
next: 14.0.4-canary.18
eslint-config-next: 14.0.3
react: 18.2.0
react-dom: 18.2.0
typescript: 5.3.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
App Router
### Additional context
Tested on both the latest canary `14.0.4-canary.18` and `14.0.3` | https://github.com/vercel/next.js/issues/59011 | https://github.com/vercel/next.js/pull/59038 | 6ac1367687aebeeec1530bc6d6528ac296ffc2db | 298bbe54896a5c26fa23605d431c950914c9f7ed | "2023-11-28T13:54:50Z" | javascript | "2023-11-28T22:54:04Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 58,909 | ["packages/next/src/server/lib/incremental-cache/index.ts"] | ISR revalidation is using stale data | ### Link to the code that reproduces this issue
https://github.com/hallatore/revalidate-bug
### To Reproduce
1. Build the app and run `npm run start`
2. Open frontpage http://localhost:3000
3. Note: The frontpage reloads every second
4. Observe how the time is only updating every ~10 seconds. (It should be every ~5 seconds)
### Example code
page.tsx
```typescriptreact
async function Page() {
const response = await fetch(
"http://worldtimeapi.org/api/timezone/Europe/Oslo",
{
next: {
revalidate: 5,
},
}
);
const json = (await response.json()) as { datetime: string };
return (
<p>{json.datetime}</p>
);
}
export default Page;
```
### Current vs. Expected behavior
## Current behavior
Page revalidation is getting (mostly) stale fetch data, causing every second revalidation to reuse old data.
## Expected behavior
The page derives it's revalidation from the fetch call. So it makes sense that when the page is revalidated it's because it should be re-rendered with updated fetch data.
The time in the example should update every ~5 seconds.
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: win32
Arch: x64
Version: Windows 11 Pro
Binaries:
Node: 20.10.0
npm: N/A
Yarn: N/A
pnpm: 8.6.2
Relevant Packages:
next: 14.0.4-canary.16
eslint-config-next: 14.0.4-canary.16
react: 18.2.0
react-dom: 18.2.0
typescript: 5.3.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
App Router, Data fetching (gS(S)P, getInitialProps)
### Additional context
_No response_ | https://github.com/vercel/next.js/issues/58909 | https://github.com/vercel/next.js/pull/58926 | ef3c6490fe6eabcbf9a1bd51244f4d14473e1c64 | ca19ffb63b6a17e55828f601eb3677033e523e41 | "2023-11-25T18:49:25Z" | javascript | "2023-11-29T02:54:31Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 58,579 | ["packages/next/src/server/app-render/action-encryption.ts", "test/e2e/app-dir/actions/app/server/page.js"] | Server actions wrong character encoding | ### Link to the code that reproduces this issue
https://codesandbox.io/p/sandbox/floral-leaf-rf3fhk?file=/app/page.tsx:9,23
### To Reproduce
1. Run with npm run dev
2. Click the test button
3. Watch the next.js console
### Current vs. Expected behavior
Current:
```
outside: öüóőúéáű
inside: öüóőúéáű
inside item: öüóQúéáq
```
Expexted:
```
outside: öüóőúéáű
inside: öüóőúéáű
inside item: öüóőúéáű
```
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 23.1.0: Mon Oct 9 21:28:12 PDT 2023; root:xnu-10002.41.9~6/RELEASE_ARM64_T8103
Binaries:
Node: 20.7.0
npm: 10.2.4
Yarn: N/A
pnpm: N/A
Relevant Packages:
next: 14.0.3
eslint-config-next: N/A
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
App Router
### Additional context
_No response_ | https://github.com/vercel/next.js/issues/58579 | https://github.com/vercel/next.js/pull/59000 | 7bdb61c28d5046a90e14c98b3ee2d01cd143daa2 | c85caae8d6b4e87b71c4482461fb5cd5e4d647f1 | "2023-11-17T10:49:27Z" | javascript | "2023-11-28T10:20:47Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 58,463 | ["packages/next/src/server/app-render/action-encryption.ts", "test/e2e/app-dir/actions/app/server/page.js"] | server action will throw JSON SyntaxError when access variable which has Chinese character | ### Link to the code that reproduces this issue
https://github.com/xiefenga/nextjs-server-action-bug-reproduce
### To Reproduce
1. Start the application in development (next dev)
2. Click save
3. Terminal will print the error
### Current vs. Expected behavior
Expect to work correctly without errors
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 23.1.0: Mon Oct 9 21:28:12 PDT 2023; root:xnu-10002.41.9~6/RELEASE_ARM64_T8103
Binaries:
Node: 18.16.0
npm: 9.5.1
Yarn: 1.22.19
pnpm: 8.7.5
Relevant Packages:
next: 14.0.2
eslint-config-next: 14.0.2
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
App Router
### Additional context
_No response_ | https://github.com/vercel/next.js/issues/58463 | https://github.com/vercel/next.js/pull/59000 | 7bdb61c28d5046a90e14c98b3ee2d01cd143daa2 | c85caae8d6b4e87b71c4482461fb5cd5e4d647f1 | "2023-11-15T02:41:39Z" | javascript | "2023-11-28T10:20:47Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 58,428 | ["packages/next/src/build/handle-externals.ts", "packages/next/src/build/webpack-config.ts", "packages/next/src/build/webpack/plugins/next-trace-entrypoints-plugin.ts", "test/e2e/app-dir/app-external/app-external.test.ts", "test/e2e/app-dir/app-external/app/optout/action/actions.js", "test/e2e/app-dir/app-external/app/optout/action/page.js", "test/e2e/app-dir/app-external/next.config.js", "test/e2e/app-dir/app-external/node_modules_bak/dual-pkg-optout/index.cjs", "test/e2e/app-dir/app-external/node_modules_bak/dual-pkg-optout/index.mjs", "test/e2e/app-dir/app-external/node_modules_bak/dual-pkg-optout/package.json"] | [Next:^14] Server Action: Unexpected identifier "(action-browser)/..." | ### Link to the code that reproduces this issue
https://github.com/liquiFruit/libsql-action-test
### To Reproduce
1. Install deps and run app in dev mode.
2. Visit `http://localhost:3000/`.
3. Click the "create user" button.
4. Take note of the error that appears.
### Current vs. Expected behavior
Currently, this runtime error prevents calling the `tryCreateUser` action.
The expected behavior would be for the action to be successfully called -- as it does when downgrading to `next: ^13` and enabling experimental server actions. This was the functionality when I had the `"use server"` in `@/server/db/index.ts` and had not created `@/server/actions.ts`
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
OS: Windows 11, 64bit.
Next.js version: 14.0.3-canary.7
```
### Which area(s) are affected? (Select all that apply)
App Router
### Additional context
I tested the same code on nextjs version `^13` and all works as expected. | https://github.com/vercel/next.js/issues/58428 | https://github.com/vercel/next.js/pull/59369 | 42ec6c89bb21cd33d891e3351fe4aa61562f39d0 | 2874bc0656df9031d10eea7beee36ce70e53acef | "2023-11-14T12:58:48Z" | javascript | "2023-12-07T17:11:11Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 58,306 | ["packages/next/src/server/lib/incremental-cache/fetch-cache.ts", "packages/next/src/server/lib/incremental-cache/file-system-cache.ts"] | Fetches Come Through Uncached in 14.0.2-canary.6 | ### Link to the code that reproduces this issue
https://github.com/madeincookware/cache-regression-repro
### To Reproduce
4. Visit a deployment of the repo on 14.0.1 https://cache-regression-repro-4tdgf5dex-madein.vercel.app
5. See that the caching behavior behaves as expected
1. Visit a deployment of the repro on 14.0.3-canary.0 https://cache-regression-repro-95zmmzx5n-madein.vercel.app
2. See that the first request is cached
3. Refresh, and see that the data is fetched freshly each time
### Current vs. Expected behavior
The data from the fetch should continue to be cached until it is invalidated.
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 22.6.0: Fri Sep 15 13:41:28 PDT 2023; root:xnu-8796.141.3.700.8~1/RELEASE_ARM64_T6020
Binaries:
Node: 18.18.2
npm: 9.8.1
Yarn: N/A
pnpm: 8.10.2
Relevant Packages:
next: 14.0.3-canary.0
eslint-config-next: 14.0.3-canary.0
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
App Router, Data fetching (gS(S)P, getInitialProps)
### Additional context
We traced this one back to a commit that happens between canary.5 and canary.6. | https://github.com/vercel/next.js/issues/58306 | https://github.com/vercel/next.js/pull/58460 | 375d85d95e96df7be09f37eb620f977ae1cfd850 | 4cbfe7d7e859f07b0fd3ab343e6784695dd5e1e5 | "2023-11-10T15:50:30Z" | javascript | "2023-11-15T01:24:08Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 58,074 | ["packages/next/src/server/config.test.ts", "packages/next/src/server/config.ts", "test/integration/image-optimizer/test/index.test.ts", "test/integration/next-image-new/asset-prefix/test/index.test.js"] | images.domains is deprecated when standalone not using that options | ### Link to the code that reproduces this issue
https://codesandbox.io/p/sandbox/peaceful-taussig-kf6gyp?file=%2Fpackage.json%3A5%2C27
### To Reproduce
1. build next app as standalone mode without config images.domain
2. build
3. show warning
`The "images.dominas" configuration is deprecated. Please use "images.remotePatterns" configuration instead.`
### Current vs. Expected behavior
the warning should not be showed up
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 22.6.0: Fri Sep 15 13:41:28 PDT 2023; root:xnu-8796.141.3.700.8~1/RELEASE_ARM64_T6000
Binaries:
Node: 20.9.0
npm: 10.1.0
Yarn: 4.0.1
pnpm: 8.10.0
Relevant Packages:
next: 14.0.1
eslint-config-next: 14.0.1
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: standalone
```
### Which area(s) are affected? (Select all that apply)
Not sure
### Additional context
_No response_ | https://github.com/vercel/next.js/issues/58074 | https://github.com/vercel/next.js/pull/58656 | c0bafcb3541252e7ca915d2d6b16b535338459ea | a2b781fafe54011d9f006a9423cfbd0d14d551c4 | "2023-11-06T04:52:51Z" | javascript | "2023-11-22T02:20:59Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 58,049 | ["packages/next/src/client/components/router-reducer/reducers/server-action-reducer.ts", "packages/next/src/server/lib/router-utils/filesystem.ts", "test/e2e/app-dir/actions/app-action.test.ts", "test/e2e/app-dir/actions/app/interception-routes/(with-modal)/@modal/(.)test/page.js", "test/e2e/app-dir/actions/app/interception-routes/(with-modal)/@modal/default.js", "test/e2e/app-dir/actions/app/interception-routes/(with-modal)/layout.js", "test/e2e/app-dir/actions/app/interception-routes/(with-modal)/page.js", "test/e2e/app-dir/actions/app/interception-routes/test/page.js"] | Server Action Hydration issue | ### Link to the code that reproduces this issue
https://github.com/RootedXpert/crm-portal/tree/develop
### To Reproduce
Server Action Hydration issue in page under dynamic routes
HTML from server:
HTML After Hydration
### Current vs. Expected behavior
Current Behavoir:
Expected behavior
No hydration error warning
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
System:
Platform: Windows
Arch: x64
Version: windows 11 home 22H2
Binaries:
Node: 18.17.1
npm:10.2.0
Relevant Packages:
next: 14.0.1
eslint-config-next: 14.0.1
react: 18.2.0
react-dom: 18.2.0
typescript: 5
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
App Router
### Additional context
_No response_ | https://github.com/vercel/next.js/issues/58049 | https://github.com/vercel/next.js/pull/59175 | 840b60bc8bb1e760a85c5e19388072dcd0751b78 | 363c2e8eb7e0bfdb2c89d1129e3d440f8848ad8b | "2023-11-05T11:40:19Z" | javascript | "2023-12-01T22:45:00Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 57,978 | ["packages/next/src/server/lib/incremental-cache/fetch-cache.ts", "packages/next/src/server/lib/incremental-cache/file-system-cache.ts"] | `fetch` cache and `unstable_cache` not caching correctly on Vercel since `14.0.2-canary.6` | ### Link to the code that reproduces this issue
https://github.com/pawelblaszczyk5/revalidate-vercel-test
### To Reproduce
1. Go to https://revalidate-vercel-test.vercel.app/fetch-cache-test or https://revalidate-vercel-test.vercel.app/revalidate-tag-test
2. Refresh
3. Observe the random number being changed despite it being cached in code
### Current vs. Expected behavior
I tried the reproduction with different canaries after spotting that it works with latest stable and doesn't work on canary. It turns out since exactly `14.0.2-canary.6` version the `fetch` cache and `unstable_cache` doesn't seem to be cached properly on Vercel. It works locally, but after deployed the fetch/function are always re-invoked.
Here in my code you can see these resources being marked for cache
https://github.com/pawelblaszczyk5/revalidate-vercel-test/blob/4c4cd9f732515be45c18734e7d985fa24bf312ba/app/fetch-cache-test/page.tsx#L13
https://github.com/pawelblaszczyk5/revalidate-vercel-test/blob/4c4cd9f732515be45c18734e7d985fa24bf312ba/app/revalidate-tag-test/page.tsx#L14
Expected behavior would be to be cached properly on Vercel
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 23.2.0: Fri Oct 13 09:27:54 PDT 2023; root:xnu-10002.60.54~14/RELEASE_ARM64_T6000
Binaries:
Node: 18.18.0
npm: 9.8.1
Yarn: 1.22.19
pnpm: 8.6.2
Relevant Packages:
next: 14.0.2-canary.6
eslint-config-next: 14.0.1
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Not sure, App Router
### Additional context
Here is a deployment on the first not working canary: https://revalidate-vercel-test.vercel.app/fetch-cache-test
Here is a deployment with last working canary (`14.0.2-canary.5`): https://revalidate-vercel-test-ij8w5h8b9-pawelblaszczyk5.vercel.app/fetch-cache-test
There're two URLs affected by this issue on each of this pages `/fetch-cache-test` and `/revalidate-tag-test`. There is also server action for revalidating these tags. | https://github.com/vercel/next.js/issues/57978 | https://github.com/vercel/next.js/pull/58460 | 375d85d95e96df7be09f37eb620f977ae1cfd850 | 4cbfe7d7e859f07b0fd3ab343e6784695dd5e1e5 | "2023-11-03T10:42:15Z" | javascript | "2023-11-15T01:24:08Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 57,816 | ["docs/02-app/02-api-reference/04-functions/generate-viewport.mdx"] | Docs: generateViewport incorrectly recommends using generateMetadata for async support | ### What is the improvement or update you wish to see?
The documentation for the new [`generateViewport`](https://nextjs.org/docs/app/api-reference/functions/generate-viewport#generateviewport-function) function recommends using `generateMetadata` if `async` support is required.
> Marking generateViewport as async is not yet supported. If you still require this functionality, continue using the previous generateMetadata option. We will be adding support for async in an upcoming minor release.
However, returning `colorScheme` or `themeColor` from `generateMetadata` has no effect, other than a warning.
> Unsupported metadata colorScheme is configured in metadata export. Please move it to viewport export instead.
The documentation should be adjusted, since support for asynchronously loading `colorScheme` or `themeColor` was effectively dropped in Next.js 14. The recommended workaround is misleading.
### Is there any context that might help us understand?
It looks like this support was originally planned, but was removed:
- https://github.com/vercel/next.js/pull/57302#issuecomment-1779031877
- https://github.com/vercel/next.js/pull/57302#issuecomment-1779658492
### Does the docs page already exist? Please link to it.
https://nextjs.org/docs/app/api-reference/functions/generate-viewport#generateviewport-function | https://github.com/vercel/next.js/issues/57816 | https://github.com/vercel/next.js/pull/58192 | f206573f93cf3b64d76a7c4f0f0fc311d2d4a6bb | 36490fe27d18fb3aaaffac4d54b109e028cc3a68 | "2023-10-31T14:25:18Z" | javascript | "2023-11-08T14:18:00Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 57,743 | ["packages/next/src/server/app-render/get-layer-assets.tsx"] | Using --turbo Flag With npm run dev Seems To Throw "Encountered two children with the same key, `0`" Error | ### Link to the code that reproduces this issue
https://github.com/RockyWearsAHat/nextKeysMustBeUniqueWhenUsingTurbo
### To Reproduce
likely have to npm install gsap / remove the GSAP import from FirstGSAPPage (there's no actual code that uses it, just the import, bug is not specific to GSAP as even after removing import gsap bug persists)
then
npm run dev
--turbo already declared in package.json
### Current vs. Expected behavior
Page expected to render without errors.
Page renders with errors that I generally associate with array.map when the objects don't have keys, but only when the --turbo flag is declared inside the the package.json
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: win32
Arch: x64
Version: Windows 10 Home
Binaries:
Node: 20.9.0
npm: N/A
Yarn: N/A
pnpm: N/A
Relevant Packages:
next: 14.0.1-canary.3
eslint-config-next: 14.0.0
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Turbopack (--turbo)
### Additional context
_No response_ | https://github.com/vercel/next.js/issues/57743 | https://github.com/vercel/next.js/pull/58249 | e2f3059b48a779c2a755c21da26570d251305c01 | a628e6344efe926f1eeb5a9277956d1f0372f794 | "2023-10-30T10:55:04Z" | javascript | "2023-11-09T16:44:06Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 57,715 | ["docs/02-app/01-building-your-application/06-optimizing/07-analytics.mdx"] | Docs: reportWebVitals in app router | ### What is the improvement or update you wish to see?
https://nextjs.org/docs/app/building-your-application/optimizing/analytics is empty compared to https://nextjs.org/docs/pages/building-your-application/optimizing/analytics and does not tell you how to use reportWebVitals, or if it's even supported in the app structure.
### Is there any context that might help us understand?
N/A
### Does the docs page already exist? Please link to it.
https://nextjs.org/docs/app/building-your-application/optimizing/analytics | https://github.com/vercel/next.js/issues/57715 | https://github.com/vercel/next.js/pull/58196 | 4024b25e8cc0d76d832efb14858d65718a24211e | 0cdddd419f4bd8147d975bdd840f09cef331c8e2 | "2023-10-29T17:34:15Z" | javascript | "2023-11-09T12:36:33Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 57,709 | ["packages/next/src/server/app-render/get-layer-assets.tsx"] | [Turbopack] Warning: Encountered two children with the same key, `0`. Keys should be unique so that components maintain their identity across updates | ### Link to the code that reproduces this issue
https://github.com/jersoncarin/turbopack-warning-bug
### To Reproduce
1. git clone https://github.com/jersoncarin/turbopack-warning-bug.git
2. npm install
3. npm run turbo (next dev --turbo)
4. open devtools and you will see the warning
### Current vs. Expected behavior
**Current Behavior:**
Showing this warning `app-index.js:31 Warning: Encountered two children with the same key, `0`. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.`
**Expected behavior**
No warning using turbo
### Verify canary release
- [x] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: win32
Arch: x64
Version: Windows 11 Pro
Binaries:
Node: 21.1.0
npm: N/A
Yarn: N/A
pnpm: 8.5.1
Relevant Packages:
next: 14.0.0
eslint-config-next: N/A
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
App Router, Turbopack (--turbo)
### Additional context
I tested using the `next dev` without turbo it's working fine without any warning, but when I use `next dev --turbo` it will show the warning.
I tried also using the `next@canary` but it's same warning | https://github.com/vercel/next.js/issues/57709 | https://github.com/vercel/next.js/pull/58249 | e2f3059b48a779c2a755c21da26570d251305c01 | a628e6344efe926f1eeb5a9277956d1f0372f794 | "2023-10-29T14:38:31Z" | javascript | "2023-11-09T16:44:06Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 57,680 | ["packages/next/src/server/typescript/constant.ts"] | Meta theme-color is missing in the html, while meta viewport value is incorrect | ### Link to the code that reproduces this issue
https://github.com/Senbonzakura1234/debug-metadata
### To Reproduce
1/ run `next dev`
### Current vs. Expected behavior
- log show
```powershell
⚠ Unsupported metadata themeColor is configured in metadata export. Please move it to viewport export instead.
⚠ Unsupported metadata viewport is configured in metadata export. Please move it to viewport export instead.
```
those 2 meta field didn't rendered to the html
- change the code move themeColor and viewport option to viewport export:
```ts
export const viewport: Viewport = {
themeColor: '#996c254d',
width: '1024'
}
```
those 2 meta field rendered to the html, but getting `"viewport" is not a valid Next.js entry export value` error message in vscode.
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: win32
Arch: x64
Version: Windows 10 Home Single Language
Binaries:
Node: 18.18.2
npm: N/A
Yarn: N/A
pnpm: N/A
Relevant Packages:
next: 14.0.1-canary.1
eslint-config-next: 14.0.1-canary.1
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
ESLint (eslint-config-next), Metadata (metadata, generateMetadata, next/head)
### Additional context
_No response_ | https://github.com/vercel/next.js/issues/57680 | https://github.com/vercel/next.js/pull/57554 | d88d8aed36c068d2c1520a3901b02224ec329d38 | 24a71dcd72fd367d415367671efe6eff4d833471 | "2023-10-28T18:35:51Z" | javascript | "2023-10-30T00:59:47Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 57,632 | ["packages/next/src/server/pipe-readable.ts", "packages/next/src/server/render-result.ts", "packages/next/src/server/send-response.ts"] | fetch revalidation not working with Nextjs 14.0.0 | ### Link to the code that reproduces this issue
https://codesandbox.io/p/sandbox/blissful-boyd-mh27hy
### To Reproduce
#### Home Page
```tsx
import Link from "next/link";
const Home = () => {
return (
<div>
<Link href="/time" className="border-2 p-2 mx-auto">
Time
</Link>
</div>
);
};
export default Home;
```
#### TimePage
```tsx
const Time = async () => {
const res = await fetch("http://localhost:3000/api", {
next: { revalidate: 2 },
});
const data = res.json();
return <div>{data}</div>;
};
export default Time;
```
#### GET Route.
```tsx
import { NextResponse } from "next/server";
export const GET = () => {
return NextResponse.json(Date.now());
};
export const dynamic = "force-dynamic";
```
Step 1 : Navigate to `Time` using link on home page.
Step 2 : Navigate back to `Home`.
Step 3 : wait for more than 2 seconds.
Step 4 : Again navigate to `Time`.
You see that The Cache is not changed even after completion of 2 seconds which was mentiond in `fetch` of `Time`.
https://github.com/vercel/next.js/assets/87939462/0cdda015-7599-415c-bcf4-ad634e1d1063
### Current vs. Expected behavior
The cache is not updated which should be updated when mentioned revalidation time has completed.
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 23.0.0: Fri Sep 15 14:41:34 PDT 2023; root:xnu-10002.1.13~1/RELEASE_ARM64_T8103
Binaries:
Node: 19.4.0
npm: 9.6.7
Yarn: 1.22.17
pnpm: N/A
Relevant Packages:
next: 14.0.0
eslint-config-next: 14.0.0
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Not sure
### Additional context
_No response_ | https://github.com/vercel/next.js/issues/57632 | https://github.com/vercel/next.js/pull/58744 | a2b781fafe54011d9f006a9423cfbd0d14d551c4 | 48a566bc4fcfc48d8489f096a87e792912c4989f | "2023-10-27T20:19:20Z" | javascript | "2023-11-22T02:37:35Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 57,624 | ["packages/next-swc/crates/core/src/optimize_barrel.rs", "packages/next-swc/crates/core/tests/fixture/optimize-barrel/normal/4/input.js", "packages/next-swc/crates/core/tests/fixture/optimize-barrel/normal/4/output.js", "packages/next/src/build/webpack-config.ts", "packages/next/src/build/webpack/loaders/next-barrel-loader.ts", "packages/next/src/build/webpack/loaders/next-flight-client-entry-loader.ts", "packages/next/src/build/webpack/plugins/flight-client-entry-plugin.ts", "test/development/basic/barrel-optimization/barrel-optimization.test.ts", "test/development/basic/barrel-optimization/fixture/app/mui/page.js", "test/turbopack-tests-manifest.json"] | `optimizePackageImports` no longer functional in v14 | ### Link to the code that reproduces this issue
https://github.com/mwskwong/optimize-package-imports-bug
### To Reproduce
1. Create a Next.js project
2. Import any MUI component (`Button` in the example) using named import to `page.tsx`
3. Observe the bundle size
### Current vs. Expected behavior
**Current**
The entire `@mui/material` is included in the client bundle, despite this package is by default included in `optimizePackageImports`.
**Expect**
Only `Button` and its dependencies are included in the client bundle.
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: win32
Arch: x64
Version: Windows 10 Home
Binaries:
Node: 18.17.1
npm: N/A
Yarn: N/A
pnpm: N/A
Relevant Packages:
next: 14.0.1-canary.3
eslint-config-next: 14.0.1-canary.3
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
App Router
### Additional context
Downgrade to Next.js 13.5 to observe the expected behavior.
<sub>[NEXT-1713](https://linear.app/vercel/issue/NEXT-1713/optimizepackageimports-no-longer-functional-in-v14)</sub> | https://github.com/vercel/next.js/issues/57624 | https://github.com/vercel/next.js/pull/59254 | b88e263f4c654b7909b93e98e620d362405e9eb5 | 6790004d79ad17d1d512ee24d8cb5abead591e6e | "2023-10-27T18:24:52Z" | javascript | "2023-12-05T16:17:31Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 57,622 | ["packages/next/src/build/handle-externals.ts", "packages/next/src/build/webpack-config.ts", "packages/next/src/build/webpack/plugins/next-trace-entrypoints-plugin.ts", "test/e2e/app-dir/app-external/app-external.test.ts", "test/e2e/app-dir/app-external/app/optout/action/actions.js", "test/e2e/app-dir/app-external/app/optout/action/page.js", "test/e2e/app-dir/app-external/next.config.js", "test/e2e/app-dir/app-external/node_modules_bak/dual-pkg-optout/index.cjs", "test/e2e/app-dir/app-external/node_modules_bak/dual-pkg-optout/index.mjs", "test/e2e/app-dir/app-external/node_modules_bak/dual-pkg-optout/package.json"] | 14.0.0 Server Actions webpack issues | ### Link to the code that reproduces this issue
The latest canary server actions no longer works in VM due to host/origin check, so here's a GH repo: https://github.com/khuezy/server_actions_bug
https://codesandbox.io/p/sandbox/practical-silence-zgrvzc
### To Reproduce
1. Go to https://codesandbox.io/p/sandbox/practical-silence-zgrvzc
2. Open the /app/page.tsx file and see instructions
3. Click "Click me" button on the app to see the pop up, everything is fine.
4. Comment out the Scenario1 (happy path) and uncomment the Scenario2 block, save file and wait for app to reload
5. Click "Click me" and see error in the terminal
6. Comment out the Scenario2 and uncomment the Scenario3 block, save file and wait for app to reload
7. Click "Click me" and see new error in the terminal
### Current vs. Expected behavior
In Next 13.5.6, server actions did not have any issues with webpack.
In Next 14.0.0 is broken with webpack importing certain libraries
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: linux
Arch: x64
Version: #1 SMP PREEMPT_DYNAMIC Sun Aug 6 20:05:33 UTC 2023
Binaries:
Node: 20.5.1
npm: 9.8.0
Yarn: 1.22.19
pnpm: 8.10.0
Relevant Packages:
next: 14.0.0
eslint-config-next: 14.0.0
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
App Router
### Additional context
[v14.0.1-canary.0](https://github.com/vercel/next.js/releases/tag/v14.0.1-canary.0) only contains a docs change.
[v14.0.2-canary.10](https://github.com/vercel/next.js/releases/tag/v14.0.2-canary.10) still broken
<sub>[NEXT-1711](https://linear.app/vercel/issue/NEXT-1711/1400-server-actions-webpack-issues)</sub> | https://github.com/vercel/next.js/issues/57622 | https://github.com/vercel/next.js/pull/59369 | 42ec6c89bb21cd33d891e3351fe4aa61562f39d0 | 2874bc0656df9031d10eea7beee36ce70e53acef | "2023-10-27T18:21:13Z" | javascript | "2023-12-07T17:11:11Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 57,603 | ["packages/next-swc/crates/next-core/src/pages_structure.rs"] | --turbo flag not work with pageExtensions | ### Link to the code that reproduces this issue
https://github.com/bightg30098/turbo-flag-not-work-with-page-extensions
### To Reproduce
```bash
pnpm dlx create-next-app@latest
✔ What is your project named? … my-app
✔ Would you like to use TypeScript? … Yes
✔ Would you like to use ESLint? … Yes
✔ Would you like to use Tailwind CSS? … Yes
✔ Would you like to use `src/` directory? … Yes
✔ Would you like to use App Router? (recommended) … No
✔ Would you like to customize the default import alias (@/*)? … No
```
1. update dev script with `"dev": "next dev --turbo"`
2. add `pageExtensions: ['page.tsx']` to next.config.js
3. rename _app.tsx, _document.tsx, index.tsx to _app.page.tsx, _document.page.tsx, _document.page.tsx
4. start dev server with `pnpm dev`
### Current vs. Expected behavior
```bash
▲ Next.js 14.0.0 (turbo)
- Local: http://localhost:3000
✓ Ready in 1284ms
⨯ PageNotFoundError: Cannot find module for page: route not found /
at Object.ensurePage (/Users/bightg30098/Repositories/turbo-flag-not-work-with-page-extensions/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/server/lib/router-utils/setup-dev-bundler.js:966:27)
at async DevBundlerService.ensurePage (/Users/bightg30098/Repositories/turbo-flag-not-work-with-page-extensions/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/server/lib/dev-bundler-service.js:18:20)
at async DevServer.ensurePage (/Users/bightg30098/Repositories/turbo-flag-not-work-with-page-extensions/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/server/dev/next-dev-server.js:518:9)
at async Object.ensure (/Users/bightg30098/Repositories/turbo-flag-not-work-with-page-extensions/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/server/dev/next-dev-server.js:164:17)
at async DevRouteMatcherManager.matchAll (/Users/bightg30098/Repositories/turbo-flag-not-work-with-page-extensions/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/server/future/route-matcher-managers/dev-route-matcher-manager.js:94:13)
at async DevRouteMatcherManager.match (/Users/bightg30098/Repositories/turbo-flag-not-work-with-page-extensions/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/server/future/route-matcher-managers/default-route-matcher-manager.js:155:26)
at async NextNodeServer.handleCatchallRenderRequest (/Users/bightg30098/Repositories/turbo-flag-not-work-with-page-extensions/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/server/next-server.js:222:31)
at async DevServer.handleRequestImpl (/Users/bightg30098/Repositories/turbo-flag-not-work-with-page-extensions/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/server/base-server.js:748:17) {
code: 'ENOENT'
}
✓ Compiled /_error in 322ms
```
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 23.0.0: Fri Sep 15 14:42:57 PDT 2023; root:xnu-10002.1.13~1/RELEASE_ARM64_T8112
Binaries:
Node: 20.7.0
npm: 10.1.0
Yarn: N/A
pnpm: 8.9.2
Relevant Packages:
next: 14.0.0
eslint-config-next: 14.0.0
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Turbopack (--turbo)
### Additional context
_No response_
<sub>[PACK-1950](https://linear.app/vercel/issue/PACK-1950/turbo-flag-not-work-with-pageextensions)</sub> | https://github.com/vercel/next.js/issues/57603 | https://github.com/vercel/next.js/pull/58504 | 4deb69793ea63927dcaf8875f231518f3a475c7d | 85a77c4c34aec536cab175fd0337a7d7a19e51cd | "2023-10-27T14:03:10Z" | javascript | "2023-11-16T23:03:27Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 57,593 | ["docs/02-app/01-building-your-application/09-upgrading/01-codemods.mdx"] | Docs: Incorrect heading structure for Next.js 14 codemods | ### What is the improvement or update you wish to see?
Fix the incorrect heading structure for both, `next-og-import` and `metadata-to-viewport-export` codemods.
### Is there any context that might help us understand?
Codemod names should be H5 instead of H4.
### Does the docs page already exist? Please link to it.
https://nextjs.org/docs/app/building-your-application/upgrading/codemods#next-og-import | https://github.com/vercel/next.js/issues/57593 | https://github.com/vercel/next.js/pull/57605 | 86d3043d22e58344d785ed9cf6fc15de0c8c8c3d | ee9a13aaa0592102e229bb3e5959cebe0a7a060c | "2023-10-27T12:32:22Z" | javascript | "2023-10-28T01:54:49Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 57,582 | ["packages/next/src/build/collect-build-traces.ts", "test/e2e/app-dir/app/standalone-gsp.test.ts"] | Pages using `getStaticProps` is broken in next.js 14 | ### Link to the code that reproduces this issue
https://github.com/peakercope/material-ui-nextjs-pages-router-ts-example
### To Reproduce
1. Clone repo
2. Install dependencies `yarn install`
3. Build project `yarn build`
4. Run app `node .next/standalone/server.js`
5. Open `http://localhost:3000` in any browser
### Current vs. Expected behavior
**Current behavior:**
`500 Internal Server Error` in browser
Console log:
```
⨯ file:///material-ui-nextjs-pages-router-ts-example/.next/standalone/node_modules/swr/_internal/dist/index.mjs:1
import React, { useEffect, useLayoutEffect, createContext, useContext, useMemo, useRef, createElement } from 'react';
^^^^^^^^^^^^^
SyntaxError: Named export 'createContext' not found. The requested module 'react' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:
import pkg from 'react';
const { useEffect, useLayoutEffect, createContext, useContext, useMemo, useRef, createElement } = pkg;
at ModuleJob._instantiate (node:internal/modules/esm/module_job:124:21)
at async ModuleJob.run (node:internal/modules/esm/module_job:190:5)
```
**Expected behavior:**
App opens without error
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 23.1.0: Mon Oct 9 21:27:24 PDT 2023; root:xnu-10002.41.9~6/RELEASE_ARM64_T6000
Binaries:
Node: 18.18.2
npm: 9.8.1
Yarn: 4.0.0
pnpm: 7.25.0
Relevant Packages:
next: 14.0.0
eslint-config-next: 14.0.0
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: standalone
```
### Which area(s) are affected? (Select all that apply)
Not sure
### Additional context
Pages `http://localhost:3000` and `http://localhost:3000/about` responses with error.
While page `http://localhost:3000/without-static-props` which doesn't have `getStaticProps` function opens successfully.
<sub>[NEXT-1700](https://linear.app/vercel/issue/NEXT-1700/pages-using-getstaticprops-is-broken-in-nextjs-14)</sub> | https://github.com/vercel/next.js/issues/57582 | https://github.com/vercel/next.js/pull/57766 | 3553c6516d7a9aba98876f9660af0ee7c94dc2a3 | 9128b58654fdb7e07a909d6e8b742c28aed78a21 | "2023-10-27T09:50:35Z" | javascript | "2023-10-30T17:24:51Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 57,581 | ["packages/next/package.json", "packages/next/src/compiled/@vercel/nft/index.js", "packages/next/src/lib/fs/rename.ts", "packages/next/src/lib/fs/write-atomic.ts", "packages/next/src/server/lib/router-utils/setup-dev-bundler.ts", "pnpm-lock.yaml"] | The turbo package in nextjs 14 has a bug: EPERM: operation not permitted | ### Link to the code that reproduces this issue
https://github.com/peymanath/terxine/tree/nextjs14-turbo
### To Reproduce
Hello everyone,
i'm using Turbo in the developer environment nextjs14, but I'm getting the following error.
Has anyone encountered this error?
Note: When I get this error that NEXTjs wants to render my routes.
```bash
▲ Next.js 14.0.0 (turbo)
- Local: http://localhost:3000
✓ Ready in 1161ms
○ Compiling /branchs/page ...
✓ Compiled /branchs/page in 3.9s
○ Compiling /_error ...
✓ Compiled /_error in 766ms
⨯ [Error: EPERM: operation not permitted, rename 'D:\Work\Development\Project\FrontEnd\Terxine\terxine\.next\build-manifest.json.tmp.jazqmzy5ees' -> 'D:\Work\Development\Project\FrontEnd\Terxine\terxine\.next\build-manifest.json'] {
errno: -4048,
code: 'EPERM',
syscall: 'rename',
path: 'D:\\Work\\Development\\Project\\FrontEnd\\Terxine\\terxine\\.next\\build-manifest.json.tmp.jazqmzy5ees',
dest: 'D:\\Work\\Development\\Project\\FrontEnd\\Terxine\\terxine\\.next\\build-manifest.json'
}
```
### Current vs. Expected behavior
When I use Turbo, this problem occurs and the fonts of my site do not load and the application does not work properly and it also gives this error, but without Turbopack there is no problem, the application works properly.
### Verify canary release
- [x] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: win32
Arch: x64
Version: Windows 10 Pro
Binaries:
Node: 18.18.1
npm: N/A
Yarn: N/A
pnpm: 8.9.2
Relevant Packages:
next: 14.0.1-canary.0
eslint-config-next: 14.0.0
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
App Router, Turbopack (--turbo)
### Additional context
I am using version 13.5, today I wanted to change to 14 and use turbopack and I had this problem. I tested it when I use create-next-app, it works fine, but there is a problem with my project.
<sub>[PACK-1956](https://linear.app/vercel/issue/PACK-1956/the-turbo-package-in-nextjs-14-has-a-bug-eperm-operation-not-permitted)</sub> | https://github.com/vercel/next.js/issues/57581 | https://github.com/vercel/next.js/pull/58835 | e62c18b89d26f6b52ba092bcac4ecdff3f71776b | 40a6e613fe700cf7de0797f6f1afcfdf6b10a4e6 | "2023-10-27T09:11:31Z" | javascript | "2023-11-27T15:19:45Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 57,533 | ["packages/next/src/shared/lib/router/utils/app-paths.ts"] | Build compilation warning "Node.js module is loaded ('url' at line 3)" when using middleware | ### Link to the code that reproduces this issue
https://github.com/frasergr/url-edge-warning-next14
### To Reproduce
1. `npx create-next-app@latest`
2. Add `middleware.ts` (warning is present whether there is any code in the `middleware()` function or not)
3. `npm run build`
4. Observe warning
NOTE: subsequent builds will not show the warning but if you delete `.next/` and build again it will show the warning
### Current vs. Expected behavior
Results in an unexpected warning during build:
```
⚠ Compiled with warnings
./node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected]/node_modules/next/dist/esm/shared/lib/router/utils/app-paths.js
A Node.js module is loaded ('url' at line 3) which is not supported in the Edge Runtime.
```
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: linux
Arch: x64
Version: #26~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Thu Jul 13 16:27:29 UTC 2
Binaries:
Node: 18.17.1
npm: 9.6.7
Yarn: N/A
pnpm: 8.6.12
Relevant Packages:
next: 14.0.0
eslint-config-next: 14.0.0
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
App Router, Middleware / Edge (API routes, runtime)
### Additional context
The warning appeared in [email protected] | https://github.com/vercel/next.js/issues/57533 | https://github.com/vercel/next.js/pull/57685 | 24a71dcd72fd367d415367671efe6eff4d833471 | 3248ee71c8e3b4c329e60aec9d8f550612a9ab0a | "2023-10-26T20:05:27Z" | javascript | "2023-10-30T02:15:11Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 57,528 | ["packages/next/src/server/config-schema.ts"] | Config key validation for `logging` is missing | ### Link to the code that reproduces this issue
https://github.com/blurrah/next-logging-validation-reproduction
### To Reproduce
1. Start the app in development mode
2. See warning about unrecognized key
### Current vs. Expected behavior
The `logging` object has been moved out of experimental but not yet in the config validation. This means it'll warn you that the key is unrecognized.
Expected: It should properly validate the object.
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 22.5.0: Thu Jun 8 22:22:20 PDT 2023; root:xnu-8796.121.3~7/RELEASE_ARM64_T6000
Binaries:
Node: 20.5.1
npm: 9.8.0
Yarn: 1.22.19
pnpm: 8.9.2
Relevant Packages:
next: 13.5.7-canary.37
eslint-config-next: N/A
react: 18.2.0
react-dom: 18.2.0
typescript: 5.1.3
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Not sure
### Additional context
_No response_ | https://github.com/vercel/next.js/issues/57528 | https://github.com/vercel/next.js/pull/57530 | 54a9da0a1edc419b8e84c7b63bcfbdc0e8195114 | c88e089ade9c6835da0a6169719460f0b29da0df | "2023-10-26T19:25:20Z" | javascript | "2023-10-29T15:09:33Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 57,410 | ["examples/with-strict-csp/middleware.js"] | Docs: CSP documentation and examples render users vulnerable to headers injection | ### What is the improvement or update you wish to see?
Official documentation and official examples contain code that is putting **the applications using it in considerable danger**.
It is further escalated due to this code being copied and propagated: [google search](https://www.google.com/search?q=%22const+requestHeaders+%3D+new+Headers%28request.headers%29%22&sca_esv=576211123&sxsrf=AM9HkKmaC2sSdALvlwPPLz5BF7X3xFU6ug%3A1698178316844&ei=DCU4ZdSJM_6SwPAPgO-b2A0&ved=0ahUKEwjUv9yav4-CAxV-CRAIHYD3BtsQ4dUDCBA&uact=5&oq=%22const+requestHeaders+%3D+new+Headers%28request.headers%29%22&gs_lp=Egxnd3Mtd2l6LXNlcnAiNSJjb25zdCByZXF1ZXN0SGVhZGVycyA9IG5ldyBIZWFkZXJzKHJlcXVlc3QuaGVhZGVycykiMgcQIRigARgKMgcQIRigARgKMgcQIRigARgKMgcQIRigARgKMgcQIRigARgKSOEOUPAGWNwMcAB4AJABAJgBlwGgAaUCqgEDMi4xuAEDyAEA-AEBwgIIEAAYogQYsAPCAgQQIxgn4gMEGAEgQYgGAZAGBA&sclient=gws-wiz-serp).
Vulnerable example:
https://github.com/vercel/next.js/tree/canary/examples/with-strict-csp
Code snippets and examples should not contain a code that makes the applications using it vulnerable. I have reported this to [email protected], but was redirected here.
I do not see a reason to set nonce and CSP headers on request headers, so the snippet should just be modifying response headers, without touching request at all.
### Is there any context that might help us understand?
```
const requestHeaders = new Headers(request.headers)
// [...]
return NextResponse.next({
headers: requestHeaders,
request: {
headers: requestHeaders,
},
})
```
This code is copying **all request headers into server response**. It allows the actor to inject malicious headers that will be returned by the server. It also **allows modification of other headers, like Cache-Control, which might ex. result in caching malicious responses on CDN**.
### Proof of concept
1. Download and run the example: https://github.com/vercel/next.js/tree/canary/examples/with-strict-csp
2. Run `curl -v -o /dev/null -s -H 'Cache-Control: malicious' -H 'X-Malicious: Anyvalue' http://localhost:3000/`
```
* Trying 127.0.0.1:3000...
* Connected to localhost (127.0.0.1) port 3000 (#0)
> GET / HTTP/1.1
> Host: localhost:3000
> User-Agent: curl/7.86.0
> Accept: */*
> Cache-Control: malicious
> X-Malicious: Anyvalue
>
* Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
< accept: */*
< cache-control: malicious
< content-security-policy: default-src 'self'; script-src 'self' 'nonce-MTJmNTdhOTItYTRkMi00Njk3LWJhZWYtYzM3OTRhMjcwZmJh' 'strict-dynamic'; style-src 'self' 'nonce-MTJmNTdhOTItYTRkMi00Njk3LWJhZWYtYzM3OTRhMjcwZmJh'; img-src 'self' blob: data:; font-src 'self'; object-src 'none'; base-uri 'self'; form-action 'self'; frame-ancestors 'none'; block-all-mixed-content; upgrade-insecure-requests;
< host: localhost:3000
< user-agent: curl/7.86.0
< x-malicious: Anyvalue
< x-nonce: MTJmNTdhOTItYTRkMi00Njk3LWJhZWYtYzM3OTRhMjcwZmJh
< Vary: RSC, Next-Router-State-Tree, Next-Router-Prefetch, Next-Url, Accept-Encoding
< X-Powered-By: Next.js
< Content-Type: text/html; charset=utf-8
< Date: Tue, 24 Oct 2023 20:05:11 GMT
< Connection: keep-alive
< Keep-Alive: timeout=5
< Transfer-Encoding: chunked
<
```
### Does the docs page already exist? Please link to it.
https://nextjs.org/docs/pages/building-your-application/configuring/content-security-policy | https://github.com/vercel/next.js/issues/57410 | https://github.com/vercel/next.js/pull/58304 | e50782829b8167b0d85abcbc29291239c9e703de | ff257800fc94e97c5c6c41c49a8424b741497ebc | "2023-10-25T11:00:14Z" | javascript | "2023-11-10T15:14:54Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 57,051 | ["docs/02-app/02-api-reference/04-functions/generate-metadata.mdx", "packages/next/src/lib/metadata/generate/alternate.tsx", "packages/next/src/lib/metadata/generate/basic.tsx", "test/e2e/app-dir/metadata/metadata.test.ts"] | Unable to add multiple meta tags with the same name (app directory) | ### Link to the code that reproduces this issue
https://codesandbox.io/p/sandbox/staging-firefly-cf45hv
### To Reproduce
it's easy to reproduce, create a new next project, using the app directory
use generateMetadata other field to add meta tags that require multiple ones with the same name
### Current vs. Expected behavior
I want to add multiple meta tags with the same name, **example** _music:song, citation_author..._
I was checking the `metadata-interface.d.ts` file
` other?: {
[name: string]: string | number | Array<string | number>;
} & DeprecatedMetadataFields;
`
using the `generateMetadata` function
```
export async function generateMetadata() {
return {
other: {
'music:song:track': ['1','2','3']
}
};
}
```
is resulting in
```
<meta name="music:song:track" content="1,2,3">
```
instead of
```
<meta name="music:song:track" content="1">
<meta name="music:song:track" content="2">
<meta name="music:song:track" content="3">
```
And adding `<meta />` tags in next `<head />` is not rendering too
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: linux
Arch: x64
Version: #1 SMP PREEMPT_DYNAMIC Sun Aug 6 20:05:33 UTC 2023
Binaries:
Node: 16.17.0
npm: 8.15.0
Yarn: 1.22.19
pnpm: 7.1.0
Relevant Packages:
next: 13.4.13-canary.13
eslint-config-next: N/A
react: 18.2.0
react-dom: 18.2.0
typescript: 5.1.3
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
App Router, Metadata (metadata, generateMetadata, next/head)
### Additional context
_No response_
<sub>[NEXT-1746](https://linear.app/vercel/issue/NEXT-1746/unable-to-add-multiple-meta-tags-with-the-same-name-app-directory)</sub> | https://github.com/vercel/next.js/issues/57051 | https://github.com/vercel/next.js/pull/59106 | d37b5076297e39e11b81e9154ccb8fef3dafa56c | 778fb871314e840390496f4147483ba18d974d83 | "2023-10-19T12:37:33Z" | javascript | "2023-11-30T15:44:49Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 57,027 | ["docs/03-pages/01-building-your-application/01-routing/02-dynamic-routes.mdx"] | Docs: The explanation for "Dynamic Routes" is incorrect. | ### What is the improvement or update you wish to see?
In the "Optional Catch-all Segments", if params is `{}`, can't reach `/shop`. The correct value should be `{ slug: [] }`
### Is there any context that might help us understand?
Just need to change the params from `{}` to `{ slug: [] }`.
### Does the docs page already exist? Please link to it.
https://nextjs.org/docs/pages/building-your-application/routing/dynamic-routes | https://github.com/vercel/next.js/issues/57027 | https://github.com/vercel/next.js/pull/57029 | fa100e29b12d536977fe825619788fbed87b193a | 0bb6b56c8213e1fdec0ce1e2f19b9ecb855433b3 | "2023-10-19T02:23:29Z" | javascript | "2023-10-27T01:09:05Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 56,996 | ["packages/next/src/server/lib/router-server.ts", "test/e2e/socket-io/app/layout.js", "test/e2e/socket-io/app/page.js", "test/e2e/socket-io/index.test.js", "test/e2e/socket-io/pages/api/socket.js"] | Web Socket (Socket IO) is not working with NextJS 13.5 | ### Link to the code that reproduces this issue
https://github.com/AntonioErdeljac/next13-discord-clone
### To Reproduce
1. Clone the tutorial https://github.com/AntonioErdeljac/next13-discord-clone
2. Upgrade NextJS to the latest version
3. You will start getting the error:
`Error handling upgrade request TypeError: Cannot read properties of undefined (reading 'bind') at DevServer.handleRequestImpl`
The SoketIO will not connect. You can only fix this error if you downgrade to 13.4.12
Once you downgrade, your client will be able to establish the connection successfully
### Current vs. Expected behavior
Client should be able to connect using Web Socket (SocketIO). However, we are getting the below error when using the latest NextJS version:
`Error handling upgrade request TypeError: Cannot read properties of undefined (reading 'bind') at DevServer.handleRequestImpl`
NextJS 13.4.12 version seems to be working fine.
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: win32
Arch: x64
Version: Windows 10 Enterprise
Binaries:
Node: 18.18.1
npm: N/A
Yarn: N/A
pnpm: N/A
Relevant Packages:
next: 13.4.12
eslint-config-next: 13.0.0
react: 18.2.0
react-dom: 18.2.0
typescript: 4.9.5
Next.js Config:
output: N/A
warn - Latest canary version not detected, detected: "13.4.12", newest: "13.5.6-canary.6".
Please try the latest canary version (`npm install next@canary`) to confirm the issue still exists before creating a new issue.
Read more - https://nextjs.org/docs/messages/opening-an-issue
```
### Which area(s) are affected? (Select all that apply)
App Router, Middleware / Edge (API routes, runtime), Package manager (npm, pnpm, Yarn)
### Additional context
_No response_ | https://github.com/vercel/next.js/issues/56996 | https://github.com/vercel/next.js/pull/57245 | 4a37c2d1a15e28f4780e304401eb453f2eff9d62 | eb4b41e513642cf1064731abef28b939df40bba8 | "2023-10-18T10:47:10Z" | javascript | "2023-10-23T17:23:34Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 56,810 | ["packages/next/src/server/lib/start-server.ts"] | Manual Graceful shutdowns do not work | ### Link to the code that reproduces this issue
https://github.com/higgins/next13-graceful-shutdown-bug
### To Reproduce
1. git clone https://github.com/higgins/next13-graceful-shutdown-bug.git
2. cd next13-graceful-shutdown-bug
3. npm i
4. npm run build
5. npm start
6. Send `SIGINT` or `SIGTERM` to the running server and observe no `Received SIGINT: cleaning up` or `Received SIGTERM: cleaning up` message logged
### Current vs. Expected behavior
Following steps 1-5 in previous section, I expect to see `Received SIGINT: cleaning up` or `Received SIGTERM: cleaning up` message logged after sending `SIGINT` or `SIGTERM` to the current server.
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 22.6.0: Fri Sep 15 13:41:28 PDT 2023; root:xnu-8796.141.3.700.8~1/RELEASE_ARM64_T6020
Binaries:
Node: 18.17.1
npm: 9.6.7
Yarn: N/A
pnpm: 8.7.5
Relevant Packages:
next: 13.5.5-canary.13
eslint-config-next: N/A
react: 18.2.0
react-dom: 18.2.0
typescript: N/A
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Not sure, App Router
### Additional context
We see the expected log message `Received SIGINT: cleaning up` **only at build time**
The run-time event handler is not attached. | https://github.com/vercel/next.js/issues/56810 | https://github.com/vercel/next.js/pull/59117 | a5e60f179b9589fc64f8c11d42940a7a5628d0e5 | cdff6df0980b854b7c0ce06ada82bc58ab545d2a | "2023-10-13T19:04:16Z" | javascript | "2023-12-01T03:05:20Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 56,741 | ["docs/03-pages/01-building-your-application/03-data-fetching/02-get-static-paths.mdx"] | Docs: description for 'getStaticPaths' in data-fetching docs need changes. | ### What is the improvement or update you wish to see?
If you see this documentation page closely you can find there is no description for 'getStaticPaths' instead of it's just copy paste of 'getStaticProps'.
I'm requesting the maintainers of this repo to please look into this.
### Is there any context that might help us understand?
I have made this changes from my end and If maintainers give this issue as hacktoberfest issue it would be great as a beginner and also I have made my PR already with changes based on my intuition.
https://github.com/vercel/next.js/pull/56740
Hoping to get this PR merge.
### Does the docs page already exist? Please link to it.
https://nextjs.org/docs/pages/building-your-application/data-fetching#fetching-data-on-the-client-side | https://github.com/vercel/next.js/issues/56741 | https://github.com/vercel/next.js/pull/56757 | a5d34d53f8b118ef97935a08fe1c960bd3ea9503 | 6fdba20b6d11fa6be459dc26214e6bbeb0c37652 | "2023-10-12T10:53:21Z" | javascript | "2023-10-12T16:18:20Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 56,615 | ["packages/next/src/server/lib/router-server.ts", "test/e2e/multi-zone/app/apps/first/pages/index.tsx", "test/e2e/multi-zone/app/apps/second/pages/index.tsx", "test/e2e/multi-zone/multi-zone.test.ts"] | Rewrite loop when using next-dev with localhost and different ports e.g. MultiZone setup | ### Link to the code that reproduces this issue
https://github.com/PacoSoftwerft/multi-zone-microfrontends
### To Reproduce
## Start main-site
```bash
cd main-site
npm run dev
```
## Start blog
Start the blog in a new shell
```bash
cd blog
npm run dev
```
## Bug
Open `http://localhost:3000/blog`, it is loading in a loop.
### Current vs. Expected behavior
Expected behavior:
rewrite to same domain "localhost" with different port should work like they did in 13.4.12
Version `[email protected]` is working just fine.
Stop the `main-site` then
```bash
cd main-site
npm i [email protected] --save-exact
npm run dev
```
open `http://localhost:3000/blog`
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Distributor ID: Ubuntu
Description: Ubuntu 22.04.3 LTS
Release: 22.04
Codename: jammy
Node: v18.18.0
npm: 10.1.0
```
### Which area(s) are affected? (Select all that apply)
Routing (next/router, next/navigation, next/link)
### Additional context
This bug was introduced with **13.4.13**
The bug only appears when using the **Pages Router**
The bug depends on the version of the app that rewrites, here **main-site**.
It seems like the **port** is stripped/not respected somewhere.
The rewrite works if it points to another domain.
Additional info 2023-10-20
The bug only appears when **both** zones are started with `npm run dev`
| main (3000) | blog (3001) | works? |
|---|---|---|
| `npm run dev` | `npm run dev` | ❌ |
| `npm run dev` | `npm run build` `npm run start` | ✅ |
| `npm run build` `npm run start` | `npm run dev` | ✅ |
| `npm run build` `npm run start` | `npm run build` `npm run start` | ✅| | https://github.com/vercel/next.js/issues/56615 | https://github.com/vercel/next.js/pull/59307 | 1f6defd4b097fb24d1fcf75a12cb77f082ed9706 | 61b825be3937dc1f095cde942d623c79559b2c53 | "2023-10-09T14:14:37Z" | javascript | "2023-12-06T20:15:42Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 56,614 | ["Cargo.lock", "Cargo.toml", "packages/next-swc/crates/core/Cargo.toml", "packages/next-swc/crates/core/src/cjs_optimizer.rs", "packages/next-swc/crates/core/src/optimize_server_react.rs", "packages/next-swc/crates/core/src/page_config.rs", "packages/next/package.json", "pnpm-lock.yaml"] | Maximum call stack size exceeded | ### Link to the code that reproduces this issue
https://github.com/Deeds67/nextjs-max-call-stack-size-exceeded
### To Reproduce
1. Add dependency `"@material-tailwind/react": "^2.1.0",`
2. Create a `NavbarDefault` component as listed here: https://www.material-tailwind.com/docs/react/navbar#navbar
3. Render this component on a page
4. Run `npm run build`
### Current vs. Expected behavior
Current behavior:
Build fails with the following error:
```RangeError: Maximum call stack size exceeded```
Expected behavior: Build should successfully pass.
Here's the full error output:
```
✗ npm run build
> [email protected] build
> next build
✓ Creating an optimized production build
✓ Compiled successfully
✓ Linting and checking validity of types
✓ Collecting page data
Generating static pages (0/5) [ ]RangeError: Maximum call stack size exceeded
at P (/home/pierre/dev/ts/max-call-stack-error/.next/server/chunks/241.js:5:231722)
at l (/home/pierre/dev/ts/max-call-stack-error/.next/server/chunks/241.js:5:227295)
at /home/pierre/dev/ts/max-call-stack-error/.next/server/chunks/241.js:5:228496
at Array.forEach (<anonymous>)
at /home/pierre/dev/ts/max-call-stack-error/.next/server/chunks/241.js:5:228469
at Array.forEach (<anonymous>)
at a (/home/pierre/dev/ts/max-call-stack-error/.next/server/chunks/241.js:5:228289)
at /home/pierre/dev/ts/max-call-stack-error/.next/server/chunks/241.js:5:228553
at Array.forEach (<anonymous>)
at l (/home/pierre/dev/ts/max-call-stack-error/.next/server/chunks/241.js:5:228246)
Error occurred prerendering page "/_not-found". Read more: https://nextjs.org/docs/messages/prerender-error
RangeError: Maximum call stack size exceeded
at P (/home/pierre/dev/ts/max-call-stack-error/.next/server/chunks/241.js:5:231722)
at l (/home/pierre/dev/ts/max-call-stack-error/.next/server/chunks/241.js:5:227295)
at /home/pierre/dev/ts/max-call-stack-error/.next/server/chunks/241.js:5:228496
at Array.forEach (<anonymous>)
at /home/pierre/dev/ts/max-call-stack-error/.next/server/chunks/241.js:5:228469
at Array.forEach (<anonymous>)
at a (/home/pierre/dev/ts/max-call-stack-error/.next/server/chunks/241.js:5:228289)
at /home/pierre/dev/ts/max-call-stack-error/.next/server/chunks/241.js:5:228553
at Array.forEach (<anonymous>)
at l (/home/pierre/dev/ts/max-call-stack-error/.next/server/chunks/241.js:5:228246)
RangeError: Maximum call stack size exceeded
at P (/home/pierre/dev/ts/max-call-stack-error/.next/server/chunks/241.js:5:231722)
at l (/home/pierre/dev/ts/max-call-stack-error/.next/server/chunks/241.js:5:227295)
at /home/pierre/dev/ts/max-call-stack-error/.next/server/chunks/241.js:5:228496
at Array.forEach (<anonymous>)
at /home/pierre/dev/ts/max-call-stack-error/.next/server/chunks/241.js:5:228469
at Array.forEach (<anonymous>)
at a (/home/pierre/dev/ts/max-call-stack-error/.next/server/chunks/241.js:5:228289)
at /home/pierre/dev/ts/max-call-stack-error/.next/server/chunks/241.js:5:228553
at Array.forEach (<anonymous>)
at l (/home/pierre/dev/ts/max-call-stack-error/.next/server/chunks/241.js:5:228246)
Error occurred prerendering page "/". Read more: https://nextjs.org/docs/messages/prerender-error
RangeError: Maximum call stack size exceeded
at P (/home/pierre/dev/ts/max-call-stack-error/.next/server/chunks/241.js:5:231722)
at l (/home/pierre/dev/ts/max-call-stack-error/.next/server/chunks/241.js:5:227295)
at /home/pierre/dev/ts/max-call-stack-error/.next/server/chunks/241.js:5:228496
at Array.forEach (<anonymous>)
at /home/pierre/dev/ts/max-call-stack-error/.next/server/chunks/241.js:5:228469
at Array.forEach (<anonymous>)
at a (/home/pierre/dev/ts/max-call-stack-error/.next/server/chunks/241.js:5:228289)
at /home/pierre/dev/ts/max-call-stack-error/.next/server/chunks/241.js:5:228553
at Array.forEach (<anonymous>)
at l (/home/pierre/dev/ts/max-call-stack-error/.next/server/chunks/241.js:5:228246)
✓ Generating static pages (5/5)
> Export encountered errors on following paths:
/_not-found
/page: /
```
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: linux
Arch: x64
Version: #202309191142~1695998943~22.04~070916d SMP PREEMPT_DYNAMIC Fri S
Binaries:
Node: 20.3.1
npm: 9.6.7
Yarn: N/A
pnpm: N/A
Relevant Packages:
next: 13.5.5-canary.4
eslint-config-next: 13.5.4
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Not sure
### Additional context
App works when running `npm run dev`, but not when building a production ready app using `npm run build`
<sub>[WEB-1744](https://linear.app/vercel/issue/WEB-1744/maximum-call-stack-size-exceeded)</sub> | https://github.com/vercel/next.js/issues/56614 | https://github.com/vercel/next.js/pull/56770 | 552b9747ff9551884499f165499dd6db1d8c4907 | 4b3dfdaa957ed3443b74cd0ef16e4c20b21416f6 | "2023-10-09T14:05:02Z" | javascript | "2023-10-17T13:19:28Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 56,612 | ["Cargo.lock", "Cargo.toml", "packages/next-swc/crates/core/Cargo.toml", "packages/next-swc/crates/napi/src/minify.rs", "packages/next/package.json", "packages/next/src/build/webpack/plugins/terser-webpack-plugin/src/index.ts", "pnpm-lock.yaml", "test/integration/export-intent/test/index.test.js"] | Problem With OpenAPI Private Identifiers | ### Link to the code that reproduces this issue
https://codesandbox.io/p/sandbox/competent-swartz-l9zwsj
### To Reproduce
1. Use [email protected] to generate typescript based on on OpenAPI specifications
2. Build the application (yarn build)
3. Start the production server (yarn start)
4. Open the application
5. Gets success responses of 200
6. The promise is not resolved in try and catch
### Current vs. Expected behavior
The generated files work well when running the application locally with yarn dev. But when running the build, the requests do not get resolved. The only difference compared to the previous versions is that it uses private identifiers.
Downgrading to [email protected] resolves the issue and has no problem. The issue is with using the latest next versions (13.5.4).
Request example:
```javascript
const getUser = async () => {
try {
const currentUser: any = await UsersSelfService.getSelf({}) // request is successfully made
// But Does not reach here
} catch (err) {
// Does not reach here
}
}
```
CancelablePromise generated from the codegen:
```typescript
/* generated using openapi-typescript-codegen -- do no edit */
/* istanbul ignore file */
/* tslint:disable */
/* eslint-disable */
export class CancelError extends Error {
constructor(message: string) {
super(message);
this.name = 'CancelError';
}
public get isCancelled(): boolean {
return true;
}
}
export interface OnCancel {
readonly isResolved: boolean;
readonly isRejected: boolean;
readonly isCancelled: boolean;
(cancelHandler: () => void): void;
}
export class CancelablePromise<T> implements Promise<T> {
#isResolved: boolean;
#isRejected: boolean;
#isCancelled: boolean;
readonly #cancelHandlers: (() => void)[];
readonly #promise: Promise<T>;
#resolve?: (value: T | PromiseLike<T>) => void;
#reject?: (reason?: any) => void;
constructor(
executor: (
resolve: (value: T | PromiseLike<T>) => void,
reject: (reason?: any) => void,
onCancel: OnCancel
) => void
) {
this.#isResolved = false;
this.#isRejected = false;
this.#isCancelled = false;
this.#cancelHandlers = [];
this.#promise = new Promise<T>((resolve, reject) => {
this.#resolve = resolve;
this.#reject = reject;
const onResolve = (value: T | PromiseLike<T>): void => {
if (this.#isResolved || this.#isRejected || this.#isCancelled) {
return;
}
this.#isResolved = true;
this.#resolve?.(value);
};
const onReject = (reason?: any): void => {
if (this.#isResolved || this.#isRejected || this.#isCancelled) {
return;
}
this.#isRejected = true;
this.#reject?.(reason);
};
const onCancel = (cancelHandler: () => void): void => {
if (this.#isResolved || this.#isRejected || this.#isCancelled) {
return;
}
this.#cancelHandlers.push(cancelHandler);
};
Object.defineProperty(onCancel, 'isResolved', {
get: (): boolean => this.#isResolved,
});
Object.defineProperty(onCancel, 'isRejected', {
get: (): boolean => this.#isRejected,
});
Object.defineProperty(onCancel, 'isCancelled', {
get: (): boolean => this.#isCancelled,
});
return executor(onResolve, onReject, onCancel as OnCancel);
});
}
get [Symbol.toStringTag]() {
return "Cancellable Promise";
}
public then<TResult1 = T, TResult2 = never>(
onFulfilled?: ((value: T) => TResult1 | PromiseLike<TResult1>) | null,
onRejected?: ((reason: any) => TResult2 | PromiseLike<TResult2>) | null
): Promise<TResult1 | TResult2> {
return this.#promise.then(onFulfilled, onRejected);
}
public catch<TResult = never>(
onRejected?: ((reason: any) => TResult | PromiseLike<TResult>) | null
): Promise<T | TResult> {
return this.#promise.catch(onRejected);
}
public finally(onFinally?: (() => void) | null): Promise<T> {
return this.#promise.finally(onFinally);
}
public cancel(): void {
if (this.#isResolved || this.#isRejected || this.#isCancelled) {
return;
}
this.#isCancelled = true;
if (this.#cancelHandlers.length) {
try {
for (const cancelHandler of this.#cancelHandlers) {
cancelHandler();
}
} catch (error) {
console.warn('Cancellation threw an error', error);
return;
}
}
this.#cancelHandlers.length = 0;
this.#reject?.(new CancelError('Request aborted'));
}
public get isCancelled(): boolean {
return this.#isCancelled;
}
}
```
tsconfig.json:
```javascript
{
"compilerOptions": {
"baseUrl": ".",
"target": "es6",
"lib": ["dom", "dom.iterable", "esnext"],
"allowJs": true,
"skipLibCheck": true,
"esModuleInterop": true,
"allowSyntheticDefaultImports": true,
"strict": false,
"forceConsistentCasingInFileNames": true,
"noFallthroughCasesInSwitch": true,
"module": "esnext",
"moduleResolution": "node",
"resolveJsonModule": true,
"isolatedModules": true,
"noEmit": true,
"jsx": "preserve",
"incremental": true
},
"include": ["src"],
"exclude": ["node_modules", ".next"]
}
```
next.config.js
```javascript
const nextConfig = {
swcMinify: true,
reactStrictMode: false,
}
```
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: linux
Arch: x64
Version: #34~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Thu Sep 7 13:12:03 UTC 2
Binaries:
Node: 18.16.0
npm: 9.5.1
Yarn: 1.22.19
pnpm: N/A
Relevant Packages:
next: 13.5.5-canary.4
eslint-config-next: 13.5.4
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Not sure
### Additional context
_No response_
<sub>[WEB-1743](https://linear.app/vercel/issue/WEB-1743/problem-with-openapi-private-identifiers)</sub> | https://github.com/vercel/next.js/issues/56612 | https://github.com/vercel/next.js/pull/57904 | da0f2ea11a4b0463e465b6a98ccac38532b8b5ef | c370c179b50fb09c6cb1f2a3b2c81c3302504c2b | "2023-10-09T12:40:15Z" | javascript | "2023-11-07T15:26:28Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 56,580 | ["packages/next/src/server/base-server.ts", "test/production/app-dir-prevent-304-caching/app/layout.js", "test/production/app-dir-prevent-304-caching/app/page.js", "test/production/app-dir-prevent-304-caching/index.test.ts", "test/production/app-dir-prevent-304-caching/next.config.js"] | App router time base revalidation failure | ### Link to the code that reproduces this issue
https://github.com/ehsmsh/nextjs-app-router-time-revalidation-bug
### To Reproduce
1. Build the application (yarn build)
2. Start the production server (yarn start)
3. Refresh the page a bunch of times
4. Open a private tab or a new browser (bypass cache)
5. Check the result
### Current vs. Expected behavior
The result should be revalidated based on:
```
export const revalidate = 1
```
but after some refreshes, it stops updating and returns a totally empty page. If it is stale in your current tab, try it in another browser or a private tab to bypass the browser cache and you'll see the empty page rather than the stale not revalidated data.
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: linux
Arch: x64
Version: #1 SMP Fri Jan 27 02:56:13 UTC 2023
Binaries:
Node: 18.17.1
npm: 9.8.1
Yarn: 1.22.19
pnpm: N/A
```
### Which area(s) are affected? (Select all that apply)
App Router
### Additional context
_No response_ | https://github.com/vercel/next.js/issues/56580 | https://github.com/vercel/next.js/pull/57737 | ac54377e6723543333109adff43a804778712a8f | 74153e1208e0f3cab8fa736e9192fd3ff7ad12cc | "2023-10-08T07:51:30Z" | javascript | "2023-11-01T00:48:03Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 56,550 | ["Cargo.lock", "Cargo.toml", "packages/next-swc/crates/core/Cargo.toml", "packages/next-swc/crates/core/src/cjs_optimizer.rs", "packages/next-swc/crates/core/src/optimize_server_react.rs", "packages/next-swc/crates/core/src/page_config.rs", "packages/next/package.json", "pnpm-lock.yaml"] | Build breaking when importing JSBI in 13.5.4 | ### Link to the code that reproduces this issue
https://github.com/jeremypress/next-issue-repro
### To Reproduce
1. run the application (this runs a built version of the app) https://replit.com/@jeremy/next-1354
2. notice the client side error
3. run the app on 13.5.3 https://replit.com/@jeremy/next-1353
4. notice no errors
Relevant code:
```typescript
import '../styles/globals.css'
import type { AppProps } from 'next/app'
import JSBI from 'jsbi';
const modulePath = require.resolve('jsbi');
console.log(modulePath);
function MyApp({ Component, pageProps }: AppProps) {
const x: JSBI = JSBI.BigInt(Math.floor(Math.random() * 10000));
console.log(x);
return <Component {...pageProps} />
}
export default MyApp
```
This package is linking to UMD via the "browser" entry, which isn't great, but something changed behavior wise between next 13.5.3 and next 13.5.4
### Current vs. Expected behavior
Following reproduction steps,
I did not expect this type error
`TypeError: Cannot call a class as a function`
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Node 18, mac/linux, default next.config.js
```
### Which area(s) are affected? (Select all that apply)
SWC transpilation
### Additional context
I tried to original submit this with a repl, which I think should be a valid way to submit bugs 🤷🏻
<sub>[WEB-1742](https://linear.app/vercel/issue/WEB-1742/build-breaking-when-importing-jsbi-in-1354)</sub> | https://github.com/vercel/next.js/issues/56550 | https://github.com/vercel/next.js/pull/56770 | 552b9747ff9551884499f165499dd6db1d8c4907 | 4b3dfdaa957ed3443b74cd0ef16e4c20b21416f6 | "2023-10-07T00:16:20Z" | javascript | "2023-10-17T13:19:28Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 56,456 | ["packages/next/src/server/dev/log-app-dir-error.ts"] | failed to fetch still present | ### Link to the code that reproduces this issue
https://github.com/AlvaroAquijeDiaz/toldyouso
### To Reproduce
1. start & login
2. go to `/secrets`
### Current vs. Expected behavior
should work
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 23.0.0: Fri Sep 15 14:41:43 PDT 2023; root:xnu-10002.1.13~1/RELEASE_ARM64_T6000
Binaries:
Node: 18.17.1
npm: 9.6.7
Yarn: 1.22.19
pnpm: 8.6.6
Relevant Packages:
next: 13.5.5-canary.2
eslint-config-next: 13.5.4
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
App Router
### Additional context
```
✓ Compiled /secrets/page in 483ms (1262 modules)
⨯ Internal error: TypeError: fetch failed
at Object.fetch (node:internal/deps/undici/undici:11576:11)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
⨯ Internal error: TypeError: fetch failed
at Object.fetch (node:internal/deps/undici/undici:11576:11)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
digest: "956933652"
```
I'm on the latest version, saw issues closed but this is still present even when deployed or when using `http://127.0.0.1:3000` is not fixing anything | https://github.com/vercel/next.js/issues/56456 | https://github.com/vercel/next.js/pull/56528 | edb92a30b5e7d5a10a64e2038699359317cad98f | 67cd9146c63f2c3f4f4358193cc89a9aaf0d604b | "2023-10-05T01:18:30Z" | javascript | "2023-10-06T23:22:13Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 56,408 | ["Cargo.lock", "Cargo.toml", "packages/next/package.json", "pnpm-lock.yaml"] | Prerender error with minify enabled | ### Link to the code that reproduces this issue
https://github.com/KDederichs/sentry_next_reproducer
### To Reproduce
Not sure what changed, I updated Nextjs from 13.4.19 to 13.5.4 and suddenly builds fail when minify is enabled.
Suddenly I'm getting errors like this on build:
```
✓ Creating an optimized production build
✓ Compiled successfully
Skipping linting
✓ Checking validity of types
✓ Collecting page data
Generating static pages (0/23) [ ] ⚠ Entire page /social-login/error deopted into client-side rendering. https://nextjs.org/docs/messages/deopted-into-client-rendering /social-login/error
⚠ Entire page /reset deopted into client-side rendering. https://nextjs.org/docs/messages/deopted-into-client-rendering /reset
Generating static pages (0/23) [= ] ⚠ Entire page /social-login/success deopted into client-side rendering. https://nextjs.org/docs/messages/deopted-into-client-rendering /social-login/success
⚠ Entire page /user/coins deopted into client-side rendering. https://nextjs.org/docs/messages/deopted-into-client-rendering /user/coins
Generating static pages (16/23) [== ]
{}
TypeError: ie is not a function
at <PATH_REPLACED>.next/server/chunks/888.js:1:13486
at Array.filter (<anonymous>)
at <PATH_REPLACED>.next/server/chunks/888.js:1:13453
at <PATH_REPLACED>.next/server/chunks/888.js:1:13504
at Object.rZ [as useMemo] (<PATH_REPLACED>node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected]/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:30300)
at t.useMemo (<PATH_REPLACED>node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected]/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:75:7338)
at de (<PATH_REPLACED>.next/server/chunks/888.js:1:13298)
at AvatarDropzone (<PATH_REPLACED>.next/server/app/user/settings/page.js:1:4793)
at nd (<PATH_REPLACED>node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected]/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:35308)
at nh (<PATH_REPLACED>node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected]/node
Error occurred prerendering page "/user/settings". Read more: https://nextjs.org/docs/messages/prerender-error
TypeError: ie is not a function
at <PATH_REPLACED>.next/server/chunks/888.js:1:13486
at Array.filter (<anonymous>)
at <PATH_REPLACED>.next/server/chunks/888.js:1:13453
at <PATH_REPLACED>.next/server/chunks/888.js:1:13504
at Object.rZ [as useMemo] (<PATH_REPLACED>node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected]/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:30300)
at t.useMemo (<PATH_REPLACED>node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected]/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:75:7338)
at de (<PATH_REPLACED>.next/server/chunks/888.js:1:13298)
at AvatarDropzone (<PATH_REPLACED>.next/server/app/user/settings/page.js:1:4793)
at nd (<PATH_REPLACED>node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected]/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:35308)
at nh (<PATH_REPLACED>node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected]/node_modules/next/dist/c
✓ Generating static pages (23/23)
```
### Current vs. Expected behavior
I'd expect it to build regardless of minification.
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 23.0.0: Fri Sep 15 14:41:34 PDT 2023; root:xnu-10002.1.13~1/RELEASE_ARM64_T8103
Binaries:
Node: 18.13.0
npm: 9.6.7
Yarn: 1.22.19
pnpm: 8.7.4
Relevant Packages:
next: 13.5.4
eslint-config-next: N/A
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Not sure
### Additional context
Looks like 13.5.3 still works, so it has to be something that happened in 13.5.4
Note: Reproducer link is completely unrelated, I just don't want this closed again -.-
If you REALLY REALLY REALLY need one, I'll try to dig and see what minification fails now but I'd rather not.
<sub>[WEB-1796](https://linear.app/vercel/issue/WEB-1796/prerender-error-with-minify-enabled)</sub> | https://github.com/vercel/next.js/issues/56408 | https://github.com/vercel/next.js/pull/57121 | c5207751a20d2dc731a5ec18d6548e8bb8dfab41 | 652a553a130c57df276db5e2267a8233e1552a73 | "2023-10-04T10:36:04Z" | javascript | "2023-10-23T03:01:31Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 56,357 | ["packages/next/src/build/collect-build-traces.ts", "test/integration/image-optimizer/test/util.ts"] | Missing node_modules in standalone output | ### Link to the code that reproduces this issue
https://github.com/noreiller/next-missing-modules-in-standalone-pages
### To Reproduce
1. Run `npm i`
2. Run `npm i [email protected]`
3. Run `npm run build`
4. See that the directory `.next/standalone/node_modules/@kontent-ai/delivery-sdk/dist/cjs/mappers` only contains the `index.js` file.
### Current vs. Expected behavior
Starting from [v13.5.4-canary.4](https://github.com/vercel/next.js/commit/f5ac079e5426f6894c97925bd9cc2a1a8c2e9efa), the directory `.next/standalone/node_modules/@kontent-ai/delivery-sdk/dist/cjs/mappers` only contains the `index.js` file while previously it contained all the required modules used in the `index.js` file.
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: linux
Arch: x64
Version: #33~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Thu Sep 7 10:33:52 UTC 2
Binaries:
Node: 18.12.1
npm: 8.19.2
Yarn: 1.22.19
pnpm: 8.2.0
Relevant Packages:
next: 13.5.4
eslint-config-next: 13.5.4
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: standalone
```
### Which area(s) are affected? (Select all that apply)
Standalone mode (output: "standalone")
### Additional context
In `node_modules`:
In `.next/standalone/node_modules`:
<sub>[NEXT-1675](https://linear.app/vercel/issue/NEXT-1675/missing-node-modules-in-standalone-output)</sub> | https://github.com/vercel/next.js/issues/56357 | https://github.com/vercel/next.js/pull/56674 | 52356a0e14c51b096a6229f25bdd31a0f14da5a9 | 7a08f0082dd3d085d1345233273ac526f2833bba | "2023-10-03T10:48:51Z" | javascript | "2023-10-10T19:41:44Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 56,296 | ["packages/next-swc/crates/core/src/server_actions.rs", "packages/next-swc/crates/core/tests/errors/server-actions/client-graph/1/output.stderr"] | Docs: Invalid URL (404) provided on server actions error | ### What is the improvement or update you wish to see?
My wrong code has led me to an error logging that should an invalid URL for the Nextjs app router docs.
here is the error logged:
```
It is not allowed to define inline "use server" annotated Server Actions in Client Components.
| To use Server Actions in a Client Component, you can either export them from a separate file with "use server" at the top, or pass them down through props from a Server Component.
|
| Read more: https://nextjs.org/docs/app/api-reference/server-actions#with-client-components
|
```
But the problem here is the provided URL is not a valid page:
https://nextjs.org/docs/app/api-reference/server-actions#with-client-components
I believe it should be referencing this page covering server actions:
https://nextjs.org/docs/app/api-reference/functions/server-actions#with-client-components
### Is there any context that might help us understand?
this could lead to people not being able to find the proper documentation although it exists
### Does the docs page already exist? Please link to it.
https://nextjs.org/docs/app/api-reference/functions/server-actions#with-client-components | https://github.com/vercel/next.js/issues/56296 | https://github.com/vercel/next.js/pull/56323 | 3172cfedc8b759fec89fda373c86b86931fc02f1 | eeb9b3325d6c21107463532b9ae99f48b0cd524f | "2023-10-02T09:56:29Z" | javascript | "2023-10-02T22:32:43Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 56,286 | ["packages/next/src/server/app-render/action-handler.ts", "packages/next/src/server/body-streams.ts", "test/e2e/app-dir/actions/middleware.js"] | Server action hangs in form when Javascript is disabled | ### Link to the code that reproduces this issue
https://github.com/jchamale/next-bug-runtime.git
### To Reproduce
1. Start the server development
2. Open the page, then open dev tools
3. Disable Javascript
4. Reload page
5. Fill the form and submit
6. The request will never finish
7. Changing the runtime on the home page to `edge` is working fine.
8. The bug was tested in Chrome and confirmed in Safari
### Current vs. Expected behavior
The server action should work no matter what the runtime is. It seems that adding a middleware will break the server action for being ran if JS is disabled.
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 23.0.0: Fri Sep 15 14:41:43 PDT 2023; root:xnu-10002.1.13~1/RELEASE_ARM64_T6000
Binaries:
Node: 18.18.0
npm: 9.8.1
Yarn: N/A
pnpm: N/A
Relevant Packages:
next: 13.5.3
eslint-config-next: 13.5.3
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
App Router, Middleware / Edge (API routes, runtime)
### Additional context
I tested in latest version as well with the same result.
```sh
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 23.0.0: Fri Sep 15 14:41:43 PDT 2023; root:xnu-10002.1.13~1/RELEASE_ARM64_T6000
Binaries:
Node: 18.18.0
npm: 9.8.1
Yarn: N/A
pnpm: N/A
Relevant Packages:
next: 13.5.4-canary.8
eslint-config-next: 13.5.3
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
``` | https://github.com/vercel/next.js/issues/56286 | https://github.com/vercel/next.js/pull/57381 | 81582629608a431521c55732c3690cdedb80c1d7 | 59ebfbea9ee832f01c0a0d10a956b92814124fc7 | "2023-10-02T06:54:22Z" | javascript | "2023-10-25T02:44:10Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 56,259 | ["packages/next/src/build/webpack/loaders/next-app-loader.ts", "packages/next/src/build/webpack/plugins/flight-client-entry-plugin.ts", "packages/next/src/server/app-render/entry-base.ts", "test/e2e/app-dir/global-error/catch-all/app/[lang]/[...slug]/page.js", "test/e2e/app-dir/global-error/catch-all/app/[lang]/global-error.js", "test/e2e/app-dir/global-error/catch-all/app/[lang]/layout.js", "test/e2e/app-dir/global-error/catch-all/index.test.ts", "test/e2e/app-dir/global-error/next.config.js"] | Error layout, global error and not found issues with internationalization | ### Link to the code that reproduces this issue
https://github.com/mertafor/next-error-template-issue
### To Reproduce
1 - Run pnpm build
2 - Build process fails by throwing following error :
```
> [email protected] build /Users/mertdaglaroglu/Documents/WebProjects/Reactive/comnet/next-error-template-issue
> next build
✓ Creating an optimized production build
✓ Compiled successfully
✓ Linting and checking validity of types
✓ Collecting page data
Generating static pages (0/5) [ ]Error: Could not find the module "/Users/mertdaglaroglu/Documents/WebProjects/Reactive/comnet/next-error-template-issue/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/client/components/error-boundary.js#" in the React Client Manifest. This is probably a bug in the React Server Components bundler.
at ex (/Users/mertdaglaroglu/Documents/WebProjects/Reactive/comnet/next-error-template-issue/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/compiled/next-server/app-page-experimental.runtime.prod.js:125:12678)
at /Users/mertdaglaroglu/Documents/WebProjects/Reactive/comnet/next-error-template-issue/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/compiled/next-server/app-page-experimental.runtime.prod.js:125:25344
at Object.toJSON (/Users/mertdaglaroglu/Documents/WebProjects/Reactive/comnet/next-error-template-issue/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/compiled/next-server/app-page-experimental.runtime.prod.js:125:26437)
at stringify (<anonymous>)
at ej (/Users/mertdaglaroglu/Documents/WebProjects/Reactive/comnet/next-error-template-issue/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/compiled/next-server/app-page-experimental.runtime.prod.js:125:14133)
at eI (/Users/mertdaglaroglu/Documents/WebProjects/Reactive/comnet/next-error-template-issue/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/compiled/next-server/app-page-experimental.runtime.prod.js:125:14661)
at Timeout._onTimeout (/Users/mertdaglaroglu/Documents/WebProjects/Reactive/comnet/next-error-template-issue/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/compiled/next-server/app-page-experimental.runtime.prod.js:125:12095)
at listOnTimeout (node:internal/timers:573:17)
at process.processTimers (node:internal/timers:514:7)
Error: Could not find the module "/Users/mertdaglaroglu/Documents/WebProjects/Reactive/comnet/next-error-template-issue/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/client/components/error-boundary.js#" in the React Client Manifest. This is probably a bug in the React Server Components bundler.
at ex (/Users/mertdaglaroglu/Documents/WebProjects/Reactive/comnet/next-error-template-issue/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/compiled/next-server/app-page-experimental.runtime.prod.js:125:12678)
at /Users/mertdaglaroglu/Documents/WebProjects/Reactive/comnet/next-error-template-issue/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/compiled/next-server/app-page-experimental.runtime.prod.js:125:25344
at Object.toJSON (/Users/mertdaglaroglu/Documents/WebProjects/Reactive/comnet/next-error-template-issue/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/compiled/next-server/app-page-experimental.runtime.prod.js:125:26437)
at stringify (<anonymous>)
at ej (/Users/mertdaglaroglu/Documents/WebProjects/Reactive/comnet/next-error-template-issue/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/compiled/next-server/app-page-experimental.runtime.prod.js:125:14133)
at eI (/Users/mertdaglaroglu/Documents/WebProjects/Reactive/comnet/next-error-template-issue/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/compiled/next-server/app-page-experimental.runtime.prod.js:125:14661)
at Timeout._onTimeout (/Users/mertdaglaroglu/Documents/WebProjects/Reactive/comnet/next-error-template-issue/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/compiled/next-server/app-page-experimental.runtime.prod.js:125:12095)
at listOnTimeout (node:internal/timers:573:17)
at process.processTimers (node:internal/timers:514:7)
[Error: An error occurred in the Server Components render. The specific message is omitted in production builds to avoid leaking sensitive details. A digest property is included on this error instance which may provide additional details about the nature of the error.] {
digest: '2779839787'
}
Error occurred prerendering page "/_not-found". Read more: https://nextjs.org/docs/messages/prerender-error
Error: An error occurred in the Server Components render. The specific message is omitted in production builds to avoid leaking sensitive details. A digest property is included on this error instance which may provide additional details about the nature of the error.
✓ Generating static pages (5/5)
> Export encountered errors on following paths:
/_not-found
ELIFECYCLE Command failed with exit code 1.
```
### Current vs. Expected behavior
Unfortunately default pages like not-found and global-error pages are not well planned for internationalization, or at least I'd say it's not very well explained in docs. Either I'm doing something wrong or it's a buggy behavior on Next's side.
It's recommended to create `not-found.tsx` and `global-error.tsx` directly inside of app folder. However, inserting these files to app folder won't work because `layout.tsx` is inside` app/[lang] `folder instead. As you can see in the minimal repo I provided, I've been able to fix this problem by creating a `[...not-found]` folder to catch any 404 error. Also `global-error.tsx` is being used to catch any other server error such as 500 and was used to work in `app/[lang]` folder safely. However recent releases don't allow this.
Now, when I use `global-error.tsx` inside of app folder, I get a build error. It's gone when I delete it. That said, right now I have no option to catch global errors and fallback page will be Next's default error page. Also I'm hoping an official solution for working with `not-found.tsx` page directly instead of `[...not-found]` workaround.
This issue started after v13.4.20-canary.12 :
- Default app router not found (My guess is this one is causing the problem)
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 23.0.0: Fri Sep 15 14:43:05 PDT 2023; root:xnu-10002.1.13~1/RELEASE_ARM64_T6020
Binaries:
Node: 20.5.1
npm: 9.8.0
Yarn: 1.22.19
pnpm: 8.7.6
Relevant Packages:
next: 13.5.4-canary.8
eslint-config-next: 13.5.3
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
App Router
### Additional context
It works fine with any version before v13.4.20-canary.12
<sub>[NEXT-1749](https://linear.app/vercel/issue/NEXT-1749/error-layout-global-error-and-not-found-issues-with)</sub> | https://github.com/vercel/next.js/issues/56259 | https://github.com/vercel/next.js/pull/59085 | 956636c86f508bb79cfc10c6a9bc40039de6366c | d37b5076297e39e11b81e9154ccb8fef3dafa56c | "2023-10-01T11:39:20Z" | javascript | "2023-11-30T15:36:14Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 56,235 | ["packages/next/src/server/app-render/app-render.tsx", "test/e2e/app-dir/app/app/(newroot)/dashboard/project/[projectId]/page.js", "test/production/app-dir/unexpected-error/app/isr-unexpected-error/page.tsx", "test/production/app-dir/unexpected-error/app/layout.tsx", "test/production/app-dir/unexpected-error/app/ssr-unexpected-error-after-streaming/loading.tsx", "test/production/app-dir/unexpected-error/app/ssr-unexpected-error-after-streaming/page.tsx", "test/production/app-dir/unexpected-error/app/ssr-unexpected-error/page.tsx", "test/production/app-dir/unexpected-error/next.config.js", "test/production/app-dir/unexpected-error/unexpected-error.test.ts"] | Server response status is 200 for unexpected error before streaming | ### Link to the code that reproduces this issue
https://codesandbox.io/p/sandbox/nice-panini-2z3mcp
### To Reproduce
1. Create new application
2. Add new app route in which an error is thrown after the build before any streaming should have started (e.g., no loading or suspense).
4. Build the app and access the app route.
5. The response code is 200
### Current vs. Expected behavior
**Current Behavior**
At the moment, when an unexpected error occurs during app server rendering, a 200 ok is returned as status code. This seems to be undesirable because of the success status CDNs will cache the error pages and crawlers will index the page considering the error content as the actual content.
**Desired Behavior**
This issue is related to discussion https://github.com/vercel/next.js/discussions/53225. Even though I understand that the response status code cannot be set if streaming has started, in my view it would be best to set the response status to 500 whenever it can (so before the streaming has started) for SEO and (CDN) http caching. This would also be consistent with how 404s currently work; that is, response status code is set to 404 if `NotFoundError` occurred before streaming (related [issue](https://github.com/vercel/next.js/issues/43831) & [PR](https://github.com/vercel/next.js/pull/55542)).
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 22.5.0: Thu Jun 8 22:22:23 PDT 2023; root:xnu-8796.121.3~7/RELEASE_ARM64_T6020
Binaries:
Node: 18.15.0
npm: 9.5.0
Yarn: 1.22.19
pnpm: 8.7.1
Relevant Packages:
next: 13.5.4-canary.6
eslint-config-next: 13.5.4-canary.6
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
App Router
### Additional context
_No response_ | https://github.com/vercel/next.js/issues/56235 | https://github.com/vercel/next.js/pull/56236 | ee9bee96afbd75eca35f2bc02cfbd54846d26162 | 218d0709eb97017e5bbd55f603bce033206bf71e | "2023-09-30T11:29:41Z" | javascript | "2023-10-17T13:32:20Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 56,212 | ["packages/next/src/client/components/router-reducer/fetch-server-response.ts", "test/e2e/app-dir/navigation/app/hash-link-to-pages-router/global.css", "test/e2e/app-dir/navigation/app/hash-link-to-pages-router/page.js", "test/e2e/app-dir/navigation/navigation.test.ts"] | Hash is removed when linking from app router to pages router | ### Link to the code that reproduces this issue
https://github.com/blurrah/nextjs-app-page-router-hash-issue-reproduction
### To Reproduce
1. Start the application in development mode
2. Click on the issue link
### Current vs. Expected behavior
Following the steps from the previous section I expect the hash in the link to be available, but it's being removed when switching from the app router to the pages router. It does however keep the hash when switching from pages router to the app router.
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 22.5.0: Thu Jun 8 22:22:20 PDT 2023; root:xnu-8796.121.3~7/RELEASE_ARM64_T6000
Binaries:
Node: 20.5.1
npm: 9.8.0
Yarn: 1.22.19
pnpm: 8.5.0
Relevant Packages:
next: 13.5.4-canary.7
eslint-config-next: N/A
react: 18.2.0
react-dom: 18.2.0
typescript: 5.1.3
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
App Router, Routing (next/router, next/navigation, next/link)
### Additional context
I see this happening on a production site running 13.4.12 and on the latest canary. | https://github.com/vercel/next.js/issues/56212 | https://github.com/vercel/next.js/pull/56223 | a970f284398d4125c04908d42704b2ab98b9d98b | a2f9ef5a34418d562581f54353ed51491a019484 | "2023-09-29T13:51:20Z" | javascript | "2023-10-02T21:43:04Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 56,174 | ["packages/create-next-app/templates/index.ts"] | create-next-app puts all dependencies to `latest` instead of pinning version | ### Link to the code that reproduces this issue
https://github.com/vercel/next.js
### To Reproduce
`pnpm create next-app`
### Current vs. Expected behavior
Current: All packages are `latest`.
Expected: Package versions should be pinned.
The reason package versions should be pinned is because, in my opinion, the job of upgrading packages should be the developer's responsibility, as the developer needs to ensure the app still works normally before upgrading any dependencies – as who knows, there could be a release where a dependency may bring breaking changes to the codebase.
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Not applicable.
```
### Which area(s) are affected? (Select all that apply)
CLI (create-next-app)
### Additional context
I used a dummy link for the "Link to the code that reproduces this issue" section because here it doesn't require a reproduction repository to see the bug. Sorry about that.
Looks like the bug is from https://github.com/vercel/next.js/pull/55730.
<sub>[NEXT-1664](https://linear.app/vercel/issue/NEXT-1664/create-next-app-puts-all-dependencies-to-latest-instead-of-pinning)</sub> | https://github.com/vercel/next.js/issues/56174 | https://github.com/vercel/next.js/pull/56177 | 403cb4a6ac446dfb5176bf21a0d31b412323c49e | 4ec443931aaf53bd831fa57ac5733b97d7dac550 | "2023-09-28T15:46:43Z" | javascript | "2023-09-28T18:22:02Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 56,151 | ["examples/with-jest/package.json"] | npm run build fails in example with-jest | ### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: linux
Arch: x64
Version: #33~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Thu Sep 7 10:33:52 UTC 2
Binaries:
Node: 16.20.0
npm: 8.19.4
Yarn: N/A
pnpm: N/A
Relevant Packages:
next: 13.5.4-canary.4
eslint-config-next: N/A
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which example does this report relate to?
with-jest
### What browser are you using? (if relevant)
_No response_
### How are you deploying your application? (if relevant)
_No response_
### Describe the Bug
`npm run build` fails with:
```shell
Type error: Cannot find type definition file for 'testing-library__jest-dom'.
The file is in the program because:
Entry point for implicit type library 'testing-library__jest-dom'
```
### Expected Behavior
`npm run build` should run successfully.
### To Reproduce
1. In terminal run `npx create-next-app --example with-jest with-jest-app`
2. cd into with-jest-app `cd with-jest-app/`
3. update next `npm install next@canary`
4. run `npm run build` | https://github.com/vercel/next.js/issues/56151 | https://github.com/vercel/next.js/pull/56152 | 741114adeaaa8abcffb46f75c62bf386ae229cd0 | a623685f44c743299cc422e3015861013cec72a1 | "2023-09-28T11:13:15Z" | javascript | "2023-09-29T01:56:09Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 56,072 | ["packages/next/src/client/components/router-reducer/reducers/restore-reducer.ts", "test/e2e/app-dir/interception-middleware-rewrite/app/[lang]/@modal/(.)photos/[id]/page.tsx", "test/e2e/app-dir/interception-middleware-rewrite/app/[lang]/layout.tsx", "test/e2e/app-dir/interception-middleware-rewrite/app/[lang]/photos/[id]/page.tsx", "test/e2e/app-dir/interception-middleware-rewrite/interception-middleware-rewrite.test.ts"] | Route interception not working as expected when using NextResponse.rewrite | ### Link to the code that reproduces this issue
https://github.com/mastoj/nextgram
### To Reproduce
1. Start application in dev mode
2. Go to start page
3. Click photo
4. Refresh page
5. Go back
6. Click another photo
### Current vs. Expected behavior
Actual: In step 3. above a modal is shown, but not in step 6.
Expected: The modal should be shown in step 6 as well.
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 22.5.0: Thu Jun 8 22:22:23 PDT 2023; root:xnu-8796.121.3~7/RELEASE_ARM64_T6020
Binaries:
Node: 18.16.1
npm: 9.5.1
Yarn: 1.22.19
pnpm: 8.6.10
Relevant Packages:
next: 13.5.4-canary.1
eslint-config-next: N/A
react: 18.2.0
react-dom: 18.2.0
typescript: 5.1.3
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
App Router, Middleware / Edge (API routes, runtime)
### Additional context
This could potentially impact any application that does internationalization using the path and rewriting in middleware to add the market/country or whatnot to render the right page. | https://github.com/vercel/next.js/issues/56072 | https://github.com/vercel/next.js/pull/59094 | d509c2d52894e23e89eaec136847a0a60cd26519 | d605ef610136b9bb62583b0d0f02c56f515188d8 | "2023-09-27T08:09:45Z" | javascript | "2023-11-30T07:57:42Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 55,942 | ["packages/next/src/server/lib/router-server.ts", "test/e2e/app-dir/x-forwarded-headers/app/route.tsx", "test/e2e/app-dir/x-forwarded-headers/x-forwarded-headers.test.ts"] | Forwarded request headers are null | ### Link to the code that reproduces this issue
https://github.com/razvanMiu/nextjs-forwarded-headers-issue
### To Reproduce
1. Start application in development (npm run dev)
2. Check logged value of `X-Forwarded-Host` header
### Current vs. Expected behavior
Following the steps from the previous section, I expected the `X-Forwarded-Host` to return the current host but I get `null` instead.
I use `X-Forwarded-Host` to forward the server name of nginx and it worked as expected in nextjs <= 13.4.12
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 22.5.0: Mon Apr 24 20:52:24 PDT 2023; root:xnu-8796.121.2~5/RELEASE_ARM64_T6000
Binaries:
Node: 20.5.1
npm: 9.8.0
Yarn: N/A
pnpm: N/A
Relevant Packages:
next: 13.5.2
eslint-config-next: 13.5.2
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Not sure
### Additional context
The first version that introduced the bug is `13.4.13-canary.0` since reverting to `13.4.12` works as expected
<sub>[NEXT-1663](https://linear.app/vercel/issue/NEXT-1663/forwarded-request-headers-are-null)</sub> | https://github.com/vercel/next.js/issues/55942 | https://github.com/vercel/next.js/pull/56797 | ac8a6035df20a65dcebad2570c867e59d43ff0ee | fe0bfbf9118cef355fd6f2f6e667deb57ad66e69 | "2023-09-25T09:02:18Z" | javascript | "2023-10-13T17:58:33Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 55,932 | ["packages/next/src/build/webpack/plugins/flight-client-entry-plugin.ts"] | Server Actions - ⨯ TypeError: e._formData.forEach is not a function | ### Link to the code that reproduces this issue
https://github.com/krasimir/nextjs-sc
### To Reproduce
Make sure that you are using Node v18.0.0
1. Start the application with `yarn dev`
2. Open http://localhost:3000
3. Try submitting the form
### Current vs. Expected behavior
The expected behavior is get the form submitted successfully.
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 22.6.0: Wed Jul 5 22:22:05 PDT 2023; root:xnu-8796.141.3~6/RELEASE_ARM64_T6000
Binaries:
Node: 18.0.0
npm: 8.6.0
Yarn: 1.22.19
pnpm: N/A
Relevant Packages:
next: 13.5.2
eslint-config-next: 13.5.2
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Data fetching (gS(S)P, getInitialProps)
### Additional context
Once I switched to Node v20 the problem is gone.
<sub>[NEXT-1658](https://linear.app/vercel/issue/NEXT-1658/server-actions-⨯-typeerror-e-formdataforeach-is-not-a-function)</sub> | https://github.com/vercel/next.js/issues/55932 | https://github.com/vercel/next.js/pull/57191 | c43c9159615f722d8c0e3a0d172cd70d424e1df8 | eae65fa7b957b84a1efca9c71efaf91b8dd423cc | "2023-09-25T04:45:48Z" | javascript | "2023-10-21T19:32:46Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 55,891 | ["packages/next/src/lib/mkcert.ts"] | Error while trying HTTPS support for development --experimental-https | ### Link to the code that reproduces this issue
https://github.com/aayman997/test-https
### To Reproduce
1. Create a new Next.js project with version 13.5.0 or above
2. Edit dev script to be `"dev": "next dev --experimental-https"`
3. Run the development server
### Current vs. Expected behavior
Current behavior:
An error occurred while generating a self-signed certificate and the server started with HTTP
Expected behavior:
the self-signed certificate should be created usually and the server run with HTTPS
### Verify canary release
- [x] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: Windows 11 Pro
Arch: x64
Version: 22H2
Binaries:
Node: 18.18.0
npm: 9.8.1
Relevant Packages:
next: 13.5.2
react: 18.2.0
react-dom: 18.2.0
```
### Which area(s) are affected? (Select all that apply)
Not sure
### Additional context
_No response_ | https://github.com/vercel/next.js/issues/55891 | https://github.com/vercel/next.js/pull/55947 | 9e3c1829b0d904910ea1718f02a46888138bb8ea | e0e573546b6eb13247fc61e4360af01a498c7b60 | "2023-09-23T22:46:58Z" | javascript | "2023-09-25T15:57:58Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 55,869 | ["docs/02-app/02-api-reference/01-components/image.mdx"] | Docs: bug - markdown table not rendered for the Image component page | ### What is the improvement or update you wish to see?
[This](https://nextjs.org/docs/pages/api-reference/components/image) docs page has the following broken prop table:
### Is there any context that might help us understand?
This PR https://github.com/vercel/next.js/pull/55776 might be the cause
### Does the docs page already exist? Please link to it.
https://nextjs.org/docs/pages/api-reference/components/image | https://github.com/vercel/next.js/issues/55869 | https://github.com/vercel/next.js/pull/55889 | 951af1d9fc4d97c7e06c9cf4f3fdba91981144fc | 814db26c9cb09ebdd97c9b63fb4e1b220290e326 | "2023-09-23T13:00:06Z" | javascript | "2023-09-23T22:30:26Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 55,862 | ["packages/next/src/lib/helpers/get-registry.ts", "test/integration/cli/test/index.test.js"] | Node inspector stopped working on v13.5.x | ### Link to the code that reproduces this issue
https://codesandbox.io/p/sandbox/sweet-lumiere-xtd4sp
### To Reproduce
1. Start the application with `NODE_OPTIONS='--inspect' next dev`
### Current vs. Expected behavior
Current behaviour:
Next attempts to start inspector processes on the same port for app/pages
```
Debugger listening on ws://127.0.0.1:9229/ad4c68d8-17a0-4a19-8eef-xxxxxxxx
For help, see: https://nodejs.org/en/docs/inspector
Starting inspector on 127.0.0.1:9229 failed: address already in use
the --inspect option was detected, the Next.js router server should be inspected at port 9229.
Starting inspector on 127.0.0.1:9229 failed: address already in use
Starting inspector on 127.0.0.1:9229 failed: address already in use
```
Expected behaviour:
```
Debugger listening on ws://127.0.0.1:9229/289f58ca-1415-44d8-ba9d-xxxxxxx
For help, see: https://nodejs.org/en/docs/inspector
- info Loaded env from /home/user/next/.env.local
...
Debugger listening on ws://127.0.0.1:9230/30db6056-c4af-49ec-af1d-xxxxxx
For help, see: https://nodejs.org/en/docs/inspector
- info the --inspect option was detected, the Next.js router server should be inspected at port 9230.
- ready started server on [::]:3000, url: http://localhost:3000
- info the --inspect option was detected, the Next.js server for app should be inspected at port 9232.
- info the --inspect option was detected, the Next.js server for pages should be inspected at port 9231.
```
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: linux
Arch: x64
Version: #1
Binaries:
Node: 18.16.0
npm: 9.5.1
Yarn: 3.6.3
pnpm: N/A
Relevant Packages:
next: 13.5.2
eslint-config-next: N/A
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Not sure, CLI (create-next-app)
### Additional context
Reverting to v13.4.19 works. | https://github.com/vercel/next.js/issues/55862 | https://github.com/vercel/next.js/pull/59530 | eb6aae640f140c40f53503247007e179f6f7ba12 | b441cff7a90fe205842ec1932289166e7116de6f | "2023-09-23T08:07:53Z" | javascript | "2023-12-12T15:03:13Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 55,785 | ["packages/next-swc/crates/next-core/src/next_client/context.rs", "packages/next-swc/crates/next-core/src/next_server/context.rs"] | Css not load from node_module when run with mode: next dev --turbo | ### Link to the code that reproduces this issue
https://codesandbox.io/p/sandbox/nice-star-fcnhf5
### To Reproduce
1. Visit codesanbox above
2. npm run dev
3. Do not show error but css seem not loading and effect to layout
The result as below:
<img width="663" alt="Screenshot 2023-09-22 at 11 04 13" src="https://github.com/vercel/next.js/assets/24804332/e364b832-15e5-4b1e-9590-f697b3ee9495">
<img width="1440" alt="Screenshot 2023-09-22 at 11 05 50" src="https://github.com/vercel/next.js/assets/24804332/150940e2-4f9c-45fe-ad38-0fa2db4ac8f8">
### Current vs. Expected behavior
The result work correct as expected if we follow the step as below:
1. Visit codesanbox above
2. Edit package.json and remove option --turbo
3. npm run dev
4. The result work as expected
Or use
`next build`
The result:
<img width="1457" alt="Screenshot 2023-09-22 at 11 08 14" src="https://github.com/vercel/next.js/assets/24804332/d63f27c9-796d-4763-8317-ebb03d066093">
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: linux
Arch: x64
Version: #1 SMP PREEMPT_DYNAMIC Sun Aug 6 20:05:33 UTC 2023
Binaries:
Node: 20.5.1
npm: 9.8.0
Yarn: 1.22.19
pnpm: N/A
Relevant Packages:
next: 13.5.3-canary.1
eslint-config-next: 13.5.1
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Turbopack (--turbo)
### Additional context
_No response_ | https://github.com/vercel/next.js/issues/55785 | https://github.com/vercel/next.js/pull/56679 | c8b2d1b44a9f9376eee7bc6c26e84bd7f5c03354 | d79f8a2f0381e23ac9b82fb7428f306e7a40a360 | "2023-09-22T04:02:52Z" | javascript | "2023-10-10T23:16:12Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 55,741 | ["packages/next/index.d.ts"] | next/navigation can't be auto imported when using vscode | ### Link to the code that reproduces this issue
https://github.com/thomas901/minimal-reproduction
### To Reproduce
1. using create-next-app
```
❯ npx create-next-app@latest
✔ What is your project named? … my-app
✔ Would you like to use TypeScript? … No / (Yes)
✔ Would you like to use ESLint? … No / (Yes)
✔ Would you like to use Tailwind CSS? … (No) / Yes
✔ Would you like to use `src/` directory? … No / (Yes)
✔ Would you like to use App Router? (recommended) … No / (Yes)
✔ Would you like to customize the default import alias? … (No) / Yes
Creating a new Next.js app in (directory)/my-app.
Using npm.
Initializing project with template: app
Installing dependencies:
- react
- react-dom
- next
- typescript
- @types/react
- @types/node
- @types/react-dom
- eslint
- eslint-config-next
```
2. Open file _src/app/page.tsx_
### Current vs. Expected behavior
_In file src/app/page.tsx:_
### Expected Example
Type `useAmp` and auto import adds `import { useAmp } from "next/amp";` to the top of file.
### Current
Type `useSearchParams` and auto import fails to find the correct import. (Need to manually type it out)
_Note_: It seems to only affect the functions declared in `next/navigation`
### Expected
Type `useSearchParams` and auto import should add `import { useSearchParams } from "next/navigation";`
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: linux
Arch: x64
Version: #1 SMP Fri Jan 27 02:56:13 UTC 2023
Binaries:
Node: 18.17.1
npm: 9.6.7
Yarn: N/A
pnpm: N/A
Relevant Packages:
next: 13.5.2
eslint-config-next: 13.5.2
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
TypeScript (plugin, built-in types)
### Additional context
_No response_
<sub>[NEXT-1649](https://linear.app/vercel/issue/NEXT-1649/nextnavigation-cant-be-auto-imported-when-using-vscode)</sub> | https://github.com/vercel/next.js/issues/55741 | https://github.com/vercel/next.js/pull/55743 | ade8d7cdc4b1b3d85bdf93728116a87c234adf95 | 5daf2ee572aa106cf143f421cf7bd2e0c742eb36 | "2023-09-21T14:07:01Z" | javascript | "2023-09-21T14:25:13Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 55,706 | ["packages/next/src/cli/next-dev-args.ts", "packages/next/src/cli/next-dev.ts", "packages/next/src/lib/mkcert.ts", "packages/next/src/server/lib/start-server.ts", "packages/next/src/server/next-server.ts", "test/e2e/app-dir/next-image/next-image-https.test.ts"] | `Image` component does not work with https `next dev` | ### Link to the code that reproduces this issue
https://github.com/peakercope/material-ui-nextjs-pages-router-ts-example
### To Reproduce
1. Clone the example repo
2. Run `pnpm i`
3. Run `pnpm dev`
4. Open `https://localhost:3000/` in browser
### Current vs. Expected behavior
Current result: Banner is not visible
Expected result: Banner is visible
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 22.6.0: Wed Jul 5 22:22:05 PDT 2023; root:xnu-8796.141.3~6/RELEASE_ARM64_T6000
Binaries:
Node: 18.18.0
npm: 9.8.1
Yarn: 1.22.19
pnpm: 7.25.0
Relevant Packages:
next: 13.5.2
eslint-config-next: 13.5.2
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Not sure
### Additional context
Image response with 500 error code in browser with message `"url" parameter is valid but upstream response is invalid`
<img width="570" alt="image" src="https://github.com/vercel/next.js/assets/10975462/d5564ca1-c695-4d8f-9459-c99649af48b2">
Terminal console error:
```
upstream image response failed for /_next/static/media/half-page-banners-desktop-dog-coat.d9613929.jpeg TypeError: fetch failed
at Object.fetch (node:internal/deps/undici/undici:11576:11)
at async invokeRequest (/material-ui-nextjs-pages-router-ts/node_modules/.pnpm/[email protected]_biqbaboplfbrettd7655fr4n2y/node_modules/next/dist/server/lib/server-ipc/invoke-request.js:17:12)
at async /material-ui-nextjs-pages-router-ts/node_modules/.pnpm/[email protected]_biqbaboplfbrettd7655fr4n2y/node_modules/next/dist/server/next-server.js:362:39
at async imageOptimizer (/material-ui-nextjs-pages-router-ts/node_modules/.pnpm/[email protected]_biqbaboplfbrettd7655fr4n2y/node_modules/next/dist/server/image-optimizer.js:537:13)
at async cacheEntry.imageResponseCache.get.incrementalCache (/material-ui-nextjs-pages-router-ts/node_modules/.pnpm/[email protected]_biqbaboplfbrettd7655fr4n2y/node_modules/next/dist/server/next-server.js:519:61)
at async /material-ui-nextjs-pages-router-ts/node_modules/.pnpm/[email protected]_biqbaboplfbrettd7655fr4n2y/node_modules/next/dist/server/response-cache/index.js:102:36 {
cause: SocketError: other side closed
at Socket.onSocketEnd (/material-ui-nextjs-pages-router-ts/node_modules/.pnpm/[email protected]_biqbaboplfbrettd7655fr4n2y/node_modules/next/dist/compiled/undici/index.js:1:73361)
at Socket.emit (node:events:529:35)
at endReadableNT (node:internal/streams/readable:1368:12)
at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
code: 'UND_ERR_SOCKET',
socket: {
localAddress: '::1',
localPort: 60275,
remoteAddress: '::1',
remotePort: 3000,
remoteFamily: 'IPv6',
timeout: undefined,
bytesWritten: 946,
bytesRead: 0
}
}
}
```
<sub>[NEXT-1646](https://linear.app/vercel/issue/NEXT-1646/image-component-does-not-work-with-https-next-dev)</sub> | https://github.com/vercel/next.js/issues/55706 | https://github.com/vercel/next.js/pull/55775 | 57cd1d028499a28663de34ab85401be04462e464 | f20728ac3d2e520b306d7fd971830ac3ea5a282e | "2023-09-21T08:26:42Z" | javascript | "2023-09-22T14:26:20Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 55,682 | ["Cargo.lock", "Cargo.toml", "packages/next-swc/crates/core/Cargo.toml", "packages/next-swc/crates/napi/src/minify.rs", "packages/next/package.json", "packages/next/src/build/webpack/plugins/terser-webpack-plugin/src/index.ts", "pnpm-lock.yaml", "test/integration/export-intent/test/index.test.js"] | Minification causes "TypeError: Expected signal to be an instanceof AbortSignal" error with NextJS 13.5 + Azure Blob Storage 12.16.0 | ### Link to the code that reproduces this issue
https://github.com/jorupp/next-azure-blob-repro
### To Reproduce
1. Set `STORAGE_ACCOUNT_NAME` and `STORAGE_ACCOUNT_KEY` to the name/key of an Azure Storage account (it doesn't need to have any blob containers or blobs in it).
2. `npm run build`
3. `npm run start`
4. Go to <http://localhost:3000>
### Current vs. Expected behavior
Expected: show the number of blob containers in the storage account.
Actual:
```
TypeError: Expected signal to be an instanceof AbortSignal
at new G (C:\projects\personal\next-azure-blob\.next\server\chunks\786.js:29:45773)
at C:\projects\personal\next-azure-blob\.next\server\chunks\786.js:29:47293
at new Promise (<anonymous>)
at Object.J [as default] (C:\projects\personal\next-azure-blob\.next\server\chunks\786.js:29:47245)
at eN.fetch (C:\projects\personal\next-azure-blob\.next\server\chunks\786.js:2:4247)
at eN.sendRequest (C:\projects\personal\next-azure-blob\.next\server\chunks\786.js:2:1989)
```
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: win32
Arch: x64
Version: Windows 10 Enterprise
Binaries:
Node: 18.17.1
npm: N/A
Yarn: N/A
pnpm: N/A
Relevant Packages:
next: 13.5.2-canary.2
eslint-config-next: 13.5.2
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Not sure
### Additional context
Reverting to 13.4.19 works. 13.4.20-canary.18 works too. 13.4.20-canary.19 doesn't work.
From reviewing https://github.com/vercel/next.js/compare/v13.4.20-canary.18...v13.4.20-canary.19, I suspected https://github.com/vercel/next.js/commit/30da48fcd28b1fc07dcfa06d89b28bec95897d10, where I found `experimental.serverMinification`. Setting that to `false` in `next.config.js` avoids the issue.
<sub>[WEB-1676](https://linear.app/vercel/issue/WEB-1676/minification-causes-typeerror-expected-signal-to-be-an-instanceof)</sub> | https://github.com/vercel/next.js/issues/55682 | https://github.com/vercel/next.js/pull/57904 | da0f2ea11a4b0463e465b6a98ccac38532b8b5ef | c370c179b50fb09c6cb1f2a3b2c81c3302504c2b | "2023-09-20T19:11:47Z" | javascript | "2023-11-07T15:26:28Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 55,649 | ["packages/next/src/cli/next-dev.ts"] | Multiple next-router-worker instances duplicated | ### Link to the code that reproduces this issue
https://github.com/azvyae/minimal-repro
### To Reproduce
Just run the application with `npm run dev` then stop the app, the `next-router-worker` wont dismissed and duplicated many times, eating resources
### Current vs. Expected behavior
Here are the screenshot provided
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: linux
Arch: x64
Version: #7-Ubuntu SMP PREEMPT_DYNAMIC Fri Jun 23 15:37:39 UTC 2023
Binaries:
Node: 20.3.0
npm: 9.6.7
Yarn: N/A
pnpm: 8.6.6
Relevant Packages:
next: 13.5.1-canary.1
eslint-config-next: N/A
react: 18.2.0
react-dom: 18.2.0
typescript: 5.1.3
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
App Router
### Additional context
_No response_ | https://github.com/vercel/next.js/issues/55649 | https://github.com/vercel/next.js/pull/55652 | d97af317a3bba6e774eb4c82333d4c056c3b7ff8 | 23c3ea44d88ebc5f5f395eccff88252d7fac3bc2 | "2023-09-20T09:53:40Z" | javascript | "2023-09-20T14:31:53Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 55,629 | ["docs/02-app/01-building-your-application/04-caching/index.mdx"] | Docs: Update Cache Interactions API table | ### What is the improvement or update you wish to see?
I would like to see the [Cache Interactions API table](https://nextjs.org/docs/app/building-your-application/caching#apis) updated to reflect `Revalidate (Server Action)` in the `Router cache` column for the `revalidateTag` and `revalidatePath` rows.
The `Router cache` column / `cookies` row should also be updated from `Revalidate` to `Revalidate (Server Action)` since Route Handlers are not tied to any specific routes.
### Is there any context that might help us understand?
According to the second bullet point within the [Data Cache and Client-side Router cache](https://nextjs.org/docs/app/building-your-application/caching#data-cache-and-client-side-router-cache) section of the docs both `revalidateTag` and `revalidatePath` will invalidate the Router cache when used in a Server Action.
### Does the docs page already exist? Please link to it.
[Cache Interaction API table](https://nextjs.org/docs/app/building-your-application/caching#apis) | https://github.com/vercel/next.js/issues/55629 | https://github.com/vercel/next.js/pull/55630 | 9d86c1224caf507b0fbf2397aedb46936b587c9a | 3dc2c1c7f8441cdee31da9f7e0986d654c7fd2e7 | "2023-09-20T02:36:07Z" | javascript | "2023-09-25T17:48:30Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 55,611 | ["docs/02-app/02-api-reference/05-next-config-js/optimizePackageImports.mdx"] | Invalid next.config.js option `optimizePackageImports` | ### Link to the code that reproduces this issue
https://codesandbox.io/p/sandbox/vercel-next-js-reproduction-template-go8s7s
### To Reproduce
1. Create a new Next.js application: `npx create-next-app@latest`
2. Update the `next.config.js` to match the example below
3. Run `npm run dev`
```js
// next.config.js
/** @type {import('next').NextConfig} */
const nextConfig = {
optimizePackageImports: [],
}
module.exports = nextConfig
```
### Current vs. Expected behavior
Current behaviour:
```
⚠ Invalid next.config.js options detected:
⚠ The root value has an unexpected property, optimizePackageImports, which is not in the list of allowed properties (amp, analyticsId, assetPrefix, basePath, cleanDistDir, compiler, compress, configOrigin, crossOrigin, devIndicators, distDir, env, eslint, excludeDefaultMomentLocales, experimental, exportPathMap, generateBuildId, generateEtags, headers, httpAgentOptions, i18n, images, modularizeImports, onDemandEntries, optimizeFonts, output, outputFileTracing, pageExtensions, poweredByHeader, productionBrowserSourceMaps, publicRuntimeConfig, reactProductionProfiling, reactStrictMode, redirects, rewrites, sassOptions, serverRuntimeConfig, skipMiddlewareUrlNormalize, skipTrailingSlashRedirect, staticPageGenerationTimeout, swcMinify, target, trailingSlash, transpilePackages, typescript, useFileSystemPublicRoutes, webpack).
```
Expected behaviour:
As per the [Next.js 13.5 blog post](https://nextjs.org/blog/next-13-5#optimized-package-imports), and [v13.5.1 release notes](https://github.com/vercel/next.js/releases/tag/v13.5.1), `optimizePackageImports` should be a valid option.
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 22.6.0: Wed Jul 5 22:22:05 PDT 2023; root:xnu-8796.141.3~6/RELEASE_ARM64_T6000
Binaries:
Node: 16.18.0
npm: 8.19.2
Yarn: 1.22.19
pnpm: 8.3.1
Relevant Packages:
next: 13.5.1-canary.1
eslint-config-next: 13.5.1
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Not sure
### Additional context
_No response_ | https://github.com/vercel/next.js/issues/55611 | https://github.com/vercel/next.js/pull/55614 | a429e04fecadb8fdece8320bc797f85aec8fe65f | 7e17de988019845b5102b899241b967ef49e688e | "2023-09-19T19:58:07Z" | javascript | "2023-09-19T21:49:29Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 55,609 | ["packages/next/src/build/webpack-config.ts", "packages/next/src/build/webpack/plugins/flight-client-entry-plugin.ts", "packages/next/src/shared/lib/constants.ts", "test/development/basic/barrel-optimization.test.ts", "test/development/basic/barrel-optimization/app/client/page.js", "test/development/basic/barrel-optimization/node_modules_bak/my-lib/client.js", "test/development/basic/barrel-optimization/node_modules_bak/my-lib/index.js"] | Could not find the module in the React Client Manifest. This is probably a bug in the React Server Components bundler. | ### Link to the code that reproduces this issue
https://codesandbox.io/p/sandbox/recursing-mountain-yxz8hj?file=/src/components/MediaCard.tsx
### To Reproduce
Start the application in `v13.5.1` and see how "Unhandled Runtime Error" immediately pops up.
If `return <Typography>{text}</Typography>;` in MediaCard.tsx in the codesandbox-reproduction is replaced by `return <p>{text}</p>;`, the error goes away.
Also, if the usage of Box in `page.tsx` is removed, the error also goes away.
### Current vs. Expected behavior
Currently with `v13.5.1`, when using named imports in both a parent and child file, "Unhandled Runtime Error" is shown. If using named imports in only one of the files, everything works as expected.
Expected to be able to use named imports everywhere as in `v13.4.19`.
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: linux
Arch: x64
Version: #1 SMP PREEMPT_DYNAMIC Sun Aug 6 20:05:33 UTC 2023
Binaries:
Node: 16.17.0
npm: 8.15.0
Yarn: 1.22.19
pnpm: 7.1.0
Relevant Packages:
next: 13.5.1
eslint-config-next: 13.4.19
react: 18.2.0
react-dom: 18.2.0
typescript: 5.1.6
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Not sure, App Router
### Additional context
<img width="1446" alt="image" src="https://github.com/vercel/next.js/assets/31009729/06a65037-ea00-4c50-a906-89f3d04b9ad4">
*I've only tested named imports from `@mui/material`* | https://github.com/vercel/next.js/issues/55609 | https://github.com/vercel/next.js/pull/56020 | 4e445982495a6177bb40633e5ae5fe6083553da6 | ed38f03e4616df3cd370cbe3c5869c6857570988 | "2023-09-19T19:29:03Z" | javascript | "2023-09-26T16:03:51Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 55,608 | ["packages/next/src/server/pipe-readable.ts"] | TypeError [ERR_INVALID_STATE]: Invalid state: ReadableStream is already closed | ### Link to the code that reproduces this issue
https://github.com/willianrod/next-readable-stream-error
### To Reproduce
1. Run the project locally
2. Go to `/auth/login`
3. The app will redirect you to `/sample/list` after resolving the promise
4. You should now see the error on your console
### Current vs. Expected behavior
**Current:** Right now, when I'm navigating between pages with server components I'm seeing errors on my development console.
**Expected:** When navigating between pages no errors should be prompted
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 22.5.0: Thu Jun 8 22:22:23 PDT 2023; root:xnu-8796.121.3~7/RELEASE_ARM64_T6020
Binaries:
Node: 18.16.0
npm: 9.5.1
Yarn: 1.22.19
pnpm: 8.6.12
Relevant Packages:
next: 13.5.1
eslint-config-next: 13.5.1
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
App Router
### Additional context
There is a discussion with more people with the same issue. The latest request was to update to the latest version `13.5.1` and see if the issue was still happening.
https://github.com/vercel/next.js/discussions/55027
```
Internal error: TypeError [ERR_INVALID_STATE]: Invalid state: ReadableStream is already closed
at new NodeError (node:internal/errors:399:5)
at ReadableByteStreamController.enqueue (node:internal/webstreams/readablestream:1150:13)
at /path/to/app/readable-error/node_modules/next/dist/compiled/next-server/app-page.runtime.dev.js:1:447268
at ut (/path/to/app/readable-error/node_modules/next/dist/compiled/next-server/app-page.runtime.dev.js:1:447318)
at ct (/path/to/app/readable-error/node_modules/next/dist/compiled/next-server/app-page.runtime.dev.js:1:446596)
at Timeout._onTimeout (/path/to/app/readable-error/node_modules/next/dist/compiled/next-server/app-page.runtime.dev.js:1:443766)
at listOnTimeout (node:internal/timers:569:17)
at process.processTimers (node:internal/timers:512:7
``` | https://github.com/vercel/next.js/issues/55608 | https://github.com/vercel/next.js/pull/55684 | 4e877c01ba3166922d37189e317f5afbe33c8795 | ea01649a478a0b9ab224b8e66bc3e86297010e96 | "2023-09-19T19:17:47Z" | javascript | "2023-09-21T20:14:44Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 55,605 | ["packages/next/src/server/lib/start-server.ts"] | Invalid ERR_INVALID_ARG_TYPE on SIGINT | ### Link to the code that reproduces this issue
https://github.com/Yovach/nextjs-sigint
### To Reproduce
1. Install Node.js 20 (I din't tried 18)
2. Start the application with `pnpm dev`
3. Press CMD/CTRL + C
### Current vs. Expected behavior
Current :
X uncaughtException: TypeError [ERR_INVALID_ARG_TYPE]: The "code" argument must be of type number. Received type string ('SIGINT')
at process.set [as exitCode] (node:internal/bootstrap/node:123:9)
at process.exit (node:internal/process/per_thread:188:24)
at process.cleanup (/home/quentin/labs/reproduction-app/node_modules/.pnpm/[email protected][email protected][email protected]/node_modules/next/dist/server/lib/start-server.js:208:29)
at process.emit (node:events:526:35) {
code: 'ERR_INVALID_ARG_TYPE'
}
Following the previous step, the `next dev` server should gracefully stop without error like in `13.4.19`
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: linux
Arch: x64
Version: #1 SMP Mon Aug 7 19:01:48 UTC 2023
Binaries:
Node: 20.7.0
npm: 10.1.0
Yarn: 1.22.19
pnpm: 8.7.6
Relevant Packages:
next: 13.5.1-canary.1
eslint-config-next: N/A
react: 18.2.0
react-dom: 18.2.0
typescript: 5.1.3
Next.js Config:
output: N/A
warn - Latest canary version not detected, detected: "13.5.1-canary.1", newest: "13.5.1".
Please try the latest canary version (`npm install next@canary`) to confirm the issue still exists before creating a new issue.
Read more - https://nextjs.org/docs/messages/opening-an-issue
```
### Which area(s) are affected? (Select all that apply)
CLI (create-next-app)
### Additional context
_No response_ | https://github.com/vercel/next.js/issues/55605 | https://github.com/vercel/next.js/pull/55606 | 7e17de988019845b5102b899241b967ef49e688e | 12e888126ccf968193e7570a68db1bc35f90d52d | "2023-09-19T18:49:23Z" | javascript | "2023-09-19T22:19:52Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 55,604 | ["package.json", "packages/next/src/compiled/@vercel/og/index.edge.d.ts", "packages/next/src/compiled/@vercel/og/index.edge.js", "packages/next/src/compiled/@vercel/og/index.node.d.ts", "packages/next/src/compiled/@vercel/og/index.node.js", "pnpm-lock.yaml"] | ImageResponse type error on route after updating to 13.5.1 | ### Link to the code that reproduces this issue
https://github.com/Dannymx/shockinglemon.com/tree/develop
### To Reproduce
1. Clone repo
2. next build
3. See type error on GET route handler
### Current vs. Expected behavior
**Current:**
```
app/api/og/route.tsx
Type error: Route "app/api/og/route.tsx" has an invalid export:
"Promise<NextResponse<unknown> | ImageResponse>" is not a valid GET return type:
Expected "Response | Promise<Response>", got "Promise<NextResponse<unknown> | ImageResponse>".
Expected "Promise<Response>", got "Promise<NextResponse<unknown> | ImageResponse>".
Expected "Response", got "NextResponse<unknown> | ImageResponse".
ELIFECYCLE Command failed with exit code 1.
```
**Expected**: no type errors
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
next info
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 22.6.0: Wed Jul 5 22:21:53 PDT 2023; root:xnu-8796.141.3~6/RELEASE_ARM64_T6020
Binaries:
Node: 18.17.1
npm: 9.6.7
Yarn: N/A
pnpm: 8.7.5
Relevant Packages:
next: 13.5.1
eslint-config-next: 13.5.1
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
App Router, TypeScript (plugin, built-in types)
### Additional context
This started happening after updating to 13.5.1
<sub>[NEXT-1639](https://linear.app/vercel/issue/NEXT-1639/imageresponse-type-error-on-route-after-updating-to-1351)</sub> | https://github.com/vercel/next.js/issues/55604 | https://github.com/vercel/next.js/pull/55654 | fcca4ce9555f906e54ce20174b4bdd4af3210f13 | 38877dda37bb3c16f25f78e0fa5cf09458fe18bb | "2023-09-19T18:42:28Z" | javascript | "2023-09-20T12:16:49Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 55,561 | ["packages/next/src/build/utils.ts", "packages/next/src/build/webpack-config.ts", "packages/next/src/lib/constants.ts", "test/e2e/app-dir/metadata-dynamic-routes/app/client-ref-dependency/client-component.tsx", "test/e2e/app-dir/metadata-dynamic-routes/app/client-ref-dependency/sitemap.tsx", "test/e2e/app-dir/metadata-dynamic-routes/index.test.ts"] | Build fail when using `React.cache` in `sitemap.ts` | ### Link to the code that reproduces this issue
https://github.com/mwskwong/cache-in-sitemap
### To Reproduce
1. Call a function, e.g. fetcher, wrapped in `React.cache` in `sitemap.ts`
2. Attempt to build the project
### Current vs. Expected behavior
Current: the following error will appear during build
```
Collecting page data ..TypeError: (0 , p.cache) is not a function
at 5398 (\.next\server\app\sitemap.xml\route.js:1:605)
at t (\.next\server\webpack-runtime.js:1:127)
at a (\.next\server\app\sitemap.xml\route.js:1:1737)
at \.next\server\app\sitemap.xml\route.js:1:1764
at t.X (\.next\server\webpack-runtime.js:1:1191)
at \.next\server\app\sitemap.xml\route.js:1:1750
at Object.<anonymous> (\.next\server\app\sitemap.xml\route.js:1:1791)
at Module._compile (node:internal/modules/cjs/loader:1256:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
at Module.load (node:internal/modules/cjs/loader:1119:32)
> Build error occurred
Error: Failed to collect page data for /sitemap.xml
at \node_modules\next\dist\build\utils.js:1191:15
at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
type: 'Error'
}
```
Expected: build should be successful
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: win32
Arch: x64
Version: Windows 10 Home
Binaries:
Node: 18.17.1
npm: N/A
Yarn: N/A
pnpm: N/A
Relevant Packages:
next: 13.4.20-canary.40
eslint-config-next: N/A
react: 18.2.0
react-dom: 18.2.0
typescript: 5.1.3
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
App Router
### Additional context
_No response_
<sub>[NEXT-1635](https://linear.app/vercel/issue/NEXT-1635/build-fail-when-using-reactcache-in-sitemapts)</sub> | https://github.com/vercel/next.js/issues/55561 | https://github.com/vercel/next.js/pull/55579 | bad53655e8669389e534578980791079b37ea37f | 063154918c28b4f2a45ffd8d506fc44924483d6e | "2023-09-19T01:21:49Z" | javascript | "2023-09-19T13:45:59Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 55,495 | ["packages/next/src/build/webpack/loaders/next-edge-ssr-loader/render.ts", "packages/next/src/client/components/static-generation-async-storage.external.ts", "packages/next/src/server/app-render/app-render.tsx", "packages/next/src/server/base-http/index.ts", "packages/next/src/server/base-http/web.ts", "packages/next/src/server/next-server.ts", "packages/next/src/server/web/adapter.ts", "packages/next/src/server/web/types.ts", "test/e2e/app-dir/app-static/app-fetch-logging.test.ts"] | Fetch logging on edge is not working | ### Link to the code that reproduces this issue or a replay of the bug
https://github.com/gadicc/nextjs-fetch-config-weirdness
### To Reproduce
1. `npm run dev` (in one terminal)
2. `npm run test` (in another terminal)
```
✓ Compiled /api/configRuntime/route in 126ms (15 modules)
GET /api/configRuntime 200 in 303ms
│ GET http://ifconfig.me/ 200 in 4ms (cache: HIT)
✓ Compiled /api/runtime/route in 611ms (117 modules)
GET /api/runtime 200 in 702ms
```
### Current vs. Expected behavior
To my best understanding both routes should behave identically, as the only difference between the two files is:
```ts
// api/configRuntime/route.ts
export const config = { runtime: "edge" }
// api/runtime/route.ts
export const runtime = 'edge'
```
With `config.runtime`, fetch caching works as is shown in the console output above.
With `runtime`, there is no indication that any fetching occurred.
I did notice the big difference in compiled modules in the `runtime` route, so maybe these two setups are meant to behave very differently, but I couldn't find any mention of it in the docs.
**There is no way to sidestep this since `build` fails with the deprecated `config` const**.
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: linux
Arch: x64
Version: #1 SMP PREEMPT_DYNAMIC Wed, 06 Sep 2023 21:01:01 +0000
Binaries:
Node: 18.16.1
npm: 9.5.1
Yarn: 1.22.19
pnpm: N/A
Relevant Packages:
next: 13.4.20-canary.33
eslint-config-next: 13.4.19
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
App Router, Data fetching (gS(S)P, getInitialProps), Middleware / Edge (API routes, runtime)
### Additional context
_No response_
<sub>[NEXT-1661](https://linear.app/vercel/issue/NEXT-1661/fetch-caching-on-edge-breaks-when-moving-from-configruntime-to-segment)</sub> | https://github.com/vercel/next.js/issues/55495 | https://github.com/vercel/next.js/pull/56108 | 2ff2c0b4b2e9bb1d0d0a34500181face36ba7076 | 7b48a1e2f026eb7e57daaa19ea14d12200bdf2ee | "2023-09-17T13:10:39Z" | javascript | "2023-09-27T22:39:42Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 55,389 | ["packages/next/src/client/page-loader.ts", "packages/next/src/server/lib/router-utils/setup-dev.ts", "test/development/basic/asset-prefix.test.ts", "test/development/basic/asset-prefix/next.config.js", "test/development/basic/asset-prefix/pages/index.js"] | Infinite index page reload | ### Link to the code that reproduces this issue or a replay of the bug
https://github.com/4zuko/next-example-infinite-reload
### To Reproduce
1. Start the application in development (next dev)
2. Visit http://localhost:3000/base-path
### Current vs. Expected behavior
**`Current`**: The page is loaded but is stuck in an infinite reload loop.
**`Expected`**: The page should just load.
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: x64
Version: Darwin Kernel Version 22.4.0: Mon Mar 6 21:00:17 PST 2023; root:xnu-8796.101.5~3/RELEASE_X86_64
Binaries:
Node: 18.17.0
npm: 9.8.1
Yarn: 1.22.19
pnpm: 8.6.12
Relevant Packages:
next: 13.4.19
eslint-config-next: 13.4.19
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: standalone
```
### Which area(s) are affected? (Select all that apply)
Not sure
### Additional context
- The example uses **`Pages Router`**
- The bug can be reproduced in next.js versions **`>=13.4.13`**
<sub>[NEXT-1618](https://linear.app/vercel/issue/NEXT-1618/infinite-index-page-reload)</sub> | https://github.com/vercel/next.js/issues/55389 | https://github.com/vercel/next.js/pull/55416 | 2e2211d27b3f0ff1cff5553453df4cf391996163 | 1e332532c7e0036de2e09802b83eb7d692b2d654 | "2023-09-14T13:58:27Z" | javascript | "2023-09-15T01:11:03Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 55,267 | ["packages/next-swc/crates/core/src/react_server_components.rs"] | On Windows, `The Next.js 'metadata' API is not allowed in a client component.` error does not occur | ### Link to the code that reproduces this issue or a replay of the bug
https://codesandbox.io/p/sandbox/new-darkness-hfp4mj
### To Reproduce
1. open and run CodeSandBox.
2. open url "/sample"
### Current vs. Expected behavior
In the CodeSandBox I provided, you will get the following error, but this does not cause any error on Windows OS and can be executed without any problem.
```
./app/sample/page.tsx
ReactServerComponentsError:
You are attempting to export "metadata" from a component marked with "use client", which is disallowed. Either remove the export, or the "use client" directive. Read more: https://nextjs.org/docs/getting-started/react-essentials#the-use-client-directive
,-[/workspace/app/sample/page.tsx:2:1]
2 |
3 | import { Metadata } from "next";
4 |
5 | export const metadata: Metadata = {
: ^^^^^^^^
6 | title: "sample"
7 | }
7 |
`----
File path:
./app/sample/page.tsx
```
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: Windows
Arch: arm64
Version: 11
Binaries:
Node: 18.17.1
npm: 9.8.1
Relevant Packages:
"eslint": "8.48.0",
"eslint-config-next": "13.4.19",
"next": "13.4.19",
"react": "18.2.0",
"react-dom": "18.2.0",
"typescript": "5.2.2"
```
### Which area(s) are affected? (Select all that apply)
Metadata (metadata, generateMetadata, next/head)
### Additional context
_No response_ | https://github.com/vercel/next.js/issues/55267 | https://github.com/vercel/next.js/pull/55294 | 800fdc11aed6b4502c28e4c75328ecab826b3ce7 | 2ea729082423a1890a5d43c1e3ab795d57566aee | "2023-09-12T09:16:36Z" | javascript | "2023-09-13T23:22:09Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 55,167 | ["examples/with-jest-babel/package.json", "examples/with-jest/package.json"] | Do you need to install type definitions for a test runner? | ### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 22.6.0: Wed Jul 5 22:22:52 PDT 2023; root:xnu-8796.141.3~6/RELEASE_ARM64_T8103
Binaries:
Node: 18.17.1
npm: 9.6.7
Yarn: 1.22.19
pnpm: 8.6.7
Relevant Packages:
next: 13.4.20-canary.23
eslint-config-next: N/A
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which example does this report relate to?
with-jest
### What browser are you using? (if relevant)
_No response_
### How are you deploying your application? (if relevant)
_No response_
### Describe the Bug
```
yarn create next-app --example with-jest with-jest-app
```
After creating the with-jest application as described in the documentation, I get the attached error when I look at the test file.
### Expected Behavior
Tests can be run without installing type definitions for the test runner.
### To Reproduce
```
yarn create next-app --example with-jest with-jest-app
```
Execute the above to open the test file.
| https://github.com/vercel/next.js/issues/55167 | https://github.com/vercel/next.js/pull/56193 | c20e21bd387946c40bad63a36b9df230ee00ac1a | 55a638ba4210e172afbd01aee1fb8a82353e428f | "2023-09-09T10:37:58Z" | javascript | "2023-09-29T13:53:20Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 55,050 | ["errors/reserved-port.mdx", "packages/next/src/cli/next-dev.ts", "packages/next/src/cli/next-start.ts", "packages/next/src/lib/helpers/get-reserved-port.ts", "test/integration/cli/test/index.test.js"] | Next.js should not start on "bad ports" | ### Link to the code that reproduces this issue or a replay of the bug
https://codesandbox.io/p/sandbox/stupefied-parm-nkr2wn
### To Reproduce
1. A Next.js application in production (`npm run start`) on a "bad port" (as defined by the fetch standard, e.g. `4045`).
2. Access a page that uses a "next/image" component.
### Current vs. Expected behavior
The demonstrative example showcases the loading of a "next/image" component .
It loads fine in development mode, but fails in production when running on a "bad port":
- the page displays a broken image
- the output from `next start` will display a stacktrace like:
```
upstream image response failed for /_next/static/media/test.37141d1a.png TypeError: fetch failed
at Object.fetch (node_modules/next/dist/compiled/undici/index.js:1:26669)
at async invokeRequest (node_modules/next/dist/server/lib/server-ipc/invoke-request.js:17:12)
at async node_modules/next/dist/server/next-server.js:359:35
at async imageOptimizer (node_modules/next/dist/server/image-optimizer.js:537:13)
at async cacheEntry.imageResponseCache.get.incrementalCache (node_modules/next/dist/server/next-server.js:598:60)
at async node_modules/next/dist/server/response-cache/index.js:99:36 {
cause: Error: bad port
at makeNetworkError (node_modules/next/dist/compiled/undici/index.js:2:55255)
at mainFetch (node_modules/next/dist/compiled/undici/index.js:2:29022)
at fetching (node_modules/next/dist/compiled/undici/index.js:2:28803)
at fetch (node_modules/next/dist/compiled/undici/index.js:2:26721)
at Object.fetch (node_modules/next/dist/compiled/undici/index.js:1:26638)
at globalThis.fetch (node_modules/next/dist/server/node-polyfill-fetch.js:30:26)
at invokeRequest (node_modules/next/dist/server/lib/server-ipc/invoke-request.js:17:18)
at node_modules/next/dist/server/next-server.js:359:74
at imageOptimizer (node_modules/next/dist/server/image-optimizer.js:537:19)
at NextNodeServer.imageOptimizer (node_modules/next/dist/server/next-server.js:354:16)
```
The stacktrace explains what's going on:
- The image optimizer attempts to fetch the image for optimization, using the `undici` implementation of `fetch`.
- Because the server is running on a "bad port", `undici` throws an error.
The result is a production deployment that should work fine, but none of the images load, because the optimizer crashes when attempting to fetch them.
Here's how the fetch standard defines a "bad port":
https://fetch.spec.whatwg.org/#bad-port
One possible solution could be to mirror Undici's list of "bad ports", and raise it as an issue when running Next.js in production.
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: linux
Arch: x64
Version: #1 SMP PREEMPT_DYNAMIC Sun Aug 6 20:05:33 UTC 2023
Binaries:
Node: 16.17.0
npm: 8.15.0
Yarn: 1.22.19
pnpm: 7.1.0
Relevant Packages:
next: 13.4.20-canary.18
eslint-config-next: N/A
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Image optimization (next/image, next/legacy/image)
### Additional context
_No response_
<sub>[NEXT-1608](https://linear.app/vercel/issue/NEXT-1608/nextjs-image-optimizer-bug-caused-by-undici-when-running-on-a-bad-port)</sub> | https://github.com/vercel/next.js/issues/55050 | https://github.com/vercel/next.js/pull/55237 | 92e1b3fef9088aa646eecd8d95611e26751412f7 | 3afba0d12ded048b43882eb5c42d6fde95c99929 | "2023-09-06T12:24:43Z" | javascript | "2023-09-12T07:31:35Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 54,984 | ["packages/next/src/client/link.tsx", "packages/next/src/client/resolve-href.ts", "packages/next/src/shared/lib/router/router.ts", "test/e2e/skip-trailing-slash-redirect/app/app/layout.js", "test/e2e/skip-trailing-slash-redirect/app/app/with-app-dir/another/page.js", "test/e2e/skip-trailing-slash-redirect/app/app/with-app-dir/blog/[slug]/page.js", "test/e2e/skip-trailing-slash-redirect/app/app/with-app-dir/page.js", "test/e2e/skip-trailing-slash-redirect/index.test.ts"] | skipTrailingSlashRedirect option is not being applied | ### Link to the code that reproduces this issue or a replay of the bug
https://github.com/blauakqa/nextjs-trailing-slash-issue
### To Reproduce
To replicate:
- npm install
- npm run dev
- open the browser and go to http://localhost:300
- check the link (link-with-slash) and the trailing slash is removed
### Current vs. Expected behavior
Expect the rendered url `/link-with-slash/` to have a `trailing slash` under the `Links with trailing slash` header
Actual result is the trailing slash is removed
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 22.5.0: Thu Jun 8 22:22:20 PDT 2023; root:xnu-8796.121.3~7/RELEASE_ARM64_T6000
Binaries:
Node: 18.12.1
npm: 8.19.2
Yarn: 1.22.15
pnpm: 6.11.0
Relevant Packages:
next: 13.4.20-canary.15
eslint-config-next: N/A
react: 18.2.0
react-dom: 18.2.0
typescript: N/A
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Routing (next/router, next/navigation, next/link)
### Additional context
We have skipTrailingSlashRedirect set to true.
If we set breakpoints, we can see that on line 294 of `webpack-config.js`, `config.skipTrailingSlashRedirect` is `true`.
However, when we hit line 14 of `normalize-trailing-slash.js`, `process.env.__NEXT_MANUAL_TRAILING_SLASH` is `undefined` in the `normalizePathTrailingSlash` function
If we manually set `__NEXT_MANUAL_TRAILING_SLASH` to `true` via a .env file, it works as expected.
The supplied example has two urls
- /link-with-slash/
- /link-no-slash
When you run the example, have noticed the following when `normalizePathTrailingSlash` function is executed
- First execution, `path` parameter is `/link-with-slash/` and the value of `process.env.__NEXT_MANUAL_TRAILING_SLASH` is `undefined`
- Second execution, `path` parameter is `/link-with-slash` and the value of `process.env.__NEXT_MANUAL_TRAILING_SLASH` is `true` - trailing slash is already removed
Have tried it on the following NextJS versions and the issue still occurs locally and on Vercel
- 13.4.4
- 13.4.19
- canary (v13.4.20-canary.15)
Cheers
<sub>[NEXT-1599](https://linear.app/vercel/issue/NEXT-1599/skiptrailingslashredirect-option-is-not-being-applied)</sub> | https://github.com/vercel/next.js/issues/54984 | https://github.com/vercel/next.js/pull/55067 | 15980a66d4bdbcd5e9f3494bcaa1a286f6ec9aee | 1f797faaa6933ab2b8311251a167613f5a75a901 | "2023-09-04T15:30:44Z" | javascript | "2023-09-06T18:03:37Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 54,967 | ["packages/next/src/build/webpack-config.ts", "packages/next/src/build/webpack/plugins/flight-client-entry-plugin.ts", "packages/next/src/shared/lib/constants.ts", "test/development/basic/barrel-optimization.test.ts", "test/development/basic/barrel-optimization/app/client/page.js", "test/development/basic/barrel-optimization/node_modules_bak/my-lib/client.js", "test/development/basic/barrel-optimization/node_modules_bak/my-lib/index.js"] | Barrel optimizer (optimizeImports) breaks RSC Components bundler: Could not find the module in the React Client Manifest | ### Link to the code that reproduces this issue or a replay of the bug
https://github.com/florianliebig/next-error-optimize-package-imports
### To Reproduce
Checkout example repo
```pnpm i && pnpm build```
Steps to create error:
1. Use pnpm or import any external dep with server & client components in same wildcard export (in this case [index.tsx](https://github.com/florianliebig/next-error-optimize-package-imports/blob/main/packages/components/src/index.tsx) exporting simple [ClientComponent](https://github.com/florianliebig/next-error-optimize-package-imports/blob/main/packages/components/src/client/client-component.tsx) & [ServerComponent](https://github.com/florianliebig/next-error-optimize-package-imports/blob/main/packages/components/src/server/server-component.tsx)
2. Adjust next.config.json to use experimental [optimizePackageImports](https://github.com/florianliebig/next-error-optimize-package-imports/blob/main/next.config.js#L14) from https://github.com/vercel/next.js/pull/54695
3. Import both server & client component in one [page](https://github.com/florianliebig/next-error-optimize-package-imports/blob/main/src/app/product/page.tsx) from barrel file
4. Build and / or start and see the error "Could not find the module ... in the React Client Manifest"
### Current vs. Expected behavior
```
Error occurred prerendering page "/". Read more: https://nextjs.org/docs/messages/prerender-error
Error: Could not find the module "/Users/florianliebig/code/next-error-optimize-package-imports/packages/components/src/client/client-component.tsx#ClientComponent" in the React Client Manifest. This is probably a bug in the React Server Components bundler.
```
I would expect both Server & client components to be optimized properly from https://github.com/vercel/next.js/pull/54695
```import { ClientComponent, ServerComponent } from '@shared/components';```
### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 22.6.0: Wed Jul 5 22:17:35 PDT 2023; root:xnu-8796.141.3~6/RELEASE_ARM64_T8112
Binaries:
Node: 18.16.0
npm: 9.6.7
Yarn: 1.22.19
pnpm: 8.6.2
Relevant Packages:
next: 13.5.3-canary.0
eslint-config-next: 13.4.19
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
App Router, SWC transpilation
### Additional context
_No response_ | https://github.com/vercel/next.js/issues/54967 | https://github.com/vercel/next.js/pull/56020 | 4e445982495a6177bb40633e5ae5fe6083553da6 | ed38f03e4616df3cd370cbe3c5869c6857570988 | "2023-09-04T09:49:07Z" | javascript | "2023-09-26T16:03:51Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 54,892 | ["packages/next/src/build/webpack/loaders/next-app-loader.ts", "test/e2e/app-dir/not-found-default/index.test.ts", "test/e2e/app-dir/not-found/group-route-root-not-found/app/(group)/group-dynamic/[id]/page.js", "test/e2e/app-dir/not-found/group-route-root-not-found/app/layout.js", "test/e2e/app-dir/not-found/group-route-root-not-found/app/not-found.js", "test/e2e/app-dir/not-found/group-route-root-not-found/app/page.js", "test/e2e/app-dir/not-found/group-route-root-not-found/index.test.ts"] | Root route group renders root not-found incorrectly | ### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 22.5.0: Thu Jun 8 22:22:20 PDT 2023; root:xnu-8796.121.3~7/RELEASE_ARM64_T6000
Binaries:
Node: 18.13.0
npm: 8.13.2
Yarn: 1.22.19
pnpm: 8.6.6
Relevant Packages:
next: 13.4.20-canary.15
eslint-config-next: N/A
react: 18.2.0
react-dom: 18.2.0
typescript: 5.1.3
Next.js Config:
output: N/A
```
### Which area(s) of Next.js are affected? (leave empty if unsure)
App Router
### Link to the code that reproduces this issue or a replay of the bug
https://github.com/tom-sherman/next-not-found-route-group-bug
### To Reproduce
1. Run the repo
2. Go to `/foo/a`
### Describe the Bug
When you use `notFound()` inside of a route group at the root of the app directory and have a root `not-found.tsx` it's not rendered, instead the default Next.js not found is rendered inside of your root layout.
<img width="1006" alt="image" src="https://github.com/vercel/next.js/assets/9257001/d1933d08-0d47-4a0d-9626-fc29021961f2">
eg. https://next-not-found-route-group-bug.vercel.app/foo/a
This doesn't happen if the route group is anywhere other than the root eg. https://next-not-found-route-group-bug.vercel.app/nested/foo/a
### Expected Behavior
Root not-found should render inside the layout as it does with undefined routes eg. https://next-not-found-route-group-bug.vercel.app/nested/foo/a or https://next-not-found-route-group-bug.vercel.app/undefined
### Which browser are you using? (if relevant)
_No response_
### How are you deploying your application? (if relevant)
_No response_
<sub>[NEXT-1588](https://linear.app/vercel/issue/NEXT-1588/root-route-group-renders-root-not-found-incorrectly)</sub> | https://github.com/vercel/next.js/issues/54892 | https://github.com/vercel/next.js/pull/54931 | ef6140723aad48dad3636bc4d84cc6add874a69b | 6bc23cd2bd593168517a2f9cdd390fb98a08657d | "2023-09-01T14:50:10Z" | javascript | "2023-09-03T20:15:24Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 54,746 | ["packages/next/src/client/components/router-reducer/reducers/server-action-reducer.ts", "test/e2e/app-dir/actions/app-action.test.ts"] | Form are being submitted twice in nextjs canary | ### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 23.0.0: Fri Aug 18 00:02:20 PDT 2023; root:xnu-10002.1.11~5/RELEASE_ARM64_T8103
Binaries:
Node: 18.16.0
npm: 9.5.1
Yarn: 1.22.19
pnpm: 8.6.7
Relevant Packages:
next: 13.4.20-canary.12
eslint-config-next: N/A
react: 18.2.0
react-dom: 18.2.0
typescript: 5.1.3
Next.js Config:
output: N/A
```
### Which area(s) of Next.js are affected? (leave empty if unsure)
App Router, Data fetching (gS(S)P, getInitialProps)
### Link to the code that reproduces this issue or a replay of the bug
https://github.com/Fredkiss3/nextjs-form-double-submission
### To Reproduce
1. Clone the project and run it
2. Go to the link `/other` and then navigate back (either with the back button or link in the header)
3. Click on the `submit` button of the form
4. Observe the network tab
https://github.com/vercel/next.js/assets/38298743/48f7da51-7239-4719-acc0-2898444c4e74
### Describe the Bug
When a user navigates aways and back with `next/link` and resubmits a form which uses a server action, the form get submitted twice.
This error seems to have appeared in `[email protected]`, up to `[email protected]` it was working as expected
### Expected Behavior
The form should only ever be submitted once, not twice.
### Which browser are you using? (if relevant)
_No response_
### How are you deploying your application? (if relevant)
_No response_
<sub>[NEXT-1589](https://linear.app/vercel/issue/NEXT-1589/form-are-being-submitted-twice-in-nextjs-canary)</sub> | https://github.com/vercel/next.js/issues/54746 | https://github.com/vercel/next.js/pull/54948 | 6bc23cd2bd593168517a2f9cdd390fb98a08657d | c013e98fa4a4d65de08d315e3930936c34bf381f | "2023-08-30T01:34:19Z" | javascript | "2023-09-03T20:31:48Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 54,706 | ["packages/next/src/experimental/testmode/playwright/index.ts", "packages/next/src/experimental/testmode/playwright/next-fixture.ts", "packages/next/src/experimental/testmode/playwright/page-route.ts"] | Testmode playwright breaks when `setExtraHTTPHeaders` is called | ### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 22.6.0: Wed Jul 5 22:22:52 PDT 2023; root:xnu-8796.141.3~6/RELEASE_ARM64_T8103
Binaries:
Node: 18.4.0
npm: 8.12.1
Yarn: 1.22.19
pnpm: 7.2.1
Relevant Packages:
next: 13.4.20-canary.11
eslint-config-next: N/A
react: 18.2.0
react-dom: 18.2.0
typescript: 5.2.2
Next.js Config:
output: N/A
```
### Which area(s) of Next.js are affected? (leave empty if unsure)
Data fetching (gS(S)P, getInitialProps)
### Link to the code that reproduces this issue or a replay of the bug
https://github.com/joshuajaco/next-testmode-playwright-issue
### To Reproduce
Checkout [this repository ](https://github.com/joshuajaco/next-testmode-playwright-issue) and run `npm run test`.
This will run the playwright tests which fail with the following error:
```
[WebServer] - error Error: No test info
```
### Describe the Bug
When calling `page.setExtraHTTPHeaders` inside of a playwright test, the testmode breaks.
This is because the `Next-Test-Proxy-Port` and `Next-Test-Data` headers are removed.
Also, for some reason `extraHTTPHeaders` is `undefined` in my test, so even when spreading `extraHTTPHeaders` does not work.
```ts
await page.setExtraHTTPHeaders({ ...extraHTTPHeaders });
```
Related to https://github.com/microsoft/playwright/issues/26751
### Expected Behavior
Either `page.setExtraHTTPHeaders` does not remove the testmode headers or `extraHTTPHeaders` contains the headers so we can spread them when calling `page.setExtraHTTPHeaders`.
### Which browser are you using? (if relevant)
_No response_
### How are you deploying your application? (if relevant)
_No response_ | https://github.com/vercel/next.js/issues/54706 | https://github.com/vercel/next.js/pull/55087 | 12252c271140657164f34290a35a07f0a2d8d279 | 5b85a40142b14b9b16903d5172f82d35f40303ec | "2023-08-29T09:22:54Z" | javascript | "2023-09-08T15:50:44Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 54,592 | ["bench/nested-deps-app-router/package.json", "bench/nested-deps/package.json"] | pnpm dev not working with next.js source code | ### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: linux
Arch: x64
Version: #48-Ubuntu SMP Tue Jun 20 20:34:08 UTC 2023
Binaries:
Node: 18.17.1
npm: 9.6.7
Yarn: N/A
pnpm: 8.6.11
Relevant Packages:
next: 13.4.20-canary.9
eslint-config-next: N/A
react: 18.2.0
react-dom: 18.2.0
typescript: N/A
Next.js Config:
output: N/A
```
### Which area(s) of Next.js are affected? (leave empty if unsure)
Package manager (npm, pnpm, Yarn), Turbopack (--turbo)
### Link to the code that reproduces this issue or a replay of the bug
https://github.com/vercel/next.js
### To Reproduce
1. Install the [GitHub CLI](https://github.com/cli/cli#installation).
1. Clone the Next.js repository (download only recent commits for faster clone):
```
gh repo clone vercel/next.js -- --depth=3000 --branch canary --single-branch
```
1. Enable pnpm:
```
corepack enable pnpm
```
1. Install the dependencies with:
```
pnpm install
```
1. Start developing and watch for code changes:
```
pnpm dev
```
### Describe the Bug
I was trying to start contributing to nextjs open source, and the official code doesn't seem to work!
During pnpm install
```
...
WARN Failed to create bin at /workspaces/next.js/bench/nested-deps-app-router/node_modules/.bin/next. ENOENT: no such file or directory, open '/workspaces/next.js/packages/next/dist/bin/next'
WARN Failed to create bin at /workspaces/next.js/bench/next-minimal-server/node_modules/.bin/next. ENOENT: no such file or directory, open '/workspaces/next.js/packages/next/dist/bin/next'
WARN Failed to create bin at /workspaces/next.js/bench/nested-deps/node_modules/.bin/next. ENOENT: no such file or directory, open '/workspaces/next.js/packages/next/dist/bin/next'
WARN Failed to create bin at /workspaces/next.js/bench/app-router-server/node_modules/.bin/next. ENOENT: no such file or directory, open '/workspaces/next.js/packages/next/dist/bin/next'
WARN Failed to create bin at /workspaces/next.js/packages/next-plugin-storybook/node_modules/.bin/next. ENOENT: no such file or directory, open '/workspaces/next.js/packages/next/dist/bin/next'
WARN 5 other warnings
...
```
During pnpm dev
```
...
7:58:04 AM - Starting compilation in watch mode...
@next/third-parties:dev:
bench-nested-deps-app-router:dev: node:internal/modules/cjs/loader:1077
bench-nested-deps-app-router:dev: const err = new Error(message);
bench-nested-deps-app-router:dev: ^
bench-nested-deps-app-router:dev:
bench-nested-deps-app-router:dev: Error: Cannot find module 'webpack/lib/javascript/BasicEvaluatedExpression'
bench-nested-deps-app-router:dev: Require stack:
bench-nested-deps-app-router:dev: - /usr/local/share/nvm/versions/node/v18.17.1/lib/node_modules/next/dist/compiled/webpack/webpack.js
bench-nested-deps-app-router:dev: - /usr/local/share/nvm/versions/node/v18.17.1/lib/node_modules/next/dist/server/config-utils.js
bench-nested-deps-app-router:dev: - /usr/local/share/nvm/versions/node/v18.17.1/lib/node_modules/next/dist/server/config.js
bench-nested-deps-app-router:dev: - /usr/local/share/nvm/versions/node/v18.17.1/lib/node_modules/next/dist/cli/next-dev.js
bench-nested-deps-app-router:dev: - /usr/local/share/nvm/versions/node/v18.17.1/lib/node_modules/next/dist/lib/commands.js
bench-nested-deps-app-router:dev: - /usr/local/share/nvm/versions/node/v18.17.1/lib/node_modules/next/dist/bin/next
bench-nested-deps-app-router:dev: at Module._resolveFilename (node:internal/modules/cjs/loader:1077:15)
bench-nested-deps-app-router:dev: at Module._load (node:internal/modules/cjs/loader:922:27)
bench-nested-deps-app-router:dev: at Module.require (node:internal/modules/cjs/loader:1143:19)
bench-nested-deps-app-router:dev: at require (node:internal/modules/cjs/helpers:121:18)
bench-nested-deps-app-router:dev: at exports.init (/usr/local/share/nvm/versions/node/v18.17.1/lib/node_modules/next/dist/compiled/webpack/webpack.js:9:33)
bench-nested-deps-app-router:dev: at loadWebpackHook (/usr/local/share/nvm/versions/node/v18.17.1/lib/node_modules/next/dist/server/config-utils.js:18:5)
bench-nested-deps-app-router:dev: at loadConfig (/usr/local/share/nvm/versions/node/v18.17.1/lib/node_modules/next/dist/server/config.js:535:46)
bench-nested-deps-app-router:dev: at nextDev (/usr/local/share/nvm/versions/node/v18.17.1/lib/node_modules/next/dist/cli/next-dev.js:281:40) {
bench-nested-deps-app-router:dev: code: 'MODULE_NOT_FOUND',
bench-nested-deps-app-router:dev: requireStack: [
bench-nested-deps-app-router:dev: '/usr/local/share/nvm/versions/node/v18.17.1/lib/node_modules/next/dist/compiled/webpack/webpack.js',
bench-nested-deps-app-router:dev: '/usr/local/share/nvm/versions/node/v18.17.1/lib/node_modules/next/dist/server/config-utils.js',
bench-nested-deps-app-router:dev: '/usr/local/share/nvm/versions/node/v18.17.1/lib/node_modules/next/dist/server/config.js',
bench-nested-deps-app-router:dev: '/usr/local/share/nvm/versions/node/v18.17.1/lib/node_modules/next/dist/cli/next-dev.js',
bench-nested-deps-app-router:dev: '/usr/local/share/nvm/versions/node/v18.17.1/lib/node_modules/next/dist/lib/commands.js',
bench-nested-deps-app-router:dev: '/usr/local/share/nvm/versions/node/v18.17.1/lib/node_modules/next/dist/bin/next'
bench-nested-deps-app-router:dev: ]
bench-nested-deps-app-router:dev: }
bench-nested-deps-app-router:dev:
bench-nested-deps-app-router:dev: Node.js v18.17.1
bench-nested-deps-app-router:dev: ELIFECYCLE Command failed with exit code 1.
bench-nested-deps:dev: node:internal/modules/cjs/loader:1077
bench-nested-deps:dev: const err = new Error(message);
bench-nested-deps:dev: ^
bench-nested-deps:dev:
bench-nested-deps:dev: Error: Cannot find module 'webpack/lib/javascript/BasicEvaluatedExpression'
bench-nested-deps:dev: Require stack:
bench-nested-deps:dev: - /usr/local/share/nvm/versions/node/v18.17.1/lib/node_modules/next/dist/compiled/webpack/webpack.js
bench-nested-deps:dev: - /usr/local/share/nvm/versions/node/v18.17.1/lib/node_modules/next/dist/server/config-utils.js
bench-nested-deps:dev: - /usr/local/share/nvm/versions/node/v18.17.1/lib/node_modules/next/dist/server/config.js
bench-nested-deps:dev: - /usr/local/share/nvm/versions/node/v18.17.1/lib/node_modules/next/dist/cli/next-dev.js
bench-nested-deps:dev: - /usr/local/share/nvm/versions/node/v18.17.1/lib/node_modules/next/dist/lib/commands.js
bench-nested-deps:dev: - /usr/local/share/nvm/versions/node/v18.17.1/lib/node_modules/next/dist/bin/next
bench-nested-deps:dev: at Module._resolveFilename (node:internal/modules/cjs/loader:1077:15)
bench-nested-deps:dev: at Module._load (node:internal/modules/cjs/loader:922:27)
bench-nested-deps:dev: at Module.require (node:internal/modules/cjs/loader:1143:19)
bench-nested-deps:dev: at require (node:internal/modules/cjs/helpers:121:18)
bench-nested-deps:dev: at exports.init (/usr/local/share/nvm/versions/node/v18.17.1/lib/node_modules/next/dist/compiled/webpack/webpack.js:9:33)
bench-nested-deps:dev: at loadWebpackHook (/usr/local/share/nvm/versions/node/v18.17.1/lib/node_modules/next/dist/server/config-utils.js:18:5)
bench-nested-deps:dev: at loadConfig (/usr/local/share/nvm/versions/node/v18.17.1/lib/node_modules/next/dist/server/config.js:535:46)
bench-nested-deps:dev: at nextDev (/usr/local/share/nvm/versions/node/v18.17.1/lib/node_modules/next/dist/cli/next-dev.js:281:40) {
bench-nested-deps:dev: code: 'MODULE_NOT_FOUND',
bench-nested-deps:dev: requireStack: [
bench-nested-deps:dev: '/usr/local/share/nvm/versions/node/v18.17.1/lib/node_modules/next/dist/compiled/webpack/webpack.js',
bench-nested-deps:dev: '/usr/local/share/nvm/versions/node/v18.17.1/lib/node_modules/next/dist/server/config-utils.js',
bench-nested-deps:dev: '/usr/local/share/nvm/versions/node/v18.17.1/lib/node_modules/next/dist/server/config.js',
bench-nested-deps:dev: '/usr/local/share/nvm/versions/node/v18.17.1/lib/node_modules/next/dist/cli/next-dev.js',
bench-nested-deps:dev: '/usr/local/share/nvm/versions/node/v18.17.1/lib/node_modules/next/dist/lib/commands.js',
bench-nested-deps:dev: '/usr/local/share/nvm/versions/node/v18.17.1/lib/node_modules/next/dist/bin/next'
bench-nested-deps:dev: ]
bench-nested-deps:dev: }
bench-nested-deps:dev:
bench-nested-deps:dev: Node.js v18.17.1
bench-nested-deps:dev: ELIFECYCLE Command failed with exit code 1.
bench-nested-deps-app-router:dev: ERROR: command finished with error: command (/workspaces/next.js/bench/nested-deps-app-router) pnpm run dev exited (1)
create-next-app:dev: ELIFECYCLE Command failed.
next:dev: ELIFECYCLE Command failed.
@next/font:dev: ELIFECYCLE Command failed.
@next/third-parties:dev: ELIFECYCLE Command failed.
@next/polyfill-module:dev: ELIFECYCLE Command failed.
@next/react-refresh-utils:dev: ELIFECYCLE Command failed.
@next/env:dev: ELIFECYCLE Command failed.
@next/codemod:dev: ELIFECYCLE Command failed.
@next/react-dev-overlay:dev: ELIFECYCLE Command failed.
@next/polyfill-nomodule:dev: ELIFECYCLE Command failed.
bench-nested-deps-app-router#dev: command (/workspaces/next.js/bench/nested-deps-app-router) pnpm run dev exited (1)
Tasks: 0 successful, 12 total
Cached: 0 cached, 12 total
Time: 8.365s
Failed: bench-nested-deps-app-router#dev
ERROR run failed: command exited (1)
ELIFECYCLE Command failed with exit code 1.
...
```
### Expected Behavior
Start developing and watch for code changes:
### Which browser are you using? (if relevant)
Irrelevant
### How are you deploying your application? (if relevant)
pnpm dev | https://github.com/vercel/next.js/issues/54592 | https://github.com/vercel/next.js/pull/54600 | 6d401c1a4735ddaf0c7e479d64c4ae38d50105c0 | 40b322635295275b8864c38bb47383e4b74d194f | "2023-08-26T07:58:52Z" | javascript | "2023-08-26T22:58:00Z" |
closed | vercel/next.js | https://github.com/vercel/next.js | 54,480 | ["packages/eslint-config-next/package.json", "packages/next/src/compiled/assert/assert.js", "packages/next/src/compiled/util/util.js", "pnpm-lock.yaml"] | Stale [email protected] in [email protected] | ### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 21.6.0: Sat Jun 18 17:07:22 PDT 2022; root:xnu-8020.140.41~1/RELEASE_ARM64_T6000
Binaries:
Node: 18.17.1
npm: 9.6.7
Yarn: 3.2.3
pnpm: N/A
Relevant packages:
next: 13.3.0
eslint-config-next: N/A
react: 18.2.0
react-dom: 18.2.0
```
### Which area(s) of Next.js are affected? (leave empty if unsure)
ESLint (eslint-config-next)
### Link to the code that reproduces this issue or a replay of the bug
x
### To Reproduce
Try using `'import/no-duplicates': ['warn', { 'prefer-inline': true }],` with the latest `eslint-config-next`
### Describe the Bug
Related ticket: https://github.com/import-js/eslint-plugin-import/issues/2863
Trying to add support for typescript's new flag [verbatimModuleSyntax](https://www.typescriptlang.org/tsconfig#verbatimModuleSyntax).
Since the codebase is big, the idea is to add eslint warning rules for imports and as soon as the developer touches a file, it will --fix its content based on the following rules:
```
'@typescript-eslint/consistent-type-exports': 'warn',
'@typescript-eslint/consistent-type-imports': 'warn',
'@typescript-eslint/no-import-type-side-effects': 'warn',
'import/no-duplicates': ['warn', { 'prefer-inline': true }],
```
But since the `[email protected]` is not latest, i get:
> Configuration for rule "import/no-duplicates" is invalid: Value {"prefer-inline":true} should NOT have additional properties.
By declaring the `import` plugin inside my eslint configuration, I get the: `Error: Plugin "import" was conflicted between ...`
Would it be possible to update the package to LTS?
### Expected Behavior
Using `'import/no-duplicates': ['warn', { 'prefer-inline': true }],` yields no errors
### Which browser are you using? (if relevant)
_No response_
### How are you deploying your application? (if relevant)
_No response_ | https://github.com/vercel/next.js/issues/54480 | https://github.com/vercel/next.js/pull/54490 | 4d6febf426340db44a80552766aa1944fd3c411e | 9a2a3496393002cd683b26c7ed1ae0b73a27f9d6 | "2023-08-24T08:32:44Z" | javascript | "2023-08-25T10:58:06Z" |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.