Datasets:

Languages:
Thai
ArXiv:
License:

Fix conditional logic in _info and _load_hf_data_from_remote for correct label assignment and data fetching

#1
  1. '_info' enhancements and bug fix

    • Updated the if conditions so that any subset_id ending with "domain" now uses DOMAIN_LABELS, and any ending with "intent" uses INTENT_LABELS. This improves the logic by removing hard-coded comparisons and making it more dynamic.
  2. Refined '_load_hf_data_from_remote'

    • Simplified the logic in load_hf_data_from_remote by using subset_id.endswith(...) to check for "domain" or "intent", and dynamically constructing the HF_REMOTE_REF as mteb/mtop{subset}. This ensures that datasets.load_dataset fetches the correct dataset, either mteb/mtop_domain or mteb/mtop_intent.
  3. Kept backward‑compatible defaults

    • Left DEFAULT_CONFIG_NAME unchanged to mtop_intent_classification_domain_source so that existing workflows continue to work without any extra branches or special cases.
  4. Version updates

    • Increased _SOURCE_VERSION to 1.0.1 and set _SEACROWD_VERSION to 2025.04.22 to reflect these changes and fixes.
HarshalGoyal916 changed pull request status to closed
HarshalGoyal916 changed pull request status to open
This comment has been hidden
HarshalGoyal916 changed pull request title from Fix conditional logic in _info and _load_hf_data_from_remote for correct label assignment and data fetching to pr/2
This comment has been hidden
HarshalGoyal916 changed pull request title from pr/2 to Fix conditional logic in _info and _load_hf_data_from_remote for correct label assignment and data fetching
SEACrowd org

Thank you for the fix, @HarshalGoyal916 !

holylovenia changed pull request status to merged
Your need to confirm your account before you can post a new comment.

Sign up or log in to comment