Fix conditional logic in _info and _load_hf_data_from_remote for correct label assignment and data fetching
#1
by
HarshalGoyal916
- opened
'_info' enhancements and bug fix
- Updated the if conditions so that any subset_id ending with "domain" now uses DOMAIN_LABELS, and any ending with "intent" uses INTENT_LABELS. This improves the logic by removing hard-coded comparisons and making it more dynamic.
Refined '_load_hf_data_from_remote'
- Simplified the logic in load_hf_data_from_remote by using subset_id.endswith(...) to check for "domain" or "intent", and dynamically constructing the HF_REMOTE_REF as mteb/mtop{subset}. This ensures that datasets.load_dataset fetches the correct dataset, either mteb/mtop_domain or mteb/mtop_intent.
Kept backward‑compatible defaults
- Left
DEFAULT_CONFIG_NAME
unchanged tomtop_intent_classification_domain_source
so that existing workflows continue to work without any extra branches or special cases.
- Left
Version updates
- Increased
_SOURCE_VERSION
to1.0.1
and set_SEACROWD_VERSION
to2025.04.22
to reflect these changes and fixes.
- Increased
HarshalGoyal916
changed pull request status to
closed
HarshalGoyal916
changed pull request status to
open
This comment has been hidden
HarshalGoyal916
changed pull request title from
Fix conditional logic in _info and _load_hf_data_from_remote for correct label assignment and data fetching
to pr/2
This comment has been hidden
HarshalGoyal916
changed pull request title from
pr/2
to Fix conditional logic in _info and _load_hf_data_from_remote for correct label assignment and data fetching
holylovenia
changed pull request status to
merged