fix thresholds

app.py

@@ -39,53 +39,86 @@ def get_device_data(device):
     
     return df[device_cols]
 
-def get_color_for_value(val, min_val, max_val):
-    """Return a color based on where the value falls in the range"""
-    if min_val == max_val:
-        return ""  # No color if all values are the same
+def get_color_for_metric(val, metric_name):
+    """Return a color based on the metric type and value"""
+    try:
+        val = float(val)
+    except (ValueError, TypeError):
+        return ""
         
-    normalized = (val - min_val) / (max_val - min_val)
-    
-    if normalized < 0.33:
-        return ""  # Low values are blank
-    elif normalized < 0.66:
-        # Medium values are green
-        intensity = int(255 * ((normalized - 0.33) / 0.33))
-        return f"background-color: rgba(0, {intensity}, 0, 0.3)"
-    else:
-        # High values are red
-        intensity = int(255 * ((normalized - 0.66) / 0.34))
-        return f"background-color: rgba({intensity}, 0, 0, 0.3)"
+    # Define thresholds for different metrics
+    if "BPM" in metric_name:
+        # Lower is better for BPM
+        if val <= 50:
+            return "background-color: rgba(0, 180, 0, 0.3)"  # Green
+        elif val >= 54:
+            return "background-color: rgba(180, 0, 0, 0.3)"  # Red
+        else:
+            return "background-color: rgba(180, 180, 180, 0.1)"  # Light gray for middle range
+            
+    elif "Score" in metric_name:
+        # Higher is better for Score
+        if val >= 85:
+            return "background-color: rgba(0, 180, 0, 0.3)"  # Dark green
+        elif val >= 75:
+            return "background-color: rgba(0, 140, 0, 0.2)"  # Medium green
+        elif val <= 70:
+            return "background-color: rgba(180, 0, 0, 0.3)"  # Red
+        else:
+            return "background-color: rgba(180, 180, 180, 0.1)"  # Light gray
+            
+    elif "HRV" in metric_name:
+        # Higher is better for HRV
+        if val >= 80:
+            return "background-color: rgba(0, 180, 0, 0.3)"  # Dark green
+        elif val <= 55:
+            return "background-color: rgba(180, 0, 0, 0.3)"  # Red
+        else:
+            return "background-color: rgba(180, 180, 180, 0.1)"  # Light gray
+            
+    elif "Deep" in metric_name:
+        # Higher might be better for Deep sleep
+        if val >= 1.0:
+            return "background-color: rgba(0, 180, 0, 0.3)"  # Green
+        elif val <= 0.2:
+            return "background-color: rgba(180, 0, 0, 0.3)"  # Red
+        else:
+            return "background-color: rgba(180, 180, 180, 0.1)"  # Light gray
+            
+    elif "REM" in metric_name:
+        # Higher might be better for REM
+        if val >= 1.5:
+            return "background-color: rgba(0, 180, 0, 0.3)"  # Green
+        elif val <= 0.8:
+            return "background-color: rgba(180, 0, 0, 0.3)"  # Red
+        else:
+            return "background-color: rgba(180, 180, 180, 0.1)"  # Light gray
+            
+    elif "Light" in metric_name:
+        # Medium values might be ideal for Light sleep
+        if 5.0 <= val <= 6.0:
+            return "background-color: rgba(0, 180, 0, 0.3)"  # Green
+        elif val >= 6.3 or val <= 4.5:
+            return "background-color: rgba(180, 0, 0, 0.3)"  # Red
+        else:
+            return "background-color: rgba(180, 180, 180, 0.1)"  # Light gray
+            
+    return ""  # Default no color
 
 def prepare_data_with_styling(df):
     data = df.values.tolist()
     headers = list(df.columns)
     
-    # Get min/max for each numeric column
-    col_ranges = {}
-    for i, col in enumerate(headers):
-        if col not in ['Day', 'Date', 'Day of Week', 'Notes']:
-            try:
-                values = [float(row[i]) for row in data if row[i] != "" and pd.notna(row[i])]
-                if values:
-                    col_ranges[i] = {'min': min(values), 'max': max(values)}
-            except (ValueError, TypeError):
-                continue
-    
     # Create styling
     styling = []
     for row in data:
         row_styling = []
         for i, val in enumerate(row):
-            if i in col_ranges and val != "" and pd.notna(val):
-                try:
-                    val_float = float(val)
-                    style = get_color_for_value(val_float, col_ranges[i]['min'], col_ranges[i]['max'])
-                    row_styling.append(["", f"width: var(--cell-width-3); left: auto; {style}"])
-                except (ValueError, TypeError):
-                    row_styling.append(["", ""])
-            else:
+            if headers[i] in ['Day', 'Date', 'Day of Week', 'Notes'] or val == "":
                 row_styling.append(["", ""])
+            else:
+                style = get_color_for_metric(val, headers[i])
+                row_styling.append(["", f"width: var(--cell-width-3); left: auto; {style}"])
         styling.append(row_styling)
     
     return {