Change in arrow assignment
Browse files- src/popover.ts +11 -9
src/popover.ts
CHANGED
@@ -101,11 +101,7 @@ export function repositionPopover(element: Element) {
|
|
101 |
popover.wrapper.style.top = `auto`;
|
102 |
|
103 |
popover.arrow.classList.add("driver-popover-arrow-none");
|
104 |
-
|
105 |
-
return;
|
106 |
-
}
|
107 |
-
|
108 |
-
if (isTopOptimal) {
|
109 |
const topToSet = Math.min(topValue, window.innerHeight - popoverDimensions.height - popoverArrowDimensions.width);
|
110 |
|
111 |
let leftToSet = 0;
|
@@ -118,8 +114,6 @@ export function repositionPopover(element: Element) {
|
|
118 |
),
|
119 |
popoverArrowDimensions.width
|
120 |
);
|
121 |
-
|
122 |
-
popover.arrow.classList.add("driver-popover-arrow-side-top", "driver-popover-arrow-align-start");
|
123 |
} else if (requiredAlignment === "end") {
|
124 |
leftToSet = Math.max(
|
125 |
Math.min(
|
@@ -128,16 +122,24 @@ export function repositionPopover(element: Element) {
|
|
128 |
),
|
129 |
popoverArrowDimensions.width
|
130 |
);
|
131 |
-
popover.arrow.classList.add("driver-popover-arrow-side-top", "driver-popover-arrow-align-end");
|
132 |
}
|
133 |
|
134 |
-
// popover.arrow.classList.add("driver-popover-arrow-bottom");
|
135 |
|
136 |
popover.wrapper.style.top = `${topToSet}px`;
|
137 |
popover.wrapper.style.left = `${leftToSet}px`;
|
138 |
popover.wrapper.style.bottom = `auto`;
|
139 |
popover.wrapper.style.right = "auto";
|
|
|
|
|
140 |
}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
141 |
}
|
142 |
|
143 |
function createPopover(): PopoverDOM {
|
|
|
101 |
popover.wrapper.style.top = `auto`;
|
102 |
|
103 |
popover.arrow.classList.add("driver-popover-arrow-none");
|
104 |
+
} else if (isTopOptimal) {
|
|
|
|
|
|
|
|
|
105 |
const topToSet = Math.min(topValue, window.innerHeight - popoverDimensions.height - popoverArrowDimensions.width);
|
106 |
|
107 |
let leftToSet = 0;
|
|
|
114 |
),
|
115 |
popoverArrowDimensions.width
|
116 |
);
|
|
|
|
|
117 |
} else if (requiredAlignment === "end") {
|
118 |
leftToSet = Math.max(
|
119 |
Math.min(
|
|
|
122 |
),
|
123 |
popoverArrowDimensions.width
|
124 |
);
|
|
|
125 |
}
|
126 |
|
|
|
127 |
|
128 |
popover.wrapper.style.top = `${topToSet}px`;
|
129 |
popover.wrapper.style.left = `${leftToSet}px`;
|
130 |
popover.wrapper.style.bottom = `auto`;
|
131 |
popover.wrapper.style.right = "auto";
|
132 |
+
} else if (isBottomOptimal) {
|
133 |
+
// @todo - handle bottom rendering
|
134 |
}
|
135 |
+
|
136 |
+
// We need to check which position we end up rendering the popover at
|
137 |
+
// to be able to assign the proper arrow class
|
138 |
+
renderPopoverArrow();
|
139 |
+
}
|
140 |
+
|
141 |
+
function renderPopoverArrow() {
|
142 |
+
// @todo
|
143 |
}
|
144 |
|
145 |
function createPopover(): PopoverDOM {
|