kamrify commited on
Commit
34b7e3b
·
1 Parent(s): aafd6df

Fix popover not showing in non-animated versiong

Browse files
Files changed (2) hide show
  1. index.html +1 -0
  2. src/highlight.ts +2 -1
index.html CHANGED
@@ -333,6 +333,7 @@ npm install driver.js</pre
333
 
334
  document.getElementById("basic-tour").addEventListener("click", () => {
335
  const driverObj = driver({
 
336
  steps: [
337
  {
338
  element: ".page-header",
 
333
 
334
  document.getElementById("basic-tour").addEventListener("click", () => {
335
  const driverObj = driver({
336
+ animate: true,
337
  steps: [
338
  {
339
  element: ".page-header",
src/highlight.ts CHANGED
@@ -69,6 +69,7 @@ function transferHighlight(toElement: Element, toStep: DriveStep) {
69
  const isToDummyElement = toElement.id === "driver-dummy-element";
70
  const isFromDummyElement = fromElement.id === "driver-dummy-element";
71
 
 
72
  const highlightStartedHook = getConfig("onHighlightStarted");
73
  const highlightedHook = getConfig("onHighlighted");
74
  const deselectedHook = getConfig("onDeselected");
@@ -81,7 +82,7 @@ function transferHighlight(toElement: Element, toStep: DriveStep) {
81
  highlightStartedHook(isToDummyElement ? undefined : toElement, toStep);
82
  }
83
 
84
- const hasDelayedPopover = !isFirstHighlight;
85
  let isPopoverRendered = false;
86
 
87
  hidePopover();
 
69
  const isToDummyElement = toElement.id === "driver-dummy-element";
70
  const isFromDummyElement = fromElement.id === "driver-dummy-element";
71
 
72
+ const isAnimatedTour = getConfig("animate");
73
  const highlightStartedHook = getConfig("onHighlightStarted");
74
  const highlightedHook = getConfig("onHighlighted");
75
  const deselectedHook = getConfig("onDeselected");
 
82
  highlightStartedHook(isToDummyElement ? undefined : toElement, toStep);
83
  }
84
 
85
+ const hasDelayedPopover = !isFirstHighlight && isAnimatedTour;
86
  let isPopoverRendered = false;
87
 
88
  hidePopover();