kamrify commited on
Commit
2d9f282
·
1 Parent(s): 17851f6

Decrease animatino duration and popover not showing fix

Browse files
Files changed (3) hide show
  1. src/common/constants.js +3 -3
  2. src/driver.scss +2 -2
  3. src/index.js +0 -1
src/common/constants.js CHANGED
@@ -28,12 +28,12 @@ export const CLASS_NEXT_STEP_BTN = 'driver-next-btn';
28
  export const CLASS_PREV_STEP_BTN = 'driver-prev-btn';
29
  export const CLASS_BTN_DISABLED = 'driver-disabled';
30
 
31
- // It must match the one set in the animations in CSS file
32
- export const ANIMATION_DURATION_MS = 400;
33
 
34
  // language=HTML
35
  export const POPOVER_HTML = (className = '') => `
36
- <div id="${ID_POPOVER} ${className}">
37
  <div class="${CLASS_POPOVER_TIP}"></div>
38
  <div class="${CLASS_POPOVER_TITLE}">Popover Title</div>
39
  <div class="${CLASS_POPOVER_DESCRIPTION}">Popover Description</div>
 
28
  export const CLASS_PREV_STEP_BTN = 'driver-prev-btn';
29
  export const CLASS_BTN_DISABLED = 'driver-disabled';
30
 
31
+ // NOTE: It must match the one set in the animations in CSS file
32
+ export const ANIMATION_DURATION_MS = 300;
33
 
34
  // language=HTML
35
  export const POPOVER_HTML = (className = '') => `
36
+ <div id="${ID_POPOVER}" class="${className}">
37
  <div class="${CLASS_POPOVER_TIP}"></div>
38
  <div class="${CLASS_POPOVER_TITLE}">Popover Title</div>
39
  <div class="${CLASS_POPOVER_DESCRIPTION}">Popover Description</div>
src/driver.scss CHANGED
@@ -9,9 +9,9 @@ $overlay-z-index: 100002 !default;
9
  $stage-z-index: 100003 !default;
10
  $highlighted-element-z-index: 100004 !default;
11
 
12
- // If you update this duration, make sure to
13
  // update `ANIMATION_DURATION_MS` constant
14
- $animation-ms: 400 !default;
15
  $animation-sec: ($animation-ms / 1000) * 1s !default;
16
 
17
  div#driver-popover-item {
 
9
  $stage-z-index: 100003 !default;
10
  $highlighted-element-z-index: 100004 !default;
11
 
12
+ // Note: If you update this duration, make sure to
13
  // update `ANIMATION_DURATION_MS` constant
14
+ $animation-ms: 300 !default;
15
  $animation-sec: ($animation-ms / 1000) * 1s !default;
16
 
17
  div#driver-popover-item {
src/index.js CHANGED
@@ -417,7 +417,6 @@ export default class Driver {
417
  }
418
 
419
  this.isActivated = true;
420
-
421
  this.currentStep = index;
422
  this.overlay.highlight(this.steps[index]);
423
  }
 
417
  }
418
 
419
  this.isActivated = true;
 
420
  this.currentStep = index;
421
  this.overlay.highlight(this.steps[index]);
422
  }