Update app.py

app.py

@@ -2600,6 +2600,172 @@ def create_ui(manager: IssueManager) -> gr.Blocks:
             # Return default updates to clear the UI
             return default_updates
 
+        try:
+            # The first column (index 0) is the Issue ID
+            selected_id = int(evt.value[0])
+            logger.info(f"Issue selected via Dataframe: ID {selected_id}")
+
+            if selected_id not in manager.issues:
+                logger.error(f"Selected issue ID {selected_id} not found in manager's issue list.")
+                return {
+                    **default_updates,
+                    "issue_preview_html": gr.update(value=f"<p style='color: red; font-weight: bold;'>Error: Issue {selected_id} not found in the current list. Try re-scanning.</p>"),
+                    "selected_issue_id_hidden": gr.update(value=""), # Ensure hidden state is cleared
+                }
+
+            issue_data = manager.issues[selected_id]
+            files_content: Dict[str, str] = {}
+            context_source_msg = "Loading context..."
+            context_load_start = time.time()
+
+            # --- Load or Compute Code Context ---
+            # Prioritize pre-computed context if available
+            context_data = manager.precomputed_context.get(selected_id) # Use .get for safety
+
+            if context_data:
+                 timestamp = context_data.get('timestamp', 0)
+                 timestamp_str = datetime.fromtimestamp(timestamp).strftime('%Y-%m-%d %H:%M:%S')
+                 if context_data.get("error"):
+                     context_source_msg = f"Pre-computed (Failed @ {timestamp_str})"
+                     files_content["error_context.txt"] = f"# Error loading pre-computed context:\n# {context_data['error']}"
+                 elif context_data.get("files"):
+                     context_source_msg = f"Pre-computed ({len(context_data['files'])} files @ {timestamp_str})"
+                     logger.info(f"Loading {len(context_data['files'])} files from pre-computed context for issue {selected_id}: {context_data['files']}")
+                     loaded_count = 0
+                     for file_path_str in context_data["files"]:
+                         full_path = manager.repo_local_path / file_path_str
+                         try:
+                             if full_path.is_file():
+                                 # Use resolved path for robust reading
+                                 resolved_full_path = full_path.resolve()
+                                 # Double-check it's still in the repo path after resolve
+                                 if resolved_full_path.is_relative_to(manager.repo_local_path.resolve()):
+                                     files_content[file_path_str] = resolved_full_path.read_text(encoding='utf-8', errors='ignore')
+                                     loaded_count += 1
+                                 else:
+                                     logger.warning(f"Pre-computed file path {file_path_str} resolved outside repo during load for issue {selected_id}.")
+                                     files_content[file_path_str] = f"# File path resolved outside repository: {file_path_str}"
+                             else:
+                                 logger.warning(f"Pre-computed file path {file_path_str} not found or not a file during load for issue {selected_id}.")
+                                 files_content[file_path_str] = f"# File not found or not a file: {file_path_str}"
+                         except Exception as e:
+                             logger.warning(f"Error reading pre-computed file {full_path} for issue {selected_id}: {e}")
+                             files_content[file_path_str] = f"# Error reading file: {e}"
+                     # This check should be outside the for loop, indented the same as the for loop
+                     if loaded_count == 0 and context_data.get("files"): # Use .get for safety
+                          files_content["error_reading_files.txt"] = "# Precomputed context found file references, but failed to read any file content."
+                 # This else corresponds to elif context_data.get("files"):
+                 else: # Line 2690 - Corrected indentation
+                     context_source_msg = f"Pre-computed (No files found @ {timestamp_str})"
+                     files_content[f"issue_{selected_id}_context.md"] = context_data.get("content", "# No specific code context found (pre-computed).")
+
+            else: # Handle on-demand context computation
+                 logger.info(f"Context not pre-computed for issue {selected_id}, computing on demand for editor.")
+                 context_source_msg = "Computed On-Demand"
+                 context_result = await manager._get_code_context(issue_data)
+
+                 # Store the newly computed context for future use (e.g., patch generation)
+                 manager.precomputed_context[selected_id] = {
+                     "content": context_result.get("content"),
+                     "files": context_result.get("files", []),
+                     "error": context_result.get("error"),
+                     "timestamp": time.time()
+                 }
+
+                 if "error" in context_result and context_result["error"]:
+                     context_source_msg += f" (Error: {context_result['error']})"
+                     files_content["error_context.txt"] = f"# Error loading context on demand:\n# {context_result['error']}"
+                 elif context_result.get("files"):
+                     context_source_msg += f" ({len(context_result['files'])} files)"
+                     logger.info(f"Loading {len(context_result['files'])} files computed on-demand for issue {selected_id}: {context_result['files']}")
+                     loaded_count = 0
+                     for file_path_str in context_result["files"]:
+                         full_path = manager.repo_local_path / file_path_str
+                         try:
+                             if full_path.is_file():
+                                 resolved_full_path = full_path.resolve()
+                                 if resolved_full_path.is_relative_to(manager.repo_local_path.resolve()):
+                                     files_content[file_path_str] = resolved_full_path.read_text(encoding='utf-8', errors='ignore')
+                                     loaded_count +=1
+                                 else:
+                                     logger.warning(f"On-demand file path {file_path_str} resolved outside repo during load for issue {selected_id}.")
+                                     files_content[file_path_str] = f"# File path resolved outside repository: {file_path_str}"
+                             else:
+                                logger.warning(f"On-demand file path {file_path_str} not found or not a file during load for issue {selected_id}.")
+                                files_content[file_path_str] = f"# File not found or not a file: {file_path_str}"
+                         except Exception as e:
+                             logger.warning(f"Error reading on-demand file {full_path} for issue {selected_id}: {e}")
+                             files_content[file_path_str] = f"# Error reading file: {e}"
+                     # This check should be outside the try/except and for loop
+                     if loaded_count == 0 and context_result.get("files"): # Use .get for safety
+                          files_content["error_reading_files.txt"] = "# Context computation found file references, but failed to read any file content."
+                 # This else corresponds to the inner if/elif within the on-demand block
+                 else:
+                     context_source_msg += " (No files found)"
+                     files_content[f"issue_{selected_id}_context.md"] = context_result.get("content", "# No specific code context found.")
+
+            # This line should be outside both the 'if context_data' and its 'else' branch
+            context_load_duration = time.time() - context_load_start
+            logger.info(f"Context loading for editor took {context_load_duration:.2f}s. Source: {context_source_msg}")
+
+            if not files_content:
+                 files_content["placeholder.txt"] = f"# No relevant files found or context failed to load for issue {selected_id}."
+
+            # Initialize or update the OT editor instance for this issue
+            manager.code_editors[selected_id] = OTCodeEditor(initial_value=files_content)
+            logger.info(f"Initialized/Updated OT editor state for issue {selected_id} with files: {list(files_content.keys())}")
+
+            # Determine the initial language hint for the editor based on the first file extension
+            initial_language = "text" # Default to plain text
+            if files_content:
+                 first_file_name = list(files_content.keys())[0]
+                 # Extract extension (part after the last dot)
+                 _, ext = os.path.splitext(first_file_name)
+                 if ext:
+                     # Remove leading dot and convert to lowercase
+                     ext = ext[1:].lower()
+                     # Map common extensions to ACE editor modes (approximate)
+                     # Check available modes in ACE editor documentation if needed
+                     lang_map = {
+                         'py': 'python', 'js': 'javascript', 'jsx': 'javascript', 'ts': 'typescript', 'tsx': 'typescript',
+                         'java': 'java', 'c': 'c_cpp', 'cpp': 'c_cpp', 'h': 'c_cpp', 'hpp': 'c_cpp', 'cs': 'csharp',
+                         'go': 'golang', 'rs': 'rust', 'php': 'php', 'rb': 'ruby', 'html': 'html', 'css': 'css',
+                         'scss': 'scss', 'less': 'less', 'md': 'markdown', 'yaml': 'yaml', 'yml': 'yaml', 'json': 'json',
+                         'toml': 'toml', 'sh': 'sh', 'bash': 'sh', 'zsh': 'sh', 'sql': 'sql', 'xml': 'xml',
+                         'dockerfile': 'dockerfile', 'makefile': 'makefile', 'txt': 'text', 'log': 'text',
+                         'conf': 'text', 'cfg': 'text', 'ini': 'ini'
+                     }
+                     initial_language = lang_map.get(ext, 'text')
+
+
+            # Prepare updates for all relevant UI components
+            updates = {
+                # Update the hidden state element with the selected ID (as string)
+                "selected_issue_id_hidden": gr.update(value=str(selected_id)),
+                "issue_preview_html": gr.update(value=generate_issue_preview(selected_id)),
+                "code_edit_component": gr.update(value=files_content, interactive=True, language=initial_language),
+                "ai_output_display": gr.update(value=f"*Context loaded ({context_source_msg}). Ready for AI actions or editing.*"),
+                "copy_patch_btn": gr.update(visible=False), # Hide copy button on new selection
+            }
+            return updates
+
+        except (ValueError, TypeError, IndexError, KeyError, AttributeError) as e:
+            logger.exception(f"Error processing issue selection event (evt.value: {getattr(evt, 'value', 'N/A')}): {e}")
+            # Return default state plus an error message
+            return {
+                **default_updates,
+                "issue_preview_html": gr.update(value="<p style='color: red; font-weight: bold;'>Error loading issue details. Please check logs and try again.</p>"),
+                "code_edit_component": gr.update(value={"error.txt": f"# Error loading code context for selection.\n# Error: {e}"}, interactive=False, language="text"),
+                "ai_output_display": gr.update(value="*Error processing selection. See logs.*"),
+                "selected_issue_id_hidden": gr.update(value=""), # Ensure hidden state is cleared
+                "copy_patch_btn": gr.update(visible=False), # Hide copy button on error
+            }
+        # Check if a row was actually selected and has a value
+        if evt.index is None or not hasattr(evt, 'value') or not evt.value or evt.value[0] is None:
+            logger.info("Issue deselected or invalid selection event.")
+            # Return default updates to clear the UI
+            return default_updates
+
         try:
             # The first column (index 0) is the Issue ID
             selected_id = int(evt.value[0])