Address Changes

Database/models/address.js

@@ -3,7 +3,7 @@ const { Schema } = mongoose;
 
 const addressSchema = new Schema({
     user: {
-        type: Schema.Types.ObjectId,
+        type: Number,
         ref: 'User',
         required: true
     },

routes/address.js

@@ -2,100 +2,81 @@ const express = require("express");
 const router = express.Router();
 const mongoose = require("mongoose");
 const Address = require("../Database/models/address");
+const { successResponse, failedResponse } = require("../utils/responseModel");
 
-// Response helpers
-const response = {
-  success: (data, message = "Success") => ({
-    status: "success",
-    code: 200,
-    data,
-    message
-  }),
-  error: (message = "Error", code = 400) => ({
-    status: "error",
-    code,
-    message
-  })
-};
 
 // Middleware for async error handling
-const asyncHandler = fn => (req, res, next) => 
-  Promise.resolve(fn(req, res, next)).catch(next);
+const asyncHandler = fn => (req, res, next) =>
+    Promise.resolve(fn(req, res, next)).catch(next);
 
 // Validation middleware
 const validateAddressData = (req, res, next) => {
-  const requiredFields = ['user', 'name', 'mobileNumber', 'pinCode', 'address'];
-  const missingFields = requiredFields.filter(field => !req.body[field]);
-  
-  if (missingFields.length > 0) {
-    return res.status(400).json(response.error(
-      `Missing required fields: ${missingFields.join(', ')}`
-    ));
-  }
-  next();
+    const requiredFields = ['user', 'name', 'mobileNumber', 'pinCode', 'address'];
+    const missingFields = requiredFields.filter(field => !req.body[field]);
+
+    if (missingFields.length > 0) {
+        return res.status(400).json(failedResponse(
+            `Missing required fields: ${missingFields.join(', ')}`
+        ));
+    }
+    next();
 };
 
 // Create address
 router.post("/", validateAddressData, asyncHandler(async (req, res) => {
-  const newAddress = new Address(req.body);
-  const savedAddress = await newAddress.save();
-  res.status(201).json(response.success(savedAddress, "Address created successfully"));
+    const addressData = {
+        ...req.body,
+        user: parseInt(req.body.user) // Convert to number
+    };
+
+    const newAddress = new Address(addressData);
+    res.status(201).json(successResponse("Address created successfully", newAddress));
 }));
 
 // Get addresses by user
 router.get("/user/:userId", asyncHandler(async (req, res) => {
-  if (!mongoose.Types.ObjectId.isValid(req.params.userId)) {
-    return res.status(400).json(response.error("Invalid user ID"));
-  }
+    const userId = parseInt(req.params.userId);
+    if (isNaN(userId)) {
+        return res.status(400).json(response.error("Invalid user ID"));
+    }
 
-  const addresses = await Address.find({ user: req.params.userId });
-  if (!addresses.length) {
-    return res.status(404).json(response.error("No addresses found", 404));
-  }
-  res.json(response.success(addresses));
+    const addresses = await Address.find({ user: userId });
+    res.json(successResponse("Success!", addresses));
 }));
 
 // Get all addresses
 router.get("/", asyncHandler(async (req, res) => {
-  const addresses = await Address.find().populate('user', 'username email');
-  res.json(response.success(addresses));
+    const addresses = await Address.find().populate('user', 'username email');
+    res.json(successResponse("Success!", addresses));
 }));
 
 // Update address
 router.put("/:id", validateAddressData, asyncHandler(async (req, res) => {
-  if (!mongoose.Types.ObjectId.isValid(req.params.id)) {
-    return res.status(400).json(response.error("Invalid address ID"));
-  }
+    const updatedAddress = await Address.findOneAndUpdate(
+        { _id: req.params.id },
+        req.body,
+        { new: true, runValidators: true }
+    );
 
-  const updatedAddress = await Address.findByIdAndUpdate(
-    req.params.id,
-    req.body,
-    { new: true, runValidators: true }
-  );
-
-  if (!updatedAddress) {
-    return res.status(404).json(response.error("Address not found", 404));
-  }
-  res.json(response.success(updatedAddress, "Address updated successfully"));
+    if (!updatedAddress) {
+        return res.status(404).json(failedResponse("Address not found", 404));
+    }
+    res.json(successResponse("Address updated successfully", updatedAddress));
 }));
 
 // Delete address
 router.delete("/:id", asyncHandler(async (req, res) => {
-  if (!mongoose.Types.ObjectId.isValid(req.params.id)) {
-    return res.status(400).json(response.error("Invalid address ID"));
-  }
-
-  const deletedAddress = await Address.findByIdAndDelete(req.params.id);
-  if (!deletedAddress) {
-    return res.status(404).json(response.error("Address not found", 404));
-  }
-  res.json(response.success(null, "Address deleted successfully"));
+    const deletedAddress = await Address.findOneAndDelete({ _id: req.params.id });
+    if (!deletedAddress) {
+        return res.status(404).json(failedResponse("Address not found", 404));
+    }
+    res.json(successResponse("Address deleted successfully", null,));
 }));
 
 // Error handling middleware
 router.use((err, req, res, next) => {
-  console.error(err.stack);
-  res.status(500).json(response.error("Internal server error", 500));
+    console.error(err.stack);
+    res.status(500).json(failedResponse("Internal server error", 500));
 });
 
 module.exports = router;