Update app.py

app.py

@@ -11,28 +11,26 @@ DEFAULT_API_URL = "https://agents-course-unit4-scoring.hf.space"
 
 def run_and_submit_all(profile):
     """
-    Fetch all questions, run the SmolAgent on them, submit all answers,
-    and display the results.
+    Fetch all questions, run the agent on them, submit all answers,
+    and return the status and results table.
     """
-    space_id = os.getenv("SPACE_ID")
-
     if profile is None:
-        return "Please login to Hugging Face with the button.", None
+        return "Please login to Hugging Face with the login button.", None
     username = profile.username
 
-    # Instantiate the agent
+    # Instantiate agent
     try:
         agent = create_agent()
     except Exception as e:
         return f"Error initializing agent: {e}", None
 
-    agent_code = f"https://huggingface.co/spaces/{space_id}/tree/main"
+    agent_code = f"https://huggingface.co/spaces/{os.getenv('SPACE_ID')}/tree/main"
 
     # Fetch questions
     try:
-        response = requests.get(f"{DEFAULT_API_URL}/questions", timeout=15)
-        response.raise_for_status()
-        questions = response.json()
+        resp = requests.get(f"{DEFAULT_API_URL}/questions", timeout=15)
+        resp.raise_for_status()
+        questions = resp.json()
     except Exception as e:
         return f"Error fetching questions: {e}", None
 
@@ -42,24 +40,24 @@ def run_and_submit_all(profile):
     # Run agent on each question
     results = []
     payload = []
-    for q in questions:
-        task_id = q.get("task_id")
-        question_text = q.get("question")
-        if not task_id or not question_text:
+    for item in questions:
+        task_id = item.get("task_id")
+        question_text = item.get("question")
+        if not task_id or question_text is None:
             continue
         try:
-            answer = agent.run(question=question_text)
+            ans = agent.run(question=question_text)
         except Exception as e:
-            answer = f"ERROR: {e}"
-        results.append({"Task ID": task_id, "Question": question_text, "Answer": answer})
-        payload.append({"task_id": task_id, "submitted_answer": answer})
+            ans = f"ERROR: {e}"
+        results.append({"Task ID": task_id, "Question": question_text, "Answer": ans})
+        payload.append({"task_id": task_id, "submitted_answer": ans})
 
     # Submit answers
-    submit_payload = {"username": username, "agent_code": agent_code, "answers": payload}
+    submission = {"username": username, "agent_code": agent_code, "answers": payload}
     try:
-        resp = requests.post(f"{DEFAULT_API_URL}/submit", json=submit_payload, timeout=60)
-        resp.raise_for_status()
-        data = resp.json()
+        r = requests.post(f"{DEFAULT_API_URL}/submit", json=submission, timeout=60)
+        r.raise_for_status()
+        data = r.json()
         status = (
             f"Submission Successful!\n"
             f"User: {data.get('username')}\n"
@@ -74,10 +72,10 @@ def run_and_submit_all(profile):
 
 def test_random_question(profile):
     """
-    Fetch a random GAIA question and return its answer by the agent.
+    Fetch a random question and return the question and agent's answer.
     """
     if profile is None:
-        return "Please login to test.", ""
+        return "Please login to Hugging Face with the login button.", ""
     try:
         q = fetch_random_question()
         agent = create_agent()
@@ -86,31 +84,32 @@ def test_random_question(profile):
     except Exception as e:
         return f"Error: {e}", ""
 
-
 # --- Gradio Interface ---
 with gr.Blocks() as demo:
     gr.Markdown("# SmolAgent Evaluation Runner")
     gr.Markdown(
         """
         **Instructions:**
-        1. Clone this space and define your agent logic in agent.py.
-        2. Log in with your Hugging Face account using the login button.
-        3. Use 'Run Evaluation & Submit All Answers' or 'Test Random Question'.
+        1. Clone this space and implement your agent logic in agent.py.
+        2. Log in with your Hugging Face account using the login button below.
+        3. Use the buttons to run evaluation or test a random question.
         """
     )
 
     login = gr.LoginButton()
-    run_all = gr.Button("Run Evaluation & Submit All Answers")
-    test = gr.Button("Test Random Question")
+    state = gr.State(value=None)
+    login.click(lambda user: user, inputs=[login], outputs=[state])
+
+    run_all_btn = gr.Button("Run Evaluation & Submit All Answers")
+    test_btn = gr.Button("Test Random Question")
 
-    status = gr.Textbox(label="Status / Result", lines=5, interactive=False)
-    table = gr.DataFrame(label="Results Table", wrap=True)
-    qbox = gr.Textbox(label="Random Question", lines=3, interactive=False)
-    abox = gr.Textbox(label="Agent Answer", lines=3, interactive=False)
+    status_output = gr.Textbox(label="Status / Result", lines=5, interactive=False)
+    results_table = gr.DataFrame(label="Results Table", wrap=True)
+    question_box = gr.Textbox(label="Random Question", lines=3, interactive=False)
+    answer_box = gr.Textbox(label="Agent Answer", lines=3, interactive=False)
 
-    # Attach login component directly as input for profile
-    run_all.click(fn=run_and_submit_all, inputs=[login], outputs=[status, table])
-    test.click(fn=test_random_question, inputs=[login], outputs=[qbox, abox])
+    run_all_btn.click(fn=run_and_submit_all, inputs=[state], outputs=[status_output, results_table])
+    test_btn.click(fn=test_random_question, inputs=[state], outputs=[question_box, answer_box])
 
 if __name__ == "__main__":
     demo.launch(debug=True, share=False)