Update app.py

app.py

@@ -5,82 +5,57 @@ import pandas as pd
 
 from agent import create_agent, fetch_random_question
 
-# --- Constants ---
 DEFAULT_API_URL = "https://agents-course-unit4-scoring.hf.space"
 
-
 def run_and_submit_all(profile):
-    """
-    Fetch all questions, run the agent on them, submit all answers,
-    and return the status and results table.
-    """
-    # Check login
     if not profile:
         return "Please login to Hugging Face with the login button.", None
-
-    # Extract username (support both .username and .name)
     username = getattr(profile, "username", None) or getattr(profile, "name", None)
     if not username:
         return "Login error: username not found.", None
 
-    # Build URLs
-    questions_url = f"{DEFAULT_API_URL}/questions"
-    submit_url = f"{DEFAULT_API_URL}/submit"
-
-    # Instantiate agent
-    try:
-        agent = create_agent()
-    except Exception as e:
-        return f"Error initializing agent: {e}", None
-
     # Fetch questions
     try:
-        resp = requests.get(questions_url, timeout=15)
-        resp.raise_for_status()
-        questions = resp.json()
+        qs = requests.get(f"{DEFAULT_API_URL}/questions", timeout=15)
+        qs.raise_for_status()
+        questions = qs.json()
     except Exception as e:
         return f"Error fetching questions: {e}", None
 
-    # Run agent
-    results = []
-    answers_payload = []
+    # Instantiate agent
+    agent = create_agent()
+
+    # Run and collect answers
+    results, payload = [], []
     for q in questions:
-        tid = q.get("task_id")
-        text = q.get("question")
-        if not tid or not text:
+        tid, text = q.get("task_id"), q.get("question")
+        if not (tid and text):
             continue
         try:
-            ans = agent.run(question=text)
+            ans = agent.run(text)   # <-- positional!
         except Exception as e:
             ans = f"ERROR: {e}"
-        results.append({
-            "Task ID": tid,
-            "Question": text,
-            "Answer": ans
-        })
-        answers_payload.append({
-            "task_id": tid,
-            "submitted_answer": ans
-        })
-
-    if not answers_payload:
+        results.append({"Task ID": tid, "Question": text, "Answer": ans})
+        payload.append({"task_id": tid, "submitted_answer": ans})
+
+    if not payload:
         return "Agent returned no answers.", pd.DataFrame(results)
 
-    # Submit answers
-    payload = {
+    # Submit
+    submission = {
         "username": username,
         "agent_code": f"https://huggingface.co/spaces/{os.getenv('SPACE_ID')}/tree/main",
-        "answers": answers_payload
+        "answers": payload
     }
     try:
-        resp = requests.post(submit_url, json=payload, timeout=60)
+        resp = requests.post(f"{DEFAULT_API_URL}/submit", json=submission, timeout=60)
         resp.raise_for_status()
         data = resp.json()
         status = (
             f"Submission Successful!\n"
-            f"User: {data.get('username')}\n"
-            f"Score: {data.get('score')}% ({data.get('correct_count')}/{data.get('total_attempted')})\n"
-            f"Message: {data.get('message')}"
+            f"User: {data['username']}\n"
+            f"Score: {data['score']}% ({data['correct_count']}/{data['total_attempted']})\n"
+            f"Message: {data['message']}"
         )
     except Exception as e:
         status = f"Submission Failed: {e}"
@@ -89,24 +64,15 @@ def run_and_submit_all(profile):
 
 
 def test_random_question(profile):
-    """
-    Fetch a random GAIA question and return the agent's answer.
-    """
     if not profile:
         return "Please login to Hugging Face with the login button.", ""
-
-    # Get question and run agent
-    try:
-        q = fetch_random_question()
-        question = q.get("question", "")
-        agent = create_agent()
-        answer = agent.run(question=question)
-        return question, answer
-    except Exception as e:
-        return f"Error during test: {e}", ""
+    q = fetch_random_question()
+    agent = create_agent()
+    # Positional call again
+    answer = agent.run(q["question"])
+    return q["question"], answer
 
 
-# --- Gradio Interface ---
 with gr.Blocks() as demo:
     gr.Markdown("# SmolAgent Evaluation Runner")
     gr.Markdown(
@@ -119,18 +85,16 @@ with gr.Blocks() as demo:
     )
 
     login = gr.LoginButton()
+    run_btn = gr.Button("Run Evaluation & Submit All Answers")
+    test_btn = gr.Button("Test Random Question")
 
-    run_button = gr.Button("Run Evaluation & Submit All Answers")
-    test_button = gr.Button("Test Random Question")
-
-    status_output = gr.Textbox(label="Status / Result", lines=5, interactive=False)
-    results_table = gr.DataFrame(label="Full Results Table", wrap=True)
-    question_box = gr.Textbox(label="Random Question", lines=3, interactive=False)
-    answer_box = gr.Textbox(label="Agent Answer", lines=3, interactive=False)
+    status_out = gr.Textbox(label="Status / Result", lines=5, interactive=False)
+    table_out = gr.DataFrame(label="Full Results Table", wrap=True)
+    question_out = gr.Textbox(label="Random Question", lines=3, interactive=False)
+    answer_out = gr.Textbox(label="Agent Answer", lines=3, interactive=False)
 
-    # Wire the login component directly into the callbacks
-    run_button.click(fn=run_and_submit_all, inputs=[login], outputs=[status_output, results_table])
-    test_button.click(fn=test_random_question, inputs=[login], outputs=[question_box, answer_box])
+    run_btn.click(fn=run_and_submit_all, inputs=[login], outputs=[status_out, table_out])
+    test_btn.click(fn=test_random_question, inputs=[login], outputs=[question_out, answer_out])
 
 if __name__ == "__main__":
     demo.launch(debug=True, share=False)