Update app.py

app.py

@@ -110,22 +110,20 @@ def translate_subtitles(srt_path, target_langs):
         logger.error(f"Translation failed: {str(e)}", exc_info=True)
         raise Exception(f"Translation failed: {str(e)}")
 
-def add_subtitles_ffmpeg(video_path, srt_path, output_path):
-    """Add subtitles to video using ffmpeg"""
+def burn_subtitles_ffmpeg(video_path, srt_path, output_path):
+    """Burn subtitles directly into the video using ffmpeg"""
     try:
-        logger.info(f"Adding subtitles to video using ffmpeg")
+        logger.info(f"Burning subtitles into video using ffmpeg")
+        
+        # Escape special characters in paths for ffmpeg filters
+        escaped_srt_path = srt_path.replace(":", "\\:").replace("'", "\\'").replace(" ", "\\ ")
+        
+        # Command to burn subtitles into video
         cmd = [
             'ffmpeg',
             '-i', video_path,           # Input video
-            '-f', 'srt',                # SRT format
-            '-i', srt_path,             # Input subtitles
-            '-map', '0:v',              # Map video from first input
-            '-map', '0:a',              # Map audio from first input
-            '-map', '1',                # Map subtitles from second input
-            '-c:v', 'copy',             # Copy video codec
+            '-vf', f"subtitles={escaped_srt_path}:force_style='FontSize=24,PrimaryColour=&H00FFFFFF,OutlineColour=&H00000000,BorderStyle=3'",  # Burn subtitles
             '-c:a', 'copy',             # Copy audio codec
-            '-c:s', 'mov_text',         # Use mov_text codec for subtitles
-            '-metadata:s:s:0', 'language=eng',  # Set subtitle language
             '-y',                       # Overwrite output file
             output_path
         ]
@@ -134,30 +132,30 @@ def add_subtitles_ffmpeg(video_path, srt_path, output_path):
         process = subprocess.run(cmd, capture_output=True, text=True)
         
         if process.returncode != 0:
-            logger.error(f"ffmpeg error: {process.stderr}")
+            logger.error(f"Subtitle burning failed: {process.stderr}")
             
-            # If subtitle embedding fails, try burning subtitles into video
-            logger.info("Attempting to burn subtitles into video")
+            # Try alternative method
+            logger.info("Trying alternative method for subtitle burning")
             cmd = [
                 'ffmpeg',
                 '-i', video_path,           # Input video
-                '-vf', f"subtitles='{srt_path}'",  # Burn subtitles into video
+                '-vf', f"subtitles='{srt_path}'",  # Simpler subtitle filter
                 '-c:a', 'copy',             # Copy audio codec
                 '-y',                       # Overwrite output file
                 output_path
             ]
             
-            logger.info(f"Running fallback command: {' '.join(cmd)}")
+            logger.info(f"Running alternative command: {' '.join(cmd)}")
             process = subprocess.run(cmd, capture_output=True, text=True)
             
             if process.returncode != 0:
-                logger.error(f"Subtitle burning failed: {process.stderr}")
-                raise Exception(f"Failed to add subtitles: {process.stderr}")
+                logger.error(f"Alternative subtitle burning failed: {process.stderr}")
+                raise Exception(f"Failed to burn subtitles: {process.stderr}")
         
         return output_path
     except Exception as e:
-        logger.error(f"Subtitle addition failed: {str(e)}", exc_info=True)
-        raise Exception(f"Subtitle addition failed: {str(e)}")
+        logger.error(f"Subtitle burning failed: {str(e)}", exc_info=True)
+        raise Exception(f"Subtitle burning failed: {str(e)}")
 
 def process_video(video_file, source_lang, target_langs, progress=gr.Progress()):
     """Process video with translation"""
@@ -200,7 +198,7 @@ def process_video(video_file, source_lang, target_langs, progress=gr.Progress())
             logger.info(f"Adding {lang_code} subtitles to video: {output_path}")
             
             try:
-                output_video = add_subtitles_ffmpeg(base_video, sub_path, output_path)
+                output_video = burn_subtitles_ffmpeg(base_video, sub_path, output_path)
                 
                 # Verify the output file exists and has content
                 if os.path.exists(output_video) and os.path.getsize(output_video) > 1000:
@@ -214,7 +212,7 @@ def process_video(video_file, source_lang, target_langs, progress=gr.Progress())
         # If all output videos failed, return the original
         if not output_videos:
             logger.warning("All subtitle additions failed, returning original video")
-            output_videos = [base_video]
+            return base_video, "Failed to add subtitles to video, returning original"
             
         progress(1.0, "Done!")
         return output_videos[0], f"Processing complete. Video saved to: {output_videos[0]}"
@@ -252,4 +250,11 @@ with gr.Blocks() as demo:
     )
 
 if __name__ == "__main__":
+    # Display ffmpeg version at startup
+    try:
+        version_info = subprocess.run(['ffmpeg', '-version'], capture_output=True, text=True)
+        logger.info(f"ffmpeg version info: {version_info.stdout.split('\\n')[0]}")
+    except:
+        logger.warning("Could not determine ffmpeg version")
+    
     demo.launch()