Update app.py

app.py

@@ -2,102 +2,195 @@ import gradio as gr
 import pandas as pd
 from mcq_generator import ImprovedMCQGenerator, is_suitable_for_students
 import io
-
-# Initialize MCQ Generator
-mcq_generator = ImprovedMCQGenerator()
+import tempfile # <-- Import tempfile
+import traceback # <-- Optional: for better error logging
+
+# Initialize MCQ Generator (Keep this outside the function for efficiency)
+try:
+    mcq_generator = ImprovedMCQGenerator()
+    print("✅ MCQ Generator Initialized Successfully")
+except Exception as e:
+    print(f"❌ Failed to initialize MCQ Generator: {e}")
+    # You might want to stop the app or handle this more gracefully
+    mcq_generator = None
 
 def generate_mcqs_ui(paragraph, num_questions):
-    if not paragraph.strip():
-        return None, None, "⚠️ Please enter a valid paragraph."
+    # Check if generator initialized properly
+    if mcq_generator is None:
+        return None, None, None, "❌ Error: MCQ Generator failed to initialize. Check server logs."
+
+    # --- Input Validation ---
+    if not paragraph or not paragraph.strip():
+        return None, None, None, "⚠️ Please enter a valid paragraph."
 
+    print("\n--- Checking Suitability ---") # Add logging
     if not is_suitable_for_students(paragraph):
-        return None, None, "❌ The paragraph is not suitable for MCQ generation (due to bias/toxicity/short length)."
+        print("❌ Paragraph deemed unsuitable.") # Add logging
+        # Return None for HTML and both file paths, plus the status message
+        return None, None, None, "❌ The paragraph is not suitable for MCQ generation (due to bias/toxicity/short length)."
+    print("✅ Paragraph suitable.") # Add logging
 
     try:
+        print(f"--- Generating {num_questions} MCQs ---") # Add logging
         # Generate MCQs using the generator
         mcqs = mcq_generator.generate_mcqs(paragraph, num_questions)
 
-        # Create pretty formatted MCQ list
-        pretty_mcqs = []
+        if not mcqs:
+             print("⚠️ No MCQs generated (potentially issue in generator logic).") # Add logging
+             return None, None, None, "⚠️ Could not generate MCQs for this text. Try different content or fewer questions."
+
+        print(f"✅ Generated {len(mcqs)} MCQs successfully.") # Add logging
+
+        # --- Create Pretty HTML Output ---
+        pretty_mcqs_html = ""
         for idx, mcq in enumerate(mcqs):
             options = ""
-            for opt_idx, option in enumerate(mcq['options']):
+            # Ensure options exist and handle potential errors
+            mcq_options = mcq.get('options', [])
+            answer_index = mcq.get('answer_index', -1)
+            question_text = mcq.get('question', '[No Question Text]')
+
+            for opt_idx, option in enumerate(mcq_options):
                 options += f"<b>{chr(65+opt_idx)}.</b> {option}<br>"
+
             question_html = f"<div style='margin-bottom:20px; padding:10px; border:1px solid #ccc; border-radius:10px; background:#f9f9f9;'>"
-            question_html += f"<b>Q{idx+1}:</b> {mcq['question']}<br><br>{options}"
-            question_html += f"<i><b>Answer:</b> {chr(65+mcq['answer_index'])}</i>"
+            question_html += f"<b>Q{idx+1}:</b> {question_text}<br><br>{options}"
+            if 0 <= answer_index < len(mcq_options):
+                 question_html += f"<i><b>Answer:</b> {chr(65+answer_index)}</i>"
+            else:
+                 question_html += f"<i><b>Answer:</b> [Invalid Answer Index]</i>"
             question_html += "</div>"
-            pretty_mcqs.append(question_html)
+            pretty_mcqs_html += question_html
 
-        # Prepare text output and CSV data
+        # --- Prepare Text Output and CSV Data ---
         txt_output = ""
         csv_data = []
 
         for idx, mcq in enumerate(mcqs):
-            txt_output += f"Q{idx+1}: {mcq['question']}\n"
-            for opt_idx, option in enumerate(mcq['options']):
+            mcq_options = mcq.get('options', [])
+            answer_index = mcq.get('answer_index', -1)
+            question_text = mcq.get('question', '[No Question Text]')
+
+            txt_output += f"Q{idx+1}: {question_text}\n"
+            for opt_idx, option in enumerate(mcq_options):
                 txt_output += f"   {chr(65+opt_idx)}. {option}\n"
-            txt_output += f"Answer: {chr(65+mcq['answer_index'])}\n\n"
-
-            csv_data.append({
-                'Question': mcq['question'],
-                'Option A': mcq['options'][0],
-                'Option B': mcq['options'][1],
-                'Option C': mcq['options'][2],
-                'Option D': mcq['options'][3],
-                'Answer': chr(65+mcq['answer_index'])
-            })
-
-        # Create in-memory text file
+
+            if 0 <= answer_index < len(mcq_options):
+                txt_output += f"Answer: {chr(65+answer_index)}\n\n"
+            else:
+                txt_output += f"Answer: [Invalid Answer Index]\n\n"
+
+            # Ensure 4 options for CSV, padding if necessary
+            options_padded = mcq_options + [''] * (4 - len(mcq_options))
+            csv_row = {
+                'Question': question_text,
+                'Option A': options_padded[0],
+                'Option B': options_padded[1],
+                'Option C': options_padded[2],
+                'Option D': options_padded[3],
+                'Answer': chr(65+answer_index) if 0 <= answer_index < len(mcq_options) else '[Invalid]'
+            }
+            csv_data.append(csv_row)
+
+        # --- Create In-Memory Buffers (Still useful for structuring data) ---
         txt_buffer = io.StringIO()
         txt_buffer.write(txt_output)
         txt_buffer.seek(0)
 
-        # Create in-memory CSV file
         csv_buffer = io.StringIO()
         pd.DataFrame(csv_data).to_csv(csv_buffer, index=False)
         csv_buffer.seek(0)
 
-        # Return Gradio-compatible downloadable files
-        txt_file = gr.File(value=txt_buffer, file_name="mcqs.txt", file_type="text/plain")
-        csv_file = gr.File(value=csv_buffer, file_name="mcqs.csv", file_type="text/csv")
+        # --- Create Temporary Files and Get Paths ---
+        print("--- Creating temporary files ---") # Add logging
+        # Use delete=False so Gradio can access the file after the 'with' block closes it.
+        # Gradio should handle the cleanup of these temporary files.
+        with tempfile.NamedTemporaryFile(mode="w", suffix=".txt", delete=False, encoding='utf-8') as temp_txt:
+            temp_txt.write(txt_buffer.getvalue())
+            txt_filepath = temp_txt.name
+            print(f"Created TXT temp file: {txt_filepath}") # Add logging
 
-        return pretty_mcqs, [txt_file, csv_file], "✅ MCQs generated successfully!"
+        with tempfile.NamedTemporaryFile(mode="w", suffix=".csv", delete=False, encoding='utf-8') as temp_csv:
+            temp_csv.write(csv_buffer.getvalue())
+            csv_filepath = temp_csv.name
+            print(f"Created CSV temp file: {csv_filepath}") # Add logging
+
+        # --- Return HTML, File Paths, and Status ---
+        # Return order must match the `outputs` list in demo.launch()
+        return pretty_mcqs_html, txt_filepath, csv_filepath, "✅ MCQs generated successfully!"
 
     except Exception as e:
-        return None, None, f"❌ Error generating MCQs: {str(e)}"
+        print(f"❌ Error during MCQ generation process: {e}") # Add logging
+        print(traceback.format_exc()) # Print detailed traceback for debugging
+        # Return None for HTML and both file paths, plus the error message
+        return None, None, None, f"❌ Error generating MCQs: {str(e)}"
 
 
-# Define Gradio interface
-with gr.Blocks() as demo:
+# --- Define Gradio Interface ---
+with gr.Blocks(theme=gr.themes.Soft()) as demo: # Added a theme for aesthetics
     gr.Markdown("<h1 style='text-align:center;'>📚 Smart MCQ Generator</h1>")
-    
-    # Input for the paragraph and number of questions
-    with gr.Row():
-        paragraph_input = gr.Textbox(lines=8, label="Enter Paragraph for MCQs", placeholder="Paste your study material here...")
-    with gr.Row():
-        num_questions_slider = gr.Slider(1, 10, step=1, value=5, label="Number of Questions")
-    
-    # Generate Button
+    gr.Markdown("Enter a paragraph of study material, choose the number of questions, and get MCQs instantly!") # Added description
+
     with gr.Row():
-        generate_btn = gr.Button("🚀 Generate MCQs")
-    
-    # Status box to show the message (success/error)
-    status = gr.Textbox(label="Status", interactive=False)
+        paragraph_input = gr.Textbox(
+            lines=10, # Increased lines
+            label="Enter Paragraph for MCQs",
+            placeholder="Paste your study material here (ideally 50-500 words)...",
+            elem_id="paragraph-input" # Added elem_id for potential CSS styling
+        )
 
-    # MCQ output and download links
     with gr.Row():
-        mcq_output = gr.HTML()
+        num_questions_slider = gr.Slider(
+            minimum=1, # Explicit minimum
+            maximum=10, # Explicit maximum
+            step=1,
+            value=5,
+            label="Number of Questions to Generate",
+            elem_id="num-questions-slider"
+        )
 
     with gr.Row():
-        download_output = gr.File(label="Download MCQs (TXT/CSV)")
+        generate_btn = gr.Button("🚀 Generate MCQs", variant="primary") # Made button primary
+
+    # Status box
+    status = gr.Textbox(label="Status", interactive=False, placeholder="Generation status will appear here...", elem_id="status-box")
+
+    # Use Accordion for tidier output section
+    with gr.Accordion("Generated MCQs & Downloads", open=True): # Default to open
+        # MCQ HTML output
+        mcq_output = gr.HTML(label="Generated MCQs")
+
+        # Download links - SEPARATED
+        with gr.Row():
+            download_txt = gr.File(label="Download MCQs (.txt)")
+            download_csv = gr.File(label="Download MCQs (.csv)")
 
-    # Set up the button to trigger MCQ generation
+    # Set up the button click event
     generate_btn.click(
         fn=generate_mcqs_ui,
         inputs=[paragraph_input, num_questions_slider],
-        outputs=[mcq_output, download_output, status]
+        # Outputs must match the return order of generate_mcqs_ui
+        outputs=[mcq_output, download_txt, download_csv, status],
+        api_name="generate_mcqs" # Added api_name for potential API usage
     )
 
-# Launch the app
-demo.launch(share=True, server_name="0.0.0.0", server_port=7860)
+    # Add Examples
+    gr.Examples(
+        examples=[
+            ["The cell is the basic structural and functional unit of all living organisms. Cells can be classified into two main types: prokaryotic and eukaryotic. Prokaryotic cells, found in bacteria and archaea, lack a defined nucleus and membrane-bound organelles. In contrast, eukaryotic cells, which make up plants, animals, fungi, and protists, contain a nucleus that houses the cell’s DNA, as well as various organelles like mitochondria and the endoplasmic reticulum.", 3],
+            ["The Industrial Revolution began in Great Britain in the late 18th century. It marked a shift from manual labor to machine-based manufacturing. Key innovations included the steam engine, improved by James Watt, and mechanized looms in the textile industry. This led to increased productivity, urbanization, and the rise of new social classes.", 4],
+            ["Photosynthesis is the process used by plants, algae, and cyanobacteria to convert light energy into chemical energy, through a process that uses sunlight, water and carbon dioxide. This chemical energy is stored in carbohydrate molecules, such as sugars and starches, which are synthesized from carbon dioxide and water – hence the name photosynthesis, from the Greek φῶς, phos, 'light', and σύνθεσις, synthesis, 'putting together'. In most cases, oxygen is also released as a waste product.", 5]
+        ],
+        inputs=[paragraph_input, num_questions_slider],
+        outputs=[mcq_output, download_txt, download_csv, status], # Ensure outputs match here too
+        fn=generate_mcqs_ui,
+        cache_examples=False # Maybe disable caching during debugging
+    )
+
+
+# --- Launch the app ---
+# share=True generates a public link (useful for HF Spaces)
+# server_name="0.0.0.0" makes it accessible within the container network
+# server_port=7860 is the standard Gradio port for Spaces
+print("--- Launching Gradio App ---")
+demo.launch(share=True, server_name="0.0.0.0", server_port=7860)